@pellux/goodvibes-agent 0.1.55 → 0.1.57

package/src/input/onboarding/onboarding-wizard-rules.ts

@@ -1,171 +1,9 @@
-import type { OnboardingStep1CapabilityId } from '../../runtime/onboarding/index.ts';
-import { INBOUND_EXTERNAL_SURFACE_IDS, REQUIRED_EXTERNAL_SETUP_FIELD_IDS } from './onboarding-wizard-constants.ts';
-import {
-  EXTERNAL_SURFACE_SPECS,
-  getExternalSurfaceAutoStartDefaultValue,
-  getExternalSurfaceAutoStartFieldId,
-  isExternalSurfaceSelectedByDefault,
-} from './onboarding-wizard-external-surfaces.ts';
-import { getExternalSurfaceSpecByFieldId, normalizeText, uniqueNonEmpty } from './onboarding-wizard-helpers.ts';
+import { normalizeText } from './onboarding-wizard-helpers.ts';
 import type { OnboardingWizardController } from './onboarding-wizard.ts';
 
-export function getSharedIpDefault(
-  controller: OnboardingWizardController,
-    enabled: { readonly controlPlane: boolean; readonly httpListener: boolean; readonly web: boolean },
-  ): boolean {
-    if (!controller.runtimeSnapshot) return true;
-    const hosts = uniqueNonEmpty([
-      enabled.controlPlane ? controller.runtimeSnapshot.bindSettings.controlPlane.host : '',
-      enabled.httpListener ? controller.runtimeSnapshot.bindSettings.httpListener.host : '',
-      enabled.web ? controller.runtimeSnapshot.bindSettings.web.host : '',
-    ]);
-    return hosts.length <= 1;
-  }
-
-export function getSharedIpHostDefault(
-  controller: OnboardingWizardController,
-    enabled: { readonly controlPlane: boolean; readonly httpListener: boolean; readonly web: boolean },
-  ): string {
-    if (!controller.runtimeSnapshot) return '0.0.0.0';
-    const hosts = uniqueNonEmpty([
-      enabled.controlPlane ? controller.runtimeSnapshot.bindSettings.controlPlane.host : '',
-      enabled.httpListener ? controller.runtimeSnapshot.bindSettings.httpListener.host : '',
-      enabled.web ? controller.runtimeSnapshot.bindSettings.web.host : '',
-    ]);
-    return hosts[0] ?? '0.0.0.0';
-  }
-
-export function toggleCapability(controller: OnboardingWizardController, capabilityId: OnboardingStep1CapabilityId): void {
-    if (capabilityId === 'local-tui-only') {
-      for (const capability of controller.getCurrentCapabilities()) {
-        controller.toggleState.set(`capabilities.${capability.id}`, capability.id === 'local-tui-only');
-      }
-      return;
-    }
-
-    const fieldId = `capabilities.${capabilityId}`;
-    const nextValue = !(controller.toggleState.get(fieldId) ?? false);
-    controller.toggleState.set(fieldId, nextValue);
-    if (nextValue) {
-      controller.toggleState.set('capabilities.local-tui-only', false);
-      return;
-    }
-
-    const anyServerCapability = controller.getCurrentCapabilities().some((capability) => (
-      capability.id !== 'local-tui-only'
-      && (controller.toggleState.get(`capabilities.${capability.id}`) ?? false)
-    ));
-    if (!anyServerCapability) controller.toggleState.set('capabilities.local-tui-only', true);
-  }
-
-export function selectAllServerCapabilities(controller: OnboardingWizardController): void {
-    for (const capability of controller.getCurrentCapabilities()) {
-      controller.toggleState.set(`capabilities.${capability.id}`, capability.id !== 'local-tui-only');
-    }
-  }
-
-export function selectLocalTuiOnly(controller: OnboardingWizardController): void {
-    for (const capability of controller.getCurrentCapabilities()) {
-      controller.toggleState.set(`capabilities.${capability.id}`, capability.id === 'local-tui-only');
-    }
-  }
-
-export function selectAllExternalSurfaces(controller: OnboardingWizardController): void {
-    for (const surface of EXTERNAL_SURFACE_SPECS) {
-      controller.toggleState.set(surface.enabledFieldId, true);
-    }
-  }
-
-export function clearExternalSurfaces(controller: OnboardingWizardController): void {
-    for (const surface of EXTERNAL_SURFACE_SPECS) {
-      controller.toggleState.set(surface.enabledFieldId, false);
-    }
-  }
-
-export function setCapabilityValue(controller: OnboardingWizardController, capabilityId: OnboardingStep1CapabilityId, selected: boolean): void {
-    if (capabilityId === 'local-tui-only') {
-      if (selected) {
-        for (const capability of controller.getCurrentCapabilities()) {
-          controller.toggleState.set(`capabilities.${capability.id}`, capability.id === 'local-tui-only');
-        }
-        return;
-      }
-
-      const anyServerCapability = controller.getCurrentCapabilities().some((capability) => (
-        capability.id !== 'local-tui-only'
-        && (controller.toggleState.get(`capabilities.${capability.id}`) ?? false)
-      ));
-      controller.toggleState.set('capabilities.local-tui-only', !anyServerCapability);
-      return;
-    }
-
-    controller.toggleState.set(`capabilities.${capabilityId}`, selected);
-    if (selected) {
-      controller.toggleState.set('capabilities.local-tui-only', false);
-      return;
-    }
-
-    const anyServerCapability = controller.getCurrentCapabilities().some((capability) => (
-      capability.id !== 'local-tui-only'
-      && (controller.toggleState.get(`capabilities.${capability.id}`) ?? false)
-    ));
-    if (!anyServerCapability) controller.toggleState.set('capabilities.local-tui-only', true);
-  }
-
-export function isCapabilitySelected(controller: OnboardingWizardController, capabilityId: OnboardingStep1CapabilityId): boolean {
-    return controller.getCapabilitySelectionState().some((capability) => capability.id === capabilityId && capability.selected);
-  }
-
-export function hasServerCapabilitiesSelected(controller: OnboardingWizardController): boolean {
-    return controller.getCapabilitySelectionState().some((capability) => capability.id !== 'local-tui-only' && capability.selected);
-  }
-
-export function shouldEnableBrowserSurface(controller: OnboardingWizardController): boolean {
-    return controller.hasServerCapabilitiesSelected()
-      && (controller.isCapabilitySelected('browser-access') || controller.isCapabilitySelected('network-access'));
-  }
-
-export function hasSelectedInboundExternalSurface(controller: OnboardingWizardController): boolean {
-    if (!controller.isCapabilitySelected('external-integrations')) return false;
-    return EXTERNAL_SURFACE_SPECS.some((surface) => (
-      INBOUND_EXTERNAL_SURFACE_IDS.has(surface.id)
-      && controller.getBooleanFieldValue(
-        surface.enabledFieldId,
-        isExternalSurfaceSelectedByDefault(surface, controller.runtimeSnapshot),
-      )
-      && controller.getStringFieldValue(
-        getExternalSurfaceAutoStartFieldId(surface),
-        getExternalSurfaceAutoStartDefaultValue(surface, controller.runtimeSnapshot),
-      ) === 'yes'
-    ));
-  }
-
-export function isRequiredExternalSetupField(controller: OnboardingWizardController, fieldId: string): boolean {
-    if (!REQUIRED_EXTERNAL_SETUP_FIELD_IDS.has(fieldId)) return false;
-    const surface = getExternalSurfaceSpecByFieldId(fieldId);
-    if (!surface) return false;
-    if (!controller.isCapabilitySelected('external-integrations')
-      || !controller.getBooleanFieldValue(
-        surface.enabledFieldId,
-        isExternalSurfaceSelectedByDefault(surface, controller.runtimeSnapshot),
-      )) {
-      return false;
-    }
-    if (fieldId === 'external-services.telegram.webhook-secret') {
-      return controller.getStringFieldValue('external-services.telegram.mode', 'webhook') === 'webhook';
-    }
-    if (
-      fieldId === 'external-services.whatsapp.verify-token'
-      || fieldId === 'external-services.whatsapp.phone-number-id'
-    ) {
-      return controller.getStringFieldValue('external-services.whatsapp.provider', 'meta-cloud') === 'meta-cloud';
-    }
-    return true;
-  }
-
 export function getSelectedSecretMedium(controller: OnboardingWizardController): 'secure' | 'plaintext' {
     const policy = controller.getStringFieldValue(
-      'external-services.secret-policy',
+      'agent-setup.secret-policy',
       controller.runtimeSnapshot?.runtimeDefaults.secretStoragePolicy ?? 'preferred_secure',
     );
     if (policy === 'require_secure') return 'secure';
@@ -174,57 +12,6 @@ export function getSelectedSecretMedium(controller: OnboardingWizardController):
     return 'plaintext';
   }
 
-export function shouldEnableHttpListener(controller: OnboardingWizardController): boolean {
-    return controller.hasServerCapabilitiesSelected()
-      && (controller.isCapabilitySelected('webhook-events') || controller.hasSelectedInboundExternalSurface());
-  }
-
-export function shouldExposeHttpListenerNetworkFields(controller: OnboardingWizardController): boolean {
-    return controller.hasServerCapabilitiesSelected()
-      && (
-        controller.isCapabilitySelected('webhook-events')
-        || controller.isCapabilitySelected('external-integrations')
-        || controller.hasSelectedInboundExternalSurface()
-      );
-  }
-
-export function shouldExposeControlPlaneNetwork(controller: OnboardingWizardController): boolean {
-    return controller.hasServerCapabilitiesSelected()
-      && (controller.isCapabilitySelected('browser-access') || controller.isCapabilitySelected('network-access'));
-  }
-
-export function requiresAuthBootstrap(controller: OnboardingWizardController): boolean {
-    return controller.hasServerCapabilitiesSelected()
-      && (!controller.hasLocalAuthUser() || controller.hasBootstrapCredentialPresent());
-  }
-
-export function hasAdminAuthUser(controller: OnboardingWizardController): boolean {
-    return (controller.runtimeSnapshot?.auth.snapshot.users ?? [])
-      .some((user) => user.roles.includes('admin'));
-  }
-
-export function hasLocalAuthUser(controller: OnboardingWizardController): boolean {
-    return (controller.runtimeSnapshot?.auth.snapshot.userCount ?? 0) > 0
-      || (controller.runtimeSnapshot?.auth.snapshot.users ?? []).length > 0;
-  }
-
-export function hasBootstrapCredentialPresent(controller: OnboardingWizardController): boolean {
-    return controller.runtimeSnapshot?.auth.snapshot.bootstrapCredentialPresent === true;
-  }
-
-export function getDefaultAdminUsername(controller: OnboardingWizardController): string {
-    const users = controller.runtimeSnapshot?.auth.snapshot.users ?? [];
-    if (controller.hasBootstrapCredentialPresent()) {
-      const existingAdmin = users.find((user) => user.roles.includes('admin'));
-      if (existingAdmin) return existingAdmin.username;
-    }
-    const candidates = controller.hasBootstrapCredentialPresent()
-      ? ['goodvibes-admin', 'admin']
-      : ['admin', 'goodvibes-admin'];
-    const candidate = candidates.find((username) => !users.some((user) => user.username === username));
-    return candidate ?? `goodvibes-admin-${users.length + 1}`;
-  }
-
 export function getBooleanFieldValue(controller: OnboardingWizardController, fieldId: string, fallback: boolean): boolean {
     return controller.toggleState.get(fieldId) ?? fallback;
   }
@@ -233,24 +20,3 @@ export function getStringFieldValue(controller: OnboardingWizardController, fiel
     const value = controller.textState.get(fieldId) ?? controller.radioState.get(fieldId);
     return normalizeText(value ?? fallback);
   }
-
-export function parseIntegerFieldValue(controller: OnboardingWizardController, fieldId: string, fallback: number): number | null {
-    const raw = controller.getStringFieldValue(fieldId, String(fallback));
-    if (!/^-?\d+$/.test(raw)) return null;
-    const parsed = Number.parseInt(raw, 10);
-    return Number.isInteger(parsed) ? parsed : null;
-  }
-
-export function getPortFieldValue(controller: OnboardingWizardController, fieldId: string, fallback: number): number {
-    const parsed = controller.parseIntegerFieldValue(fieldId, fallback);
-    if (parsed === null || parsed < 1 || parsed > 65535) return fallback;
-    return parsed;
-  }
-
-export function getNumberFieldValue(controller: OnboardingWizardController, fieldId: string, fallback: number, min?: number, max?: number): number {
-    const parsed = controller.parseIntegerFieldValue(fieldId, fallback);
-    if (parsed === null) return fallback;
-    if (min !== undefined && parsed < min) return fallback;
-    if (max !== undefined && parsed > max) return fallback;
-    return parsed;
-  }

package/src/input/onboarding/onboarding-wizard-state.ts

@@ -1,7 +1,5 @@
 import type { ModelPickerTarget } from '../model-picker.ts';
-import type { OnboardingStep1CapabilityItem } from '../../runtime/onboarding/index.ts';
-import { DEFAULT_CAPABILITIES, NETWORK_HOST_FIELD_IDS } from './onboarding-wizard-constants.ts';
-import { areSelectionsEqual, clamp, cloneSelection, getExternalSurfaceSetupFieldSpec, isMalformedGoodVibesSecretReferenceValue, isValidHostValue, normalizeText } from './onboarding-wizard-helpers.ts';
+import { areSelectionsEqual, clamp, cloneSelection, isMalformedGoodVibesSecretReferenceValue, normalizeText } from './onboarding-wizard-helpers.ts';
 import type { OnboardingWizardController } from './onboarding-wizard.ts';
 import type { OnboardingWizardFieldDefinition, OnboardingWizardModelSelection, OnboardingWizardStepDefinition } from './onboarding-wizard-types.ts';
 
@@ -77,53 +75,10 @@ export function getFieldValidationError(
       return `${step.shortLabel}: ${field.label} is required.`;
     }
 
-    if (field.id === 'accounts.admin-username') {
-      const password = normalizeText(controller.getStringFieldValue('accounts.admin-password', ''));
-      if (!required && password.length > 0 && value.length === 0) {
-        return `${step.shortLabel}: ${field.label} is required when setting a local auth password.`;
-      }
-      const existing = controller.runtimeSnapshot?.auth.snapshot.users.find((user) => user.username === value);
-      if ((required || password.length > 0) && existing && !existing.roles.includes('admin')) {
-        return `${step.shortLabel}: ${field.label} must be an existing admin user or a new username.`;
-      }
-    }
-
-    if (field.id === 'accounts.admin-password' && value.length > 0 && value.length < 8) {
-      return `${step.shortLabel}: ${field.label} must be at least 8 characters.`;
-    }
-
     if (field.kind === 'masked' && isMalformedGoodVibesSecretReferenceValue(value)) {
       return `${step.shortLabel}: ${field.label} must be a secret value or a goodvibes://secrets/... reference.`;
     }
 
-    if (NETWORK_HOST_FIELD_IDS.has(field.id)) {
-      if (!isValidHostValue(value)) {
-        return `${step.shortLabel}: ${field.label} must be a host or IP address, not a URL.`;
-      }
-      return null;
-    }
-
-    if (field.id === 'network.service-port' || field.id === 'network.browser-port' || field.id === 'network.webhook-port') {
-      const parsed = controller.parseIntegerFieldValue(field.id, Number.parseInt(field.defaultValue, 10));
-      if (parsed === null || parsed < 1 || parsed > 65535) {
-        return `${step.shortLabel}: ${field.label} must be a port number from 1 to 65535.`;
-      }
-      return null;
-    }
-
-    if (field.kind !== 'text') return null;
-    const setupField = getExternalSurfaceSetupFieldSpec(field.id);
-    if (setupField?.valueType !== 'number') return null;
-    const parsed = controller.parseIntegerFieldValue(field.id, Number.parseInt(field.defaultValue, 10));
-    if (parsed === null) {
-      return `${step.shortLabel}: ${field.label} must be a number.`;
-    }
-    if (setupField.min !== undefined && parsed < setupField.min) {
-      return `${step.shortLabel}: ${field.label} must be at least ${setupField.min}.`;
-    }
-    if (setupField.max !== undefined && parsed > setupField.max) {
-      return `${step.shortLabel}: ${field.label} must be at most ${setupField.max}.`;
-    }
     return null;
   }
 
@@ -340,26 +295,3 @@ export function isFieldSatisfied(controller: OnboardingWizardController, field:
     const selection = controller.getFieldValue(field) as OnboardingWizardModelSelection;
     return selection.providerId.length > 0 || selection.modelId.length > 0;
   }
-
-export function getCurrentCapabilities(controller: OnboardingWizardController): readonly OnboardingStep1CapabilityItem[] {
-    return controller.runtimeDerived.step1Capabilities.length > 0
-      ? controller.runtimeDerived.step1Capabilities
-      : DEFAULT_CAPABILITIES;
-  }
-
-export function getCapabilitySelectionState(controller: OnboardingWizardController): readonly OnboardingStep1CapabilityItem[] {
-    return controller.getCurrentCapabilities().map((capability) => ({
-      ...capability,
-      selected: controller.toggleState.get(`capabilities.${capability.id}`) ?? capability.selected,
-    }));
-  }
-
-export function hasExistingAccessState(controller: OnboardingWizardController): boolean {
-    const auth = controller.runtimeSnapshot?.auth.snapshot;
-    return controller.mode !== 'new'
-      || (controller.runtimeSnapshot?.subscriptions.active.length ?? 0) > 0
-      || (controller.runtimeSnapshot?.subscriptions.pending.length ?? 0) > 0
-      || (auth?.userCount ?? 0) > 0
-      || (auth?.sessionCount ?? 0) > 0
-      || Boolean(auth?.bootstrapCredentialPresent);
-  }