@pellux/goodvibes-agent 0.1.21 → 0.1.23

package/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 All notable changes to GoodVibes Agent will be recorded here.
 
+## 0.1.23 - 2026-05-31
+
+- 18d7381 Harden analyze and registry tool policy
+
+## 0.1.22 - 2026-05-31
+
+- 07e4445 Mark control tool read-only in agent runtime
+
 ## 0.1.21 - 2026-05-31
 
 - d83f325 Keep inspect scaffold dry-run-only in agent runtime

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pellux/goodvibes-agent",
-  "version": "0.1.21",
+  "version": "0.1.23",
   "private": false,
   "description": "Near-fork GoodVibes operator assistant with the GoodVibes TUI shell, renderer, input, fullscreen workspace, and daemon-connected Agent product brain.",
   "type": "module",

package/src/tools/agent-analysis-registry-policy.ts

@@ -0,0 +1,127 @@
+import type { Tool } from '@pellux/goodvibes-sdk/platform/types';
+
+type AnalyzeToolArgs = {
+  readonly mode?: unknown;
+  readonly [key: string]: unknown;
+};
+
+type RegistryToolArgs = {
+  readonly mode?: unknown;
+  readonly path?: unknown;
+  readonly [key: string]: unknown;
+};
+
+const READ_ONLY_ANALYZE_TOOL_MODES = [
+  'impact',
+  'dependencies',
+  'dead_code',
+  'security',
+  'coverage',
+  'bundle',
+  'preview',
+  'diff',
+  'surface',
+  'breaking',
+  'permissions',
+  'env_audit',
+  'test_find',
+] as const;
+
+const READ_ONLY_REGISTRY_TOOL_MODES = ['search', 'recommend', 'dependencies', 'preview'] as const;
+
+const READ_ONLY_ANALYZE_TOOL_MODE_SET = new Set<string>(READ_ONLY_ANALYZE_TOOL_MODES);
+const READ_ONLY_REGISTRY_TOOL_MODE_SET = new Set<string>(READ_ONLY_REGISTRY_TOOL_MODES);
+
+const ANALYZE_NETWORK_DENIAL = [
+  'GoodVibes Agent only exposes local, static analyze modes from the main conversation.',
+  'npm registry upgrade checks and hidden secondary LLM diff analysis are disabled here.',
+  'Use explicit Agent CLI/slash commands or GoodVibes TUI delegation for package-upgrade and code-review workflows.',
+].join(' ');
+
+const REGISTRY_CONTENT_DENIAL = [
+  'GoodVibes Agent only exposes registry discovery, recommendation, dependency, and bounded preview from the main conversation.',
+  'Full registry content materialization and arbitrary .goodvibes file reads are disabled here.',
+  'Use explicit Agent CLI/slash commands for intentional local registry changes or deeper inspection.',
+].join(' ');
+
+export const AGENT_READ_ONLY_ANALYZE_TOOL_MODES = READ_ONLY_ANALYZE_TOOL_MODES;
+export const AGENT_READ_ONLY_REGISTRY_TOOL_MODES = READ_ONLY_REGISTRY_TOOL_MODES;
+export const AGENT_ANALYZE_NETWORK_DENIAL_MESSAGE = ANALYZE_NETWORK_DENIAL;
+export const AGENT_REGISTRY_CONTENT_DENIAL_MESSAGE = REGISTRY_CONTENT_DENIAL;
+
+export function wrapAnalyzeToolForAgentPolicy(tool: Tool): void {
+  narrowAnalyzeToolDefinitionForAgentPolicy(tool);
+  const originalExecute = tool.execute.bind(tool);
+  tool.execute = async (args) => {
+    const denial = validateAnalyzeToolInvocationForAgentPolicy(args as AnalyzeToolArgs);
+    if (denial) return { success: false, error: denial };
+    return originalExecute(args);
+  };
+}
+
+export function wrapRegistryToolForAgentPolicy(tool: Tool): void {
+  narrowRegistryToolDefinitionForAgentPolicy(tool);
+  const originalExecute = tool.execute.bind(tool);
+  tool.execute = async (args) => {
+    const denial = validateRegistryToolInvocationForAgentPolicy(args as RegistryToolArgs);
+    if (denial) return { success: false, error: denial };
+    return originalExecute(args);
+  };
+}
+
+export function validateAnalyzeToolInvocationForAgentPolicy(args: AnalyzeToolArgs): string | null {
+  if (typeof args.mode === 'string' && !READ_ONLY_ANALYZE_TOOL_MODE_SET.has(args.mode)) return ANALYZE_NETWORK_DENIAL;
+  return null;
+}
+
+export function validateRegistryToolInvocationForAgentPolicy(args: RegistryToolArgs): string | null {
+  if (typeof args.mode === 'string' && !READ_ONLY_REGISTRY_TOOL_MODE_SET.has(args.mode)) return REGISTRY_CONTENT_DENIAL;
+  if (args.mode === 'preview' && typeof args.path === 'string' && !isAllowedAgentRegistryPreviewPath(args.path)) {
+    return REGISTRY_CONTENT_DENIAL;
+  }
+  return null;
+}
+
+function narrowAnalyzeToolDefinitionForAgentPolicy(tool: Tool): void {
+  tool.definition.description = [
+    'Run local, static project analysis for GoodVibes Agent.',
+    'npm registry upgrade checks and hidden secondary LLM diff analysis are disabled in the main conversation.',
+    'Delegate package-upgrade and review workflows to GoodVibes TUI when they become build/fix/review work.',
+  ].join(' ');
+  tool.definition.sideEffects = ['read_fs'];
+
+  const properties = tool.definition.parameters.properties;
+  if (!isRecord(properties)) return;
+  const modeProperty = properties.mode;
+  if (isRecord(modeProperty)) {
+    modeProperty.enum = [...READ_ONLY_ANALYZE_TOOL_MODES];
+    modeProperty.description = 'Local static analysis mode allowed by GoodVibes Agent main-conversation policy.';
+  }
+
+  delete properties.packages;
+}
+
+function narrowRegistryToolDefinitionForAgentPolicy(tool: Tool): void {
+  tool.definition.description = [
+    'Discover and preview GoodVibes Agent skills, agents, and tools.',
+    'Full content materialization and arbitrary .goodvibes file reads are disabled in the main conversation.',
+  ].join(' ');
+  tool.definition.sideEffects = ['read_fs'];
+
+  const properties = tool.definition.parameters.properties;
+  if (!isRecord(properties)) return;
+  const modeProperty = properties.mode;
+  if (isRecord(modeProperty)) {
+    modeProperty.enum = [...READ_ONLY_REGISTRY_TOOL_MODES];
+    modeProperty.description = 'Bounded registry discovery modes allowed by GoodVibes Agent main-conversation policy.';
+  }
+}
+
+function isAllowedAgentRegistryPreviewPath(path: string): boolean {
+  const normalized = path.replace(/\\/g, '/');
+  return /(?:^|\/)\.goodvibes\/(?:skills|agents)\/.+(?:\.md|\/(?:SKILL|AGENT)\.md)$/i.test(normalized);
+}
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return typeof value === 'object' && value !== null && !Array.isArray(value);
+}

package/src/tools/wrfc-agent-guard.ts

@@ -1,5 +1,9 @@
 import type { Tool } from '@pellux/goodvibes-sdk/platform/types';
 import type { ToolRegistry } from '@pellux/goodvibes-sdk/platform/tools';
+import {
+  wrapAnalyzeToolForAgentPolicy,
+  wrapRegistryToolForAgentPolicy,
+} from './agent-analysis-registry-policy.ts';
 
 type AgentToolArgs = {
   readonly mode?: unknown;
@@ -96,6 +100,7 @@ const READ_ONLY_TEAM_TOOL_MODES = ['list', 'show'] as const;
 const READ_ONLY_WORKLIST_TOOL_MODES = ['list', 'show'] as const;
 const READ_ONLY_PACKET_TOOL_MODES = ['list', 'show'] as const;
 const READ_ONLY_QUERY_TOOL_MODES = ['list', 'show'] as const;
+const READ_ONLY_CONTROL_TOOL_MODES = ['commands', 'panels', 'subscriptions', 'sandbox-presets'] as const;
 const READ_ONLY_REMOTE_TOOL_MODE_SET = new Set<string>(READ_ONLY_REMOTE_TOOL_MODES);
 const READ_ONLY_CHANNEL_TOOL_MODE_SET = new Set<string>(READ_ONLY_CHANNEL_TOOL_MODES);
 const READ_ONLY_MCP_TOOL_MODE_SET = new Set<string>(READ_ONLY_MCP_TOOL_MODES);
@@ -110,6 +115,7 @@ const READ_ONLY_TEAM_TOOL_MODE_SET = new Set<string>(READ_ONLY_TEAM_TOOL_MODES);
 const READ_ONLY_WORKLIST_TOOL_MODE_SET = new Set<string>(READ_ONLY_WORKLIST_TOOL_MODES);
 const READ_ONLY_PACKET_TOOL_MODE_SET = new Set<string>(READ_ONLY_PACKET_TOOL_MODES);
 const READ_ONLY_QUERY_TOOL_MODE_SET = new Set<string>(READ_ONLY_QUERY_TOOL_MODES);
+const READ_ONLY_CONTROL_TOOL_MODE_SET = new Set<string>(READ_ONLY_CONTROL_TOOL_MODES);
 
 const LOCAL_AGENT_DENIAL = [
   'GoodVibes Agent does not spawn local Engineer/Reviewer/Tester/Verifier roots or run local WRFC chains.',
@@ -177,6 +183,12 @@ const DURABLE_WORKFLOW_MUTATION_DENIAL = [
   'Use explicit Agent CLI/slash commands or GoodVibes TUI delegation for intentional workflow changes.',
 ].join(' ');
 
+const CONTROL_MUTATION_DENIAL = [
+  'GoodVibes Agent only inspects copied product-control surfaces from the main conversation.',
+  'Product-control mutation, daemon lifecycle, and service posture changes are disabled here.',
+  'Use explicit Agent CLI/slash commands for Agent-owned changes, and keep daemon lifecycle external.',
+].join(' ');
+
 export function installAgentToolPolicyGuard(registry: ToolRegistry, options: AgentToolPolicyGuardOptions = {}): void {
   const agentTool = registry.list().find((tool) => tool.definition.name === 'agent');
   if (!agentTool) throw new Error('Agent tool policy guard could not find the agent tool.');
@@ -214,6 +226,20 @@ export function installAgentToolPolicyGuard(registry: ToolRegistry, options: Age
       wrapBlockedSettingsToolForAgentPolicy(tool);
     } else if (tool.definition.name === 'inspect') {
       wrapInspectToolForAgentPolicy(tool);
+    } else if (tool.definition.name === 'analyze') {
+      wrapAnalyzeToolForAgentPolicy(tool);
+    } else if (tool.definition.name === 'registry') {
+      wrapRegistryToolForAgentPolicy(tool);
+    } else if (tool.definition.name === 'control') {
+      wrapModeRestrictedToolForAgentPolicy(tool, {
+        allowedModes: READ_ONLY_CONTROL_TOOL_MODES,
+        modeSet: READ_ONLY_CONTROL_TOOL_MODE_SET,
+        description: [
+          'Read-only product-control inspection for GoodVibes Agent.',
+          'Command, panel, subscription, and sandbox preset catalogs can be inspected, but product-control mutation and daemon lifecycle are external.',
+        ].join(' '),
+        denial: CONTROL_MUTATION_DENIAL,
+      });
     } else if (tool.definition.name === 'task') {
       wrapModeRestrictedToolForAgentPolicy(tool, {
         allowedModes: READ_ONLY_TASK_TOOL_MODES,
@@ -505,6 +531,7 @@ export const AGENT_READ_ONLY_TEAM_TOOL_MODES = READ_ONLY_TEAM_TOOL_MODES;
 export const AGENT_READ_ONLY_WORKLIST_TOOL_MODES = READ_ONLY_WORKLIST_TOOL_MODES;
 export const AGENT_READ_ONLY_PACKET_TOOL_MODES = READ_ONLY_PACKET_TOOL_MODES;
 export const AGENT_READ_ONLY_QUERY_TOOL_MODES = READ_ONLY_QUERY_TOOL_MODES;
+export const AGENT_READ_ONLY_CONTROL_TOOL_MODES = READ_ONLY_CONTROL_TOOL_MODES;
 export const AGENT_REMOTE_MUTATION_DENIAL_MESSAGE = REMOTE_MUTATION_DENIAL;
 export const AGENT_CHANNEL_ACTION_DENIAL_MESSAGE = CHANNEL_ACTION_DENIAL;
 export const AGENT_MCP_SECURITY_MUTATION_DENIAL_MESSAGE = MCP_SECURITY_MUTATION_DENIAL;
@@ -513,6 +540,18 @@ export const AGENT_STATE_MUTATION_DENIAL_MESSAGE = STATE_MUTATION_DENIAL;
 export const AGENT_SETTINGS_MUTATION_DENIAL_MESSAGE = SETTINGS_MUTATION_DENIAL;
 export const AGENT_INSPECT_WRITE_DENIAL_MESSAGE = INSPECT_WRITE_DENIAL;
 export const AGENT_DURABLE_WORKFLOW_MUTATION_DENIAL_MESSAGE = DURABLE_WORKFLOW_MUTATION_DENIAL;
+export const AGENT_CONTROL_MUTATION_DENIAL_MESSAGE = CONTROL_MUTATION_DENIAL;
+
+export {
+  AGENT_ANALYZE_NETWORK_DENIAL_MESSAGE,
+  AGENT_READ_ONLY_ANALYZE_TOOL_MODES,
+  AGENT_READ_ONLY_REGISTRY_TOOL_MODES,
+  AGENT_REGISTRY_CONTENT_DENIAL_MESSAGE,
+  validateAnalyzeToolInvocationForAgentPolicy,
+  validateRegistryToolInvocationForAgentPolicy,
+  wrapAnalyzeToolForAgentPolicy,
+  wrapRegistryToolForAgentPolicy,
+} from './agent-analysis-registry-policy.ts';
 
 function isRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === 'object' && value !== null && !Array.isArray(value);
@@ -659,6 +698,7 @@ function narrowInspectToolDefinitionForAgentPolicy(tool: Tool): void {
 
 function narrowModeToolDefinitionForAgentPolicy(tool: Tool, allowedModes: readonly string[], description: string): void {
   tool.definition.description = description;
+  tool.definition.sideEffects = [];
 
   const properties = tool.definition.parameters.properties;
   if (!isRecord(properties)) return;

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.1.21';
+let _version = '0.1.23';
 let _sdkVersion = '0.33.35';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8')) as {