@pellux/goodvibes-agent 0.1.12 → 0.1.14

package/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 All notable changes to GoodVibes Agent will be recorded here.
 
+## 0.1.14 - 2026-05-31
+
+- d128004 Block background exec in agent runtime
+
+## 0.1.13 - 2026-05-31
+
+- 989b048 Block local coding tools in agent runtime
+
 ## 0.1.12 - 2026-05-31
 
 - 1843a77 Handle external daemon SDK mismatch in live verification

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pellux/goodvibes-agent",
-  "version": "0.1.12",
+  "version": "0.1.14",
   "private": false,
   "description": "Near-fork GoodVibes operator assistant with the GoodVibes TUI shell, renderer, input, fullscreen workspace, and daemon-connected Agent product brain.",
   "type": "module",

package/src/tools/wrfc-agent-guard.ts

@@ -6,10 +6,27 @@ type AgentToolArgs = {
   readonly [key: string]: unknown;
 };
 
+type ExecCommandArgs = {
+  readonly cmd?: unknown;
+  readonly background?: unknown;
+  readonly until?: unknown;
+  readonly [key: string]: unknown;
+};
+
+type ExecToolArgs = {
+  readonly commands?: unknown;
+  readonly parallel?: unknown;
+  readonly file_ops?: unknown;
+  readonly [key: string]: unknown;
+};
+
 type AgentToolPolicyGuardOptions = {
   readonly getLastUserMessage?: () => string | null;
 };
 
+const BLOCKED_MAIN_CONVERSATION_TOOL_NAMES = ['write', 'edit', 'workflow', 'repl'] as const;
+const AGENT_EXEC_BACKGROUND_COMMAND = /^\s*bg_(?:status|output|stop)\b/;
+
 const READ_ONLY_AGENT_TOOL_MODES = [
   'status',
   'list',
@@ -23,6 +40,7 @@ const READ_ONLY_AGENT_TOOL_MODES = [
 ] as const;
 
 const READ_ONLY_AGENT_TOOL_MODE_SET = new Set<string>(READ_ONLY_AGENT_TOOL_MODES);
+const BLOCKED_MAIN_CONVERSATION_TOOL_NAME_SET = new Set<string>(BLOCKED_MAIN_CONVERSATION_TOOL_NAMES);
 
 const LOCAL_AGENT_DENIAL = [
   'GoodVibes Agent does not spawn local Engineer/Reviewer/Tester/Verifier roots or run local WRFC chains.',
@@ -30,10 +48,29 @@ const LOCAL_AGENT_DENIAL = [
   'For explicit build/fix/review work, delegate one request to GoodVibes TUI through the public shared-session/build-delegation contract with the full original user ask.',
 ].join(' ');
 
+const LOCAL_CODING_TOOL_DENIAL = [
+  'GoodVibes Agent does not perform direct local file mutation, local WRFC workflow execution, or local sandbox/REPL execution from the main conversation.',
+  'For explicit build/fix/review/code execution work, delegate one request to GoodVibes TUI through the public shared-session/build-delegation contract with the full original user ask.',
+  'For durable Agent memory, skills, personas, routines, and knowledge, use the Agent-owned commands and isolated Agent Knowledge routes.',
+].join(' ');
+
+const BACKGROUND_EXEC_DENIAL = [
+  'GoodVibes Agent only runs foreground, serial command-line work from the main conversation.',
+  'Background processes, parallel command batches, background process controls, and exec pre-command file operations are disabled here.',
+  'For long-running build/fix/review work, delegate one request to GoodVibes TUI through the public shared-session/build-delegation contract.',
+].join(' ');
+
 export function installAgentToolPolicyGuard(registry: ToolRegistry, options: AgentToolPolicyGuardOptions = {}): void {
   const agentTool = registry.list().find((tool) => tool.definition.name === 'agent');
   if (!agentTool) throw new Error('Agent tool policy guard could not find the agent tool.');
   wrapAgentToolForAgentPolicy(agentTool, options);
+  for (const tool of registry.list()) {
+    if (tool.definition.name === 'exec') {
+      wrapExecToolForAgentPolicy(tool);
+    } else if (BLOCKED_MAIN_CONVERSATION_TOOL_NAME_SET.has(tool.definition.name)) {
+      wrapBlockedMainConversationToolForAgentPolicy(tool);
+    }
+  }
 }
 
 export function wrapAgentToolForAgentPolicy(tool: Tool, _options: AgentToolPolicyGuardOptions = {}): void {
@@ -55,8 +92,53 @@ export function normalizeAgentToolInvocationForAgentPolicy(args: AgentToolArgs):
   return args;
 }
 
+export function wrapBlockedMainConversationToolForAgentPolicy(tool: Tool): void {
+  tool.definition.description = [
+    `Blocked in GoodVibes Agent main conversation: ${tool.definition.name}.`,
+    'Use explicit GoodVibes TUI build delegation for build/fix/review/code execution work.',
+    'Use Agent-owned local registries and isolated Agent Knowledge routes for Agent memory and knowledge work.',
+  ].join(' ');
+  tool.definition.sideEffects = [];
+  tool.execute = async () => ({ success: false, error: LOCAL_CODING_TOOL_DENIAL });
+}
+
+export function wrapExecToolForAgentPolicy(tool: Tool): void {
+  narrowExecToolDefinitionForAgentPolicy(tool);
+  const originalExecute = tool.execute.bind(tool);
+  tool.execute = async (args) => {
+    const denial = validateExecToolInvocationForAgentPolicy(args as ExecToolArgs);
+    if (denial) return { success: false, error: denial };
+    return originalExecute(args);
+  };
+}
+
+export function validateExecToolInvocationForAgentPolicy(args: ExecToolArgs): string | null {
+  if (args.parallel === true) return BACKGROUND_EXEC_DENIAL;
+  if (Array.isArray(args.file_ops) && args.file_ops.length > 0) return BACKGROUND_EXEC_DENIAL;
+  if (args.file_ops !== undefined && !Array.isArray(args.file_ops)) return BACKGROUND_EXEC_DENIAL;
+  if (!Array.isArray(args.commands)) return null;
+
+  for (const command of args.commands) {
+    if (!isRecord(command)) continue;
+    const commandArgs = command as ExecCommandArgs;
+    if (commandArgs.background === true) return BACKGROUND_EXEC_DENIAL;
+    if (typeof commandArgs.cmd === 'string' && AGENT_EXEC_BACKGROUND_COMMAND.test(commandArgs.cmd)) {
+      return BACKGROUND_EXEC_DENIAL;
+    }
+    if (isRecord(commandArgs.until)) {
+      const killAfter = commandArgs.until.kill_after;
+      if (killAfter !== true) return BACKGROUND_EXEC_DENIAL;
+    }
+  }
+
+  return null;
+}
+
 export const AGENT_LOCAL_SPAWN_DENIAL_MESSAGE = LOCAL_AGENT_DENIAL;
 export const AGENT_READ_ONLY_TOOL_MODES = READ_ONLY_AGENT_TOOL_MODES;
+export const AGENT_BLOCKED_MAIN_CONVERSATION_TOOL_NAMES = BLOCKED_MAIN_CONVERSATION_TOOL_NAMES;
+export const AGENT_MAIN_CONVERSATION_TOOL_DENIAL_MESSAGE = LOCAL_CODING_TOOL_DENIAL;
+export const AGENT_EXEC_BACKGROUND_DENIAL_MESSAGE = BACKGROUND_EXEC_DENIAL;
 
 function isRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === 'object' && value !== null && !Array.isArray(value);
@@ -78,6 +160,35 @@ function narrowAgentToolDefinitionForAgentPolicy(tool: Tool): void {
   modeProperty.description = 'Read-only Agent inspection mode. Local spawn, batch-spawn, cancel, message, wait, and plan modes are disabled in GoodVibes Agent.';
 }
 
+function narrowExecToolDefinitionForAgentPolicy(tool: Tool): void {
+  tool.definition.description = [
+    'Execute foreground shell commands serially for GoodVibes Agent main-conversation work.',
+    'Background processes, parallel batches, background process controls, and exec file_ops are disabled by Agent policy.',
+    'Delegate long-running build/fix/review execution to GoodVibes TUI instead.',
+  ].join(' ');
+
+  const properties = tool.definition.parameters.properties;
+  if (!isRecord(properties)) return;
+  delete properties.parallel;
+  delete properties.file_ops;
+
+  const commandsProperty = properties.commands;
+  if (!isRecord(commandsProperty)) return;
+  const itemSchema = commandsProperty.items;
+  if (!isRecord(itemSchema)) return;
+  const commandProperties = itemSchema.properties;
+  if (!isRecord(commandProperties)) return;
+
+  delete commandProperties.background;
+  const untilProperty = commandProperties.until;
+  if (isRecord(untilProperty)) {
+    untilProperty.description = [
+      'Pattern-based early termination.',
+      'GoodVibes Agent requires kill_after:true so until-mode does not promote the process to background.',
+    ].join(' ');
+  }
+}
+
 // Compatibility exports for copied TUI tests/imports during the near-fork phase.
 export const installWrfcAgentToolGuard = installAgentToolPolicyGuard;
 export const wrapWrfcAgentTool = wrapAgentToolForAgentPolicy;

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.1.12';
+let _version = '0.1.14';
 let _sdkVersion = '0.33.35';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8')) as {