@pellux/goodvibes-agent 0.1.116 → 1.0.0

package/src/cli/local-library-command.ts

@@ -1,9 +1,14 @@
 import { createShellPathService } from '@/runtime/index.ts';
 import { discoverPersonas, type DiscoveredPersonaRecord } from '../agent/persona-discovery.ts';
 import { AgentPersonaRegistry, type AgentPersonaRecord } from '../agent/persona-registry.ts';
+import { formatAgentRecordOrigin, formatAgentRecordReviewState } from '../agent/record-labels.ts';
 import { discoverSkills, type SkillRecord } from '../agent/skill-discovery.ts';
 import {
   AgentSkillRegistry,
+  buildAgentSkillRequirements,
+  evaluateAgentSkillBundleReadiness,
+  evaluateAgentSkillReadiness,
+  formatAgentSkillRequirement,
   type AgentSkillBundleRecord,
   type AgentSkillRecord,
 } from '../agent/skill-registry.ts';
@@ -118,8 +123,8 @@ function shellPaths(runtime: CliCommandRuntime): ReturnType<typeof createShellPa
 
 function summarizePersona(persona: AgentPersonaRecord, activePersonaId: string | null): string {
   const active = persona.id === activePersonaId ? 'active' : 'available';
-  const tags = persona.tags.length > 0 ? ` tags=${persona.tags.join(',')}` : '';
-  return `  ${persona.id}  ${active}  ${persona.reviewState}  ${persona.name} - ${persona.description}${tags}`;
+  const tags = persona.tags.length > 0 ? `  tags ${persona.tags.join(', ')}` : '';
+  return `  ${persona.id}  ${active}  ${formatAgentRecordReviewState(persona.reviewState)}  ${persona.name} - ${persona.description}${tags}`;
 }
 
 function renderPersonaList(title: string, path: string, personas: readonly AgentPersonaRecord[], activePersonaId: string | null): string {
@@ -127,12 +132,13 @@ function renderPersonaList(title: string, path: string, personas: readonly Agent
     return [
       title,
       '  No local Agent personas yet.',
+      '  No Agent-local personas yet.',
       '  Create one with: goodvibes-agent personas create --name <name> --description <summary> --body <instructions>',
     ].join('\n');
   }
   return [
     `${title} (${personas.length})`,
-    `  store: ${path}`,
+    `  store ${path}`,
     ...personas.map((persona) => summarizePersona(persona, activePersonaId)),
   ].join('\n');
 }
@@ -140,11 +146,10 @@ function renderPersonaList(title: string, path: string, personas: readonly Agent
 function renderPersona(persona: AgentPersonaRecord, activePersonaId: string | null): string {
   return [
     `Persona ${persona.name}`,
-    `  id: ${persona.id}`,
+    `  id ${persona.id}`,
     `  active: ${persona.id === activePersonaId ? 'yes' : 'no'}`,
-    `  review: ${persona.reviewState}`,
-    `  source: ${persona.source}`,
-    `  provenance: ${persona.provenance}`,
+    `  review: ${formatAgentRecordReviewState(persona.reviewState)}`,
+    `  origin: ${formatAgentRecordOrigin(persona.source, persona.provenance)}`,
     `  tags: ${persona.tags.join(', ') || '(none)'}`,
     `  triggers: ${persona.triggers.join(', ') || '(manual)'}`,
     `  created: ${persona.createdAt}`,
@@ -161,7 +166,7 @@ function summarizeDiscoveredPersona(persona: DiscoveredPersonaRecord): string {
   const description = persona.description ? ` - ${persona.description}` : '';
   return [
     `  ${persona.name}  ${persona.origin}${description}`,
-    `    path: ${persona.path}`,
+    `    path ${persona.path}`,
   ].join('\n');
 }
 
@@ -170,7 +175,7 @@ function renderDiscoveredPersonaList(personas: readonly DiscoveredPersonaRecord[
     return [
       'Discovered Agent persona files',
       '  No persona markdown files found in Agent persona folders.',
-      '  Search roots: .goodvibes/personas, .goodvibes/agent/personas, .goodvibes/agents, ~/.goodvibes/personas, ~/.goodvibes/agent/personas, ~/.goodvibes/agents',
+      '  Search roots: .goodvibes/personas, .goodvibes/agent/personas, ~/.goodvibes/personas, ~/.goodvibes/agent/personas',
     ].join('\n');
   }
   return [
@@ -203,37 +208,46 @@ function discoveredPersonaFrontmatterList(persona: DiscoveredPersonaRecord, key:
 
 function summarizeSkill(skill: AgentSkillRecord): string {
   const enabled = skill.enabled ? 'enabled' : 'disabled';
-  const tags = skill.tags.length > 0 ? ` tags=${skill.tags.join(',')}` : '';
-  return `  ${skill.id}  ${enabled}  ${skill.reviewState}  ${skill.name} - ${skill.description}${tags}`;
+  const tags = skill.tags.length > 0 ? `  tags ${skill.tags.join(', ')}` : '';
+  const readiness = evaluateAgentSkillReadiness(skill);
+  const ready = readiness.ready ? 'ready' : `needs ${readiness.missing.map(formatAgentSkillRequirement).join(',')}`;
+  return `  ${skill.id}  ${enabled}  ${formatAgentRecordReviewState(skill.reviewState)}  ${ready}  ${skill.name} - ${skill.description}${tags}`;
 }
 
-function summarizeBundle(bundle: AgentSkillBundleRecord): string {
+function summarizeBundle(bundle: AgentSkillBundleRecord, skills: readonly AgentSkillRecord[]): string {
   const enabled = bundle.enabled ? 'enabled' : 'disabled';
-  return `  ${bundle.id}  ${enabled}  ${bundle.reviewState}  ${bundle.name} - ${bundle.description} skills=${bundle.skillIds.join(',')}`;
+  const readiness = evaluateAgentSkillBundleReadiness(bundle, skills);
+  const missing = [
+    ...readiness.missingRequirements.map(formatAgentSkillRequirement),
+    ...readiness.missingSkillIds.map((skillId) => `skill:${skillId}`),
+  ];
+  const ready = readiness.ready ? 'ready' : `needs ${missing.join(',')}`;
+  return `  ${bundle.id}  ${enabled}  ${formatAgentRecordReviewState(bundle.reviewState)}  ${ready}  ${bundle.name} - ${bundle.description} skills ${bundle.skillIds.join(',')}`;
 }
 
-function renderSkillList(title: string, path: string, skills: readonly AgentSkillRecord[]): string {
+function renderSkillList(title: string, path: string, skills: readonly AgentSkillRecord[], emptyMessage?: string): string {
   if (skills.length === 0) {
     return [
       title,
-      '  No local Agent skills yet.',
-      '  Create one with: goodvibes-agent skills create --name <name> --description <summary> --procedure <steps>',
-    ].join('\n');
+      emptyMessage ? '' : '  No local Agent skills yet.',
+      `  ${emptyMessage ?? 'No Agent-local skills yet.'}`,
+      emptyMessage ? '' : '  Create one with: goodvibes-agent skills create --name <name> --description <summary> --procedure <steps>',
+    ].filter(Boolean).join('\n');
   }
   return [
     `${title} (${skills.length})`,
-    `  store: ${path}`,
+    `  store ${path}`,
     ...skills.map(summarizeSkill),
   ].join('\n');
 }
 
 function summarizeDiscoveredSkill(skill: SkillRecord): string {
   const description = skill.description ? ` - ${skill.description}` : '';
-  const dependencies = skill.dependencies.length > 0 ? ` deps=${skill.dependencies.join(',')}` : '';
-  const includes = skill.includes.length > 0 ? ` includes=${skill.includes.join(',')}` : '';
+  const dependencies = skill.dependencies.length > 0 ? `  dependencies ${skill.dependencies.join(', ')}` : '';
+  const includes = skill.includes.length > 0 ? `  includes ${skill.includes.join(', ')}` : '';
   return [
     `  ${skill.name}  ${skill.origin}${description}${dependencies}${includes}`,
-    `    path: ${skill.path}`,
+    `    path ${skill.path}`,
   ].join('\n');
 }
 
@@ -273,29 +287,40 @@ function discoveredFrontmatterList(skill: SkillRecord, key: string): readonly st
   return value.split(',').map((entry) => entry.trim()).filter(Boolean);
 }
 
-function renderBundleList(title: string, path: string, bundles: readonly AgentSkillBundleRecord[]): string {
+function discoveredFrontmatterAnyList(skill: SkillRecord, keys: readonly string[]): readonly string[] {
+  for (const key of keys) {
+    const values = discoveredFrontmatterList(skill, key);
+    if (values.length > 0) return values;
+  }
+  return [];
+}
+
+function renderBundleList(title: string, path: string, bundles: readonly AgentSkillBundleRecord[], skills: readonly AgentSkillRecord[], emptyMessage?: string): string {
   if (bundles.length === 0) {
     return [
       title,
-      '  No local Agent skill bundles yet.',
-      '  Create one with: goodvibes-agent skills bundle create --name <name> --description <summary> --skills <id,id>',
-    ].join('\n');
+      `  ${emptyMessage ?? 'No Agent-local skill bundles yet.'}`,
+      emptyMessage ? '' : '  Create one with: goodvibes-agent skills bundle create --name <name> --description <summary> --skills <id,id>',
+    ].filter(Boolean).join('\n');
   }
   return [
     `${title} (${bundles.length})`,
-    `  store: ${path}`,
-    ...bundles.map(summarizeBundle),
+    `  store ${path}`,
+    ...bundles.map((bundle) => summarizeBundle(bundle, skills)),
   ].join('\n');
 }
 
 function renderSkill(skill: AgentSkillRecord): string {
+  const readiness = evaluateAgentSkillReadiness(skill);
   return [
     `Skill ${skill.name}`,
-    `  id: ${skill.id}`,
+    `  id ${skill.id}`,
     `  enabled: ${skill.enabled ? 'yes' : 'no'}`,
-    `  review: ${skill.reviewState}`,
-    `  source: ${skill.source}`,
-    `  provenance: ${skill.provenance}`,
+    `  readiness: ${readiness.ready ? 'ready' : 'needs setup'}`,
+    `  requirements: ${skill.requirements.map(formatAgentSkillRequirement).join(', ') || '(none)'}`,
+    readiness.missing.length > 0 ? `  missing: ${readiness.missing.map(formatAgentSkillRequirement).join(', ')}` : '',
+    `  review: ${formatAgentRecordReviewState(skill.reviewState)}`,
+    `  origin: ${formatAgentRecordOrigin(skill.source, skill.provenance)}`,
     `  tags: ${skill.tags.join(', ') || '(none)'}`,
     `  triggers: ${skill.triggers.join(', ') || '(manual)'}`,
     `  created: ${skill.createdAt}`,
@@ -308,14 +333,20 @@ function renderSkill(skill: AgentSkillRecord): string {
   ].filter((line): line is string => Boolean(line)).join('\n');
 }
 
-function renderBundle(bundle: AgentSkillBundleRecord): string {
+function renderBundle(bundle: AgentSkillBundleRecord, skills: readonly AgentSkillRecord[]): string {
+  const readiness = evaluateAgentSkillBundleReadiness(bundle, skills);
+  const missing = [
+    ...readiness.missingRequirements.map(formatAgentSkillRequirement),
+    ...readiness.missingSkillIds.map((skillId) => `skill:${skillId}`),
+  ];
   return [
     `Skill bundle ${bundle.name}`,
-    `  id: ${bundle.id}`,
+    `  id ${bundle.id}`,
     `  enabled: ${bundle.enabled ? 'yes' : 'no'}`,
-    `  review: ${bundle.reviewState}`,
-    `  source: ${bundle.source}`,
-    `  provenance: ${bundle.provenance}`,
+    `  readiness: ${readiness.ready ? 'ready' : 'needs setup'}`,
+    missing.length > 0 ? `  missing: ${missing.join(', ')}` : '',
+    `  review: ${formatAgentRecordReviewState(bundle.reviewState)}`,
+    `  origin: ${formatAgentRecordOrigin(bundle.source, bundle.provenance)}`,
     `  skills: ${bundle.skillIds.join(', ')}`,
     `  created: ${bundle.createdAt}`,
     `  updated: ${bundle.updatedAt}`,
@@ -330,11 +361,11 @@ function usagePersonas(): string {
 }
 
 function usageSkills(): string {
-  return 'Usage: goodvibes-agent skills [list|enabled|active|discover|import-discovered <name> --yes|search <query>|show <id>|create|update <id>|enable <id>|disable <id>|review <id>|stale <id> <reason>|delete <id> --yes|bundle ...]';
+  return 'Usage: goodvibes-agent skills [list|enabled|active|attention|discover|import-discovered <name> --yes|search <query>|show <id>|create [--requires-env A,B] [--requires-command gh,jq]|update <id>|enable <id>|disable <id>|review <id>|stale <id> <reason>|delete <id> --yes|bundle ...]';
 }
 
 function usageBundles(): string {
-  return 'Usage: goodvibes-agent skills bundle [list|enabled|search <query>|show <id>|create|update <id>|enable <id>|disable <id>|review <id>|stale <id> <reason>|delete <id> --yes]';
+  return 'Usage: goodvibes-agent skills bundle [list|enabled|attention|search <query>|show <id>|create|update <id>|enable <id>|disable <id>|review <id>|stale <id> <reason>|delete <id> --yes]';
 }
 
 function errorOutput(runtime: CliCommandRuntime, error: unknown, kind: string): CliCommandOutput {
@@ -367,17 +398,17 @@ export async function handlePersonasCommand(runtime: CliCommandRuntime): Promise
       if (!name) return failure(runtime, 'invalid_persona_command', 'Usage: goodvibes-agent personas import-discovered <name> [--use] --yes', 2);
       const discovered = findDiscoveredPersona(await discoverPersonas(shellPaths(runtime)), name);
       if (!discovered) {
-        return failure(runtime, 'persona_discovery_not_found', `Unknown discovered Agent persona: ${name}\nRun goodvibes-agent personas discover to inspect available persona files.`, 1);
+        return failure(runtime, 'persona_discovery_not_found', `Unknown discovered Agent persona ${name}\nRun goodvibes-agent personas discover to inspect available persona files.`, 1);
       }
       if (!hasFlag(options, 'yes')) {
         return success(runtime, 'agent.personas.import_discovered.preview', { persona: discovered }, [
           'Agent persona import preview',
-          `  name: ${discovered.name}`,
-          `  origin: ${discovered.origin}`,
-          `  path: ${discovered.path}`,
-          `  description: ${discovered.description || '(none)'}`,
-          `  body characters: ${discovered.body.length}`,
-          '  next: rerun with --yes to import into the Agent-local persona registry',
+          `  name ${discovered.name}`,
+          `  origin ${discovered.origin}`,
+          `  path ${discovered.path}`,
+          `  description ${discovered.description || '(none)'}`,
+          `  body characters ${discovered.body.length}`,
+          '  next rerun with --yes to import into the Agent-local persona registry',
         ].join('\n'));
       }
       const persona = registry.create({
@@ -390,7 +421,11 @@ export async function handlePersonasCommand(runtime: CliCommandRuntime): Promise
         provenance: `discovered:${discovered.origin}:${discovered.path}`,
       });
       if (hasFlag(options, 'use')) registry.setActive(persona.id);
-      return success(runtime, 'agent.personas.import_discovered', persona, `Imported Agent persona ${persona.id}: ${persona.name}${hasFlag(options, 'use') ? ' (active)' : ''}`);
+      return success(runtime, 'agent.personas.import_discovered', persona, [
+        `Imported Agent persona ${persona.id}: ${persona.name}${hasFlag(options, 'use') ? ' (active)' : ''}`,
+        `  name ${persona.name}`,
+        `  active ${hasFlag(options, 'use') ? 'yes' : 'no'}`,
+      ].join('\n'));
     }
     if (normalized === 'search' || normalized === 'find') {
       const query = rest.join(' ').trim();
@@ -401,7 +436,7 @@ export async function handlePersonasCommand(runtime: CliCommandRuntime): Promise
       const id = rest[0];
       if (!id) return failure(runtime, 'invalid_persona_command', 'Usage: goodvibes-agent personas show <id>', 2);
       const persona = registry.get(id);
-      if (!persona) return failure(runtime, 'persona_not_found', `Unknown Agent persona: ${id}`, 1);
+      if (!persona) return failure(runtime, 'persona_not_found', `Unknown Agent persona ${id}`, 1);
       return success(runtime, 'agent.personas.show', persona, renderPersona(persona, snapshot.activePersonaId));
     }
     if (normalized === 'create') {
@@ -412,10 +447,15 @@ export async function handlePersonasCommand(runtime: CliCommandRuntime): Promise
         body: requiredOption(options, 'body', 'Usage: goodvibes-agent personas create --name <name> --description <summary> --body <instructions>'),
         tags: csvOption(options, 'tags'),
         triggers: csvOption(options, 'triggers'),
-        provenance: optionValue(options, 'provenance') ?? 'cli',
+        provenance: optionValue(options, 'provenance') ?? 'Command',
       });
       if (hasFlag(options, 'use')) registry.setActive(persona.id);
-      return success(runtime, 'agent.personas.create', persona, `Agent persona created: ${persona.id}${hasFlag(options, 'use') ? ' (active)' : ''}`);
+      return success(runtime, 'agent.personas.create', persona, [
+        'Agent persona created',
+        `  id ${persona.id}`,
+        hasFlag(options, 'use') ? '  (active)' : '',
+        `  active ${hasFlag(options, 'use') ? 'yes' : 'no'}`,
+      ].filter(Boolean).join('\n'));
     }
     if (normalized === 'update') {
       const id = rest[0];
@@ -429,13 +469,19 @@ export async function handlePersonasCommand(runtime: CliCommandRuntime): Promise
         triggers: csvOption(options, 'triggers'),
         provenance: optionValue(options, 'provenance'),
       });
-      return success(runtime, 'agent.personas.update', persona, `Agent persona updated: ${persona.id}`);
+      return success(runtime, 'agent.personas.update', persona, [
+        'Agent persona updated',
+        `  id ${persona.id}`,
+      ].join('\n'));
     }
     if (normalized === 'use') {
       const id = rest[0];
       if (!id) return failure(runtime, 'invalid_persona_command', 'Usage: goodvibes-agent personas use <id>', 2);
       const persona = registry.setActive(id);
-      return success(runtime, 'agent.personas.use', persona, `Active Agent persona: ${persona.id}`);
+      return success(runtime, 'agent.personas.use', persona, [
+        'Active Agent persona',
+        `  id ${persona.id}`,
+      ].join('\n'));
     }
     if (normalized === 'clear') {
       registry.clearActive();
@@ -445,13 +491,19 @@ export async function handlePersonasCommand(runtime: CliCommandRuntime): Promise
       const id = rest[0];
       if (!id) return failure(runtime, 'invalid_persona_command', 'Usage: goodvibes-agent personas review <id>', 2);
       const persona = registry.markReviewed(id);
-      return success(runtime, 'agent.personas.review', persona, `Agent persona reviewed: ${persona.id}`);
+      return success(runtime, 'agent.personas.review', persona, [
+        'Agent persona reviewed',
+        `  id ${persona.id}`,
+      ].join('\n'));
     }
     if (normalized === 'stale') {
       const id = rest[0];
       if (!id || rest.length < 2) return failure(runtime, 'invalid_persona_command', 'Usage: goodvibes-agent personas stale <id> <reason>', 2);
       const persona = registry.markStale(id, rest.slice(1).join(' '));
-      return success(runtime, 'agent.personas.stale', persona, `Agent persona marked stale: ${persona.id}`);
+      return success(runtime, 'agent.personas.stale', persona, [
+        'Agent persona marked stale',
+        `  id ${persona.id}`,
+      ].join('\n'));
     }
     if (normalized === 'delete' || normalized === 'remove' || normalized === 'rm') {
       const options = parseOptions(rest);
@@ -459,7 +511,10 @@ export async function handlePersonasCommand(runtime: CliCommandRuntime): Promise
       if (!id) return failure(runtime, 'invalid_persona_command', 'Usage: goodvibes-agent personas delete <id> --yes', 2);
       if (!hasFlag(options, 'yes')) return failure(runtime, 'confirmation_required', `Refusing to delete Agent persona ${id} without --yes.`, 2);
       const persona = registry.deletePersona(id);
-      return success(runtime, 'agent.personas.delete', persona, `Agent persona deleted: ${persona.id}`);
+      return success(runtime, 'agent.personas.delete', persona, [
+        `Agent persona deleted: ${id}`,
+        `  id ${persona.id}`,
+      ].join('\n'));
     }
     return failure(runtime, 'invalid_persona_command', usagePersonas(), 2);
   } catch (error) {
@@ -473,6 +528,7 @@ function skillPayloadFromOptions(options: ParsedOptions): {
   readonly procedure: string;
   readonly tags: readonly string[] | undefined;
   readonly triggers: readonly string[] | undefined;
+  readonly requirements: ReturnType<typeof buildAgentSkillRequirements>;
   readonly enabled: boolean | undefined;
   readonly provenance: string;
 } {
@@ -483,8 +539,12 @@ function skillPayloadFromOptions(options: ParsedOptions): {
     procedure: requiredOption(options, 'procedure', usage),
     tags: csvOption(options, 'tags'),
     triggers: csvOption(options, 'triggers'),
+    requirements: buildAgentSkillRequirements({
+      env: csvOption(options, 'requires-env'),
+      commands: csvOption(options, 'requires-command') ?? csvOption(options, 'requires-commands'),
+    }),
     enabled: hasFlag(options, 'enabled') ? true : undefined,
-    provenance: optionValue(options, 'provenance') ?? 'cli',
+    provenance: optionValue(options, 'provenance') ?? 'Command',
   };
 }
 
@@ -495,22 +555,26 @@ async function handleSkillBundleCommand(runtime: CliCommandRuntime, args: readon
     const registry = skillRegistry(runtime);
     const snapshot = registry.snapshot();
     if (normalized === 'list' || normalized === 'ls') {
-      return success(runtime, 'agent.skills.bundles.list', { path: snapshot.path, bundles: snapshot.bundles }, renderBundleList('Agent skill bundles', snapshot.path, snapshot.bundles));
+      return success(runtime, 'agent.skills.bundles.list', { path: snapshot.path, bundles: snapshot.bundles }, renderBundleList('Agent skill bundles', snapshot.path, snapshot.bundles, snapshot.skills));
     }
     if (normalized === 'enabled') {
-      return success(runtime, 'agent.skills.bundles.enabled', { path: snapshot.path, bundles: snapshot.enabledBundles }, renderBundleList('Enabled Agent skill bundles', snapshot.path, snapshot.enabledBundles));
+      return success(runtime, 'agent.skills.bundles.enabled', { path: snapshot.path, bundles: snapshot.enabledBundles }, renderBundleList('Enabled Agent skill bundles', snapshot.path, snapshot.enabledBundles, snapshot.skills));
+    }
+    if (normalized === 'attention' || normalized === 'needs-setup') {
+      const bundles = snapshot.bundles.filter((bundle) => !evaluateAgentSkillBundleReadiness(bundle, snapshot.skills).ready);
+      return success(runtime, 'agent.skills.bundles.attention', { path: snapshot.path, bundles }, renderBundleList('Agent skill bundles needing setup', snapshot.path, bundles, snapshot.skills, 'No Agent-local skill bundles need setup.'));
     }
     if (normalized === 'search' || normalized === 'find') {
       const query = rest.join(' ').trim();
       const results = registry.searchBundles(query);
-      return success(runtime, 'agent.skills.bundles.search', { query, results }, renderBundleList(`Agent skill bundles matching "${query}"`, snapshot.path, results));
+      return success(runtime, 'agent.skills.bundles.search', { query, results }, renderBundleList(`Agent skill bundles matching "${query}"`, snapshot.path, results, snapshot.skills));
     }
     if (normalized === 'show' || normalized === 'get') {
       const id = rest[0];
       if (!id) return failure(runtime, 'invalid_skill_bundle_command', 'Usage: goodvibes-agent skills bundle show <id>', 2);
       const bundle = registry.getBundle(id);
-      if (!bundle) return failure(runtime, 'skill_bundle_not_found', `Unknown Agent skill bundle: ${id}`, 1);
-      return success(runtime, 'agent.skills.bundles.show', bundle, renderBundle(bundle));
+      if (!bundle) return failure(runtime, 'skill_bundle_not_found', `Unknown Agent skill bundle ${id}`, 1);
+      return success(runtime, 'agent.skills.bundles.show', bundle, renderBundle(bundle, snapshot.skills));
     }
     if (normalized === 'create') {
       const options = parseOptions(rest);
@@ -520,9 +584,12 @@ async function handleSkillBundleCommand(runtime: CliCommandRuntime, args: readon
         description: requiredOption(options, 'description', usage),
         skillIds: requiredOption(options, 'skills', usage).split(',').map((entry) => entry.trim()).filter(Boolean),
         enabled: hasFlag(options, 'enabled'),
-        provenance: optionValue(options, 'provenance') ?? 'cli',
+        provenance: optionValue(options, 'provenance') ?? 'Command',
       });
-      return success(runtime, 'agent.skills.bundles.create', bundle, `Agent skill bundle created: ${bundle.id}`);
+      return success(runtime, 'agent.skills.bundles.create', bundle, [
+        'Agent skill bundle created',
+        `  id ${bundle.id}`,
+      ].join('\n'));
     }
     if (normalized === 'update') {
       const id = rest[0];
@@ -534,25 +601,37 @@ async function handleSkillBundleCommand(runtime: CliCommandRuntime, args: readon
         skillIds: csvOption(options, 'skills'),
         provenance: optionValue(options, 'provenance'),
       });
-      return success(runtime, 'agent.skills.bundles.update', bundle, `Agent skill bundle updated: ${bundle.id}`);
+      return success(runtime, 'agent.skills.bundles.update', bundle, [
+        'Agent skill bundle updated',
+        `  id ${bundle.id}`,
+      ].join('\n'));
     }
     if (normalized === 'enable' || normalized === 'disable') {
       const id = rest[0];
       if (!id) return failure(runtime, 'invalid_skill_bundle_command', `Usage: goodvibes-agent skills bundle ${normalized} <id>`, 2);
       const bundle = registry.setBundleEnabled(id, normalized === 'enable');
-      return success(runtime, `agent.skills.bundles.${normalized}`, bundle, `Agent skill bundle ${normalized}d: ${bundle.id}`);
+      return success(runtime, `agent.skills.bundles.${normalized}`, bundle, [
+        `Agent skill bundle ${normalized === 'enable' ? 'enabled' : 'disabled'}`,
+        `  id ${bundle.id}`,
+      ].join('\n'));
     }
     if (normalized === 'review') {
       const id = rest[0];
       if (!id) return failure(runtime, 'invalid_skill_bundle_command', 'Usage: goodvibes-agent skills bundle review <id>', 2);
       const bundle = registry.markBundleReviewed(id);
-      return success(runtime, 'agent.skills.bundles.review', bundle, `Agent skill bundle reviewed: ${bundle.id}`);
+      return success(runtime, 'agent.skills.bundles.review', bundle, [
+        'Agent skill bundle reviewed',
+        `  id ${bundle.id}`,
+      ].join('\n'));
     }
     if (normalized === 'stale') {
       const id = rest[0];
       if (!id || rest.length < 2) return failure(runtime, 'invalid_skill_bundle_command', 'Usage: goodvibes-agent skills bundle stale <id> <reason>', 2);
       const bundle = registry.markBundleStale(id, rest.slice(1).join(' '));
-      return success(runtime, 'agent.skills.bundles.stale', bundle, `Agent skill bundle marked stale: ${bundle.id}`);
+      return success(runtime, 'agent.skills.bundles.stale', bundle, [
+        'Agent skill bundle marked stale',
+        `  id ${bundle.id}`,
+      ].join('\n'));
     }
     if (normalized === 'delete' || normalized === 'remove' || normalized === 'rm') {
       const options = parseOptions(rest);
@@ -560,7 +639,10 @@ async function handleSkillBundleCommand(runtime: CliCommandRuntime, args: readon
       if (!id) return failure(runtime, 'invalid_skill_bundle_command', 'Usage: goodvibes-agent skills bundle delete <id> --yes', 2);
       if (!hasFlag(options, 'yes')) return failure(runtime, 'confirmation_required', `Refusing to delete Agent skill bundle ${id} without --yes.`, 2);
       const bundle = registry.deleteBundle(id);
-      return success(runtime, 'agent.skills.bundles.delete', bundle, `Agent skill bundle deleted: ${bundle.id}`);
+      return success(runtime, 'agent.skills.bundles.delete', bundle, [
+        'Agent skill bundle deleted',
+        `  id ${bundle.id}`,
+      ].join('\n'));
     }
     return failure(runtime, 'invalid_skill_bundle_command', usageBundles(), 2);
   } catch (error) {
@@ -584,9 +666,13 @@ export async function handleSkillsCommand(runtime: CliCommandRuntime): Promise<C
     if (normalized === 'active') {
       return success(runtime, 'agent.skills.active', { path: snapshot.path, skills: snapshot.activeSkills, bundles: snapshot.enabledBundles }, [
         renderSkillList('Active Agent skills', snapshot.path, snapshot.activeSkills),
-        snapshot.enabledBundles.length > 0 ? renderBundleList('Enabled Agent skill bundles', snapshot.path, snapshot.enabledBundles) : '',
+        snapshot.enabledBundles.length > 0 ? renderBundleList('Enabled Agent skill bundles', snapshot.path, snapshot.enabledBundles, snapshot.skills) : '',
       ].filter(Boolean).join('\n\n'));
     }
+    if (normalized === 'attention' || normalized === 'needs-setup') {
+      const skills = snapshot.skills.filter((skill) => !evaluateAgentSkillReadiness(skill).ready);
+      return success(runtime, 'agent.skills.attention', { path: snapshot.path, skills }, renderSkillList('Agent skills needing setup', snapshot.path, skills, 'No Agent-local skills need setup.'));
+    }
     if (normalized === 'discover') {
       const discovered = await discoverSkills(shellPaths(runtime));
       return success(runtime, 'agent.skills.discover', { skills: discovered }, renderDiscoveredSkillList(discovered));
@@ -597,17 +683,17 @@ export async function handleSkillsCommand(runtime: CliCommandRuntime): Promise<C
       if (!name) return failure(runtime, 'invalid_skill_command', 'Usage: goodvibes-agent skills import-discovered <name> [--enabled] --yes', 2);
       const discovered = findDiscoveredSkill(await discoverSkills(shellPaths(runtime)), name);
       if (!discovered) {
-        return failure(runtime, 'skill_discovery_not_found', `Unknown discovered Agent skill: ${name}\nRun goodvibes-agent skills discover to inspect available skill files.`, 1);
+        return failure(runtime, 'skill_discovery_not_found', `Unknown discovered Agent skill ${name}\nRun goodvibes-agent skills discover to inspect available skill files.`, 1);
       }
       if (!hasFlag(options, 'yes')) {
         return success(runtime, 'agent.skills.import_discovered.preview', { skill: discovered }, [
           'Agent skill import preview',
-          `  name: ${discovered.name}`,
-          `  origin: ${discovered.origin}`,
-          `  path: ${discovered.path}`,
-          `  description: ${discovered.description || '(none)'}`,
-          `  procedure characters: ${discovered.body.length}`,
-          '  next: rerun with --yes to import into the Agent-local skill registry',
+          `  name ${discovered.name}`,
+          `  origin ${discovered.origin}`,
+          `  path ${discovered.path}`,
+          `  description ${discovered.description || '(none)'}`,
+          `  procedure characters ${discovered.body.length}`,
+          '  next rerun with --yes to import into the Agent-local skill registry',
         ].join('\n'));
       }
       const skill = registry.create({
@@ -616,11 +702,19 @@ export async function handleSkillsCommand(runtime: CliCommandRuntime): Promise<C
         procedure: discovered.body,
         tags: discoveredFrontmatterList(discovered, 'tags'),
         triggers: discoveredFrontmatterList(discovered, 'triggers'),
+        requirements: buildAgentSkillRequirements({
+          env: discoveredFrontmatterAnyList(discovered, ['requiresEnv', 'requires-env', 'requires_env']),
+          commands: discoveredFrontmatterAnyList(discovered, ['requiresCommands', 'requires-commands', 'requires_commands', 'commands']),
+        }),
         enabled: hasFlag(options, 'enabled'),
         source: 'imported',
         provenance: `discovered:${discovered.origin}:${discovered.path}`,
       });
-      return success(runtime, 'agent.skills.import_discovered', skill, `Imported Agent skill ${skill.id}: ${skill.name}${skill.enabled ? ' (enabled)' : ''}`);
+      return success(runtime, 'agent.skills.import_discovered', skill, [
+        `Imported Agent skill ${skill.id}: ${skill.name}${skill.enabled ? ' (enabled)' : ''}`,
+        `  name ${skill.name}`,
+        `  enabled ${skill.enabled ? 'yes' : 'no'}`,
+      ].join('\n'));
     }
     if (normalized === 'search' || normalized === 'find') {
       const query = rest.join(' ').trim();
@@ -631,12 +725,17 @@ export async function handleSkillsCommand(runtime: CliCommandRuntime): Promise<C
       const id = rest[0];
       if (!id) return failure(runtime, 'invalid_skill_command', 'Usage: goodvibes-agent skills show <id>', 2);
       const skill = registry.get(id);
-      if (!skill) return failure(runtime, 'skill_not_found', `Unknown Agent skill: ${id}`, 1);
+      if (!skill) return failure(runtime, 'skill_not_found', `Unknown Agent skill ${id}`, 1);
       return success(runtime, 'agent.skills.show', skill, renderSkill(skill));
     }
     if (normalized === 'create') {
       const skill = registry.create(skillPayloadFromOptions(parseOptions(rest)));
-      return success(runtime, 'agent.skills.create', skill, `Agent skill created: ${skill.id}${skill.enabled ? ' (enabled)' : ''}`);
+      return success(runtime, 'agent.skills.create', skill, [
+        'Agent skill created',
+        `  id ${skill.id}`,
+        skill.enabled ? '  (enabled)' : '',
+        `  enabled ${skill.enabled ? 'yes' : 'no'}`,
+      ].filter(Boolean).join('\n'));
     }
     if (normalized === 'update') {
       const id = rest[0];
@@ -648,27 +747,45 @@ export async function handleSkillsCommand(runtime: CliCommandRuntime): Promise<C
         procedure: optionValue(options, 'procedure'),
         tags: csvOption(options, 'tags'),
         triggers: csvOption(options, 'triggers'),
+        requirements: options.values.has('requires-env') || options.values.has('requires-command') || options.values.has('requires-commands')
+          ? buildAgentSkillRequirements({
+            env: csvOption(options, 'requires-env'),
+            commands: csvOption(options, 'requires-command') ?? csvOption(options, 'requires-commands'),
+          })
+          : undefined,
         provenance: optionValue(options, 'provenance'),
       });
-      return success(runtime, 'agent.skills.update', skill, `Agent skill updated: ${skill.id}`);
+      return success(runtime, 'agent.skills.update', skill, [
+        'Agent skill updated',
+        `  id ${skill.id}`,
+      ].join('\n'));
     }
     if (normalized === 'enable' || normalized === 'disable') {
       const id = rest[0];
       if (!id) return failure(runtime, 'invalid_skill_command', `Usage: goodvibes-agent skills ${normalized} <id>`, 2);
       const skill = registry.setEnabled(id, normalized === 'enable');
-      return success(runtime, `agent.skills.${normalized}`, skill, `Agent skill ${normalized}d: ${skill.id}`);
+      return success(runtime, `agent.skills.${normalized}`, skill, [
+        `Agent skill ${normalized === 'enable' ? 'enabled' : 'disabled'}`,
+        `  id ${skill.id}`,
+      ].join('\n'));
     }
     if (normalized === 'review') {
       const id = rest[0];
       if (!id) return failure(runtime, 'invalid_skill_command', 'Usage: goodvibes-agent skills review <id>', 2);
       const skill = registry.markReviewed(id);
-      return success(runtime, 'agent.skills.review', skill, `Agent skill reviewed: ${skill.id}`);
+      return success(runtime, 'agent.skills.review', skill, [
+        'Agent skill reviewed',
+        `  id ${skill.id}`,
+      ].join('\n'));
     }
     if (normalized === 'stale') {
       const id = rest[0];
       if (!id || rest.length < 2) return failure(runtime, 'invalid_skill_command', 'Usage: goodvibes-agent skills stale <id> <reason>', 2);
       const skill = registry.markStale(id, rest.slice(1).join(' '));
-      return success(runtime, 'agent.skills.stale', skill, `Agent skill marked stale: ${skill.id}`);
+      return success(runtime, 'agent.skills.stale', skill, [
+        'Agent skill marked stale',
+        `  id ${skill.id}`,
+      ].join('\n'));
     }
     if (normalized === 'delete' || normalized === 'remove' || normalized === 'rm') {
       const options = parseOptions(rest);
@@ -676,7 +793,10 @@ export async function handleSkillsCommand(runtime: CliCommandRuntime): Promise<C
       if (!id) return failure(runtime, 'invalid_skill_command', 'Usage: goodvibes-agent skills delete <id> --yes', 2);
       if (!hasFlag(options, 'yes')) return failure(runtime, 'confirmation_required', `Refusing to delete Agent skill ${id} without --yes.`, 2);
       const skill = registry.deleteSkill(id);
-      return success(runtime, 'agent.skills.delete', skill, `Agent skill deleted: ${skill.id}`);
+      return success(runtime, 'agent.skills.delete', skill, [
+        `Agent skill deleted: ${id}`,
+        `  id ${skill.id}`,
+      ].join('\n'));
     }
     return failure(runtime, 'invalid_skill_command', usageSkills(), 2);
   } catch (error) {