@pellux/goodvibes-agent 0.1.116 → 0.1.117

package/src/runtime/onboarding/verify.ts

@@ -1,7 +1,10 @@
 import { existsSync } from 'node:fs';
 import { join } from 'node:path';
 import { isSecretRefInput } from '@pellux/goodvibes-sdk/platform/config';
-import { resolveAgentRuntimeProfileHome } from '../../agent/runtime-profile.ts';
+import { AgentPersonaRegistry } from '../../agent/persona-registry.ts';
+import { AgentRoutineRegistry } from '../../agent/routine-registry.ts';
+import { readAgentRuntimeProfileSelection, resolveAgentRuntimeProfileHome } from '../../agent/runtime-profile.ts';
+import { AgentSkillRegistry } from '../../agent/skill-registry.ts';
 import { readOnboardingRuntimeState } from './state.ts';
 import type {
   OnboardingApplyOperation,
@@ -144,6 +147,78 @@ function verifyCreateAgentProfileOperation(
   };
 }
 
+function verifySelectAgentProfileOperation(
+  deps: OnboardingVerificationDependencies,
+  operation: Extract<OnboardingApplyOperation, { kind: 'select-agent-profile' }>,
+): OnboardingVerificationItem {
+  const resolution = resolveAgentRuntimeProfileHome(deps.shellPaths.homeDirectory, operation.name);
+  const selection = readAgentRuntimeProfileSelection(deps.shellPaths.homeDirectory);
+  const ok = selection?.id === resolution.id && selection.exists;
+  return {
+    id: `selected-agent-profile:${resolution.id}`,
+    status: ok ? 'pass' : 'fail',
+    message: ok
+      ? `${resolution.id} Agent profile is selected for future launches.`
+      : `${resolution.id} Agent profile is not selected for future launches.`,
+    target: resolution.id,
+  };
+}
+
+function verifyCreateLocalPersonaOperation(
+  deps: OnboardingVerificationDependencies,
+  operation: Extract<OnboardingApplyOperation, { kind: 'create-local-persona' }>,
+): OnboardingVerificationItem {
+  const registry = AgentPersonaRegistry.fromShellPaths(deps.shellPaths);
+  const persona = registry.get(operation.name);
+  const activeOk = operation.activate === false || registry.snapshot().activePersonaId === persona?.id;
+  const ok = persona !== null && activeOk;
+  const target = persona?.id ?? operation.name.trim();
+  return {
+    id: `local-persona:${target}`,
+    status: ok ? 'pass' : 'fail',
+    message: ok
+      ? `${target} local Agent persona exists${operation.activate === false ? '' : ' and is active'}.`
+      : `${target} local Agent persona was not created${operation.activate === false ? '' : ' or activated'}.`,
+    target,
+  };
+}
+
+function verifyCreateLocalSkillOperation(
+  deps: OnboardingVerificationDependencies,
+  operation: Extract<OnboardingApplyOperation, { kind: 'create-local-skill' }>,
+): OnboardingVerificationItem {
+  const skill = AgentSkillRegistry.fromShellPaths(deps.shellPaths).get(operation.name);
+  const enabledOk = operation.enabled === false || skill?.enabled === true;
+  const ok = skill !== null && enabledOk;
+  const target = skill?.id ?? operation.name.trim();
+  return {
+    id: `local-skill:${target}`,
+    status: ok ? 'pass' : 'fail',
+    message: ok
+      ? `${target} local Agent skill exists${operation.enabled === false ? '' : ' and is enabled'}.`
+      : `${target} local Agent skill was not created${operation.enabled === false ? '' : ' or enabled'}.`,
+    target,
+  };
+}
+
+function verifyCreateLocalRoutineOperation(
+  deps: OnboardingVerificationDependencies,
+  operation: Extract<OnboardingApplyOperation, { kind: 'create-local-routine' }>,
+): OnboardingVerificationItem {
+  const routine = AgentRoutineRegistry.fromShellPaths(deps.shellPaths).get(operation.name);
+  const enabledOk = operation.enabled === false || routine?.enabled === true;
+  const ok = routine !== null && enabledOk;
+  const target = routine?.id ?? operation.name.trim();
+  return {
+    id: `local-routine:${target}`,
+    status: ok ? 'pass' : 'fail',
+    message: ok
+      ? `${target} local Agent routine exists${operation.enabled === false ? '' : ' and is enabled'}.`
+      : `${target} local Agent routine was not created${operation.enabled === false ? '' : ' or enabled'}.`,
+    target,
+  };
+}
+
 async function verifyOperation(
   deps: OnboardingVerificationDependencies,
   operation: OnboardingApplyOperation,
@@ -152,7 +227,11 @@ async function verifyOperation(
   if (operation.kind === 'set-secret') return verifySecretOperation(deps, operation);
   if (operation.kind === 'ensure-auth-user') return verifyAuthOperation(deps, operation);
   if (operation.kind === 'acknowledge') return verifyAcknowledgementOperation(deps, operation);
-  return verifyCreateAgentProfileOperation(deps, operation);
+  if (operation.kind === 'create-agent-profile') return verifyCreateAgentProfileOperation(deps, operation);
+  if (operation.kind === 'select-agent-profile') return verifySelectAgentProfileOperation(deps, operation);
+  if (operation.kind === 'create-local-persona') return verifyCreateLocalPersonaOperation(deps, operation);
+  if (operation.kind === 'create-local-skill') return verifyCreateLocalSkillOperation(deps, operation);
+  return verifyCreateLocalRoutineOperation(deps, operation);
 }
 
 export async function verifyOnboardingRequest(

package/src/runtime/operator-token-cleanup.ts

@@ -4,10 +4,10 @@
  * Shared helper that enumerates the legacy workspace-scoped `operator-tokens.json`
  * locations earlier GoodVibes builds may have written. Used by the in-process
  * bootstrap path so stale-token pruning has a single source of truth for where
- * to look. GoodVibes Agent itself does not own daemon startup.
+ * to look. GoodVibes Agent itself does not own connected-host startup.
  *
  * Adding a new legacy location: append to `workspaceOperatorTokenCandidates` and
- * the new path will be inspected on the next daemon boot.
+ * the new path will be inspected on the next connected-host boot.
  */
 
 import { join } from 'node:path';

package/src/runtime/services.ts

@@ -23,7 +23,7 @@ import { MediaProviderRegistry, ensureBuiltinMediaProviders } from '@pellux/good
 import { MultimodalService } from '@pellux/goodvibes-sdk/platform/multimodal';
 import { AgentManager } from '@pellux/goodvibes-sdk/platform/tools';
 import { AgentMessageBus } from '@pellux/goodvibes-sdk/platform/agents';
-import { WrfcController } from '@pellux/goodvibes-sdk/platform/agents';
+import type { WrfcController } from '@pellux/goodvibes-sdk/platform/agents';
 import { AgentOrchestrator } from '@pellux/goodvibes-sdk/platform/agents';
 import { ArchetypeLoader } from '@pellux/goodvibes-sdk/platform/agents';
 import { ProcessManager } from '@pellux/goodvibes-sdk/platform/tools';
@@ -73,7 +73,7 @@ import { IdempotencyStore } from '@/runtime/index.ts';
 import { OverflowHandler } from '@pellux/goodvibes-sdk/platform/tools';
 import { ToolLLM } from '@pellux/goodvibes-sdk/platform/config';
 import { ComponentHealthMonitor } from '@/runtime/index.ts';
-import { WorktreeRegistry } from '@/runtime/index.ts';
+import type { WorktreeRegistry } from '@/runtime/index.ts';
 import { SandboxSessionRegistry } from '@/runtime/index.ts';
 import { createShellPathService, type ShellPathService } from '@/runtime/index.ts';
 import { GOODVIBES_AGENT_SURFACE_ROOT } from '../config/surface.ts';
@@ -101,7 +101,7 @@ function buildFallbackModelDefinition(provider: string, modelId: string): ModelD
     description: 'Configured model available before the model catalog cache has loaded.',
     capabilities: {
       toolCalling: true,
-      codeEditing: true,
+      codeEditing: false,
       reasoning: isReasoningProvider,
       multimodal: isReasoningProvider,
     },
@@ -113,6 +113,24 @@ function buildFallbackModelDefinition(provider: string, modelId: string): ModelD
   };
 }
 
+function createDisabledAgentWorktreeRegistry(): WorktreeRegistry {
+  const registry: Pick<WorktreeRegistry, 'list' | 'attach' | 'setState' | 'cleanup'> = {
+    async list() {
+      return [];
+    },
+    attach(_path, _target) {
+      throw new Error('GoodVibes Agent does not own local worktree attachment. Delegate build, fix, and review work to GoodVibes TUI.');
+    },
+    setState(_path, _state) {
+      throw new Error('GoodVibes Agent does not own local worktree state. Delegate build, fix, and review work to GoodVibes TUI.');
+    },
+    async cleanup(_path) {
+      throw new Error('GoodVibes Agent does not own local worktree cleanup. Delegate build, fix, and review work to GoodVibes TUI.');
+    },
+  };
+  return registry as unknown as WorktreeRegistry;
+}
+
 function ensureConfiguredModelIsRoutable(providerRegistry: ProviderRegistry, configManager: ConfigManager): void {
   const configuredModel = String(configManager.get('provider.model') ?? '').trim();
   if (!configuredModel.includes(':')) return;
@@ -335,7 +353,7 @@ export interface RuntimeServices {
   readonly agentManager: AgentManager;
   readonly agentMessageBus: AgentMessageBus;
   readonly agentOrchestrator: AgentOrchestrator;
-  readonly wrfcController: WrfcController;
+  readonly wrfcController: Pick<WrfcController, 'listChains'>;
   readonly processManager: ProcessManager;
   readonly modeManager: ModeManager;
   readonly fileUndoManager: FileUndoManager;
@@ -345,7 +363,7 @@ export interface RuntimeServices {
    * Agent memory is home/profile-owned and intentionally does not move on workspace swap.
    * Called by WorkspaceSwapManager after the new directory has been verified.
    * Stores that require a process restart emit a warn-level log; they continue serving
-   * the old path until the daemon restarts with the new --working-dir.
+   * the old path until the externally owned GoodVibes host restarts with the new --working-dir.
    */
   rerootStores(newWorkingDir: string): Promise<void>;
 }
@@ -443,12 +461,9 @@ export function createRuntimeServices(options: RuntimeServicesOptions): RuntimeS
     configManager,
   });
   agentManager.setRuntimeBus(options.runtimeBus);
-  const wrfcController = new WrfcController(options.runtimeBus, agentMessageBus, {
-    agentManager,
-    configManager,
-    projectRoot: workingDirectory,
-  });
-  agentManager.setWrfcController(wrfcController);
+  const wrfcController: Pick<WrfcController, 'listChains'> = {
+    listChains: () => [],
+  };
   const hookDispatcher = new HookDispatcher({ toolLLM, projectRoot: workingDirectory }, hookActivityTracker);
   configManager.attachHookDispatcher(hookDispatcher);
   const hookWorkbench = createHookWorkbench({
@@ -578,7 +593,7 @@ export function createRuntimeServices(options: RuntimeServicesOptions): RuntimeS
   mcpRegistry.setSandboxRuntime(configManager, sandboxSessionRegistry);
   const tokenAuditor = new ApiTokenAuditor({ managed: false });
   const componentHealthMonitor = new ComponentHealthMonitor();
-  const worktreeRegistry = new WorktreeRegistry(workingDirectory);
+  const worktreeRegistry = createDisabledAgentWorktreeRegistry();
   const webhookNotifier = new WebhookNotifier();
   const replayEngine = new DeterministicReplayEngine(workingDirectory);
   const providerOptimizer = new ProviderOptimizer(providerRegistry, providerCapabilityRegistry, false);

package/src/shell/service-settings-sync.ts

@@ -1,7 +1,7 @@
 import type { ConfigKey } from '@pellux/goodvibes-sdk/platform/config';
 import type { CliServiceRuntime } from '../cli/service-posture.ts';
 
-export const AGENT_EXTERNAL_DAEMON_SERVICE_MESSAGE = 'GoodVibes Agent uses connected GoodVibes services and does not install, start, stop, restart, or uninstall them. Manage service lifecycle outside Agent.';
+export const AGENT_EXTERNAL_HOST_SERVICE_MESSAGE = 'GoodVibes Agent uses a connected GoodVibes host and does not install, start, stop, restart, or uninstall it. Manage host lifecycle outside Agent.';
 
 export interface ServiceSettingsSyncChange {
   readonly key: ConfigKey;
@@ -11,13 +11,13 @@ export interface ServiceSettingsSyncChange {
 
 export interface ServiceSettingsSyncResult {
   readonly handled: boolean;
-  readonly action?: 'external-daemon-blocked' | 'unchanged';
+  readonly action?: 'connected-host-blocked' | 'unchanged';
   readonly message?: string;
   readonly error?: string;
 }
 
 export interface ServiceSettingsSyncOptions {
-  readonly allowExternalDaemonMutation?: false;
+  readonly allowExternalHostMutation?: false;
 }
 
 export function syncServiceSettingToPlatform(
@@ -30,15 +30,15 @@ export function syncServiceSettingToPlatform(
     return {
       handled: true,
       action: 'unchanged',
-      message: 'External daemon service setting unchanged',
+      message: 'Connected-host setting unchanged',
     };
   }
 
   runtime.configManager.setDynamic(change.key, change.previousValue);
   return {
     handled: true,
-    action: 'external-daemon-blocked',
-    message: AGENT_EXTERNAL_DAEMON_SERVICE_MESSAGE,
-    error: 'daemon_lifecycle_external',
+    action: 'connected-host-blocked',
+    message: AGENT_EXTERNAL_HOST_SERVICE_MESSAGE,
+    error: 'connected_host_lifecycle_external',
   };
 }

package/src/shell/ui-openers.ts

@@ -78,6 +78,17 @@ function buildConfiguredViaMap(
   return map;
 }
 
+function agentWorkspaceCategoryForPanel(panelId: string): string {
+  if (panelId === 'knowledge') return 'knowledge';
+  if (panelId === 'memory') return 'memory';
+  if (panelId === 'work-plan' || panelId === 'tasks' || panelId === 'approval') return 'work';
+  if (panelId === 'automation' || panelId === 'schedule') return 'automation';
+  if (panelId === 'provider-health' || panelId === 'providers' || panelId === 'accounts' || panelId === 'subscription') return 'setup';
+  if (panelId === 'security' || panelId === 'policy') return 'tools';
+  if (panelId === 'qr-code') return 'channels';
+  return 'home';
+}
+
 export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
   const {
     commandContext,
@@ -284,8 +295,8 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
     render();
   };
 
-  commandContext.openAgentWorkspace = () => {
-    input.openAgentWorkspace(commandContext);
+  commandContext.openAgentWorkspace = (categoryId?: string) => {
+    input.openAgentWorkspace(commandContext, categoryId);
     render();
   };
 
@@ -296,42 +307,18 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
   };
 
   commandContext.openPanelPicker = () => {
-    if (!panelManager.isVisible()) {
-      if (panelManager.getAllOpen().length === 0) {
-        try {
-          panelManager.open('panel-list');
-        } catch {
-          // non-fatal
-        }
-      }
-      panelManager.show();
-      input.panelFocused = true;
-      conversation.setSplashSuppressed(true);
-      conversation.rebuildHistory();
-    } else if (!input.panelFocused) {
-      if (panelManager.getAllOpen().length === 0) {
-        try {
-          panelManager.open('panel-list');
-        } catch {
-          // non-fatal
-        }
-      }
-      panelManager.show();
-      input.panelFocused = true;
-      conversation.setSplashSuppressed(true);
-      conversation.rebuildHistory();
-    } else {
-      panelManager.hide();
-      input.panelFocused = false;
-      conversation.setSplashSuppressed(false);
-      conversation.rebuildHistory();
-    }
+    panelManager.hide();
+    input.panelFocused = false;
+    conversation.setSplashSuppressed(false);
+    conversation.log('Panel picker is deferred in GoodVibes Agent. Opening the Agent operator workspace instead.', { fg: '214' });
+    input.openAgentWorkspace(commandContext, 'home');
+    conversation.rebuildHistory();
     render();
   };
 
   commandContext.focusPanels = () => {
-    if (!panelManager.isVisible() || panelManager.getAllOpen().length === 0) return;
-    input.panelFocused = true;
+    input.panelFocused = false;
+    input.openAgentWorkspace(commandContext, 'home');
     render();
   };
 
@@ -342,10 +329,12 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
   };
 
   commandContext.showPanel = (panelId, pane) => {
-    panelManager.open(panelId, pane);
-    panelManager.show();
-    input.panelFocused = true;
-    conversation.setSplashSuppressed(true);
+    void pane;
+    panelManager.hide();
+    input.panelFocused = false;
+    conversation.setSplashSuppressed(false);
+    conversation.log(`Panel "${panelId}" is not part of the Agent front door yet. Opening the matching Agent workspace.`, { fg: '214' });
+    input.openAgentWorkspace(commandContext, agentWorkspaceCategoryForPanel(panelId));
     conversation.rebuildHistory();
     render();
   };

package/src/tools/agent-local-registry-tool.ts

@@ -137,6 +137,12 @@ function requireDescription(args: AgentLocalRegistryToolArgs): string {
   return description;
 }
 
+function requireTextField(value: unknown, fieldName: string): string {
+  const text = readString(value);
+  if (!text) throw new Error(`${fieldName} is required.`);
+  return text;
+}
+
 function requireSummary(args: AgentLocalRegistryToolArgs): string {
   const summary = readString(args.summary || args.description);
   if (!summary) throw new Error('summary is required.');
@@ -299,7 +305,7 @@ function handlePersona(shellPaths: ShellPathService, action: AgentLocalRegistryA
     const persona = registry.create({
       name: requireName(args),
       description: requireDescription(args),
-      body: readString(args.body),
+      body: requireTextField(args.body, 'body'),
       tags: readStringList(args.tags),
       triggers: readStringList(args.triggers),
       source: 'agent',
@@ -350,7 +356,7 @@ function handleSkill(shellPaths: ShellPathService, action: AgentLocalRegistryAct
     const skill = registry.create({
       name: requireName(args),
       description: requireDescription(args),
-      procedure: readString(args.procedure),
+      procedure: requireTextField(args.procedure, 'procedure'),
       triggers: readStringList(args.triggers),
       tags: readStringList(args.tags),
       enabled: args.enabled === true,
@@ -441,7 +447,7 @@ function handleRoutine(shellPaths: ShellPathService, action: AgentLocalRegistryA
     const routine = registry.create({
       name: requireName(args),
       description: requireDescription(args),
-      steps: readString(args.steps),
+      steps: requireTextField(args.steps, 'steps'),
       triggers: readStringList(args.triggers),
       tags: readStringList(args.tags),
       enabled: args.enabled === true,
@@ -469,7 +475,7 @@ function handleRoutine(shellPaths: ShellPathService, action: AgentLocalRegistryA
     const routine = registry.markStarted(requireId(args));
     return [
       `Started Agent-local routine ${routine.id}: ${routine.name}`,
-      'Policy: same main conversation; no hidden background job, daemon mutation, or external side effect was started.',
+      'Policy: same main conversation; no hidden background job, connected-host mutation, or external side effect was started.',
       '',
       routine.steps,
     ].join('\n');

package/src/tools/agent-tool-policy-guard.ts

@@ -83,8 +83,6 @@ const READ_ONLY_AGENT_TOOL_MODES = [
   'templates',
   'get',
   'budget',
-  'wrfc-chains',
-  'wrfc-history',
   'cohort-status',
   'cohort-report',
 ] as const;
@@ -174,7 +172,7 @@ const STATE_MUTATION_DENIAL = [
 const SETTINGS_MUTATION_DENIAL = [
   'GoodVibes Agent does not mutate configuration through model tools in the main conversation.',
   'Use explicit Agent CLI/slash settings commands for intentional config changes.',
-  'Secrets, tokens, passwords, daemon lifecycle settings, and service exposure settings require explicit user action outside the model tool surface.',
+  'Secrets, tokens, passwords, connected-host lifecycle settings, and connected-host exposure settings require explicit user action outside the model tool surface.',
 ].join(' ');
 
 const INSPECT_WRITE_DENIAL = [
@@ -191,8 +189,8 @@ const DURABLE_WORKFLOW_MUTATION_DENIAL = [
 
 const CONTROL_MUTATION_DENIAL = [
   'GoodVibes Agent only inspects runtime-owned product-control surfaces from the main conversation.',
-  'Product-control mutation, daemon lifecycle, and service posture changes are disabled here.',
-  'Use explicit Agent CLI/slash commands for Agent-owned changes, and keep daemon lifecycle external.',
+  'Product-control mutation, connected-host lifecycle, and connected-host posture changes are disabled here.',
+  'Use explicit Agent CLI/slash commands for Agent-owned changes, and keep connected-host lifecycle external.',
 ].join(' ');
 
 export function installAgentToolPolicyGuard(registry: ToolRegistry, options: AgentToolPolicyGuardOptions = {}): void {
@@ -250,7 +248,7 @@ export function installAgentToolPolicyGuard(registry: ToolRegistry, options: Age
         modeSet: READ_ONLY_CONTROL_TOOL_MODE_SET,
         description: [
           'Read-only product-control inspection for GoodVibes Agent.',
-          'Command, panel, and subscription catalogs can be inspected, but product-control mutation and daemon lifecycle are external.',
+          'Command, panel, and subscription catalogs can be inspected, but product-control mutation and connected-host lifecycle are external.',
         ].join(' '),
         denial: CONTROL_MUTATION_DENIAL,
       });
@@ -363,7 +361,7 @@ export function wrapBlockedSettingsToolForAgentPolicy(tool: Tool): void {
   tool.definition.description = [
     'Blocked in GoodVibes Agent main conversation: configuration mutation.',
     'Use explicit Agent CLI/slash settings commands for intentional config changes.',
-    'Daemon lifecycle and service exposure remain externally managed by GoodVibes TUI/daemon.',
+    'Connected-host lifecycle and service exposure remain externally managed outside GoodVibes Agent.',
   ].join(' ');
   tool.definition.sideEffects = [];
   tool.definition.parameters = {

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.1.116';
+let _version = '0.1.117';
 let _sdkVersion = '0.33.35';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8')) as {