@pellux/goodvibes-agent 0.1.111 → 0.1.113

package/docs/getting-started.md

@@ -96,9 +96,9 @@ Memory, personas, routines, and reusable Agent skills are local to GoodVibes Age
 /channels
 /agent-skills create --name "Morning Brief" --description "Daily briefing flow" --procedure "Check tasks, approvals, calendar, and unread state before summarizing." --enabled true
 /agent-skills enabled
-/skills local list
-/recall add fact Prefers concise morning briefings --scope project --tags preference
-/recall search morning
+/skills list
+/memory add fact "Prefers concise morning briefings" --scope project --tags preference
+/memory search morning
 ```
 
 The active persona plus enabled Agent routines, reviewed memory, and skills are injected into the main serial assistant conversation. Starting a routine records local usage and prints its steps; it does not spawn background agents or automation jobs. Promoting a routine to a schedule is an explicit `schedules.create` call, requires `--yes`, writes a local redacted promotion receipt, and preserves the rule that Agent Knowledge never falls back to default Knowledge/Wiki or non-Agent knowledge segments.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pellux/goodvibes-agent",
-  "version": "0.1.111",
+  "version": "0.1.113",
   "private": false,
   "description": "GoodVibes personal operator assistant TUI with a proactive Agent product brain, isolated Agent Knowledge, local profiles, routines, skills, personas, and explicit build delegation.",
   "type": "module",

package/src/cli/help.ts

@@ -188,6 +188,8 @@ const COMMAND_HELP: Record<string, CommandHelp> = {
       'skills list',
       'skills enabled',
       'skills active',
+      'skills discover',
+      'skills import-discovered <name> [--enabled] --yes',
       'skills search <query>',
       'skills show <id>',
       'skills create --name <name> --description <summary> --procedure <steps> [--tags a,b] [--triggers a,b] [--enabled]',
@@ -202,6 +204,8 @@ const COMMAND_HELP: Record<string, CommandHelp> = {
     summary: 'Manage reusable Agent-local procedures and skill bundles for the main conversation.',
     examples: [
       'skills list',
+      'skills discover',
+      'skills import-discovered "Daily Brief" --enabled --yes',
       'skills create --name "Daily Brief" --description "Summarize operator state" --procedure "Review Agent Knowledge, work plans, approvals, and routines" --enabled',
       'skills bundle create --name "Ops Pack" --description "Daily operations bundle" --skills daily-brief --enabled',
       'skills delete daily-brief --yes',
@@ -366,7 +370,6 @@ const HELP_ALIASES: Record<string, string> = {
   skill: 'skills',
   'agent-skills': 'skills',
   memories: 'memory',
-  recall: 'memory',
   subscriptions: 'subscription',
   secret: 'secrets',
   session: 'sessions',

package/src/cli/local-library-command.ts

@@ -1,5 +1,6 @@
 import { createShellPathService } from '@/runtime/index.ts';
 import { AgentPersonaRegistry, type AgentPersonaRecord } from '../agent/persona-registry.ts';
+import { discoverSkills, type SkillRecord } from '../agent/skill-discovery.ts';
 import {
   AgentSkillRegistry,
   type AgentSkillBundleRecord,
@@ -107,6 +108,13 @@ function skillRegistry(runtime: CliCommandRuntime): AgentSkillRegistry {
   }));
 }
 
+function shellPaths(runtime: CliCommandRuntime): ReturnType<typeof createShellPathService> {
+  return createShellPathService({
+    workingDirectory: runtime.workingDirectory,
+    homeDirectory: runtime.homeDirectory,
+  });
+}
+
 function summarizePersona(persona: AgentPersonaRecord, activePersonaId: string | null): string {
   const active = persona.id === activePersonaId ? 'active' : 'available';
   const tags = persona.tags.length > 0 ? ` tags=${persona.tags.join(',')}` : '';
@@ -174,6 +182,52 @@ function renderSkillList(title: string, path: string, skills: readonly AgentSkil
   ].join('\n');
 }
 
+function summarizeDiscoveredSkill(skill: SkillRecord): string {
+  const description = skill.description ? ` - ${skill.description}` : '';
+  const dependencies = skill.dependencies.length > 0 ? ` deps=${skill.dependencies.join(',')}` : '';
+  const includes = skill.includes.length > 0 ? ` includes=${skill.includes.join(',')}` : '';
+  return [
+    `  ${skill.name}  ${skill.origin}${description}${dependencies}${includes}`,
+    `    path: ${skill.path}`,
+  ].join('\n');
+}
+
+function renderDiscoveredSkillList(skills: readonly SkillRecord[]): string {
+  if (skills.length === 0) {
+    return [
+      'Discovered Agent skill files',
+      '  No SKILL.md or .md skill files found in Agent skill folders.',
+      '  Search roots: .goodvibes/skills, .goodvibes/agent/skills, ~/.goodvibes/skills, ~/.goodvibes/agent/skills',
+    ].join('\n');
+  }
+  return [
+    `Discovered Agent skill files (${skills.length})`,
+    ...skills.map(summarizeDiscoveredSkill),
+    '',
+    'Import one with: goodvibes-agent skills import-discovered <name> --yes',
+  ].join('\n');
+}
+
+function discoveredSkillLookupValues(skill: SkillRecord): readonly string[] {
+  const slug = skill.name.trim().toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/^-+|-+$/g, '');
+  const basename = skill.path.split(/[\\/]/).pop()?.replace(/\.md$/i, '') ?? '';
+  return [skill.name, slug, skill.path, basename]
+    .map((value) => value.trim().toLowerCase())
+    .filter(Boolean);
+}
+
+function findDiscoveredSkill(skills: readonly SkillRecord[], idOrName: string): SkillRecord | null {
+  const lookup = idOrName.trim().toLowerCase();
+  if (!lookup) return null;
+  return skills.find((skill) => discoveredSkillLookupValues(skill).includes(lookup)) ?? null;
+}
+
+function discoveredFrontmatterList(skill: SkillRecord, key: string): readonly string[] {
+  const value = skill.frontmatter[key];
+  if (!value) return [];
+  return value.split(',').map((entry) => entry.trim()).filter(Boolean);
+}
+
 function renderBundleList(title: string, path: string, bundles: readonly AgentSkillBundleRecord[]): string {
   if (bundles.length === 0) {
     return [
@@ -231,7 +285,7 @@ function usagePersonas(): string {
 }
 
 function usageSkills(): string {
-  return 'Usage: goodvibes-agent skills [list|enabled|active|search <query>|show <id>|create|update <id>|enable <id>|disable <id>|review <id>|stale <id> <reason>|delete <id> --yes|bundle ...]';
+  return 'Usage: goodvibes-agent skills [list|enabled|active|discover|import-discovered <name> --yes|search <query>|show <id>|create|update <id>|enable <id>|disable <id>|review <id>|stale <id> <reason>|delete <id> --yes|bundle ...]';
 }
 
 function usageBundles(): string {
@@ -453,6 +507,41 @@ export async function handleSkillsCommand(runtime: CliCommandRuntime): Promise<C
         snapshot.enabledBundles.length > 0 ? renderBundleList('Enabled Agent skill bundles', snapshot.path, snapshot.enabledBundles) : '',
       ].filter(Boolean).join('\n\n'));
     }
+    if (normalized === 'discover') {
+      const discovered = await discoverSkills(shellPaths(runtime));
+      return success(runtime, 'agent.skills.discover', { skills: discovered }, renderDiscoveredSkillList(discovered));
+    }
+    if (normalized === 'import-discovered' || normalized === 'import-skill') {
+      const options = parseOptions(rest);
+      const name = options.positionals.join(' ').trim();
+      if (!name) return failure(runtime, 'invalid_skill_command', 'Usage: goodvibes-agent skills import-discovered <name> [--enabled] --yes', 2);
+      const discovered = findDiscoveredSkill(await discoverSkills(shellPaths(runtime)), name);
+      if (!discovered) {
+        return failure(runtime, 'skill_discovery_not_found', `Unknown discovered Agent skill: ${name}\nRun goodvibes-agent skills discover to inspect available skill files.`, 1);
+      }
+      if (!hasFlag(options, 'yes')) {
+        return success(runtime, 'agent.skills.import_discovered.preview', { skill: discovered }, [
+          'Agent skill import preview',
+          `  name: ${discovered.name}`,
+          `  origin: ${discovered.origin}`,
+          `  path: ${discovered.path}`,
+          `  description: ${discovered.description || '(none)'}`,
+          `  procedure characters: ${discovered.body.length}`,
+          '  next: rerun with --yes to import into the Agent-local skill registry',
+        ].join('\n'));
+      }
+      const skill = registry.create({
+        name: discovered.name,
+        description: discovered.description || `Imported skill from ${discovered.origin} skill file.`,
+        procedure: discovered.body,
+        tags: discoveredFrontmatterList(discovered, 'tags'),
+        triggers: discoveredFrontmatterList(discovered, 'triggers'),
+        enabled: hasFlag(options, 'enabled'),
+        source: 'imported',
+        provenance: `discovered:${discovered.origin}:${discovered.path}`,
+      });
+      return success(runtime, 'agent.skills.import_discovered', skill, `Imported Agent skill ${skill.id}: ${skill.name}${skill.enabled ? ' (enabled)' : ''}`);
+    }
     if (normalized === 'search' || normalized === 'find') {
       const query = rest.join(' ').trim();
       const results = registry.search(query);

package/src/cli/parser.ts

@@ -26,7 +26,6 @@ const COMMAND_ALIASES: Readonly<Record<string, GoodVibesCliCommand>> = {
   'agent-skills': 'skills',
   memory: 'memory',
   memories: 'memory',
-  recall: 'memory',
   routines: 'routines',
   routine: 'routines',
   auth: 'auth',
@@ -66,7 +65,6 @@ function createDefaultFlags(): GoodVibesCliFlags {
     provider: undefined,
     model: undefined,
     agentProfile: undefined,
-    daemonHome: undefined,
     runtimeUrl: undefined,
     workingDir: undefined,
     help: false,
@@ -286,12 +284,6 @@ export function parseGoodVibesCli(
       if (consumed.value !== undefined) flags = withFlag(flags, 'agentProfile', consumed.value);
       continue;
     }
-    if (name === '--daemon-home') {
-      const consumed = getValue(argv, index, inlineValue, name, errors);
-      index = consumed.nextIndex;
-      if (consumed.value !== undefined) flags = withFlag(flags, 'daemonHome', consumed.value);
-      continue;
-    }
     if (name === '--runtime-url' || name === '--runtime') {
       const consumed = getValue(argv, index, inlineValue, name, errors);
       index = consumed.nextIndex;

package/src/cli/service-posture.ts

@@ -186,12 +186,6 @@ export async function buildCliServicePosture(
   if (serverBackedEnabled && !config.enabled) {
     issues.push('Connected-service settings are present, but Agent service ownership is disabled by design.');
   }
-  if (config.enabled && !config.autostart) {
-    issues.push('Connected-service autostart is off.');
-  }
-  if (config.enabled && !config.restartOnFailure) {
-    issues.push('Connected-service restart-on-failure is off.');
-  }
   for (const endpoint of endpoints) {
     if (endpoint.enabled && options.probe && endpoint.reachable === false) {
       issues.push(`${endpoint.label} is enabled but not reachable on ${endpoint.binding.host}:${endpoint.binding.port}.`);
@@ -233,8 +227,7 @@ export function formatCliServicePosture(posture: CliServicePosture, json = false
     '  ownership: managed outside goodvibes-agent',
     '  Agent owns lifecycle: no',
     `  external host config present: ${yesNo(posture.config.enabled)}`,
-    `  external host autostart config: ${yesNo(posture.config.autostart)}`,
-    `  external host restart config: ${yesNo(posture.config.restartOnFailure)}`,
+    '  external host lifecycle config: ignored by Agent',
     `  legacy host switch present: ${yesNo(posture.config.daemonEnabled)}`,
     `  log: ${posture.log.path ?? 'n/a'} (${posture.log.exists ? 'present' : 'missing'})`,
     ...(posture.log.readError ? [`  log read error: ${posture.log.readError}`] : []),

package/src/cli/status.ts

@@ -99,8 +99,6 @@ function bindLine(label: string, enabled: unknown, binding: { readonly hostMode:
 export function buildCliDoctorFindings(options: CliStatusOptions): readonly CliDoctorFinding[] {
   const config = options.configManager;
   const serviceEnabled = config.get('service.enabled') === true;
-  const serviceAutostart = config.get('service.autostart') === true;
-  const restartOnFailure = config.get('service.restartOnFailure') === true;
   const daemonEnabled = config.get('danger.daemon') === true;
   const listenerEnabled = config.get('danger.httpListener') === true;
   const webEnabled = config.get('web.enabled') === true;
@@ -180,30 +178,6 @@ export function buildCliDoctorFindings(options: CliStatusOptions): readonly CliD
     });
   }
 
-  if (serviceEnabled && !serviceAutostart) {
-    findings.push({
-      id: 'runtime-autostart-disabled',
-      area: 'runtime',
-      severity: 'warning',
-      summary: 'Connected-service autostart is off.',
-      cause: 'service.enabled is true and service.autostart is false.',
-      impact: 'Connected GoodVibes services may not be available after login or reboot even though host-managed startup is selected.',
-      action: 'Configure autostart from GoodVibes TUI or the owning host; Agent will not mutate this setting.',
-    });
-  }
-
-  if (serviceEnabled && !restartOnFailure) {
-    findings.push({
-      id: 'runtime-restart-disabled',
-      area: 'runtime',
-      severity: 'warning',
-      summary: 'Connected-service restart-on-failure is off.',
-      cause: 'service.enabled is true and service.restartOnFailure is false.',
-      impact: 'A crashed connected service or listener may stay down until manually restarted.',
-      action: 'Configure restart-on-failure from GoodVibes TUI or the owning host; Agent will not mutate this setting.',
-    });
-  }
-
   if (options.service) {
     for (const issue of options.service.issues) {
       if (findings.some((finding) => finding.summary === issue)) continue;
@@ -342,8 +316,6 @@ export function renderCliStatus(options: CliStatusOptions): string {
   const config = options.configManager;
   const snapshot = buildCliStatusSnapshot(options);
   const serviceEnabled = snapshot.runtimeConnection.enabled;
-  const serviceAutostart = snapshot.runtimeConnection.autostart;
-  const restartOnFailure = snapshot.runtimeConnection.restartOnFailure;
   const controlPlaneEnabled = snapshot.runtimeEndpoints.controlPlane.enabled;
   const listenerEnabled = snapshot.runtimeEndpoints.httpListener.enabled;
   const webEnabled = snapshot.runtimeEndpoints.web.enabled;
@@ -414,8 +386,7 @@ export function renderCliStatus(options: CliStatusOptions): string {
       '',
       'Connected-Service Config Signals:',
       `  host config present: ${yesNo(serviceEnabled)}`,
-      `  host autostart: ${yesNo(serviceAutostart)}`,
-      `  host restart policy: ${yesNo(restartOnFailure)}`,
+      '  lifecycle config: external to Agent',
       '',
       'Endpoint Diagnostics:',
       bindLine('runtimeApi', controlPlaneEnabled, controlPlaneBinding),

package/src/cli/types.ts

@@ -39,7 +39,6 @@ export interface GoodVibesCliFlags {
   readonly provider: string | undefined;
   readonly model: string | undefined;
   readonly agentProfile: string | undefined;
-  readonly daemonHome: string | undefined;
   readonly runtimeUrl: string | undefined;
   readonly workingDir: string | undefined;
   readonly help: boolean;

package/src/input/agent-workspace-categories.ts

@@ -52,7 +52,7 @@ export const AGENT_WORKSPACE_CATEGORIES: readonly AgentWorkspaceCategory[] = [
     detail: 'Agent uses connected channel accounts. Pairing, account inspection, and readiness checks are visible here; inbound delivery and public channel exposure stay policy-gated.',
     actions: [
       { id: 'pair', label: 'Pair companion', detail: 'Open the QR pairing view for companion app setup.', command: '/pair', kind: 'command', safety: 'safe' },
-      { id: 'channel-readiness', label: 'Channel readiness', detail: 'Show a read-only readiness matrix for configured messaging and notification channels.', command: '/channels', kind: 'command', safety: 'read-only' },
+      { id: 'channel-readiness', label: 'Channel readiness', detail: 'Show the read-only readiness matrix, then use /channels attention or /channels show <id> for setup detail.', command: '/channels', kind: 'command', safety: 'read-only' },
       { id: 'notification-routes', label: 'Notification routes', detail: 'Inspect configured webhook notification URLs without sending a test message.', command: '/notify list', kind: 'command', safety: 'read-only' },
       { id: 'notification-add-webhook', label: 'Add webhook target', detail: 'Open a confirmed form that adds one webhook notification target for explicit reminder and routine delivery.', editorKind: 'notify-webhook', kind: 'editor', safety: 'safe' },
       { id: 'notification-remove-webhook', label: 'Remove webhook target', detail: 'Open a confirmed form that removes one exact webhook notification target from Agent delivery.', editorKind: 'notify-webhook-remove', kind: 'editor', safety: 'safe' },
@@ -116,10 +116,9 @@ export const AGENT_WORKSPACE_CATEGORIES: readonly AgentWorkspaceCategory[] = [
     id: 'profiles',
     group: 'SETUP',
     label: 'Profiles',
-    summary: 'Isolated Agent homes, config profiles, and setup bundles.',
-    detail: 'Profiles isolate Agent state. Named homes and starter templates let one install behave like separate assistants for household, research, travel, operations, or personal workflows.',
+    summary: 'Isolated Agent homes, starter templates, and setup bundles.',
+    detail: 'Agent profiles isolate Agent state. Named homes and starter templates let one install behave like separate assistants for household, research, travel, operations, or personal workflows.',
     actions: [
-      { id: 'profiles-open', label: 'Open config profiles', detail: 'Open the config profile picker for display/provider/behavior profile files.', command: '/profiles', kind: 'command', safety: 'safe' },
       { id: 'runtime-profile-guide', label: 'Starter authoring guide', detail: 'Open the Agent-local starter authoring flow inside the Agent TUI.', command: '/agent-profile guide', kind: 'command', safety: 'safe' },
       { id: 'runtime-profile-templates', label: 'Browse starter templates', detail: 'List built-in and local Agent starter templates with persona, skill, routine, and source details.', command: '/agent-profile templates', kind: 'command', safety: 'read-only' },
       { id: 'runtime-profile-list', label: 'List Agent profiles', detail: 'List isolated Agent profile homes under this Agent home.', command: '/agent-profile list', kind: 'command', safety: 'read-only' },
@@ -221,9 +220,8 @@ export const AGENT_WORKSPACE_CATEGORIES: readonly AgentWorkspaceCategory[] = [
     summary: 'Visible task state, work plan, and approval posture.',
     detail: 'Use this workspace to inspect active operator state. Side-effecting approval decisions require explicit commands and confirmation outside this workspace.',
     actions: [
-      { id: 'workplan', label: 'Open work plan', detail: 'Open the workspace-scoped work plan panel.', command: '/workplan panel', kind: 'command', safety: 'read-only' },
-      { id: 'workplan-list', label: 'List work plan', detail: 'Print a concise work plan summary.', command: '/workplan list', kind: 'command', safety: 'read-only' },
-      { id: 'approvals', label: 'Review approvals', detail: 'Open/read approval posture. This workspace does not approve or deny requests.', command: '/approval open', kind: 'command', safety: 'read-only' },
+      { id: 'workplan', label: 'Review work plan', detail: 'Print a concise work plan summary in the main Agent transcript.', command: '/workplan list', kind: 'command', safety: 'read-only' },
+      { id: 'approvals', label: 'Review approvals', detail: 'Print the approval matrix without approving or denying requests.', command: '/approval matrix', kind: 'command', safety: 'read-only' },
     ],
   },
   {

package/src/input/agent-workspace-snapshot.ts

@@ -240,13 +240,6 @@ export function buildAgentWorkspaceRuntimeSnapshot(context: CommandContext): Age
       return [];
     }
   })();
-  const configProfileCount = (() => {
-    try {
-      return context.workspace?.profileManager?.list?.().length ?? 0;
-    } catch {
-      return 0;
-    }
-  })();
   const runtimeStarterTemplates = (() => {
     try {
       return listAgentRuntimeProfileTemplates(context.workspace?.shellPaths?.homeDirectory ?? '');
@@ -379,8 +372,8 @@ export function buildAgentWorkspaceRuntimeSnapshot(context: CommandContext): Age
     mcpConnectedServerCount: mcpSnapshot.connectedCount,
     mcpQuarantinedServerCount: mcpSnapshot.quarantinedCount,
     mcpAllowAllServerCount: mcpSnapshot.allowAllCount,
-    browserSurfaceEnabled: readConfigBoolean(context, 'web.enabled', false),
-    browserSurfacePublicBaseUrl: readConfigString(context, 'web.publicBaseUrl', '(not configured)'),
+    browserToolExposureEnabled: readConfigBoolean(context, 'web.enabled', false),
+    browserToolPublicBaseUrl: readConfigString(context, 'web.publicBaseUrl', '(not configured)'),
     activeRuntimeProfile: inferActiveRuntimeProfile(context.workspace?.shellPaths?.homeDirectory ?? ''),
     runtimeProfileCount: runtimeProfiles.length,
     runtimeProfiles: runtimeProfiles.map(summarizeRuntimeProfile),
@@ -388,7 +381,6 @@ export function buildAgentWorkspaceRuntimeSnapshot(context: CommandContext): Age
     runtimeStarterTemplateCount: runtimeStarterTemplates.length,
     localStarterTemplateCount: runtimeStarterTemplates.filter((template) => template.source === 'local').length,
     runtimeStarterTemplates: runtimeStarterTemplates.map(summarizeStarterTemplate),
-    configProfileCount,
     setupChecklist,
     warnings,
   };

package/src/input/agent-workspace-types.ts

@@ -190,8 +190,8 @@ export interface AgentWorkspaceRuntimeSnapshot {
   readonly mcpConnectedServerCount: number;
   readonly mcpQuarantinedServerCount: number;
   readonly mcpAllowAllServerCount: number;
-  readonly browserSurfaceEnabled: boolean;
-  readonly browserSurfacePublicBaseUrl: string;
+  readonly browserToolExposureEnabled: boolean;
+  readonly browserToolPublicBaseUrl: string;
   readonly activeRuntimeProfile: string;
   readonly runtimeProfileCount: number;
   readonly runtimeProfiles: readonly AgentWorkspaceRuntimeProfileItem[];
@@ -199,7 +199,6 @@ export interface AgentWorkspaceRuntimeSnapshot {
   readonly runtimeStarterTemplateCount: number;
   readonly localStarterTemplateCount: number;
   readonly runtimeStarterTemplates: readonly AgentWorkspaceRuntimeStarterTemplateItem[];
-  readonly configProfileCount: number;
   readonly setupChecklist: readonly AgentWorkspaceSetupChecklistItem[];
   readonly warnings: readonly string[];
 }

package/src/input/commands/brief-runtime.ts

@@ -101,7 +101,7 @@ export function formatAgentOperatorBriefing(ctx: CommandContext): string {
     `  skills: ${snapshot.enabledSkillCount}/${snapshot.localSkillCount} enabled; bundles ${snapshot.enabledSkillBundleCount}/${snapshot.localSkillBundleCount}; active ${snapshot.activeSkillCount}`,
     `  routines: ${snapshot.enabledRoutineCount}/${snapshot.localRoutineCount} enabled`,
     `  channels: ${readyChannels}/${snapshot.channels.length} ready; ${enabledChannels} enabled`,
-    `  voice/media: ${snapshot.voiceProviderCount} voice, ${snapshot.mediaProviderCount} media; browser surface ${snapshot.browserSurfaceEnabled ? 'enabled' : 'disabled'}`,
+    `  voice/media: ${snapshot.voiceProviderCount} voice, ${snapshot.mediaProviderCount} media; browser tools ${snapshot.voiceMediaReadiness.browserToolState}`,
     formatWorkPlanLine(workPlan.total, workPlan.counts),
     `  schedules: ${enabledJobs}/${jobs.length} visible jobs enabled`,
     '',