@pega/custom-dx-components 0.25.34 → 0.25.36

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pega/custom-dx-components",
-  "version": "0.25.34",
+  "version": "0.25.36",
   "description": "Utility for building custom UI components",
   "bin": "./bin/index.js",
   "scripts": {

package/src/tasks/create/templates/Launchpad/Widget/PAGE-CASE/Avatar.tsx.mustache

@@ -1,4 +1,3 @@
-/* eslint-disable react-hooks/rules-of-hooks */
 import React from 'react';
 import { useEffect, useState } from 'react';
 import { Avatar as CosmosAvatar } from '@pega/cosmos-react-core';

package/src/tasks/create-lib/helper.js

@@ -1,5 +1,8 @@
 
 import chalk from 'chalk';
+import fs from 'fs';
+import path from 'path';
+import { join } from 'path';
 
 import {
   sanitize,
@@ -9,9 +12,12 @@ import {
   getConfigDefaults,
   getComponents,
   updateConfigVersion,
-  getLibraryBasedCL
+  getLibraryBasedCL,
+  copyFileToShared
 } from '../../util.js';
 
+import { SHARED_FILE_NAMES } from '../../constants.js';
+
 
 export const updateAllComponentsConfig = async( newVersion ) => {
 addDebugLog("updateAllComponentsConfig", `newVersion: ${newVersion}`, "");
@@ -27,6 +33,69 @@ addDebugLog("updateAllComponentsConfig", `newVersion: ${newVersion}`, "");
   }
 };
 
+export const updateAllMigrateToLibChanges = async() => {
+  // get src/components directories
+  const componentList = await getComponents();
+  const currentDirectory = process.cwd();
+  // for each directory
+
+  for (const index in componentList) {
+    const componentKey = componentList[index];
+    const compDir = join(currentDirectory,'src', 'components', componentKey);
+
+    const componentFiles = fs.readdirSync(compDir);
+
+    componentFiles.forEach( file => {
+
+      const filePath = join(compDir, file);
+      const fileData = fs.readFileSync(filePath, { encoding: 'utf8' });
+
+       let newOutput = fileData;
+      if (SHARED_FILE_NAMES.includes(file)) {
+
+        // fix create nonce for ESLint 9
+        if (file.includes('create-nonce')) {
+          newOutput = newOutput.replace("__webpack_nonce__ = window.__webpack_nonce__;", "// eslint-disable-next-line no-undef\n__webpack_nonce__ = window.__webpack_nonce__;");
+        }
+
+        // write to shared
+        copyFileToShared(file, newOutput);
+
+        // delete file from main components
+        fs.rmSync(filePath);
+      }
+      else if (file.includes(".tsx") || file.includes(".ts") ) {
+
+        // going to search for shared file names and change the import path
+
+        for (const index in SHARED_FILE_NAMES) {
+          const sFileName = SHARED_FILE_NAMES[index].split(".")[0];
+          const orgPath = "./".concat(sFileName);
+          const newPath = "../shared/".concat(sFileName);
+
+          newOutput = newOutput.replaceAll(orgPath, newPath);
+
+          // updates for ESLint 9
+          newOutput = newOutput.replaceAll("/* eslint-disable react-hooks/exhaustive-deps */", "");
+          newOutput = newOutput.replaceAll("// eslint-disable-next-line react-hooks/exhaustive-deps", "");
+          newOutput = newOutput.replaceAll("// eslint-disable-next-line @typescript-eslint/no-unused-vars", "");
+          newOutput = newOutput.replaceAll("/* eslint-disable react-hooks/rules-of-hooks */", "");
+          newOutput = newOutput.replaceAll("/* eslint-disable-next-line no-empty */", "");
+          newOutput = newOutput.replaceAll("// eslint-disable-next-line no-empty", "");
+
+        }
+        fs.writeFileSync(filePath, newOutput);
+      }
+
+    });
+
+
+  }
+
+  console.log(`${chalk.green(`>> Code base was upgraded.  You may still have some lint errors that need to be fixed manually.`)}`);
+
+}
+
 export const getCurrentOrOriginalQuestion = async () => {
 addDebugLog("getCurrentOrOriginal", "", "");
 

package/src/tasks/create-lib/index.js

@@ -22,10 +22,11 @@ import {
   setConfigDevBuild,
   getUseInputConfig,
   getInputConfigForCommand,
-  convertYNToBoolean
+  convertYNToBoolean,
+  getComponents
 } from '../../util.js';
 
-import { getCreateLibComponentQuestions, getOkToProceedQuestion, updateAllComponentsConfig, getCurrentOrOriginalQuestion } from './helper.js';
+import { getCreateLibComponentQuestions, getOkToProceedQuestion, updateAllComponentsConfig, getCurrentOrOriginalQuestion, updateAllMigrateToLibChanges } from './helper.js';
 import { showCurrentStatus } from '../show-status/index.js';
 
 export default async options => {
@@ -49,8 +50,9 @@ export default async options => {
       const libraryName = inputConfig.libraryName;
       let version = inputConfig.libraryVersion;
       const currentOrOriginal = inputConfig.currentOrOriginal;
-      const isPermanent = inputConfig.isPermanent;
+      const isPermanent = inputConfig?.isPermanent || "N";
       let permBuild = convertYNToBoolean(isPermanent);
+      const okToUpgrade = convertYNToBoolean(inputConfig.okToUpgrade);
 
       // if have store, then that means there is a current library, so
       // store it before clearing out /src/components
@@ -97,6 +99,9 @@ export default async options => {
       // update the config jsons
       if (!hasArch) {
         await updateAllComponentsConfig(version);
+        if (okToUpgrade) {
+          await updateAllMigrateToLibChanges();
+        }
       }
 
       console.log(`${chalk.bold.green(`\nLibrary ${newOrgLib}/${version} has been created!\n`)}`);
@@ -227,8 +232,38 @@ addDebugLog("createLibrary", "", "+");
 
   // if didn't have an archive, in case you currently have components there
   // update the config jsons
+
+
   if (!hasArch) {
     await updateAllComponentsConfig(version);
+
+    const componentList = await getComponents();
+
+    if (componentList && componentList.length > 0) {
+      console.log("");
+      console.log(`You are creating a new library with existing components in ${chalk.yellow(`/src/components`)}.`);
+      console.log("These components code base can be stale and may need ES Lint updates.");
+      console.log("Some of these updates can happen automatically during library creation.");
+      console.log("");
+
+      const upgradeAnswer = await inquirer.prompt([
+        {
+          name: 'upgrade',
+          message: 'Would you like to update your code ?',
+          type: 'confirm',
+          default: true
+        }
+      ]);
+
+      if (upgradeAnswer.upgrade) {
+        await updateAllMigrateToLibChanges();
+      }
+    }
+
+
+
+
+
   }
 
   console.log(`${chalk.bold.green(`\nLibrary ${newOrgLib}/${version} has been created!\n`)}`);

package/src/tasks/create-version/index.js

@@ -61,7 +61,7 @@ addDebugLog("createVersion", "", "+");
 
     if (convertYNToBoolean(inputConfig.okToContinue)) {
       version = inputConfig.libraryVersion;
-      const isPermanent = inputConfig.isPermanent;
+      const isPermanent = inputConfig?.isPermanent || "N";
       permBuild = convertYNToBoolean(isPermanent);
       copyExisting = convertYNToBoolean(inputConfig.copyComponents);
 

package/src/tasks/delete-lib/index.js

@@ -238,7 +238,7 @@ addDebugLog("deleteLibrary", "", "+");
     const inputConfig = await getInputConfigForCommand("deleteLib");
     libraryName = inputConfig.libraryName;
     version = inputConfig.libraryVersion;
-    const isPermanent = inputConfig.isPermanent;
+    const isPermanent = inputConfig?.isPermanent || "N";
     let permBuild = convertYNToBoolean(isPermanent);
 
     if (isLibraryBasedCL) {

package/src/tasks/delete-version/index.js

@@ -42,7 +42,7 @@ addDebugLog("deleteVersion", "", "+");
   if (useInputConfig) {
     const inputConfig = await getInputConfigForCommand("deleteLibVersion");
     version = inputConfig.libraryVersion;
-    const isPermanent = inputConfig.isPermanent;
+    const isPermanent = inputConfig?.isPermanent || "N";
     let permBuild = convertYNToBoolean(isPermanent);
 
     if (isLibraryBasedCL) {

package/src/tasks/init/template/eslint.config.mjs

@@ -32,6 +32,7 @@ export default tseslint.config(
     '**/mock.stories.js',
     '**/demo.stories.tsx',
     '**/demo.test.tsx',
+    '**/*.test.tsx',
     '**/mock.stories.ts',
     '**/*.mdx',
     '**/webpack.config.js',
@@ -131,7 +132,6 @@ export default tseslint.config(
       'no-alert': 'off',
       'no-console': 'error',
       'no-fallthrough': 'error',
-      'no-undef': 'error',
       'no-unused-vars': 'off',
       'no-var': 'off',
       yoda: 'error',
@@ -155,7 +155,6 @@ export default tseslint.config(
       'react/no-unused-prop-types': 'error',
       'react/static-property-placement': 'error',
       'array-callback-return': 'error',
-      camelcase: 'error',
       'func-names': 'error',
       'no-case-declarations': 'error',
       'no-lonely-if': 'error',
@@ -208,7 +207,6 @@ export default tseslint.config(
   {
     files: ['**/*.@(ts|tsx)'],
     rules: {
-      'no-undef': 'error',
       'no-console': 'off',
       'import/prefer-default-export': 'off',
       'import/no-relative-packages': 'off',

package/src/tasks/init/template/package.json.mustache

@@ -107,7 +107,7 @@
     "@babel/preset-react": "^7.27.1",
     "@babel/preset-typescript": "^7.27.1",
     "@pega/configs": "^0.16.3",
-    "@pega/custom-dx-components": "~0.25.34",
+    "@pega/custom-dx-components": "~0.25.36",
     "@pega/pcore-pconnect-typedefs": "^4.1.0-alpha.1",
     "@storybook/addon-actions": "^8.6.12",
     "@storybook/addon-essentials": "^8.6.12",

package/src/tasks/publish/index.js

@@ -20,7 +20,8 @@ import {
   checkAccessTokenExpiration,
   checkJWTExpiration,
   getConfigDefaults,
-  getInputConfigForCommand } from '../../util.js';
+  getInputConfigForCommand,
+  convertYNToBoolean} from '../../util.js';
 
 import { getPublishComponentQuestions, publishComponentToServer, zipComponent } from './helper.js';
 import { default as buildLibrary } from '../build-lib/index.js';
@@ -66,11 +67,14 @@ addDebugLog("publish", "", "+");
     if (useInputConfig) {
       const inputConfig = await getInputConfigForCommand("publish");
 
+      const okToPubPerm = inputConfig?.okToPublishPermanent || "Y";
+      const okToPublishPerm = convertYNToBoolean(okToPubPerm);
+
       // console.log("Input config: ");
       // console.log(inputConfig);
 
       if (inputConfig.okToPublish ) {
-        if (devBuild || (!devBuild && inputConfig.okToPublishPermanent)) {
+        if (devBuild || (!devBuild && okToPublishPerm)) {
           okToPublish = true;
         }
 

package/src/tasks/switch-lib/index.js

@@ -67,7 +67,7 @@ addDebugLog("switchLibrary", "", "+");
       const newLibraryName = inputConfig.libraryName;
       newOrgLib = `${orgLib.organization}_${newLibraryName}`;
       version = inputConfig.libraryVersion;
-      const isPermanent = inputConfig.isPermanent;
+      const isPermanent = inputConfig?.isPermanent || "N";
       let permBuild = convertYNToBoolean(isPermanent);
 
       if (isLibraryBasedCL) {

package/src/tasks/switch-version/index.js

@@ -66,7 +66,7 @@ addDebugLog("switchVersion", "", "+");
     okToContinue = convertYNToBoolean(inputConfig.okToContinue);
     if (okToContinue) {
       version = inputConfig.libraryVersion;
-      const isPermanent = inputConfig.isPermanent;
+      const isPermanent = inputConfig?.isPermanent || "N";
       let permBuild = convertYNToBoolean(isPermanent);
 
       if (isLibraryBasedCL) {

package/src/util.js

@@ -1677,9 +1677,7 @@ if (showDebug) addDebugLog("getC11NB2STokenAndStaticServer", "", "");
   if (OAuthData) {
     const { C11NB2S, appStaticContentServer, access_token } = JSON.parse(OAuthData)
 
-    if (C11NB2S) {
-      return ({ C11NB2S, appStaticContentServer, access_token});
-    }
+    return ({ C11NB2S, appStaticContentServer, access_token});
 
   }
   return ({});

package/tests/assets/original/components/createAll/Launchpad/Pega_DXIL_MyPageCaseWidget/Avatar.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable react-hooks/rules-of-hooks */
 import React from 'react';
 import { useEffect, useState } from 'react';
 import { Avatar as CosmosAvatar } from '@pega/cosmos-react-core';

package/src/tasks/init/template/.eslintignore

@@ -1,15 +0,0 @@
-webpack.config.js
-src/helpers/config_access.js
-*.html
-*.css
-*.json
-*.md
-*.svg
-*.zip
-*.d.ts
-*.storybook/*
-*.cjs
-paths.js
-*.config.mjs
-dist/*
-lib/*