@peabody-soft/mbs-model-ts 1.6.0 → 1.7.0

package/dist/GeneralSettings.js

@@ -100,7 +100,8 @@ class GeneralSettings {
     // Whether the business has turned online shopping on. The server does not refuse a business that
     // has not. Model does, with a NotFoundException, after reading everything it is sent, when the
     // settings it holds do not say so or it holds none (see Model.setBusinessId). Also false for
-    // GeneralSettings.EMPTY.
+    // GeneralSettings.EMPTY. It is the only thing about what a business sells that closes it: one with
+    // nothing a customer can buy is open, with an empty catalog.
     get onlineShoppingEnabled() {
         return this._onlineShoppingEnabled;
     }

package/dist/Model.js

@@ -294,9 +294,10 @@ class Model {
     // if not linked (see requireBusinessLink).
     // Throws NotFoundException when the business cannot be opened, on a first read or a later one (a
     // business can stop being open after it was cached). The server says so when it does not exist,
-    // is deleted, or does not allow customers to join. Online shopping off, or nothing to buy, is
-    // decided here (see syncBusinessContainer). The cache is kept, except that a business that is no
-    // longer the one the businessId names is replaced by the one that is.
+    // is deleted, or does not allow customers to join. Online shopping off is decided here (see
+    // syncBusinessContainer). Having nothing to buy does not: that business is open, with an empty
+    // catalog. The cache is kept, except that a business that is no longer the one the businessId
+    // names is replaced by the one that is.
     // isStartedOver marks the one self-call, when the link the profile found for the businessId is of
     // a business that no longer has it. The profile is read again and this starts over from it.
     async businessSyncIn(isStartedOver = false) {
@@ -393,8 +394,9 @@ class Model {
     //    from a re-read profile (see businessSyncIn). Otherwise this answers true.
     // 2. Online shopping is on in the general settings (no settings means off). The server does not
     //    refuse a business for this, so this throws NotFoundException.
-    // 3. The business has something to buy: an enabled product, not sold only offline, with a priced
-    //    package. Otherwise it throws NotFoundException too.
+    // Nothing more is asked of a business. One with nothing a customer can buy (no product that is
+    // enabled, not sold only offline, and has a priced package) is open: it is published with an empty
+    // catalog, and a UI tells its customers there is nothing to buy.
     async syncBusinessContainer(containerName, businessId, businessEntityId, firstAuthTokens) {
         const cache = Model.getCache();
         const cached = await cache.readBusiness(containerName);
@@ -454,18 +456,12 @@ class Model {
             this.publishBusiness(null);
             throw new NotFoundException("The business has not turned online shopping on");
         }
-        // What the container holds now, built once for this check and the publish below. When the read
-        // changed nothing, it is the one built from the cache.
-        const business = isPublishedStale ? Model.buildPublishable(held) : cachedBusiness;
-        if (business !== null && business.catalog.productCount === 0) {
-            // A shop with nothing to buy is not found and not shown, even if the cache published it
-            this.publishBusiness(null);
-            throw new NotFoundException("The business has nothing that a customer can buy");
-        }
         // A read the store took nothing from re-renders nobody: the cache was published above, and
-        // nothing here changes what a later read answers
+        // nothing here changes what a later read answers.
+        // A business with nothing a customer can buy is published like any other. It is open, and says
+        // so with an empty catalog (Catalog.productCount), which a UI words for its customers.
         if (isPublishedStale)
-            this.publish(business);
+            this.publishBusiness(held);
         // What is published now was read to the end, is the business the businessId names, and is open
         this._isPublishedBusinessVetted = true;
         return true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@peabody-soft/mbs-model-ts",
-  "version": "1.6.0",
+  "version": "1.7.0",
   "description": "MeraBills storefront client-side model (TypeScript)",
   "author": "Peabody Soft",
   "license": "AGPL-3.0-or-later",