@pdtf/schemas 3.6.0-4 → 3.6.0-41

package/.claude/plans/not-seeing-associated-costs.md

@@ -0,0 +1,99 @@
+# Plan: associatedCost amount field not appearing for water/drainage
+
+## Context
+
+**Reported symptom**: even with the relevant SEF25 overlay extension loaded, the `amount` input does not appear under the water and drainage *associated costs* sections when a payment frequency like "Per month" or "Per year" is selected.
+
+**Are the fields correctly ref'd?** Yes — the `sef25Ref` / `ntsRef` codes line up between base and overlay:
+
+| Field path | base `combined.json` | `sef25.json` | `extensions/sc.json` |
+| --- | --- | --- | --- |
+| water `associatedCost`             | `sef25Ref U1.1`   | `U1.1`   | `ntsRef U1.1`   |
+| water `frequency`                  | `sef25Ref U1.1.2` | `U1.1.2` | `ntsRef U1.1.2` |
+| water `amount` (in oneOf branch 1) | `sef25Ref U1.1.1` | `U1.1.1` | `ntsRef U1.1.1` |
+| drainage `associatedCost`          | `sef25Ref U1.2`   | `U1.2`   | `ntsRef U1.2`   |
+| drainage `frequency`               | `sef25Ref U1.2.2` | `U1.2.2` | `ntsRef U1.2.2` |
+| drainage `amount`                  | `sef25Ref U1.2.1` | `U1.2.1` | `ntsRef U1.2.1` |
+
+There are no `$ref` indirections involved — these are inline definitions, and they all match.
+
+## Root cause — missing `discriminator` keyword
+
+The three `associatedCost` blocks (leased solar `S1.1`, mains water `U1.1`, mains foul drainage `U1.2`) follow the project's standard *discriminated oneOf* pattern: a child enum field selects which `oneOf` branch is active. Branch 0 (`Not applicable`) leaves `amount` out; branch 1 (`Per month`/`Per year`) requires `amount`.
+
+In commit [`188809f`](../../../) ("use frequency as discriminator for associatedCost") this pattern was correctly modelled with both `oneOf` **and** `"discriminator": { "propertyName": "frequency" }`. The block was later flattened, then re‑introduced in commit [`6317499`](../../../) ("re-introduce frequency discriminator on associatedCost (lenient)"). Despite the title, that commit added the `oneOf` branches but **did not put the `discriminator` keyword back**. The current state of all three blocks is therefore `oneOf` without a discriminator hint.
+
+Every other oneOf in `combined.json` carries an explicit `discriminator` (`grep -c '"discriminator"'` on the file confirms this is the universal convention here). Both AJV (configured with `discriminator: true` in [index.js:8](../../index.js#L8)) and the schema‑driven UI generator that consumes the merged schema rely on it to know which oneOf branch is active for a given form value. Without it, picking `Per month` does not switch the active branch, so the `amount` property never becomes visible.
+
+The overlay files (`sef25.json`, `extensions/sc.json`) themselves do not need a discriminator added — the overlay extractor at [src/utils/extractOverlay.js:143-167](../../src/utils/extractOverlay.js#L143) already propagates `discriminator` from base into the generated overlays, so re‑running it after the base fix will pick the discriminator up automatically.
+
+## Fix
+
+Three identical edits to **`src/schemas/v3/combined.json`** — add the missing `discriminator` to each `associatedCost` block. After the existing `"properties": { "frequency": { ... } }` line and before `"oneOf": [ ... ]`, insert:
+
+```json
+"discriminator": { "propertyName": "frequency" },
+```
+
+### Locations
+
+1. Leased solar panel `associatedCost` (`sef25Ref: "S1.1"`) — [src/schemas/v3/combined.json:21605](../../src/schemas/v3/combined.json#L21605) (insert before line ~21618 `oneOf`)
+2. Water `mainsWater` → `oneOf[0]` (No / private supply) → `associatedCost` (`U1.1`) — [src/schemas/v3/combined.json:22425](../../src/schemas/v3/combined.json#L22425) (insert before line 22438 `oneOf`)
+3. Drainage `mainsFoulDrainage` → `oneOf[2]` (off-mains) → `associatedCost` (`U1.2`) — [src/schemas/v3/combined.json:23547](../../src/schemas/v3/combined.json#L23547) (insert before line 23560 `oneOf`)
+
+Note the leased-solar block has the same bug. The user only mentioned water and drainage, but since the structure is identical and the fix is one line each, fixing all three keeps the codebase consistent and pre‑empts the same report for solar panels later. (Confirm with user — see Open Questions.)
+
+### Regenerate
+
+```bash
+npm run extract-overlays            # regenerates pdtf-transaction.json + sef25.json etc.
+npm run extract-extension-overlays  # regenerates sc.json and other extension overlays
+```
+
+`extractOverlay.js` already detects `element.discriminator` and writes both the discriminator and the per‑branch enum into the generated overlays, so the regenerated `pdtf-transaction.json`, `overlays/sef25.json`, and `overlays/extensions/sc.json` will all carry the discriminator without manual edits.
+
+### Version bump
+
+Bump `package.json` from `3.6.0-40` to `3.6.0-41`. This is a non‑breaking schema change (existing payloads still validate; only the UI hint is restored).
+
+## Verification
+
+1. **Validate the schema fix locally:**
+   ```bash
+   npm test
+   ```
+   The existing test suite must still pass. The change is purely additive (adding a discriminator keyword on top of an existing oneOf), so no current test is expected to break.
+
+2. **Spot‑check with a small AJV/UI smoke test (optional but recommended):**
+   ```js
+   const { getTransactionSchema } = require("./index");
+   const schema = getTransactionSchema(
+     "https://trust.propdata.org.uk/schemas/v3/pdtf-transaction.json",
+     ["nts2025", "sc"]   // or ["nts2025", "sef25"-style stack you actually use
+   );
+   // Walk to schema.properties.propertyPack.properties.waterAndDrainage.properties.water.properties.mainsWater.oneOf[0].properties.associatedCost
+   // and confirm BOTH of these are present:
+   //   .discriminator === { propertyName: "frequency" }
+   //   .oneOf[1].properties.amount.type === "number"
+   ```
+
+3. **End-to-end check in the consuming UI:** load the form with the SEF25 / `sc` extension stack, pick `Per month` under water and under drainage, and confirm the `amount (£)` input appears. Repeat for `Per year` (should appear) and `Not applicable` (should hide).
+
+4. **Confirm overlays were regenerated cleanly:**
+   ```bash
+   git diff src/schemas/v3/pdtf-transaction.json src/schemas/v3/overlays/sef25.json src/schemas/v3/overlays/extensions/sc.json
+   ```
+   The diff should show `discriminator: { propertyName: "frequency" }` added in each of those three generated files alongside the existing oneOf for water/drainage (and solar, if included).
+
+## Critical files
+
+- `src/schemas/v3/combined.json` — three edits, the source of truth
+- `src/schemas/v3/pdtf-transaction.json` — regenerated, do not hand-edit
+- `src/schemas/v3/overlays/sef25.json` — regenerated
+- `src/schemas/v3/overlays/extensions/sc.json` — regenerated
+- `src/utils/extractOverlay.js` — read-only reference; already handles discriminator propagation
+- `package.json` — version bump
+
+## Open questions
+
+- Include the leased solar panel `S1.1` block in the same fix? (Identical bug, one extra one-line edit, keeps the codebase consistent — recommended yes.)

package/.claude/settings.local.json

@@ -15,7 +15,6 @@
       "Bash(git commit:*)",
       "Bash(git push:*)",
       "Bash(git fetch:*)",
-      "Bash(git checkout:*)",
       "Bash(gh pr view:*)",
       "WebFetch(domain:github.com)",
       "Bash(tree:*)",
@@ -35,8 +34,28 @@
       "Bash(base64:*)",
       "Bash(gh issue view:*)",
       "Read(//Users/ed/.claude/**)",
-      "Bash(npm init:*)"
+      "Bash(npm init:*)",
+      "Bash(do echo \"=== printWidth $w ===\")",
+      "Bash(pdftoppm:*)",
+      "Bash(pdftotext:*)",
+      "Bash(/tmp/inspect2.js:*)",
+      "Bash(/tmp/inspect3.js:*)",
+      "Bash(/tmp/inspect4.js:*)",
+      "Bash(/tmp/inspect5.js:*)",
+      "Bash(/tmp/inspect6.js:*)",
+      "Bash(/tmp/final_inspect.js:*)",
+      "Bash(file:*)",
+      "Bash(gh pr create:*)",
+      "Bash(claude --version)",
+      "Bash(gh pr list --head ta6ed6 --json number,title,url)",
+      "Bash(gh pr:*)",
+      "Bash(sort -t'.' -k1,1n -k2,2n -k3,3n -k4,4n)",
+      "Bash(wc -l /Users/ed/Code/schemas/src/schemas/v3/combined.json /Users/ed/Code/schemas/src/schemas/v3/overlays/*.json)"
     ],
-    "deny": []
+    "deny": [],
+    "additionalDirectories": [
+      "/tmp",
+      "/private/tmp"
+    ]
   }
 }

package/README.md

@@ -7,7 +7,7 @@ The Property Data Trust Framework (PDTF) Schemas provide standardized JSON Schem
 
 ## Project Goals & Status
 
-**Current Version:** 3.5.0 (3.5.1-1 available as a pre-release on branch/package-tag `next`)
+**Current Version:** 3.5.0 (3.6.0-41 available as a pre-release on branch/package-tag `next`)
 
 This schema framework aims to support the [Home Buying and Selling Group](https://homebuyingandsellinggroup.co.uk) 'Property Pack' initiative, encompassing all requirements starting with the Buyers and Sellers Property Information set ([BASPI v4.0](https://homebuyingandsellinggroup.co.uk/baspi/)).
 
@@ -62,7 +62,7 @@ if (!isValid) {
 
 - **🏗️ Modular Schema System** - Base schemas with flexible overlay composition
 - **📋 Multiple Form Support** - BASPI, NTS, Law Society TA forms, and more
-- **🧩 Extension Overlays** - Granular NTS2 features as individual modules
+- **🧩 Extension Overlays** - Granular NTS2 and SEF25 features as individual modules
 - **✅ JSON Schema Validation** - Full JSON Schema Draft 07 support with AJV
 - **🔗 Verified Claims** - Support for verified data provenance tracking
 - **📚 Comprehensive Documentation** - Detailed usage guides and examples
@@ -82,7 +82,7 @@ if (!isValid) {
 │   │   │   │   └── extensions/        # Modular NTS2 extensions
 │   │   │   │       ├── jk.json        # Japanese Knotweed
 │   │   │   │       ├── tf.json        # Transfer Fees
-│   │   │   │       └── ...            # 16 total extensions
+│   │   │   │       └── ...            # NTS2 + SEF25 extensions
 │   │   │   └── combined.json          # Master schema for generation
 │   │   ├── v2/                        # Legacy schema version
 │   │   ├── verifiedClaims/            # Verified claims schemas
@@ -163,31 +163,56 @@ const errors = validateVerifiedClaims(verifiedClaims, schemaId, ["nts2023"]);
 
 #### Extension Overlays
 
-Modular NTS2 features for selective adoption:
+Modular features for selective adoption. Extensions are merged on top of an NTS base overlay.
 
 ```javascript
-// Individual extensions
-const schema = getTransactionSchema(schemaId, ["nts2023", "jk", "tf"]);
-
-// Multiple specialist issues
-const schema = getTransactionSchema(schemaId, [
-  "nts2023",
-  "as",
-  "dr",
-  "jk",
-  "sb",
-]);
+// NTS2 extensions
+const schema = getTransactionSchema(schemaId, ["nts2023", "jk", "tf", "ma"]);
+
+// SEF25 extensions (Seller Enquiry Form)
+const sef25 = ["sc", "pc", "ph", "dk", "rw", "sd", "lc", "wg", "ic", "nd", "mi", "tr"];
+const schema = getTransactionSchema(schemaId, ["nts2023", ...sef25]);
 ```
 
-| Extension         | Code | Description                      |
-| ----------------- | ---- | -------------------------------- |
-| Japanese Knotweed | `jk` | Knotweed presence and management |
-| Transfer Fees     | `tf` | Additional leasehold fees        |
-| Managing Agent    | `ma` | Leasehold managing agent details |
-| Solar Panels      | `sl` | Solar panel ownership details    |
-| Asbestos          | `as` | Asbestos presence and management |
+**NTS2 Extensions:**
 
-[View all extensions →](src/schemas/v3/overlays/README.md#extension-overlays)
+| Extension | Code | Description |
+| --- | --- | --- |
+| Japanese Knotweed | `jk` | Knotweed presence and management |
+| Asbestos | `as` | Asbestos presence and management |
+| Dry Rot | `dr` | Dry rot treatment |
+| Subsidence | `sb` | Subsidence or structural fault |
+| Health & Safety | `hs` | Ongoing health or safety issues |
+| Outside Areas | `oa` | Outside areas details |
+| Main Construction | `mc` | Construction type if standard form |
+| Loft Access | `la` | Loft access and details |
+| Spray Foam | `sf` | Spray foam insulation |
+| Solar Panels | `sl` | Solar panel ownership details |
+| Heating Installed | `hi` | Central heating installation date |
+| Flood Defences | `fd` | Flood defence information |
+| Estate Rentcharges | `er` | Estate rentcharges for freehold |
+| Managing Agent | `ma` | Leasehold managing agent details |
+| Transfer Fees | `tf` | Additional leasehold fees |
+| Onward Chain | `oc` | Other property in chain |
+
+**SEF25 Extensions (Seller Enquiry Form):**
+
+| Extension | Code | Description |
+| --- | --- | --- |
+| Supply Costs | `sc` | Private water/sewerage costs |
+| Parking Permit Cost | `pc` | Parking permit frequency |
+| Property Hazards | `ph` | 4 hazard Yes/No questions |
+| Dropped Kerb | `dk` | Dropped kerb access to parking |
+| Private Right of Way | `rw` | Private right of way |
+| Storm/Fire/Flood Damage | `sd` | Storm, fire or flood damage |
+| Solar Lease Costs | `lc` | Solar panel lease costs |
+| Warranties & Guarantees | `wg` | 7 warranty categories upfront |
+| Insurance Claims | `ic` | Insurance claims upfront |
+| Neighbour Development | `nd` | Neighbour development |
+| Material Issue | `mi` | Other material issue upfront |
+| Title Restrictions | `tr` | Title restrictions for freehold |
+
+[View full SEF25 UI spec →](docs/sef25-extensions-ui-spec.md) | [View all extensions →](src/schemas/v3/overlays/README.md#extension-overlays)
 
 ## Usage Examples
 
@@ -204,7 +229,7 @@ const legalSchema = getTransactionSchema(schemaId, ["ta6ed4", "ta7ed3"]);
 const ntsSchema = getTransactionSchema(schemaId, ["nts2023"]);
 ```
 
-### Modular NTS2 Features
+### Modular Extension Features
 
 ```javascript
 // Selective NTS2 adoption
@@ -215,15 +240,9 @@ const partialNts2 = getTransactionSchema(schemaId, [
   "ma", // Managing Agent
 ]);
 
-// Full specialist issues
-const specialistIssues = getTransactionSchema(schemaId, [
-  "nts2023",
-  "as",
-  "dr",
-  "jk",
-  "sb",
-  "hs",
-]);
+// SEF25 Seller Enquiry Form extensions
+const sef25 = ["sc", "pc", "ph", "dk", "rw", "sd", "lc", "wg", "ic", "nd", "mi", "tr"];
+const sellerEnquiry = getTransactionSchema(schemaId, ["nts2023", ...sef25]);
 ```
 
 ### Data Validation

package/docs/sef25-extensions-ui-spec.md

@@ -0,0 +1,355 @@
+# SEF25 Extension Overlays — Front-End UI Spec
+
+## Overview
+
+Extension overlays add follow-up questions to existing form sections. Each overlay is loaded by passing its key to `getTransactionSchema(schemaId, overlays)`.
+
+### Pre-existing overlays
+
+These were added before this PR and are already in production.
+
+| Overlay Key | Name | Section | Fields Added |
+|-------------|------|---------|-------------|
+| `sc` | Supply Costs | Water & Drainage | Cost fields for private water and sewerage (restructured to hasCost Yes/No gate) |
+| `pc` | Parking Permit Cost | Parking | 1 frequency field |
+| `ph` | Property Hazards | Specialist Issues | 4 Yes/No + details fields |
+
+### New overlays (this PR)
+
+| Overlay Key | Name | Section | Fields Added |
+|-------------|------|---------|-------------|
+| `dk` | Dropped Kerb | Parking | 1 Yes/No field |
+| `rw` | Private Right of Way | Rights & Informal Arrangements | 1 Yes/No + details field |
+| `sd` | Storm/Fire/Flood Damage | Environmental Issues | 1 Yes/No + details field |
+| `lc` | Solar Lease Costs | Utilities (Solar Panels) | 1 cost field (hasCost + amount + frequency) |
+| `wg` | Warranties & Guarantees | Guarantees & Warranties | Marks 7 warranty categories as required |
+| `ic` | Insurance Claims | Insurance | Marks insuranceClaims required (isInsured=Yes branch) |
+| `nd` | Neighbour Development | Notices | Adds sef25Ref to neighbourDevelopment (already required via NTS) |
+| `mi` | Material Issue | Additional Information | Marks otherMaterialIssue required |
+| `tr` | Title Restrictions | Ownership (Freehold) | Adds titleRestrictions field to freehold branch |
+
+### Existing fields with sef25Ref only (no separate overlay needed)
+
+| Field | Path | sef25Ref | Notes |
+|-------|------|----------|-------|
+| `hasBeenFlooded` | `environmentalIssues.flooding.historicalFlooding.hasBeenFlooded` | E1.2 | Already required and rendered via NTS flooding section |
+
+All fields use `sef25Ref` for reference codes.
+
+---
+
+## Pre-existing overlays (detail)
+
+### 1. Supply Costs (`sc`)
+
+#### 1a. Private Water Cost
+
+**Trigger:** Show when `propertyPack.waterAndDrainage.water.mainsWater.yesNo` = `"No"`
+
+**Path:** `propertyPack.waterAndDrainage.water.mainsWater.associatedCost`
+
+**UI:** Render alongside the existing "How is water supplied?" details field. First ask if there are costs, then show amount and frequency if Yes.
+
+| Field | Path (relative) | Type | Validation | UI Element |
+|-------|-----------------|------|------------|------------|
+| Has costs? | `associatedCost.hasCost` | `string` | Required, enum | Yes/No radio |
+| Cost (£) | `associatedCost.amount` | `number` | Required when Yes | Numeric input |
+| Payment frequency | `associatedCost.frequency` | `string` | Required when Yes, enum | Dropdown |
+
+**Frequency enum values:** `"Per month"`, `"Per year"`
+
+**Ref:** `U1.1` (hasCost: `U1.1.1`, amount: `U1.1.2`, frequency: `U1.1.3`)
+
+#### 1b. Private Sewerage Cost
+
+**Trigger:** Show when `propertyPack.waterAndDrainage.drainage.mainsFoulDrainage.yesNo` = `"No"` or `"Not known"`
+
+**Path:** `propertyPack.waterAndDrainage.drainage.mainsFoulDrainage.associatedCost`
+
+**UI:** Same hasCost pattern as water cost above.
+
+**Ref:** `U1.2` (hasCost: `U1.2.1`, amount: `U1.2.2`, frequency: `U1.2.3`)
+
+### 2. Parking Permit Cost (`pc`)
+
+**Trigger:** Show when `propertyPack.parking.controlledParking.yesNo` = `"Yes"`
+
+**Path:** `propertyPack.parking.controlledParking.costOfPermitFrequency`
+
+**UI:** Render alongside the existing cost of permit field. The frequency dropdown clarifies whether the cost amount is monthly or annual.
+
+| Field | Path (relative) | Type | Validation | UI Element |
+|-------|-----------------|------|------------|------------|
+| Payment frequency | `costOfPermitFrequency` | `string` | Enum | Dropdown |
+
+**Frequency enum values:** `"Per month"`, `"Per year"`
+
+**Ref:** `P1.1`
+
+### 3. Property Hazards (`ph`)
+
+**Trigger:** Always shown (standalone questions within Specialist Issues).
+
+**Path prefix:** `propertyPack.specialistIssues`
+
+All 4 fields follow the same pattern: Yes/No, if Yes show required details.
+
+| Property | Title | sef25Ref |
+|----------|-------|----------|
+| `wellsDitchesShaft` | Are there any wells, ditches, or shafts at the property? | H1.1 |
+| `damagedOrExposedElectrics` | Are there any damaged or exposed electrics at the property? | H1.2 |
+| `damageToFlooringOrStaircases` | Is there any damage to flooring and/or staircases? | H1.3 |
+| `knownAreasInPoorCondition` | Are there any known areas in poor condition (internal or external)? | H1.4 |
+
+---
+
+## New overlays (detail)
+
+### 4. Dropped Kerb (`dk`)
+
+**Trigger:** Always shown within Parking section.
+
+**Path:** `propertyPack.parking.droppedKerbAccess`
+
+| Field | Path (relative) | Type | Validation | UI Element |
+|-------|-----------------|------|------------|------------|
+| Dropped kerb? | `droppedKerbAccess.yesNo` | `string` | Required, enum | Yes/No radio |
+
+**Ref:** `K1.1` (yesNo: `K1.1.1`)
+
+---
+
+### 5. Private Right of Way (`rw`)
+
+**Trigger:** Always shown within Rights & Informal Arrangements, alongside the existing public right of way question.
+
+**Path:** `propertyPack.rightsAndInformalArrangements.rightsOrArrangements.privateRightOfWay`
+
+**UI:** Same pattern as `publicRightOfWay` — Yes/No, if Yes show details.
+
+| Field | Path (relative) | Type | Validation | UI Element |
+|-------|-----------------|------|------------|------------|
+| Private ROW? | `privateRightOfWay.yesNo` | `string` | Required, enum | Yes/No radio |
+| Details | `privateRightOfWay.details` | `string` | Required when Yes, minLength 1 | Text input |
+
+**Ref:** `R1.1` (yesNo: `R1.1.1`, details: `R1.1.2`)
+
+---
+
+### 6. Storm, Fire or Flood Damage (`sd`)
+
+**Trigger:** Always shown within Environmental Issues section.
+
+**Path:** `propertyPack.environmentalIssues.stormFireFloodDamage`
+
+| Field | Path (relative) | Type | Validation | UI Element |
+|-------|-----------------|------|------------|------------|
+| Damage? | `stormFireFloodDamage.yesNo` | `string` | Required, enum | Yes/No radio |
+| Details | `stormFireFloodDamage.details` | `string` | Required when Yes, minLength 1 | Text area |
+
+**Ref:** `E1.1` (yesNo: `E1.1.1`, details: `E1.1.2`)
+
+---
+
+### 7. Solar Panel Lease Costs (`lc`)
+
+**Trigger:** Show when `propertyPack.electricity.solarPanels.panelsOwnedOutright.yesNo` = `"No"` (panels are leased).
+
+**Path:** `propertyPack.electricity.solarPanels.panelsOwnedOutright.associatedCost`
+
+**UI:** Render alongside existing lease details. First ask if there are costs, then show amount and frequency if Yes.
+
+| Field | Path (relative) | Type | Validation | UI Element |
+|-------|-----------------|------|------------|------------|
+| Has costs? | `associatedCost.hasCost` | `string` | Required, enum | Yes/No radio |
+| Amount (£) | `associatedCost.amount` | `number` | Required when Yes | Numeric input |
+| Frequency | `associatedCost.frequency` | `string` | Required when Yes, enum | Dropdown |
+
+**Frequency enum values:** `"Per month"`, `"Per year"`
+
+**Ref:** `S1.1` (hasCost: `S1.1.1`, amount: `S1.1.2`, frequency: `S1.1.3`)
+
+---
+
+### 8. Warranties & Guarantees Upfront (`wg`)
+
+**Trigger:** Always shown when overlay is loaded. Displayed upfront regardless of `hasValidGuaranteesOrWarranties` value.
+
+**Path prefix:** `propertyPack.guaranteesWarrantiesAndIndemnityInsurances`
+
+**UI:** For SEF25 upfront, show all 7 warranty categories as simple Yes/No questions. No details or "Years Remaining" needed at this stage — the law firm picks up details later.
+
+| Property | Title | sef25Ref |
+|----------|-------|----------|
+| `newHomeWarranty` | New Home Warranty (NHBC or similar) | W1.1 |
+| `roofingWork` | Roofing work | W1.2 |
+| `dampProofingTreatment` | Damp proofing treatment | W1.3 |
+| `centralHeatingAndorPlumbing` | Central heating and/or plumbing | W1.4 |
+| `electricalRepairOrInstallation` | Electrical repair or installation | W1.5 |
+| `subsidenceWork` | Underpinning or other preventative work / remedial action relating to subsidence | W1.6 |
+| `otherGuarantees` | Other Guarantees or warranties | W1.7 |
+
+**Note:** These fields already exist in the base schema under the `hasValidGuaranteesOrWarranties = "Yes"` branch. The `wg` overlay marks them as required within that branch. The Moverly app shows them upfront for SEF25 users without requiring the parent gate question first.
+
+---
+
+### 9. Insurance Claims (`ic`)
+
+**Path:** `propertyPack.insurance.insuranceClaims` (inside `isInsured = "Yes"` branch)
+
+**Ref:** `I1.1` (yesNo: `I1.1.1`) — "Have you made any buildings insurance claims?"
+
+**Note:** The overlay marks insuranceClaims required within the `isInsured = "Yes"` oneOf branch.
+
+---
+
+### 10. Neighbour Development (`nd`)
+
+**Path:** `propertyPack.notices.neighbourDevelopment`
+
+**Ref:** `N1.1` — "Is the seller aware of any proposals to develop property or land nearby?"
+
+**Note:** `neighbourDevelopment` is already required via `ntsRequired` at the notices level. The `nd` overlay adds `sef25Ref` and `ntsRef` annotations so the field is identifiable as SEF25-relevant.
+
+---
+
+### 11. Material Issue (`mi`)
+
+**Path:** `propertyPack.additionalInformation.otherMaterialIssue`
+
+**Ref:** `M1.1` (yesNo: `M1.1.1`) — "Are you aware of any other material issue or information which may affect the average person's decision to proceed?"
+
+---
+
+### 12. Title Restrictions (`tr`)
+
+**Path:** `propertyPack.ownership.ownershipsToBeTransferred[Freehold].titleRestrictions`
+
+**Ref:** `T1.1` (yesNo: `T1.1.1`, details: `T1.1.2`) — "Are there any known restrictions on the title?"
+
+New field on the freehold ownership branch, modelled on `leaseRestrictions` for leasehold. Yes/No + details if Yes.
+
+---
+
+## Loading the Extensions
+
+```js
+import { getTransactionSchema, getValidator } from "@pdtf/schemas";
+
+const schemaId = "https://trust.propdata.org.uk/schemas/v3/pdtf-transaction.json";
+
+// Load all SEF25 extensions
+const sef25Extensions = ["sc", "pc", "ph", "dk", "rw", "sd", "lc", "wg", "ic", "nd", "mi", "tr"];
+const schema = getTransactionSchema(schemaId, sef25Extensions);
+
+// Or combine with other overlays
+const schema = getTransactionSchema(schemaId, ["baspiV5", ...sef25Extensions]);
+
+// Validate data against the merged schema
+const validator = getValidator(schemaId, sef25Extensions);
+```
+
+---
+
+## Summary of Trigger Conditions
+
+| Field | Visible when... |
+|-------|----------------|
+| Water cost | `mainsWater.yesNo` = `"No"` |
+| Sewerage cost | `mainsFoulDrainage.yesNo` = `"No"` or `"Not known"` |
+| Parking permit frequency | `controlledParking.yesNo` = `"Yes"` |
+| Wells/ditches/shaft | Always (within Specialist Issues) |
+| Damaged electrics | Always (within Specialist Issues) |
+| Flooring/staircase damage | Always (within Specialist Issues) |
+| Areas in poor condition | Always (within Specialist Issues) |
+| Dropped kerb access | Always (within Parking) |
+| Private right of way | Always (within Rights & Informal Arrangements) |
+| Storm/fire/flood damage | Always (within Environmental Issues) |
+| Solar panel lease costs | `panelsOwnedOutright.yesNo` = `"No"` |
+| Warranty categories (7) | Always when `wg` overlay loaded (within Guarantees & Warranties) |
+| Insurance claims | `isInsured.yesNo` = `"Yes"` (via `ic` overlay) |
+| Neighbour development | Always (via `nd` overlay) |
+| Other material issue | Always (via `mi` overlay) |
+| Title restrictions | Always (via `tr` overlay, freehold only) |
+
+---
+
+## Moverly propertyPackTasks Changes
+
+The following changes are needed in the Moverly app's `propertyPackTasks` configuration to surface the new SEF25 fields in the listing journey.
+
+### Existing tasks to deprecate
+
+The flooding and planning tasks should be stepped up to their parent section level to cover the new sibling fields (`stormFireFloodDamage` and `neighbourDevelopment`).
+
+```js
+// Replace existing flooding task with deprecated version
+{
+  name: "Flooding",
+  path: "/propertyPack/environmentalIssues/flooding",
+  category: "listing",
+  overlay: "nts2023",
+  deprecated: true, // replaced by environmental issues check
+},
+
+// Replace existing planning task with deprecated version
+{
+  name: "Planning and development",
+  path: "/propertyPack/notices/planningApplication",
+  category: "listing",
+  overlay: "nts2023",
+  deprecated: true, // replaced by notices check
+},
+```
+
+### New listing tasks to add
+
+```js
+{
+  name: "Environmental issues",
+  checkName: "sef25-environmentalIssues",
+  path: "/propertyPack/environmentalIssues",
+  category: "listing",
+  overlay: "sd",
+},
+{
+  name: "Notices",
+  checkName: "sef25-notices",
+  path: "/propertyPack/notices",
+  category: "listing",
+  overlay: "nd",
+},
+{
+  name: "Guarantees & warranties",
+  checkName: "sef25-warranties",
+  path: "/propertyPack/guaranteesWarrantiesAndIndemnityInsurances",
+  category: "listing",
+  overlay: "wg",
+},
+{
+  name: "Insurance claims",
+  checkName: "sef25-insurance",
+  path: "/propertyPack/insurance",
+  category: "listing",
+  overlay: "ic",
+},
+{
+  name: "Additional material information",
+  checkName: "sef25-additionalInformation",
+  path: "/propertyPack/additionalInformation",
+  category: "listing",
+  overlay: "mi",
+},
+```
+
+### Fields covered by existing listing tasks (no new task needed)
+
+| Extension | Covered by |
+|-----------|------------|
+| `dk` (dropped kerb) | Parking |
+| `rw` (private right of way) | Rights and easements |
+| `lc` (solar lease costs) | Electricity |
+| `sc` (supply costs) | Water and drainage |
+| `pc` (parking permit cost) | Parking |
+| `ph` (property hazards) | Specialist issues |
+| `tr` (title restrictions) | Ownership |