@pdtf/schemas 3.6.0-38 → 3.6.0-39

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pdtf/schemas",
-  "version": "3.6.0-38",
+  "version": "3.6.0-39",
   "description": "Property Data Trust Framework Schemas and Utilities",
   "main": "index.js",
   "directories": {

package/src/schemas/v3/overlays/extensions/mi.json

@@ -29,11 +29,25 @@
                   }
                 },
                 {
+                  "required": [
+                    "details"
+                  ],
                   "properties": {
+                    "details": {
+                      "ntsRef": "M1.1.2",
+                      "type": "string",
+                      "minLength": 1
+                    },
                     "yesNo": {
                       "enum": [
                         "Yes"
                       ]
+                    },
+                    "attachments": {
+                      "enum": [
+                        "Attached",
+                        "To follow"
+                      ]
                     }
                   }
                 }

package/src/schemas/v3/overlays/extensions/wg.json

@@ -27,6 +27,15 @@
               }
             },
             {
+              "required": [
+                "newHomeWarranty",
+                "roofingWork",
+                "dampProofingTreatment",
+                "centralHeatingAndorPlumbing",
+                "electricalRepairOrInstallation",
+                "subsidenceWork",
+                "otherGuarantees"
+              ],
               "properties": {
                 "newHomeWarranty": {
                   "ntsRef": "W1.1",
@@ -36,6 +45,12 @@
                   "discriminator": {
                     "propertyName": "yesNo"
                   },
+                  "properties": {
+                    "yesNo": {
+                      "ntsRef": "W1.1.1",
+                      "type": "string"
+                    }
+                  },
                   "oneOf": [
                     {
                       "properties": {
@@ -65,6 +80,12 @@
                   "discriminator": {
                     "propertyName": "yesNo"
                   },
+                  "properties": {
+                    "yesNo": {
+                      "ntsRef": "W1.2.1",
+                      "type": "string"
+                    }
+                  },
                   "oneOf": [
                     {
                       "properties": {
@@ -94,6 +115,12 @@
                   "discriminator": {
                     "propertyName": "yesNo"
                   },
+                  "properties": {
+                    "yesNo": {
+                      "ntsRef": "W1.3.1",
+                      "type": "string"
+                    }
+                  },
                   "oneOf": [
                     {
                       "properties": {
@@ -123,6 +150,12 @@
                   "discriminator": {
                     "propertyName": "yesNo"
                   },
+                  "properties": {
+                    "yesNo": {
+                      "ntsRef": "W1.4.1",
+                      "type": "string"
+                    }
+                  },
                   "oneOf": [
                     {
                       "properties": {
@@ -152,6 +185,12 @@
                   "discriminator": {
                     "propertyName": "yesNo"
                   },
+                  "properties": {
+                    "yesNo": {
+                      "ntsRef": "W1.5.1",
+                      "type": "string"
+                    }
+                  },
                   "oneOf": [
                     {
                       "properties": {
@@ -181,6 +220,12 @@
                   "discriminator": {
                     "propertyName": "yesNo"
                   },
+                  "properties": {
+                    "yesNo": {
+                      "ntsRef": "W1.6.1",
+                      "type": "string"
+                    }
+                  },
                   "oneOf": [
                     {
                       "properties": {
@@ -210,6 +255,12 @@
                   "discriminator": {
                     "propertyName": "yesNo"
                   },
+                  "properties": {
+                    "yesNo": {
+                      "ntsRef": "W1.7.1",
+                      "type": "string"
+                    }
+                  },
                   "oneOf": [
                     {
                       "properties": {

package/src/tests/v3/extensionOverlays.test.js

@@ -143,6 +143,73 @@ describe("Extension Overlays", () => {
     });
   });
 
+  describe("SEF25 extension leaf annotations", () => {
+    test("wg: every W1.x subsection exposes a yesNo ntsRef", () => {
+      const schema = getTransactionSchema(schemaId, ["nts2023", "wg"]);
+      const subsections =
+        schema.properties?.propertyPack?.properties
+          ?.guaranteesWarrantiesAndIndemnityInsurances?.oneOf?.[1]?.properties;
+
+      expect(subsections).toBeDefined();
+
+      const discriminated = Object.entries(subsections).filter(
+        ([, sub]) => sub?.discriminator?.propertyName === "yesNo"
+      );
+      expect(discriminated.length).toBeGreaterThan(0);
+
+      for (const [key, sub] of discriminated) {
+        expect(sub.ntsRef).toMatch(/^W1\.\d+$/);
+        expect(sub.properties?.yesNo?.ntsRef).toMatch(/^W1\.\d+\.1$/);
+        expect(sub.required).toContain("yesNo");
+      }
+    });
+
+    test("ic: insuranceClaims exposes a yesNo ntsRef", () => {
+      const schema = getTransactionSchema(schemaId, ["nts2023", "ic"]);
+      const icProp =
+        schema.properties?.propertyPack?.properties?.insurance?.oneOf?.[1]
+          ?.properties?.insuranceClaims;
+
+      expect(icProp).toBeDefined();
+      expect(icProp.ntsRef).toBe("I1.1");
+      expect(icProp.properties?.yesNo?.ntsRef).toBe("I1.1.1");
+      expect(icProp.required).toContain("yesNo");
+    });
+
+    test("nd: neighbourDevelopment N1.1 marker merges with nts yesNo ref", () => {
+      // nd extension only carries the parent N1.1 marker; the yesNo leaf
+      // annotation comes from the nts overlay (C4.1.1), which is required
+      // alongside nd for the field to render.
+      const schema = getTransactionSchema(schemaId, ["nts2023", "nd"]);
+      const ndProp =
+        schema.properties?.propertyPack?.properties?.notices?.properties
+          ?.neighbourDevelopment;
+
+      expect(ndProp).toBeDefined();
+      expect(ndProp.ntsRef).toBe("N1.1");
+      expect(ndProp.properties?.yesNo?.ntsRef).toBe("C4.1.1");
+      expect(ndProp.required).toContain("yesNo");
+    });
+
+    test("mi: otherMaterialIssue exposes yesNo and details ntsRef", () => {
+      const schema = getTransactionSchema(schemaId, ["nts2023", "mi"]);
+      const miProp =
+        schema.properties?.propertyPack?.properties?.additionalInformation
+          ?.properties?.otherMaterialIssue;
+
+      expect(miProp).toBeDefined();
+      expect(miProp.ntsRef).toBe("M1.1");
+      expect(miProp.properties?.yesNo?.ntsRef).toBe("M1.1.1");
+      expect(miProp.required).toContain("yesNo");
+
+      const yesBranch = miProp.oneOf?.find((branch) =>
+        branch.required?.includes("details")
+      );
+      expect(yesBranch).toBeDefined();
+      expect(yesBranch.properties?.details?.ntsRef).toBe("M1.1.2");
+    });
+  });
+
   describe("Extension overlay availability", () => {
     test("should export all extension overlays", () => {
       const expectedKeys = [