@pdtf/schemas 3.6.0-2 → 3.6.0-21

package/src/tests/v3/offers.test.js

@@ -20,7 +20,7 @@ describe("Offers object validation", () => {
           "550e8400-e29b-41d4-a716-446655440000": {
             amount: 250000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -44,7 +44,7 @@ describe("Offers object validation", () => {
           "did:example:123456789abcdefghi": {
             amount: 300000,
             currency: "GBP",
-            status: "accepted",
+            status: "Accepted",
           },
         },
       };
@@ -68,7 +68,7 @@ describe("Offers object validation", () => {
           "did:web:example.com:users:alice": {
             amount: 275000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -92,17 +92,17 @@ describe("Offers object validation", () => {
           "550e8400-e29b-41d4-a716-446655440000": {
             amount: 250000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
           "did:example:buyer123": {
             amount: 260000,
             currency: "GBP",
-            status: "accepted",
+            status: "Accepted",
           },
           "offer-abc123": {
             amount: 240000,
             currency: "GBP",
-            status: "rejected",
+            status: "Rejected",
           },
         },
       };
@@ -128,7 +128,7 @@ describe("Offers object validation", () => {
           "-invalid-key": {
             amount: 250000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -153,7 +153,7 @@ describe("Offers object validation", () => {
           "invalid key with spaces": {
             amount: 250000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -177,7 +177,7 @@ describe("Offers object validation", () => {
           "invalid@key#here": {
             amount: 250000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -203,7 +203,7 @@ describe("Offers object validation", () => {
           "offer-1": {
             amount: 250000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -227,7 +227,7 @@ describe("Offers object validation", () => {
           "offer-1": {
             amount: 250000,
             currency: "GBP",
-            status: "accepted",
+            status: "Accepted",
             inclusions: ["curtains", "carpets", "light fixtures"],
             exclusions: ["garden furniture", "shed"],
             conditions: [
@@ -245,11 +245,11 @@ describe("Offers object validation", () => {
     test("accepts all valid status values", () => {
       const validator = getValidator(schemaId);
       const validStatuses = [
-        "pending",
-        "withdrawn",
-        "rejected",
-        "accepted",
-        "noteOfInterest",
+        "Pending",
+        "Withdrawn",
+        "Rejected",
+        "Accepted",
+        "Note of Interest",
       ];
 
       validStatuses.forEach((status) => {
@@ -294,7 +294,7 @@ describe("Offers object validation", () => {
             "offer-1": {
               amount: 250000,
               currency: currency,
-              status: "pending",
+              status: "Pending",
             },
           },
         };
@@ -319,7 +319,7 @@ describe("Offers object validation", () => {
           "offer-1": {
             amount: 0,
             currency: "GBP",
-            status: "noteOfInterest",
+            status: "Note of Interest",
           },
         },
       };
@@ -330,7 +330,7 @@ describe("Offers object validation", () => {
   });
 
   describe("Invalid offer contents", () => {
-    test("rejects offer missing required amount field", () => {
+    test("accepts offer without amount field (no required fields in schema)", () => {
       const validator = getValidator(schemaId);
       const transaction = {
         transactionId: "123e4567-e89b-12d3-a456-426614174000",
@@ -344,19 +344,16 @@ describe("Offers object validation", () => {
         offers: {
           "offer-1": {
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
 
       const isValid = validator(transaction);
-      expect(isValid).toBe(false);
-      expect(
-        validator.errors.some((e) => e.message.includes("required property"))
-      ).toBe(true);
+      expect(isValid).toBe(true);
     });
 
-    test("rejects offer missing required currency field", () => {
+    test("accepts offer without currency field (no required fields in schema)", () => {
       const validator = getValidator(schemaId);
       const transaction = {
         transactionId: "123e4567-e89b-12d3-a456-426614174000",
@@ -370,16 +367,16 @@ describe("Offers object validation", () => {
         offers: {
           "offer-1": {
             amount: 250000,
-            status: "pending",
+            status: "Pending",
           },
         },
       };
 
       const isValid = validator(transaction);
-      expect(isValid).toBe(false);
+      expect(isValid).toBe(true);
     });
 
-    test("rejects offer missing required status field", () => {
+    test("accepts offer without status field (no required fields in schema)", () => {
       const validator = getValidator(schemaId);
       const transaction = {
         transactionId: "123e4567-e89b-12d3-a456-426614174000",
@@ -399,7 +396,7 @@ describe("Offers object validation", () => {
       };
 
       const isValid = validator(transaction);
-      expect(isValid).toBe(false);
+      expect(isValid).toBe(true);
     });
 
     test("rejects offer with invalid status value", () => {
@@ -441,7 +438,7 @@ describe("Offers object validation", () => {
           "offer-1": {
             amount: -100000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -465,7 +462,7 @@ describe("Offers object validation", () => {
           "offer-1": {
             amount: 250000,
             currency: "gb",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -489,7 +486,7 @@ describe("Offers object validation", () => {
           "offer-1": {
             amount: 250000,
             currency: "gbp",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -513,7 +510,7 @@ describe("Offers object validation", () => {
           "offer-1": {
             amount: 250000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
             inclusions: "curtains",
           },
         },
@@ -538,7 +535,7 @@ describe("Offers object validation", () => {
           "offer-1": {
             amount: 250000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
             inclusions: ["curtains", 123, "carpets"],
           },
         },
@@ -563,7 +560,7 @@ describe("Offers object validation", () => {
           "offer-1": {
             amount: 250000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
             exclusions: { item: "garden furniture" },
           },
         },
@@ -588,7 +585,7 @@ describe("Offers object validation", () => {
           "offer-1": {
             amount: 250000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
             conditions: "Subject to survey",
           },
         },
@@ -653,7 +650,7 @@ describe("Offers object validation", () => {
           "550e8400-e29b-41d4-a716-446655440000": {
             amount: 250000,
             currency: "GBP",
-            status: "accepted",
+            status: "Accepted",
           },
         },
       };
@@ -678,7 +675,7 @@ describe("Offers object validation", () => {
           "did:example:buyer123": {
             amount: 260000,
             currency: "GBP",
-            status: "accepted",
+            status: "Accepted",
           },
         },
       };
@@ -766,12 +763,12 @@ describe("Offers object validation", () => {
           "offer-1": {
             amount: 250000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
           "offer-2": {
             amount: 260000,
             currency: "GBP",
-            status: "accepted",
+            status: "Accepted",
           },
         },
       };

package/src/tests/v3/patternProperties.test.js

@@ -87,11 +87,11 @@ describe("patternProperties support in path validation", () => {
 
       expect(subschema).toBeDefined();
       expect(subschema.type).toBe("string");
-      expect(subschema.enum).toContain("pending");
-      expect(subschema.enum).toContain("accepted");
-      expect(subschema.enum).toContain("rejected");
-      expect(subschema.enum).toContain("withdrawn");
-      expect(subschema.enum).toContain("noteOfInterest");
+      expect(subschema.enum).toContain("Pending");
+      expect(subschema.enum).toContain("Accepted");
+      expect(subschema.enum).toContain("Rejected");
+      expect(subschema.enum).toContain("Withdrawn");
+      expect(subschema.enum).toContain("Note of Interest");
     });
 
     test("returns correct subschema for currency pattern", () => {
@@ -132,7 +132,7 @@ describe("patternProperties support in path validation", () => {
       const validOffer = {
         amount: 500000,
         currency: "GBP",
-        status: "pending",
+        status: "Pending",
       };
 
       const isValid = validator(validOffer);
@@ -146,7 +146,7 @@ describe("patternProperties support in path validation", () => {
       const validOffer = {
         amount: 300000,
         currency: "EUR",
-        status: "accepted",
+        status: "Accepted",
         inclusions: ["carpets", "curtains"],
         exclusions: ["garden furniture"],
         conditions: ["Subject to survey"],
@@ -156,20 +156,17 @@ describe("patternProperties support in path validation", () => {
       expect(isValid).toBe(true);
     });
 
-    test("validator correctly rejects invalid offer data - missing required field", () => {
+    test("validator accepts offer data without status (no required fields in schema)", () => {
       const path = "/offers/offer-789";
       const validator = getSubschemaValidator(path, schemaId);
 
-      const invalidOffer = {
+      const offer = {
         amount: 400000,
         currency: "GBP",
-        // missing required status field
       };
 
-      const isValid = validator(invalidOffer);
-      expect(isValid).toBe(false);
-      expect(validator.errors).toBeDefined();
-      expect(validator.errors.length).toBeGreaterThan(0);
+      const isValid = validator(offer);
+      expect(isValid).toBe(true);
     });
 
     test("validator correctly rejects invalid offer data - negative amount", () => {
@@ -179,7 +176,7 @@ describe("patternProperties support in path validation", () => {
       const invalidOffer = {
         amount: -100000,
         currency: "GBP",
-        status: "pending",
+        status: "Pending",
       };
 
       const isValid = validator(invalidOffer);
@@ -225,7 +222,7 @@ describe("patternProperties support in path validation", () => {
           "/offers/offer-001": {
             amount: 500000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -245,7 +242,7 @@ describe("patternProperties support in path validation", () => {
           "/offers/1sorzJCFHbWVlHA2tYXA": {
             amount: 750000,
             currency: "GBP",
-            status: "accepted",
+            status: "Accepted",
           },
         },
       };
@@ -265,7 +262,7 @@ describe("patternProperties support in path validation", () => {
           "/offers/did:example:buyer123": {
             amount: 600000,
             currency: "EUR",
-            status: "noteOfInterest",
+            status: "Note of Interest",
           },
         },
       };
@@ -301,7 +298,7 @@ describe("patternProperties support in path validation", () => {
           "/offers/offer-complete": {
             amount: 550000,
             currency: "GBP",
-            status: "accepted",
+            status: "Accepted",
             inclusions: ["carpets", "curtains", "light fixtures"],
             exclusions: ["garden shed"],
             conditions: ["Subject to survey", "Subject to mortgage approval"],
@@ -313,7 +310,7 @@ describe("patternProperties support in path validation", () => {
       expect(errors).toHaveLength(0);
     });
 
-    test("rejects claim with invalid offer data - missing required field", () => {
+    test("accepts claim with offer data without status (no required fields in schema)", () => {
       const claim = {
         timestamp: 1643115903108,
         verification: {
@@ -321,16 +318,15 @@ describe("patternProperties support in path validation", () => {
           time: "2025-01-15T12:00:00Z",
         },
         claims: {
-          "/offers/offer-invalid": {
+          "/offers/offer-no-status": {
             amount: 500000,
             currency: "GBP",
-            // missing required status field
           },
         },
       };
 
       const errors = validateVerifiedClaims([claim], schemaId);
-      expect(errors.length).toBeGreaterThan(0);
+      expect(errors).toHaveLength(0);
     });
 
     test("rejects claim with invalid offer data - negative amount", () => {
@@ -344,7 +340,7 @@ describe("patternProperties support in path validation", () => {
           "/offers/offer-negative": {
             amount: -100000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -384,7 +380,7 @@ describe("patternProperties support in path validation", () => {
           "/offers/offer-bad-currency": {
             amount: 500000,
             currency: "gbp", // should be uppercase
-            status: "pending",
+            status: "Pending",
           },
         },
       };
@@ -405,7 +401,7 @@ describe("patternProperties support in path validation", () => {
             "/offers/offer-1": {
               amount: 500000,
               currency: "GBP",
-              status: "pending",
+              status: "Pending",
             },
           },
         },
@@ -419,7 +415,7 @@ describe("patternProperties support in path validation", () => {
             "/offers/offer-2": {
               amount: 520000,
               currency: "GBP",
-              status: "accepted",
+              status: "Accepted",
             },
           },
         },
@@ -440,14 +436,14 @@ describe("patternProperties support in path validation", () => {
           "/offers/offer-1": {
             amount: 500000,
             currency: "GBP",
-            status: "pending",
+            status: "Pending",
           },
           "/offers/offer-2": {
             amount: 510000,
             currency: "GBP",
-            status: "withdrawn",
+            status: "Withdrawn",
           },
-          "/offers/offer-3/status": "rejected",
+          "/offers/offer-3/status": "Rejected",
         },
       };
 
@@ -534,6 +530,129 @@ describe("patternProperties support in path validation", () => {
     });
   });
 
+  describe("externalIds patternProperties paths", () => {
+    test("accepts claim for /externalIds with a nested key path", () => {
+      const claim = {
+        timestamp: 1643115903108,
+        verification: {
+          trust_framework: "uk_pdtf",
+          time: "2025-01-15T12:00:00Z",
+        },
+        claims: {
+          "/externalIds/nptn/selectedQuoteId": "12345577",
+        },
+      };
+
+      const errors = validateVerifiedClaims([claim], schemaId);
+      expect(errors).toHaveLength(0);
+    });
+
+    test("accepts claim for /externalIds with a simple string value", () => {
+      const claim = {
+        timestamp: 1643115903108,
+        verification: {
+          trust_framework: "uk_pdtf",
+          time: "2025-01-15T12:00:00Z",
+        },
+        claims: {
+          "/externalIds/lms": "abc-123",
+        },
+      };
+
+      const errors = validateVerifiedClaims([claim], schemaId);
+      expect(errors).toHaveLength(0);
+    });
+
+    test("accepts claim for /externalIds with a numeric value", () => {
+      const claim = {
+        timestamp: 1643115903108,
+        verification: {
+          trust_framework: "uk_pdtf",
+          time: "2025-01-15T12:00:00Z",
+        },
+        claims: {
+          "/externalIds/systemRef": 98765,
+        },
+      };
+
+      const errors = validateVerifiedClaims([claim], schemaId);
+      expect(errors).toHaveLength(0);
+    });
+
+    test("accepts claim for /externalIds with a boolean value", () => {
+      const claim = {
+        timestamp: 1643115903108,
+        verification: {
+          trust_framework: "uk_pdtf",
+          time: "2025-01-15T12:00:00Z",
+        },
+        claims: {
+          "/externalIds/isActive": true,
+        },
+      };
+
+      const errors = validateVerifiedClaims([claim], schemaId);
+      expect(errors).toHaveLength(0);
+    });
+
+    test("accepts claim for /externalIds with an object value", () => {
+      const claim = {
+        timestamp: 1643115903108,
+        verification: {
+          trust_framework: "uk_pdtf",
+          time: "2025-01-15T12:00:00Z",
+        },
+        claims: {
+          "/externalIds/nptn": {
+            selectedQuoteId: "12345577",
+            caseRef: "CASE-001",
+          },
+        },
+      };
+
+      const errors = validateVerifiedClaims([claim], schemaId);
+      expect(errors).toHaveLength(0);
+    });
+
+    test("accepts claim with multiple externalIds paths in same claim", () => {
+      const claim = {
+        timestamp: 1643115903108,
+        verification: {
+          trust_framework: "uk_pdtf",
+          time: "2025-01-15T12:00:00Z",
+        },
+        claims: {
+          "/externalIds/nptn/selectedQuoteId": "12345577",
+          "/externalIds/lms": "LMS-REF-001",
+        },
+      };
+
+      const errors = validateVerifiedClaims([claim], schemaId);
+      expect(errors).toHaveLength(0);
+    });
+
+    test("accepts claim for /externalIds root object", () => {
+      const claim = {
+        timestamp: 1643115903108,
+        verification: {
+          trust_framework: "uk_pdtf",
+          time: "2025-01-15T12:00:00Z",
+        },
+        claims: {
+          "/externalIds": {
+            nptn: {
+              selectedQuoteId: "12345577",
+            },
+            lms: "LMS-REF-001",
+          },
+        },
+      };
+
+      const errors = validateVerifiedClaims([claim], schemaId);
+      expect(errors).toHaveLength(0);
+    });
+  });
+
   describe("edge cases", () => {
     test("handles offer ID with dots", () => {
       const path = "/offers/offer.123.abc";