@pdtf/schemas 3.4.1-5 → 3.4.1-7

package/.claude/settings.local.json

@@ -8,7 +8,8 @@
       "Bash(jq:*)",
       "Bash(grep:*)",
       "Bash(rm:*)",
-      "Bash(npm test:*)"
+      "Bash(npm test:*)",
+      "Bash(npm install:*)"
     ],
     "deny": []
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pdtf/schemas",
-  "version": "3.4.1-5",
+  "version": "3.4.1-7",
   "description": "Property Data Trust Framework Schemas and Utilities",
   "main": "index.js",
   "directories": {

package/src/schemas/v3/combined.json

@@ -9228,6 +9228,12 @@
             "controlledParking",
             "electricVehicleChargingPoint"
           ],
+          "ntsl2Required": [
+            "parkingArrangements",
+            "disabledParking",
+            "controlledParking",
+            "electricVehicleChargingPoint"
+          ],
           "ta6Required": ["parkingArrangements", "controlledParking"],
           "properties": {
             "parkingArrangements": {
@@ -9456,6 +9462,11 @@
             "isConservationArea",
             "hasTreePreservationOrder"
           ],
+          "ntsl2Required": [
+            "isListed",
+            "isConservationArea",
+            "hasTreePreservationOrder"
+          ],
           "baspi4Required": [
             "isListed",
             "isConservationArea",

package/src/schemas/v3/overlays/ntsl2.json

@@ -252,6 +252,12 @@
         },
         "parking": {
           "ntsl2Ref": "B4",
+          "required": [
+            "parkingArrangements",
+            "disabledParking",
+            "controlledParking",
+            "electricVehicleChargingPoint"
+          ],
           "properties": {
             "parkingArrangements": {
               "ntsl2Ref": "B4.1",
@@ -320,6 +326,11 @@
         },
         "listingAndConservation": {
           "ntsl2Ref": "C2.1",
+          "required": [
+            "isListed",
+            "isConservationArea",
+            "hasTreePreservationOrder"
+          ],
           "properties": {
             "isListed": {
               "ntsl2Ref": "C2.1.1",

package/src/tests/v3/transactionSchema.test.js

@@ -448,3 +448,49 @@ test("validates a valid contract", () => {
   const isValid = validator(data);
   expect(isValid).toBe(true);
 });
+
+test("ntsl2025 requires parking and listingAndConservation fields", () => {
+  // This test validates that the ntsl2025 overlay correctly enforces required fields
+  // for the parking and listingAndConservation sections.
+  // It should fail validation when these fields are missing.
+  // NOTE: This test will fail until overlays are regenerated from combined.json
+  const validator = getValidator(schemaId, ["ntsl2025"]);
+  const clonedExampleTransaction = JSON.parse(
+    JSON.stringify(exampleTransaction)
+  );
+  
+  // Set up lettings-specific fields
+  clonedExampleTransaction.propertyPack.lettingInformation = {
+    rent: 3500,
+    rentFrequency: "Monthly",
+    securityDeposit: 5000,
+  };
+  delete clonedExampleTransaction.propertyPack.priceInformation;
+  delete clonedExampleTransaction.propertyPack.ownership;
+  
+  // Remove ALL parking fields - this should make validation fail
+  delete clonedExampleTransaction.propertyPack.parking.parkingArrangements;
+  delete clonedExampleTransaction.propertyPack.parking.disabledParking;
+  delete clonedExampleTransaction.propertyPack.parking.controlledParking;
+  delete clonedExampleTransaction.propertyPack.parking.electricVehicleChargingPoint;
+  
+  // Remove ALL listingAndConservation fields - this should make validation fail
+  delete clonedExampleTransaction.propertyPack.listingAndConservation.isListed;
+  delete clonedExampleTransaction.propertyPack.listingAndConservation.isConservationArea;
+  delete clonedExampleTransaction.propertyPack.listingAndConservation.hasTreePreservationOrder;
+  
+  const isValid = validator(clonedExampleTransaction);
+  
+  // The data should be INVALID because required fields are missing
+  expect(isValid).toBe(false);
+  
+  // Specifically check that parking and listingAndConservation fields are reported as missing
+  const errorMessages = validator.errors.map(e => e.message);
+  expect(errorMessages).toContain("must have required property 'parkingArrangements'");
+  expect(errorMessages).toContain("must have required property 'disabledParking'");
+  expect(errorMessages).toContain("must have required property 'controlledParking'");
+  expect(errorMessages).toContain("must have required property 'electricVehicleChargingPoint'");
+  expect(errorMessages).toContain("must have required property 'isListed'");
+  expect(errorMessages).toContain("must have required property 'isConservationArea'");
+  expect(errorMessages).toContain("must have required property 'hasTreePreservationOrder'");
+});