@pdtf/schemas 3.3.0 → 3.4.0-10

package/src/schemas/v3/skeleton.json

@@ -30,7 +30,7 @@
     "organisationReference": {},
     "role": {},
     "externalIds": {},
-    "isRemoved": {},
+    "participantStatus": {},
     "sellersCapacity": {
       "capacity": {},
       "sellersCapacityDetails": {},
@@ -215,6 +215,11 @@
         "titleNumber": {},
         "titlePropertyDescription": {},
         "ownershipType": {},
+        "estateRentcharges": {
+          "yesNo": {},
+          "details": {},
+          "amount": {}
+        },
         "wholeFreeholdForSale": {
           "yesNo": {},
           "details": {}
@@ -1067,6 +1072,7 @@
     "typeOfConstruction": {
       "isStandardForm": {
         "yesNo": {},
+        "constructionType": {},
         "details": {}
       },
       "buildingSafety": {
@@ -1494,6 +1500,7 @@
         "otherItems": {
           "itemName": {},
           "isIncludedOrExcluded": {},
+          "comments": {},
           "price": {}
         }
       },
@@ -1581,6 +1588,7 @@
         "otherItems": {
           "itemName": {},
           "isIncludedOrExcluded": {},
+          "comments": {},
           "fittedOrFreestanding": {
             "fittedOrFreestanding": {}
           },
@@ -1721,6 +1729,7 @@
           "otherRooms": {
             "itemName": {},
             "isIncludedOrExcluded": {},
+            "comments": {},
             "price": {}
           }
         },
@@ -1806,6 +1815,7 @@
         "otherRooms": {
           "itemName": {},
           "isIncludedOrExcluded": {},
+          "comments": {},
           "price": {}
         }
       },
@@ -1848,6 +1858,7 @@
         "otherRooms": {
           "itemName": {},
           "isIncludedOrExcluded": {},
+          "comments": {},
           "price": {}
         }
       },
@@ -1915,6 +1926,7 @@
         "otherItems": {
           "itemName": {},
           "isIncludedOrExcluded": {},
+          "comments": {},
           "price": {}
         }
       },
@@ -1961,6 +1973,7 @@
         "otherItems": {
           "itemName": {},
           "isIncludedOrExcluded": {},
+          "comments": {},
           "price": {}
         }
       },
@@ -2338,6 +2351,10 @@
           "hasBeenFlooded": {},
           "typeOfFlooding": {},
           "details": {}
+        },
+        "floodDefences": {
+          "hasFloodDefences": {},
+          "details": {}
         }
       },
       "radon": {
@@ -4114,5 +4131,25 @@
       "signedOn": {},
       "externalIds": {}
     }
+  },
+  "chain": {
+    "onwardPurchase": {
+      "transactionId": {},
+      "externalIds": {},
+      "address": {
+        "buildingNumber": {},
+        "buildingName": {},
+        "subBuilding": {},
+        "street": {},
+        "line1": {},
+        "line2": {},
+        "line 3": {},
+        "town": {},
+        "postcode": {},
+        "homeNation": {}
+      },
+      "uprn": {},
+      "sellingAgent": {}
+    }
   }
 }

package/src/tests/v3/transactionSchema.test.js

@@ -44,6 +44,42 @@ test("sample is valid NTS", () => {
   expect(isValid).toBe(true);
 });
 
+test("sample is not valid nts2025 out of the box", () => {
+  const validator = getValidator(schemaId, ["nts2025"]);
+  const isValid = validator(exampleTransaction);
+  expect(isValid).toBe(false);
+  expect(validator.errors.length).toBe(3);
+  expect(validator.errors.map((e) => e.message)).toEqual([
+    "must have required property 'transferFees'",
+    "must have required property 'constructionType'",
+    "must have required property 'floodDefences'",
+  ]);
+});
+
+test("sample is valid nts2025 with some additions", () => {
+  const validator = getValidator(schemaId, ["nts2025"]);
+  const clonedExampleTransaction = JSON.parse(
+    JSON.stringify(exampleTransaction)
+  );
+  clonedExampleTransaction.propertyPack.ownership.ownershipsToBeTransferred[0].leaseholdInformation.serviceCharge.transferFees =
+    {
+      yesNo: "Yes",
+      details: "Transfer fees exist",
+    };
+  clonedExampleTransaction.propertyPack.typeOfConstruction.isStandardForm = {
+    yesNo: "Yes",
+    constructionType: "Timber frame",
+  };
+  clonedExampleTransaction.propertyPack.environmentalIssues.flooding.floodDefences =
+    {
+      hasFloodDefences: "Yes",
+      details: "Flood defences exist",
+    };
+
+  const isValid = validator(clonedExampleTransaction);
+  expect(isValid).toBe(true);
+});
+
 test("sample is not valid NTSL (lettings)", () => {
   const validator = getValidator(schemaId, ["ntsl2023"]);
   const isValid = validator(exampleTransaction);

package/src/utils/extractOverlay.js

@@ -10,8 +10,9 @@ const extractFields = [
   "baspi4",
   "baspi5",
   "nts",
-  "nts-sef",
+  "nts2",
   "ntsl",
+  "ntsl2",
   "ta6",
   "ta7",
   "ta10",