@pcircle/memesh 2.9.0 → 2.9.1

package/scripts/hooks/subagent-stop.js

@@ -0,0 +1,184 @@
+#!/usr/bin/env node
+
+/**
+ * SubagentStop Hook - Capture Subagent Results to MeMesh Knowledge Graph
+ *
+ * Triggered when a subagent finishes execution.
+ *
+ * Features:
+ * - Saves code review findings to MeMesh KG (high-value results)
+ * - Tracks code review completion for pre-commit enforcement
+ * - Updates session state with subagent activity
+ * - Silent operation (no console output)
+ */
+
+import {
+  STATE_DIR,
+  MEMESH_DB_PATH,
+  readJSONFile,
+  writeJSONFile,
+  sqliteBatchEntity,
+  getDateString,
+  readStdin,
+  logError,
+  logMemorySave,
+} from './hook-utils.js';
+import fs from 'fs';
+import path from 'path';
+
+// ============================================================================
+// Constants
+// ============================================================================
+
+const CURRENT_SESSION_FILE = path.join(STATE_DIR, 'current-session.json');
+
+/** Agent types that count as code review */
+const CODE_REVIEWER_TYPES = [
+  'code-reviewer',
+  'code-review',
+  'superpowers:code-reviewer',
+  'pr-review-toolkit:code-reviewer',
+  'feature-dev:code-reviewer',
+];
+
+// ============================================================================
+// Code Review Detection
+// ============================================================================
+
+/**
+ * Check if this subagent is a code reviewer
+ * @param {string} agentType - Subagent type identifier
+ * @returns {boolean}
+ */
+function isCodeReviewer(agentType) {
+  if (!agentType) return false;
+  const lower = agentType.toLowerCase();
+  return CODE_REVIEWER_TYPES.some(t => lower.includes(t.toLowerCase()));
+}
+
+/**
+ * Mark code review as done in session state.
+ * This flag is checked by pre-tool-use.js before git commits.
+ */
+function markCodeReviewDone() {
+  const session = readJSONFile(CURRENT_SESSION_FILE, {});
+  session.codeReviewDone = true;
+  session.codeReviewTimestamp = new Date().toISOString();
+  writeJSONFile(CURRENT_SESSION_FILE, session);
+}
+
+// ============================================================================
+// MeMesh KG Save
+// ============================================================================
+
+/**
+ * Save code review results to MeMesh knowledge graph.
+ * Only saves code reviewer subagent results (high-value findings).
+ *
+ * @param {string} agentType - Subagent type
+ * @param {string} lastMessage - Agent's final response
+ * @returns {boolean} True if saved
+ */
+function saveSubagentToKG(agentType, lastMessage) {
+  try {
+    if (!fs.existsSync(MEMESH_DB_PATH)) return false;
+    if (!lastMessage || lastMessage.length < 50) return false;
+
+    // Truncate very long messages
+    const shortMessage = lastMessage.length > 1000
+      ? lastMessage.substring(0, 1000) + '...'
+      : lastMessage;
+
+    const entityName = `Code Review: ${getDateString()} ${Date.now()} ${agentType}`;
+    const metadata = JSON.stringify({
+      agentType,
+      messageLength: lastMessage.length,
+      source: 'subagent-stop-hook',
+    });
+
+    const tags = [
+      'code-review',
+      `agent:${agentType}`,
+      `date:${getDateString()}`,
+      'auto-tracked',
+      'scope:project',
+    ];
+
+    const entityId = sqliteBatchEntity(
+      MEMESH_DB_PATH,
+      { name: entityName, type: 'code_review', metadata },
+      [`[${agentType}] ${shortMessage}`],
+      tags
+    );
+
+    if (entityId === null) return false;
+
+    logMemorySave(`Code review saved: ${agentType} (${lastMessage.length} chars)`);
+    return true;
+  } catch (error) {
+    logError('saveSubagentToKG', error);
+    return false;
+  }
+}
+
+// ============================================================================
+// Session State Update
+// ============================================================================
+
+/**
+ * Track subagent activity in session state
+ * @param {string} agentType - Subagent type
+ */
+function trackSubagentInSession(agentType) {
+  const session = readJSONFile(CURRENT_SESSION_FILE, { subagents: [] });
+  if (!session.subagents) session.subagents = [];
+
+  session.subagents.push({
+    type: agentType,
+    completedAt: new Date().toISOString(),
+  });
+
+  // Keep only last 20 subagent entries
+  if (session.subagents.length > 20) {
+    session.subagents = session.subagents.slice(-20);
+  }
+
+  writeJSONFile(CURRENT_SESSION_FILE, session);
+}
+
+// ============================================================================
+// Main
+// ============================================================================
+
+async function subagentStop() {
+  try {
+    const input = await readStdin(3000);
+    if (!input || input.trim() === '') {
+      process.exit(0);
+    }
+
+    const data = JSON.parse(input);
+    const agentType = data.agent_type || data.agentType || 'unknown';
+    const lastMessage = data.last_assistant_message || data.lastAssistantMessage || '';
+
+    // Track all subagent completions in session state
+    trackSubagentInSession(agentType);
+
+    // Track code review completion (for pre-commit enforcement)
+    if (isCodeReviewer(agentType)) {
+      markCodeReviewDone();
+    }
+
+    // Save code reviewer results to MeMesh KG (high-value findings)
+    if (isCodeReviewer(agentType) && lastMessage.length > 50) {
+      saveSubagentToKG(agentType, lastMessage);
+    }
+
+    process.exit(0);
+  } catch (error) {
+    logError('SubagentStop', error);
+    process.exit(0); // Never block on hook errors
+  }
+}
+
+subagentStop();

package/scripts/hooks/templates/planning-template.md

@@ -0,0 +1,46 @@
+## Required Plan Sections
+
+Your plan MUST include all of the following sections. Incomplete plans will be rejected.
+
+### 1. System Design Description (SDD)
+- Component architecture and responsibilities
+- Data flow between components
+- Interface contracts (input/output types)
+- Dependencies and integration points
+
+### 2. Behavior-Driven Design (BDD)
+For EACH feature, write Gherkin scenarios:
+
+```gherkin
+Scenario: [descriptive name]
+  Given [precondition]
+  When [action]
+  Then [expected outcome]
+```
+
+Cover: happy path, error path, edge cases.
+
+### 3. Edge Case Handling
+
+| Edge Case | How Handled | Test Coverage |
+|-----------|------------|---------------|
+| [case] | [strategy] | [yes/no] |
+
+Include at minimum: empty input, null/undefined, boundary values, concurrent access, timeout, large data.
+
+### 4. Dry-Run Test Plan
+Before dispatching heavy tasks, verify:
+- [ ] Core function compiles (`tsc --noEmit` or `node --check`)
+- [ ] Unit test for critical path passes
+- [ ] Integration point verified with real call
+- [ ] No regressions in existing tests
+
+### 5. Risk Assessment
+
+| Risk | Probability | Impact | Mitigation |
+|------|------------|--------|------------|
+| [risk] | High/Med/Low | High/Med/Low | [strategy] |
+
+---
+
+**IMPORTANT**: After completing this plan, present it to the user and wait for explicit approval before proceeding to implementation. Do NOT auto-execute.

package/scripts/postinstall-lib.js

@@ -203,31 +203,35 @@ export async function ensurePluginEnabled(claudeDir = join(homedir(), '.claude')
  */
 export async function ensureMCPConfigured(installPath, mode, claudeDir = join(homedir(), '.claude')) {
     const mcpSettingsFile = join(claudeDir, 'mcp_settings.json');
+
     // Read existing config or create new
     let config = readJSONFile(mcpSettingsFile) || { mcpServers: {} };
     if (!config.mcpServers) {
         config.mcpServers = {};
     }
+
     // Configure memesh entry based on mode
     if (mode === 'global') {
+        // Global install: use npx (always uses latest published version)
         config.mcpServers.memesh = {
             command: 'npx',
             args: ['-y', '@pcircle/memesh'],
             env: { NODE_ENV: 'production' }
         };
-    }
-    else {
+    } else {
+        // Local dev: use node + absolute path (for testing)
         const serverPath = join(installPath, 'dist', 'mcp', 'server-bootstrap.js');
         config.mcpServers.memesh = {
             command: 'node',
-            args: [serverPath],
-            env: { NODE_ENV: 'production' }
+            args: [serverPath]
         };
     }
+
     // Remove legacy claude-code-buddy entry if exists
     if (config.mcpServers['claude-code-buddy']) {
         delete config.mcpServers['claude-code-buddy'];
     }
+
     // Write back
     writeJSONFile(mcpSettingsFile, config);
 }

package/scripts/postinstall-new.js

@@ -173,13 +173,21 @@ async function main() {
     }
 
     // Step 5: MCP Configuration
-    try {
-      await ensureMCPConfigured(installPath, mode, claudeDir);
-      results.mcpConfigured = true;
-      console.log(chalk.green('  ✅ MCP configured'));
-    } catch (error) {
-      results.errors.push(`MCP: ${error.message}`);
-      console.log(chalk.yellow(`  ⚠️  MCP configuration failed (non-fatal)`));
+    // IMPORTANT: Skip MCP config for local dev to prevent path pollution
+    // (see v2.9.0 Issue 2: Local Development Path Pollution)
+    if (mode === 'local') {
+      console.log(chalk.yellow('  ⚠️  Skipping MCP configuration (local development mode)'));
+      console.log(chalk.gray('     This prevents writing local dev paths to ~/.claude/mcp_settings.json'));
+      results.mcpConfigured = false;
+    } else {
+      try {
+        await ensureMCPConfigured(installPath, mode, claudeDir);
+        results.mcpConfigured = true;
+        console.log(chalk.green('  ✅ MCP configured'));
+      } catch (error) {
+        results.errors.push(`MCP: ${error.message}`);
+        console.log(chalk.yellow(`  ⚠️  MCP configuration failed (non-fatal)`));
+      }
     }
 
     // Step 6: Legacy Installation Fix