@payconductor/houndsman 0.3.0 → 0.5.0

package/src/tests/markdown.test.ts

@@ -0,0 +1,149 @@
+/**
+ * Markdown mínimo do `action` — blocos, inline e sanitização de links.
+ */
+
+import { describe, expect, test } from "bun:test";
+import {
+	isFilePath,
+	parseInline,
+	parseMarkdown,
+	safeUrl,
+	sectionBlocks,
+} from "../server/client/utils/markdown";
+
+describe("parseMarkdown", () => {
+	test("separa parágrafos, listas, quote e bloco de código", () => {
+		const blocks = parseMarkdown(
+			"Primeira linha\nsegunda linha.\n\n- um\n- dois\n\n1. passo\n2. outro\n\n> nota\n\n```ts\nconst x = 1;\n```",
+		);
+		expect(blocks.map((block) => block.type)).toEqual([
+			"paragraph",
+			"list",
+			"list",
+			"quote",
+			"code",
+		]);
+		expect(blocks[0]).toEqual({
+			type: "paragraph",
+			text: "Primeira linha\nsegunda linha.",
+		});
+		expect(blocks[1]).toEqual({
+			type: "list",
+			ordered: false,
+			items: ["um", "dois"],
+		});
+		expect(blocks[2]).toEqual({
+			type: "list",
+			ordered: true,
+			items: ["passo", "outro"],
+		});
+		expect(blocks[3]).toEqual({ type: "quote", text: "nota" });
+		expect(blocks[4]).toEqual({
+			type: "code",
+			language: "ts",
+			code: "const x = 1;",
+		});
+	});
+
+	test("texto vazio não gera blocos", () => {
+		expect(parseMarkdown("  \n\n ")).toEqual([]);
+	});
+
+	test("reconhece títulos, tabela e régua horizontal", () => {
+		const blocks = parseMarkdown(
+			"# Relatório\n\n| Arquivo | Severidade |\n|---|:---:|\n| a.ts | blocking |\n\n---",
+		);
+		expect(blocks).toEqual([
+			{ type: "heading", level: 1, text: "Relatório" },
+			{
+				type: "table",
+				align: [undefined, "center"],
+				header: ["Arquivo", "Severidade"],
+				rows: [["a.ts", "blocking"]],
+			},
+			{ type: "hr" },
+		]);
+	});
+
+	test("colunas só de números e barra alinham à direita", () => {
+		const blocks = parseMarkdown(
+			"| Arquivo | Linhas | Razão |\n|---|---|---|\n| a.ts | 12 | 3/4 |\n| b.ts | 7 | 1/2 |",
+		);
+		expect(blocks[0]).toMatchObject({
+			type: "table",
+			align: [undefined, "right", "right"],
+		});
+	});
+
+	test("extrai os blocos de uma seção específica", () => {
+		const blocks = sectionBlocks(
+			"# Título\n\n## Resumo de negócio\n\nTexto A.\n\n## Pontos técnicos\n\nTexto B.",
+			"resumo de negócio",
+		);
+		expect(blocks).toEqual([{ type: "paragraph", text: "Texto A." }]);
+	});
+});
+
+describe("parseInline", () => {
+	test("reconhece code, bold, itálico e link na ordem", () => {
+		const tokens = parseInline(
+			"Use `npm run ci` e **sempre** valide _tudo_ em [docs](https://x.dev).",
+		);
+		expect(tokens).toEqual([
+			{ type: "text", text: "Use " },
+			{ type: "code", text: "npm run ci" },
+			{ type: "text", text: " e " },
+			{ type: "strong", text: "sempre" },
+			{ type: "text", text: " valide " },
+			{ type: "em", text: "tudo" },
+			{ type: "text", text: " em " },
+			{ type: "link", text: "docs", url: "https://x.dev" },
+			{ type: "text", text: "." },
+		]);
+	});
+
+	test("não confunde underscore de identificador com itálico", () => {
+		expect(parseInline("foo_bar_baz")).toEqual([
+			{ type: "text", text: "foo_bar_baz" },
+		]);
+	});
+
+	test("asterisco simples também vira itálico", () => {
+		expect(parseInline("seja *rápido*")).toEqual([
+			{ type: "text", text: "seja " },
+			{ type: "em", text: "rápido" },
+		]);
+	});
+
+	test("destaca caminhos de arquivo no texto corrido", () => {
+		expect(parseInline("veja src/foo/bar.ts e review.md")).toEqual([
+			{ type: "text", text: "veja " },
+			{ type: "path", text: "src/foo/bar.ts" },
+			{ type: "text", text: " e " },
+			{ type: "path", text: "review.md" },
+		]);
+	});
+});
+
+describe("isFilePath", () => {
+	test("reconhece arquivos e caminhos, sem confundir texto comum", () => {
+		expect(isFilePath("src/foo/bar.ts")).toBe(true);
+		expect(isFilePath("review.md")).toBe(true);
+		expect(isFilePath("./scripts/ci.sh")).toBe(true);
+		expect(isFilePath("M/D")).toBe(false);
+		expect(isFilePath("duas palavras.ts")).toBe(false);
+		expect(isFilePath("https://x.dev/file.ts")).toBe(false);
+	});
+});
+
+describe("safeUrl", () => {
+	test("aceita http(s)/mailto e caminho relativo; barra o resto", () => {
+		expect(safeUrl("https://x.dev")).toBe("https://x.dev");
+		expect(safeUrl("http://x.dev")).toBe("http://x.dev");
+		expect(safeUrl("mailto:a@b.c")).toBe("mailto:a@b.c");
+		expect(safeUrl("/docs")).toBe("/docs");
+		expect(safeUrl("javascript:alert(1)")).toBeNull();
+		expect(safeUrl("//evil.dev")).toBeNull();
+		expect(safeUrl("data:text/html,x")).toBeNull();
+	});
+});

package/src/tests/review-resume.test.ts

@@ -0,0 +1,101 @@
+/**
+ * Resumo final (`review-resume.md`) — conteúdo de negócio + pontos técnicos,
+ * determinístico e limitado a `RESUME_MAX_CHARS`.
+ */
+
+import { describe, expect, test } from "bun:test";
+import {
+	RESUME_MAX_CHARS,
+	type ResumeClassification,
+	renderReviewResume,
+} from "../core/renderers/resume-renderer";
+import type { MergedFinding } from "../core/report-builder";
+
+function finding(overrides: Partial<MergedFinding> = {}): MergedFinding {
+	return {
+		rule: "regra",
+		severity: "suggestion",
+		file: "src/a.ts",
+		line: 1,
+		message: "mensagem",
+		action: "ação",
+		watchdogs: ["alpha"],
+		...overrides,
+	};
+}
+
+const classification: ResumeClassification = {
+	files: {
+		"src/a.ts": { status: "modified" },
+		"src/b.ts": { status: "added" },
+	},
+	watchdogs: { alpha: ["src/a.ts"], beta: ["src/b.ts"] },
+};
+
+describe("renderReviewResume", () => {
+	test("une contexto de negócio e pontos técnicos", () => {
+		const md = renderReviewResume({
+			branch: "feat/x",
+			date: "2026-10-17",
+			context: {
+				available: true,
+				objective: "Entregar a feature X.",
+				motivation: "Reduzir o esforço manual.",
+				changeSummary: ["Novo fluxo de cadastro.", "Ajuste no relatório."],
+			},
+			classification,
+			findings: [
+				finding({ severity: "blocking", message: "quebra o cadastro" }),
+				finding({ severity: "attention", file: "src/b.ts", line: undefined }),
+			],
+			nameOf: (id) => id.toUpperCase(),
+		});
+
+		expect(md).toContain("# Resumo da revisão — feat/x");
+		expect(md).toContain("**Data:** 2026-10-17");
+		expect(md).toContain("❌ Mudanças necessárias");
+		expect(md).toContain("Entregar a feature X.");
+		expect(md).toContain("**Por quê:** Reduzir o esforço manual.");
+		expect(md).toContain("- Novo fluxo de cadastro.");
+		expect(md).not.toContain("## Números");
+		expect(md).toContain("`src/a.ts:1` — quebra o cadastro _(ALPHA)_");
+		expect(md).toContain("`src/b.ts` — mensagem _(ALPHA)_");
+		expect(md.length).toBeLessThanOrEqual(RESUME_MAX_CHARS);
+	});
+
+	test("sem contexto da PR, cai no alcance da branch", () => {
+		const md = renderReviewResume({
+			branch: "main",
+			classification,
+			findings: [],
+		});
+
+		expect(md).toContain("Sem resumo de contexto da PR disponível.");
+		expect(md).toContain("✅ Aprovado");
+		expect(md).toContain("- Nenhum bloqueio ou ponto de atenção.");
+	});
+
+	test("respeita o teto de caracteres", () => {
+		const findings = Array.from({ length: 40 }, (_, index) =>
+			finding({
+				severity: index % 2 === 0 ? "blocking" : "attention",
+				file: `src/very/long/path/file-${index}.ts`,
+				message: "x".repeat(300),
+			}),
+		);
+		const md = renderReviewResume({
+			branch: "main",
+			context: {
+				available: true,
+				objective: "o".repeat(1000),
+				motivation: "m".repeat(1000),
+				changeSummary: ["a".repeat(200), "b".repeat(200)],
+			},
+			classification,
+			findings,
+		});
+
+		expect(md.length).toBeLessThanOrEqual(RESUME_MAX_CHARS);
+		expect(md.endsWith("…")).toBe(true);
+	});
+});

package/src/tests/review-scope.test.ts

@@ -0,0 +1,302 @@
+/**
+ * Escopo do review: completo × incremental × no-op.
+ *
+ * Congela a decisão que evita re-revisar a PR inteira: mesmo commit revisado
+ * vira no-op (sem `--full`/`--clean`), delta vira incremental com carry-over.
+ */
+
+import { describe, expect, test } from "bun:test";
+import { existsSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { ReviewScopeResolver, type ScopeOptions } from "../core/engine/review-scope";
+import type { FindingState, FindingsStateFile } from "../core/findings-state";
+import { defaultOptions, finalize, prepare, reviewContext } from "../core/orchestrator";
+import { resolveRepoIdentity } from "../core/storage/repo-identity";
+import { SQLiteStorageProvider } from "../core/storage/sqlite/sqlite-storage";
+import { fakeHoundsmanConfig } from "./fixtures/fake-project";
+
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+
+function findingState(overrides: Partial<FindingState> = {}): FindingState {
+	return {
+		id: "abcdef1234",
+		fingerprint: "0123456789abcdef",
+		watchdogIds: ["alpha"],
+		rule: "regra",
+		severity: "blocking",
+		file: "src/alpha/keep.ts",
+		line: 1,
+		message: "mensagem",
+		action: "ação",
+		anchor: null,
+		count: 1,
+		present: true,
+		decision: "pending",
+		execState: "pending",
+		createdAt: "2026-01-01T00:00:00.000Z",
+		updatedAt: "2026-01-01T00:00:00.000Z",
+		history: [],
+		...overrides,
+	};
+}
+
+function stateWith(
+	reviewedSha: string,
+	findings: Record<string, FindingState> = {},
+): FindingsStateFile {
+	return {
+		version: 2,
+		branch: "main",
+		slug: "main",
+		updatedAt: "2026-01-01T00:00:00.000Z",
+		order: Object.keys(findings),
+		reviewed: { headSha: reviewedSha, at: "2026-01-01T00:00:00.000Z" },
+		findings,
+	};
+}
+
+function options(overrides: Partial<ScopeOptions> = {}): ScopeOptions {
+	return { base: "main", head: "HEAD", full: false, clean: false, ...overrides };
+}
+
+function git(cwd: string, args: string[]): string {
+	const result = Bun.spawnSync(["git", ...args], {
+		cwd,
+		stdout: "pipe",
+		stderr: "pipe",
+	});
+	if (result.exitCode !== 0) {
+		throw new Error(`git ${args.join(" ")}: ${result.stderr.toString()}`);
+	}
+	return result.stdout.toString();
+}
+
+type Repo = { cwd: string; base: string; head: string; cleanup: () => void };
+
+/** Repositório temporário: `base` → `head` altera `src/alpha/a.ts`. */
+function makeRepo(): Repo {
+	const cwd = mkdtempSync(join(tmpdir(), "houndsman-scope-"));
+	git(cwd, ["init", "-b", "main"]);
+	git(cwd, ["config", "user.email", "scope@example.test"]);
+	git(cwd, ["config", "user.name", "Scope"]);
+	git(cwd, ["config", "commit.gpgsign", "false"]);
+	git(cwd, ["config", "tag.gpgsign", "false"]);
+
+	mkdirSync(join(cwd, "src", "alpha"), { recursive: true });
+	writeFileSync(join(cwd, "src", "alpha", "a.ts"), "export const a = 1;\n");
+	writeFileSync(join(cwd, "src", "alpha", "keep.ts"), "export const keep = 1;\n");
+	writeFileSync(join(cwd, "README.md"), "# Fake\n");
+	git(cwd, ["add", "."]);
+	git(cwd, ["commit", "-m", "initial"]);
+	const base = git(cwd, ["rev-parse", "HEAD"]).trim();
+
+	writeFileSync(join(cwd, "src", "alpha", "a.ts"), "export const a = 2;\n");
+	git(cwd, ["add", "-A"]);
+	git(cwd, ["commit", "-m", "change"]);
+	const head = git(cwd, ["rev-parse", "HEAD"]).trim();
+
+	return {
+		cwd,
+		base,
+		head,
+		cleanup: () => rmSync(cwd, { recursive: true, force: true }),
+	};
+}
+
+// ---------------------------------------------------------------------------
+// Decisão de escopo
+// ---------------------------------------------------------------------------
+
+describe("ReviewScopeResolver", () => {
+	test("mesmo commit revisado vira no-op (sem tocar no git)", () => {
+		const sha = "a".repeat(40);
+		const scope = new ReviewScopeResolver(options(), fakeHoundsmanConfig).resolve(
+			stateWith(sha),
+			sha,
+		);
+
+		expect(scope.kind).toBe("noop");
+		if (scope.kind !== "noop") throw new Error("esperava noop");
+		expect(scope.reviewedFrom).toBe(sha);
+		expect(scope.headSha).toBe(sha);
+	});
+
+	test("`--full` re-revisa o mesmo commit", () => {
+		const repo = makeRepo();
+		const originalCwd = process.cwd();
+		try {
+			process.chdir(repo.cwd);
+			const scope = new ReviewScopeResolver(
+				options({ base: repo.base, full: true }),
+				fakeHoundsmanConfig,
+			).resolve(stateWith(repo.head), repo.head);
+
+			expect(scope.kind).toBe("review");
+			if (scope.kind !== "review") throw new Error("esperava review");
+			expect(scope.classification.mode).toBe("full");
+			expect(scope.classification.headSha).toBe(repo.head);
+		} finally {
+			process.chdir(originalCwd);
+			repo.cleanup();
+		}
+	});
+
+	test("delta revisa só os arquivos alterados e carrega o resto", () => {
+		const repo = makeRepo();
+		const originalCwd = process.cwd();
+		try {
+			process.chdir(repo.cwd);
+			const previous = stateWith(repo.base, {
+				abcdef1234: findingState({ file: "src/alpha/keep.ts" }),
+				fedcba4321: findingState({ file: "src/alpha/a.ts" }),
+			});
+			const scope = new ReviewScopeResolver(
+				options({ base: repo.base }),
+				fakeHoundsmanConfig,
+			).resolve(previous, repo.head);
+
+			expect(scope.kind).toBe("review");
+			if (scope.kind !== "review") throw new Error("esperava review");
+			expect(scope.classification.mode).toBe("incremental");
+			expect(scope.classification.reviewedFrom).toBe(repo.base);
+			expect(Object.keys(scope.classification.files)).toEqual(["src/alpha/a.ts"]);
+			expect(scope.classification.carryover?.map((f) => f.file)).toEqual([
+				"src/alpha/keep.ts",
+			]);
+		} finally {
+			process.chdir(originalCwd);
+			repo.cleanup();
+		}
+	});
+
+	test("histórico reescrito (HEAD sem ancestrais comuns) cai no completo", () => {
+		const repo = makeRepo();
+		const originalCwd = process.cwd();
+		try {
+			process.chdir(repo.cwd);
+			// `repo.head` não é ancestral de `repo.base` → revisão completa.
+			const scope = new ReviewScopeResolver(
+				options({ base: repo.base }),
+				fakeHoundsmanConfig,
+			).resolve(stateWith(repo.head), repo.base);
+
+			expect(scope.kind).toBe("review");
+			if (scope.kind !== "review") throw new Error("esperava review");
+			expect(scope.classification.mode).toBe("full");
+		} finally {
+			process.chdir(originalCwd);
+			repo.cleanup();
+		}
+	});
+});
+
+// ---------------------------------------------------------------------------
+// Integração: prepare/finalize no mesmo commit
+// ---------------------------------------------------------------------------
+
+describe("prepare/finalize — mesmo commit", () => {
+	test("no-op preserva relatório e não gera briefs", async () => {
+		const repo = makeRepo();
+		const originalCwd = process.cwd();
+		const originalHome = process.env.HOUNDSMAN_HOME;
+		let storage: SQLiteStorageProvider | null = null;
+
+		try {
+			process.env.HOUNDSMAN_HOME = join(repo.cwd, ".home");
+			process.chdir(repo.cwd);
+
+			storage = new SQLiteStorageProvider(join(repo.cwd, "houndsman.db"));
+			const record = storage.getOrCreateReview({
+				repo: resolveRepoIdentity(),
+				branch: "main",
+				slug: "main",
+			});
+			const opts = {
+				...defaultOptions(),
+				base: repo.base,
+				head: "HEAD",
+				noJev: true,
+			};
+
+			let ctx = reviewContext(storage, record);
+			await prepare(opts, "main", fakeHoundsmanConfig, ctx);
+			expect(storage.getReview(record.id)?.status).toBe("reviewing");
+
+			writeFileSync(
+				ctx.work.findingFile("alpha"),
+				`${JSON.stringify(
+					{
+						watchdogId: "alpha",
+						reviewedFiles: ["src/alpha/a.ts"],
+						skipped: [],
+						findings: [
+							{
+								rule: "regra",
+								severity: "blocking",
+								file: "src/alpha/a.ts",
+								line: 1,
+								message: "achado",
+								action: "corrigir",
+							},
+						],
+					},
+					null,
+					2,
+				)}\n`,
+			);
+			finalize(opts, "main", fakeHoundsmanConfig, ctx);
+
+			const classificationBefore = storage.readArtifact(
+				record.id,
+				"classification.json",
+			)?.content;
+			const reportBefore = storage.readArtifact(record.id, "review.md")?.content;
+			const findingsBefore = JSON.stringify(
+				storage.readFindings(record.id)?.findings,
+			);
+			const reviewedBefore = storage.getReview(record.id)?.reviewedSha;
+			expect(classificationBefore).toBeTruthy();
+			expect(reportBefore).toContain("src/alpha/a.ts");
+
+			// Mesmo commit: prepare vira no-op e nada é reescrito.
+			ctx = reviewContext(storage, storage.getReview(record.id) ?? record);
+			const again = await prepare(opts, "main", fakeHoundsmanConfig, ctx);
+			expect(again.messages.join("\n")).toContain(
+				"Nenhuma alteração desde a última revisão",
+			);
+			expect(storage.readArtifact(record.id, "classification.json")?.content).toBe(
+				classificationBefore,
+			);
+			expect(storage.readArtifact(record.id, "review.md")?.content).toBe(
+				reportBefore,
+			);
+			expect(storage.getReview(record.id)?.status).toBe("review_done");
+			expect(existsSync(ctx.work.briefFile("alpha"))).toBe(false);
+
+			// Finalize sem ciclo preparado: no-op (não degrada o relatório).
+			const finalizedAgain = finalize(
+				opts,
+				"main",
+				fakeHoundsmanConfig,
+				reviewContext(storage, storage.getReview(record.id) ?? record),
+			);
+			expect(finalizedAgain.messages.join("\n")).toContain("Nada a finalizar");
+			expect(storage.readArtifact(record.id, "review.md")?.content).toBe(
+				reportBefore,
+			);
+			expect(JSON.stringify(storage.readFindings(record.id)?.findings)).toBe(
+				findingsBefore,
+			);
+			expect(storage.getReview(record.id)?.reviewedSha).toBe(reviewedBefore);
+		} finally {
+			storage?.close();
+			process.chdir(originalCwd);
+			if (originalHome === undefined) delete process.env.HOUNDSMAN_HOME;
+			else process.env.HOUNDSMAN_HOME = originalHome;
+			repo.cleanup();
+		}
+	}, 30_000);
+});

package/src/tests/review-scripts.test.ts

@@ -673,6 +673,79 @@ describe("report-builder", () => {
 		expect(md).toContain("review.alpha.md");
 	});
 
+	test("renderReport coloca o sumário antes dos achados", () => {
+		const md = renderReport(
+			"main",
+			[{ watchdogId: "alpha", reviewedFiles: ["a.ts"], skipped: [], findings: [] }],
+			[
+				{
+					rule: "R1",
+					severity: "blocking" as const,
+					file: "a.ts",
+					line: 1,
+					message: "m",
+					action: "a",
+					watchdogs: ["alpha"],
+				},
+			],
+			{ classified: { alpha: ["a.ts"] } },
+			null,
+			undefined,
+			undefined,
+			[
+				{
+					id: "alpha",
+					name: "Alpha",
+					file: "review.alpha.md",
+					findings: 1,
+					reviewedFiles: 1,
+					expectedFiles: 1,
+				},
+			],
+		);
+		const sections = [
+			"## Relatórios por domínio",
+			"## Cobertura",
+			"## Conclusão",
+			"## ❌ blocking",
+		].map((section) => md.indexOf(section));
+		expect(sections.every((index) => index >= 0)).toBe(true);
+		expect([...sections].sort((a, b) => a - b)).toEqual(sections);
+	});
+
+	test("renderReport anexa candidatos Jev depois dos achados", () => {
+		const md = renderReport(
+			"main",
+			[{ watchdogId: "alpha", reviewedFiles: [], skipped: [], findings: [] }],
+			[
+				{
+					rule: "R1",
+					severity: "blocking" as const,
+					file: "a.ts",
+					line: 1,
+					message: "m",
+					action: "a",
+					watchdogs: ["alpha"],
+				},
+			],
+			{},
+			null,
+			[
+				{
+					watchdogId: "alpha",
+					rule: "R2",
+					severity: "attention",
+					file: "b.ts",
+					confidence: 0.6,
+					questionKey: "q",
+				},
+			],
+		);
+		expect(md.indexOf("## ❌ blocking")).toBeLessThan(
+			md.indexOf("## 🔎 Candidatos não verificados"),
+		);
+	});
+
 	test("renderDomainReport mostra cobertura e não revisados", () => {
 		const md = renderDomainReport(
 			"main",
@@ -1150,13 +1223,16 @@ describe("jev-candidates", () => {
 
 describe("parseReviewArgs", () => {
 	test("lê flags de valor e booleanas", () => {
-		const opts = parseReviewArgs(
-			["--base", "develop", "--branch", "feature/x", "--finalize", "--clean"],
-			"tmp/artifacts",
-		);
+		const opts = parseReviewArgs([
+			"--base",
+			"develop",
+			"--branch",
+			"feature/x",
+			"--finalize",
+			"--clean",
+		]);
 		expect(opts.base).toBe("develop");
 		expect(opts.branch).toBe("feature/x");
-		expect(opts.dir).toBe("tmp/artifacts");
 		expect(opts.finalize).toBe(true);
 		expect(opts.clean).toBe(true);
 		expect(opts.failOnBlocking).toBe(false);