@payconductor/houndsman 0.2.0 → 0.3.0

package/src/core/git-revision.ts

@@ -11,31 +11,20 @@
  * (`parseEntries`) — não reimplementa leitura de diff.
  */
 
-import {
-	DEFAULT_MAX_PER_FILE_CHARS,
-	type DiffSource,
-	parseDiffIndex,
-	parseNumstat,
-} from "./diff-source";
+import { DEFAULT_MAX_PER_FILE_CHARS, type DiffSource } from "./diff-source";
 import { parseEntries } from "./file-classifier";
+import { runGit } from "./git-runner";
+import { GitRepository } from "./services/git-repository";
 import type { FileChurn } from "./types";
 
-/** Executa `git` (paths literais) e devolve o stdout; lança se falhar. */
-export function runGit(args: string[]): string {
-	const result = Bun.spawnSync(["git", "-c", "core.quotepath=false", ...args], {
-		stdout: "pipe",
-		stderr: "pipe",
-	});
-	if (result.exitCode !== 0) {
-		const stderr = new TextDecoder().decode(result.stderr).trim();
-		throw new Error(`git ${args.join(" ")} falhou: ${stderr}`);
-	}
-	return new TextDecoder().decode(result.stdout);
-}
+export { runGit };
+
+/** Repositório padrão (runner real) usado pelos helpers funcionais. */
+const git = new GitRepository();
 
 /** SHA completo de uma ref (`git rev-parse`). Lança se a ref não resolver. */
 export function resolveSha(ref: string): string {
-	return runGit(["rev-parse", ref]).trim();
+	return git.resolveSha(ref);
 }
 
 /** SHA do commit atual (`HEAD`). */
@@ -50,31 +39,22 @@ export function currentHeadSha(): string {
  * comportamento seguro.
  */
 export function isAncestor(ancestor: string, descendant: string): boolean {
-	const result = Bun.spawnSync(
-		["git", "merge-base", "--is-ancestor", ancestor, descendant],
-		{ stdout: "ignore", stderr: "ignore" },
-	);
-	return result.exitCode === 0;
+	return git.isAncestor(ancestor, descendant);
 }
 
 /** Conteúdo de um arquivo num commit (`git show sha:path`); null se ausente. */
 export function readFileAt(sha: string, path: string): string | null {
-	const result = Bun.spawnSync(
-		["git", "-c", "core.quotepath=false", "show", `${sha}:${path}`],
-		{ stdout: "pipe", stderr: "ignore" },
-	);
-	if (result.exitCode !== 0) return null;
-	return new TextDecoder().decode(result.stdout);
+	return git.readFileAt(sha, path);
 }
 
 /** Arquivos alterados num intervalo (`git diff range --name-status`). */
 export function diffEntries(range: string): ReturnType<typeof parseEntries> {
-	return parseEntries(runGit(["diff", range, "--name-status"]));
+	return parseEntries(git.run(["diff", range, "--name-status"]));
 }
 
 /** Churn por arquivo de um intervalo (`git diff --numstat -z range`). */
 export function diffNumstat(range: string): Map<string, FileChurn> {
-	return parseNumstat(runGit(["diff", "--numstat", "-z", range]));
+	return git.diffNumstat(range);
 }
 
 /**
@@ -86,9 +66,7 @@ export function diffPatch(
 	paths?: readonly string[],
 	maxPerFileChars: number = DEFAULT_MAX_PER_FILE_CHARS,
 ): Map<string, string> {
-	const args = ["diff", range];
-	if (paths && paths.length > 0) args.push("--", ...paths);
-	return parseDiffIndex(runGit(args), maxPerFileChars);
+	return git.diffPatch(range, paths, maxPerFileChars);
 }
 
 /** Diff (patch + churn) de `from..to` — 2 spawns, base do review incremental. */
@@ -97,9 +75,5 @@ export function collectDiffSince(
 	to: string,
 	maxPerFileChars: number = DEFAULT_MAX_PER_FILE_CHARS,
 ): DiffSource {
-	const range = `${from}..${to}`;
-	return {
-		byFile: parseDiffIndex(runGit(["diff", range]), maxPerFileChars),
-		churn: diffNumstat(range),
-	};
+	return git.collectDiffSince(from, to, maxPerFileChars);
 }

package/src/core/git-runner.ts

@@ -0,0 +1,46 @@
+/**
+ * Execução do binário `git` (biblioteca) — única camada que fala com o processo.
+ *
+ * `core.quotepath=false` mantém paths literais (acentos/unicode). O runner é
+ * injetável nos testes; `GitRepository` é a superfície OO sobre estes helpers.
+ */
+
+/** Resultado cru de uma execução do git (nunca lança). */
+export type GitResult = {
+	ok: boolean;
+	code: number;
+	stdout: string;
+	stderr: string;
+};
+
+/** Executa `git` e devolve o resultado cru. Injetável nos testes. */
+export type GitRunner = (args: string[]) => GitResult;
+
+/** Runner padrão: `git -c core.quotepath=false <args>` a partir do cwd. */
+export const defaultGitRunner: GitRunner = (args) => {
+	const result = Bun.spawnSync(["git", "-c", "core.quotepath=false", ...args], {
+		stdout: "pipe",
+		stderr: "pipe",
+	});
+	const code = result.exitCode ?? 1;
+	return {
+		ok: code === 0,
+		code,
+		stdout: new TextDecoder().decode(result.stdout),
+		stderr: new TextDecoder().decode(result.stderr),
+	};
+};
+
+/** Executa e devolve o stdout; lança com o stderr quando o git falha. */
+export function runGit(args: string[], runner: GitRunner = defaultGitRunner): string {
+	const result = runner(args);
+	if (!result.ok) {
+		throw new Error(`git ${args.join(" ")} falhou: ${result.stderr.trim()}`);
+	}
+	return result.stdout;
+}
+
+/** Executa o git sem lançar (para sondagens como `merge-base`/`show`). */
+export function tryGit(args: string[], runner: GitRunner = defaultGitRunner): GitResult {
+	return runner(args);
+}

package/src/core/github-review.ts

@@ -20,40 +20,11 @@ import {
 	type FindingState,
 	type FindingsStateFile,
 } from "./findings-state";
+import { systemClock } from "./services/clock";
+import { defaultGhRunner, type GhResult, type GhRunner } from "./services/gh-client";
 import { SEVERITY_EMOJI, type Severity } from "./types";
 
-// ---------------------------------------------------------------------------
-// Runner do `gh` (injetável nos testes)
-// ---------------------------------------------------------------------------
-
-export type GhResult = { ok: boolean; code: number; stdout: string; stderr: string };
-
-/** Executa o `gh` e devolve o resultado cru (sem lançar). */
-export type GhRunner = (args: string[]) => GhResult;
-
-/** Runner padrão: `gh` a partir do cwd; ausência do binário → `ok:false`. */
-export const defaultGhRunner: GhRunner = (args) => {
-	try {
-		const result = Bun.spawnSync(["gh", ...args], {
-			stdout: "pipe",
-			stderr: "pipe",
-		});
-		const code = result.exitCode ?? 1;
-		return {
-			ok: code === 0,
-			code,
-			stdout: new TextDecoder().decode(result.stdout).trim(),
-			stderr: new TextDecoder().decode(result.stderr).trim(),
-		};
-	} catch (error) {
-		return {
-			ok: false,
-			code: 127,
-			stdout: "",
-			stderr: error instanceof Error ? error.message : String(error),
-		};
-	}
-};
+export { type GhResult, type GhRunner, defaultGhRunner };
 
 // ---------------------------------------------------------------------------
 // Alvo (PR + repositório)
@@ -371,7 +342,7 @@ export function submitFindings(options: {
 	now?: string;
 }): SubmitOutcome {
 	const { state, target, runner } = options;
-	const now = options.now ?? new Date().toISOString();
+	const now = options.now ?? systemClock();
 	const candidates = selectSubmitCandidates(state, options.selection);
 
 	const outcome: SubmitOutcome = { posted: [], failed: [], skipped: [] };