@payconductor/houndsman 0.13.0 → 0.16.0

package/src/tests/storage.test.ts

@@ -142,6 +142,59 @@ function contract(
 			}
 		});
 
+		test("variantes A/B: mesma branch, runs separadas e findings isolados", () => {
+			const { storage, cleanup } = make();
+			try {
+				const repo = buildRepoIdentity(null, "/tmp/app");
+				const main = storage.getOrCreateReview({
+					repo,
+					branch: "feature/x",
+					slug: "feature-x",
+				});
+				const a = storage.getOrCreateReview({
+					repo,
+					branch: "feature/x",
+					variant: "baseline",
+					slug: "feature-x--baseline-abc123",
+				});
+				const b = storage.getOrCreateReview({
+					repo,
+					branch: "feature/x",
+					variant: "otimizado",
+					slug: "feature-x--otimizado-def456",
+				});
+				expect(new Set([main.id, a.id, b.id]).size).toBe(3);
+				expect(storage.findReview(repo.key, "feature/x")?.id).toBe(main.id);
+				expect(storage.findReview(repo.key, "feature/x", "baseline")?.id).toBe(
+					a.id,
+				);
+				expect(storage.findReview(repo.key, "feature/x", "otimizado")?.id).toBe(
+					b.id,
+				);
+				expect(storage.findReview(repo.key, "feature/x", "ausente")).toBeNull();
+
+				// Idempotente por (branch, variante).
+				expect(
+					storage.getOrCreateReview({
+						repo,
+						branch: "feature/x",
+						variant: "baseline",
+						slug: "outro",
+					}).id,
+				).toBe(a.id);
+				expect(storage.listReviews(repo.key)).toHaveLength(3);
+
+				// Findings/staging são por review.
+				storage.writeFindings(a.id, sampleState());
+				expect(storage.readFindings(a.id)?.findings.ab12cd34ef?.rule).toBe(
+					"regra",
+				);
+				expect(storage.readFindings(b.id)).toBeNull();
+			} finally {
+				cleanup();
+			}
+		});
+
 		test("findings: round-trip completo e preservação do short id", () => {
 			const { storage, cleanup } = make();
 			try {
@@ -195,18 +248,18 @@ function contract(
 					slug: "main",
 				});
 				const first = storage.writeArtifact(review.id, {
-					name: "review.md",
-					kind: "review",
+					name: "review-resume.md",
+					kind: "resume",
 					content: "# Review\n",
 				});
 				expect(first.id).toMatch(UUID);
 				const second = storage.writeArtifact(review.id, {
-					name: "review.md",
-					kind: "review",
+					name: "review-resume.md",
+					kind: "resume",
 					content: "# Review 2\n",
 				});
 				expect(second.id).toBe(first.id);
-				expect(storage.readArtifact(review.id, "review.md")?.content).toBe(
+				expect(storage.readArtifact(review.id, "review-resume.md")?.content).toBe(
 					"# Review 2\n",
 				);
 				storage.writeArtifact(review.id, {
@@ -215,7 +268,7 @@ function contract(
 					content: "{}",
 				});
 				expect(storage.listArtifacts(review.id).map((item) => item.name)).toEqual(
-					["manifest.json", "review.md"],
+					["manifest.json", "review-resume.md"],
 				);
 				storage.deleteArtifact(review.id, "manifest.json");
 				expect(storage.listArtifacts(review.id)).toHaveLength(1);
@@ -235,14 +288,14 @@ function contract(
 				});
 				storage.writeFindings(review.id, sampleState("main"));
 				storage.writeArtifact(review.id, {
-					name: "review.md",
-					kind: "review",
+					name: "review-resume.md",
+					kind: "resume",
 					content: "# Review\n",
 				});
 				storage.deleteReview(review.id);
 				expect(storage.getReview(review.id)).toBeNull();
 				expect(storage.readFindings(review.id)).toBeNull();
-				expect(storage.readArtifact(review.id, "review.md")).toBeNull();
+				expect(storage.readArtifact(review.id, "review-resume.md")).toBeNull();
 			} finally {
 				cleanup();
 			}
@@ -446,4 +499,136 @@ describe("migração do schema SQLite", () => {
 			rmSync(dir, { recursive: true, force: true });
 		}
 	});
+
+	test("banco v4 ganha `variant` sem perder findings (rebuild da reviews)", () => {
+		const dir = mkdtempSync(join(tmpdir(), "houndsman-migrate-v4-"));
+		const path = join(dir, "houndsman.db");
+		const reviewId = "22222222-2222-4222-8222-222222222222";
+		const legacy = new Database(path);
+		try {
+			legacy.exec(`
+				CREATE TABLE reviews (
+					id TEXT PRIMARY KEY,
+					repo_key TEXT NOT NULL,
+					repo_root TEXT NOT NULL,
+					repo_remote TEXT,
+					branch TEXT NOT NULL,
+					slug TEXT NOT NULL,
+					base TEXT,
+					head TEXT,
+					head_sha TEXT,
+					reviewed_sha TEXT,
+					reviewed_at TEXT,
+					status TEXT,
+					started_at TEXT,
+					heartbeat_at TEXT,
+					worktree_path TEXT,
+					pr_number INTEGER,
+					created_at TEXT NOT NULL,
+					updated_at TEXT NOT NULL,
+					UNIQUE(repo_key, branch)
+				);
+				CREATE TABLE findings (
+					id TEXT PRIMARY KEY,
+					review_id TEXT NOT NULL REFERENCES reviews(id) ON DELETE CASCADE,
+					short_id TEXT NOT NULL,
+					fingerprint TEXT NOT NULL,
+					watchdog_ids TEXT NOT NULL,
+					rule TEXT NOT NULL,
+					severity TEXT NOT NULL,
+					file TEXT NOT NULL,
+					line INTEGER,
+					message TEXT NOT NULL,
+					action TEXT NOT NULL,
+					evidence TEXT,
+					scenario TEXT,
+					impact TEXT,
+					confidence REAL,
+					basis TEXT,
+					anchor TEXT,
+					found_at_sha TEXT,
+					count INTEGER NOT NULL DEFAULT 1,
+					present INTEGER NOT NULL DEFAULT 1,
+					decision TEXT NOT NULL,
+					comment TEXT,
+					exec_state TEXT NOT NULL,
+					github TEXT,
+					created_at TEXT NOT NULL,
+					updated_at TEXT NOT NULL,
+					UNIQUE(review_id, short_id),
+					UNIQUE(review_id, fingerprint)
+				);
+				PRAGMA user_version = 4;
+			`);
+			legacy.run(
+				`INSERT INTO reviews
+					(id, repo_key, repo_root, branch, slug, created_at, updated_at)
+				 VALUES (?, ?, ?, ?, ?, ?, ?)`,
+				[
+					reviewId,
+					"path:/repo",
+					dir,
+					"feature/x",
+					"feature-x",
+					"2026-01-01T00:00:00.000Z",
+					"2026-01-01T00:00:00.000Z",
+				],
+			);
+			legacy.run(
+				`INSERT INTO findings
+					(id, review_id, short_id, fingerprint, watchdog_ids, rule, severity,
+					 file, line, message, action, decision, exec_state, created_at, updated_at)
+				 VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`,
+				[
+					"33333333-3333-4333-8333-333333333333",
+					reviewId,
+					"ab12cd34ef",
+					"fp-legado",
+					'["alpha"]',
+					"regra",
+					"attention",
+					"src/a.ts",
+					3,
+					"msg",
+					"ação",
+					"pending",
+					"pending",
+					"2026-01-01T00:00:00.000Z",
+					"2026-01-01T00:00:00.000Z",
+				],
+			);
+		} finally {
+			legacy.close();
+		}
+
+		const storage = new SQLiteStorageProvider(path);
+		try {
+			const review = storage.getReview(reviewId);
+			expect(review?.variant).toBeUndefined();
+			// O rebuild preserva os filhos (FKs desligadas durante a troca).
+			expect(storage.readFindings(reviewId)?.findings.ab12cd34ef?.rule).toBe(
+				"regra",
+			);
+			// E a identidade agora aceita variantes na mesma branch.
+			const repo = buildRepoIdentity(null, dir);
+			const a = storage.getOrCreateReview({
+				repo,
+				branch: "feature/x",
+				variant: "baseline",
+				slug: "feature-x--baseline-abc123",
+			});
+			const b = storage.getOrCreateReview({
+				repo,
+				branch: "feature/x",
+				variant: "otimizado",
+				slug: "feature-x--otimizado-def456",
+			});
+			expect(a.id).not.toBe(b.id);
+			expect(a.id).not.toBe(reviewId);
+			expect(storage.findReview(a.repoKey, "feature/x", "baseline")?.id).toBe(a.id);
+		} finally {
+			storage.close();
+			rmSync(dir, { recursive: true, force: true });
+		}
+	});
 });

package/src/core/renderers/report-renderer.ts

@@ -1,66 +0,0 @@
-/**
- * Renderização do relatório (biblioteca) — superfície OO sobre `report-builder`.
- *
- * O texto continua nas funções puras; a classe fixa o resolver de nomes e evita
- * repetir a lista de argumentos no orquestrador.
- */
-
-import type { JevCandidate } from "../jev";
-import {
-	type ContextSummary,
-	type DomainReport,
-	type MergedFinding,
-	renderDomainReport,
-	renderReport,
-	type WatchdogNameResolver,
-	type WatchdogReport,
-} from "../report-builder";
-
-/** Renderiza o relatório consolidado e os relatórios por domínio. */
-export class ReportRenderer {
-	private readonly nameOf: WatchdogNameResolver;
-
-	constructor(nameOf: WatchdogNameResolver) {
-		this.nameOf = nameOf;
-	}
-
-	/** Relatório consolidado (`review.md`). */
-	render(
-		branch: string,
-		reports: WatchdogReport[],
-		merged: MergedFinding[],
-		coverage: { classified?: Record<string, string[]> },
-		context?: ContextSummary | null,
-		candidates?: JevCandidate[],
-		domains: readonly DomainReport[] = [],
-	): string {
-		return renderReport(
-			branch,
-			reports,
-			merged,
-			coverage,
-			context,
-			candidates,
-			this.nameOf,
-			domains,
-		);
-	}
-
-	/** Relatório isolado de um watchdog (`review.<id>.md`). */
-	renderDomain(
-		branch: string,
-		report: WatchdogReport,
-		merged: MergedFinding[],
-		expectedFiles: number,
-		context?: ContextSummary | null,
-	): string {
-		return renderDomainReport(
-			branch,
-			report,
-			merged,
-			expectedFiles,
-			context,
-			this.nameOf,
-		);
-	}
-}

package/src/skill/example-review.md

@@ -1,66 +0,0 @@
-# PR Review — feature/add-webhook-retry
-
-**Data:** 2026-04-20
-**Watchdogs ativos:** api-contracts, backend-architecture, payments-integrations, acquirer-integrations
-**Achados:** 2 bloqueantes · 1 atenção · 1 sugestões · 1 nit
-
-## Contexto da PR
-**PR:** #482 Adicionar retry de webhooks — https://github.com/org/repo/pull/482
-**Branch:** `feature/add-webhook-retry` → `main`
-**Objetivo:** Tornar o envio de webhooks resiliente a falhas temporárias do destinatário.
-**Motivação:** Webhooks com falha exigiam reenvio manual e causavam perda de eventos em integradores.
-**Resumo das alterações:**
-- Nova fila de retry para webhooks que falharam.
-- Novo endpoint interno para reprocessar eventos manualmente.
-- Registro de tentativas no handler de envio.
-
-## Relatórios por domínio
-
-| Watchdog | Achados | Revisados | Relatório |
-|---|---|---|---|
-| Arquitetura Backend | 2 | 3/3 | [`review.backend-architecture.md`](review.backend-architecture.md) |
-| Pagamentos & Integrações | 1 | 4/4 | [`review.payments-integrations.md`](review.payments-integrations.md) |
-| Acquirer Integrations | 2 | 3/4 | [`review.acquirer-integrations.md`](review.acquirer-integrations.md) |
-
-## Cobertura
-
-| Watchdog | Arquivos revisados | Findings |
-|---|---|---|
-| API & Contratos | 2 | 0 |
-| Arquitetura Backend | 3 | 2 |
-| Pagamentos & Integrações | 4 | 1 |
-| Acquirer Integrations | 3/4 (faltam 1) | 2 |
-
-## Conclusão
-
-**Status:** ❌ Mudanças Necessárias
-**Resumo:** 2 violações bloqueantes, 1 ponto de atenção, 1 sugestão e 1 nit.
-
-## ❌ blocking
-
-- **Webhook handler sem verifySignature** — `server/src/services/integrations/acquirer/webhook/handle-charge-event.ts:15` · _Acquirer Integrations, Pagamentos & Integrações_
-  Payload processado antes de validar a assinatura do provider.
-  **Ação:** Validar `verifyWebhookSignature(payload, signature, secret)` antes de qualquer efeito.
-  **Evidência:** `const event = JSON.parse(body)`
-
-- **Promise não aguardada** — `server/src/services/webhook/webhook-retry-service.ts:92` · _Pagamentos & Integrações_
-  `updateWebhookStatus(id, 'failed')` sem `await` — status pode não persistir antes do retorno.
-  **Ação:** Adicionar `await`.
-
-## ⚠️ attention
-
-- **Retry sem backoff** — `server/src/services/webhook/webhook-retry-service.ts:55` · _Acquirer Integrations_
-  Retry com intervalo fixo de 1s.
-  **Ação:** Usar exponential backoff com jitter.
-
-## 💡 suggestion
-
-- **Complexidade** — `server/src/services/webhook/webhook-retry-service.ts:45-78` · _Arquitetura Backend_
-  `retryWithBackoff` com 6 níveis de indentação.
-  **Ação:** Extrair `calculateBackoffDelay(attempt, config)` e usar early returns.
-
-## 🔎 nit
-
-- **Ordem de membros** — `server/src/services/webhook/webhook-retry-service.ts:12` · _Arquitetura Backend_
-  Campo privado declarado antes do construtor público.
-  **Ação:** Reordenar membros (públicos primeiro).