@payconductor/houndsman 0.11.0 → 0.12.0

package/src/tests/fallback.test.ts

@@ -1,16 +1,10 @@
-/**
- * Fallback de classificação e findings emergentes (lógica/domínio).
- */
+/** Fallback de classificação (arquivos sem dono). */
 
 import { describe, expect, test } from "bun:test";
 import { defineHoundsmanConfig } from "../core/config";
 import { classifyEntries } from "../core/file-classifier";
 import { checkRegistry } from "../core/registry-check";
 import { defineWatchdog } from "../core/types";
-import { AgentState } from "../harness/investigation/agent-state";
-import { EvidenceVerifier } from "../harness/investigation/evidence-verifier";
-import { FindingCritic } from "../harness/investigation/finding-critic";
-import { FindingValidator } from "../harness/validation/finding-validator";
 
 const alpha = defineWatchdog({
 	id: "alpha",
@@ -28,7 +22,6 @@ const fallback = defineWatchdog({
 	description: "Fallback de lógica/domínio.",
 	scope: "arquivos sem dono",
 	fallback: true,
-	allowEmergentFindings: true,
 	rules: [
 		{
 			severity: "attention",
@@ -82,91 +75,3 @@ describe("classificação com fallback", () => {
 		).toBe(true);
 	});
 });
-
-describe("findings emergentes", () => {
-	const file = "a.ts";
-	const content = "const x = 1;\n";
-	const state = new AgentState();
-	const evidence = state.addEvidence({
-		file,
-		startLine: 1,
-		endLine: 1,
-		snippet: content.trim(),
-		kind: "definition",
-		sourceTool: "test",
-		confidence: 0.9,
-	});
-	const draft = {
-		rule: "Lógica: a função fazA na verdade fazB",
-		severity: "blocking" as const,
-		file,
-		line: 1,
-		message: "comportamento diverge do nome",
-		action: "renomear ou corrigir",
-		evidenceIds: [evidence.id],
-		confidence: 0.9,
-	};
-	const verifier = new EvidenceVerifier({
-		allowedFiles: [file],
-		readFile: (path) => (path === file ? content : null),
-	});
-
-	test("crítico aceita e limita a severidade quando habilitado", () => {
-		const critic = new FindingCritic({
-			knownRules: new Set([fallback.rules[0]?.text ?? ""]),
-			verifier,
-			allowEmergentFindings: true,
-		});
-		const decision = critic.reviewOne(draft, state);
-		expect(decision.verdict).toBe("keep");
-		expect(decision.draft.severity).toBe("attention");
-	});
-
-	test("crítico descarta quando o opt-in está desligado", () => {
-		const critic = new FindingCritic({
-			knownRules: new Set([fallback.rules[0]?.text ?? ""]),
-			verifier,
-		});
-		const decision = critic.reviewOne(draft, state);
-		expect(decision.verdict).toBe("drop");
-		expect(decision.reason).toContain("desabilitado");
-	});
-
-	test("validador espelha a mesma regra", () => {
-		const report = {
-			watchdogId: "default",
-			reviewedFiles: [file],
-			skipped: [],
-			findings: [draft],
-		};
-		const allowed = new FindingValidator({
-			watchdogId: "default",
-			knownRules: new Set([fallback.rules[0]?.text ?? ""]),
-			allowedFiles: new Set([file]),
-			overflow: new Set(),
-			readFile: (path) => (path === file ? content : null),
-			allowEmergentFindings: true,
-		}).validate(report);
-		expect(allowed.report.findings[0]?.severity).toBe("attention");
-		expect(allowed.dropped).toHaveLength(0);
-
-		const denied = new FindingValidator({
-			watchdogId: "default",
-			knownRules: new Set([fallback.rules[0]?.text ?? ""]),
-			allowedFiles: new Set([file]),
-			overflow: new Set(),
-			readFile: (path) => (path === file ? content : null),
-		}).validate(report);
-		expect(denied.report.findings).toHaveLength(0);
-	});
-
-	test("finding emergente sem descrição é descartado", () => {
-		const critic = new FindingCritic({
-			knownRules: new Set([fallback.rules[0]?.text ?? ""]),
-			verifier,
-			allowEmergentFindings: true,
-		});
-		const decision = critic.reviewOne({ ...draft, rule: "Lógica:" }, state);
-		expect(decision.verdict).toBe("drop");
-	});
-});

package/src/tests/fixtures/fake-model-provider.ts

@@ -41,7 +41,6 @@ export class FakeModelProvider implements ModelProvider {
 		return {
 			output: output as T,
 			usage: fakeUsage(),
-			steps: 1,
 			finishReason: "stop",
 		};
 	}

package/src/tests/review-scope.test.ts

@@ -9,6 +9,7 @@ import { describe, expect, test } from "bun:test";
 import { existsSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
+import { AstService } from "../core/ast/service";
 import { ReviewScopeResolver, type ScopeOptions } from "../core/engine/review-scope";
 import type { FindingState, FindingsStateFile } from "../core/findings-state";
 import { defaultOptions, finalize, prepare, reviewContext } from "../core/orchestrator";
@@ -138,6 +139,35 @@ describe("ReviewScopeResolver", () => {
 			if (scope.kind !== "review") throw new Error("esperava review");
 			expect(scope.classification.mode).toBe("full");
 			expect(scope.classification.headSha).toBe(repo.head);
+			expect(scope.classification.changedScope?.["src/alpha/a.ts"]).toEqual({
+				ranges: [{ start: 1, end: 1 }],
+				symbols: [],
+				source: "hunks",
+			});
+		} finally {
+			process.chdir(originalCwd);
+			repo.cleanup();
+		}
+	});
+
+	test("escopo usa o símbolo AST quando disponível", async () => {
+		const repo = makeRepo();
+		const originalCwd = process.cwd();
+		try {
+			process.chdir(repo.cwd);
+			const ast = new AstService(fakeHoundsmanConfig);
+			const scope = await new ReviewScopeResolver(
+				options({ base: repo.base, full: true }),
+				fakeHoundsmanConfig,
+				ast,
+			).resolve(null, repo.head);
+
+			expect(scope.kind).toBe("review");
+			if (scope.kind !== "review") throw new Error("esperava review");
+			const file = scope.classification.changedScope?.["src/alpha/a.ts"];
+			expect(file?.source).toBe("ast");
+			expect(file?.symbols.map((symbol) => symbol.name)).toEqual(["a"]);
+			expect(file?.ranges).toEqual([{ start: 1, end: 1 }]);
 		} finally {
 			process.chdir(originalCwd);
 			repo.cleanup();
@@ -163,6 +193,9 @@ describe("ReviewScopeResolver", () => {
 			expect(scope.classification.mode).toBe("incremental");
 			expect(scope.classification.reviewedFrom).toBe(repo.base);
 			expect(Object.keys(scope.classification.files)).toEqual(["src/alpha/a.ts"]);
+			expect(scope.classification.changedScope?.["src/alpha/a.ts"]?.ranges).toEqual(
+				[{ start: 1, end: 1 }],
+			);
 			expect(scope.classification.carryover?.map((f) => f.file)).toEqual([
 				"src/alpha/keep.ts",
 			]);

package/src/tests/worktree.test.ts

@@ -31,7 +31,6 @@ import {
 	WorktreeManager,
 } from "../core/services/worktree-manager";
 import { SQLiteStorageProvider } from "../core/storage/sqlite/sqlite-storage";
-import { parseHuntArgs } from "../harness/hunt/hunt-options";
 import { fakeHoundsmanConfig } from "./fixtures/fake-project";
 
 function git(cwd: string, args: string[]): string {
@@ -127,11 +126,10 @@ function fakeGh(
 }
 
 describe("flags de worktree", () => {
-	test("parse de review/hunt e exclusão mútua", () => {
+	test("parse de review e exclusão mútua", () => {
 		expect(parseReviewArgs(["--pr", "7"]).pr).toBe(7);
 		expect(parseReviewArgs(["--worktree", "/tmp/wt"]).worktree).toBe("/tmp/wt");
 		expect(() => parseReviewArgs(["--pr", "7", "--worktree", "/tmp/wt"])).toThrow();
-		expect(parseHuntArgs(["--pr", "8"]).pr).toBe(8);
 	});
 });
 

package/src/cli/commands/hunt-command.ts

@@ -1,51 +0,0 @@
-/** Comando `hunt` — revisão nativa com IA (harness próprio). */
-
-import { resolveReviewWorkspace } from "../../core/engine/review-workspace";
-import { HuntHarness } from "../../harness";
-import { parseHuntArgs } from "../../harness/hunt/hunt-options";
-import type { CliContext, Command } from "./command";
-
-/** Executa o harness nativo. */
-export class HuntCommand implements Command {
-	readonly name = "hunt";
-
-	async run(args: string[], context: CliContext): Promise<number> {
-		const options = parseHuntArgs(args);
-		const config = await context.config();
-		const workspace = resolveReviewWorkspace(
-			{
-				cwd: context.cwd,
-				base: options.base,
-				head: options.head,
-				branch: options.branch,
-				pr: options.pr,
-				worktree: options.worktree,
-			},
-			{ worktreesLocation: config.worktrees?.location },
-		);
-		for (const message of workspace.messages) context.logger.info(message);
-
-		const engine = await context.engine({
-			root: workspace.root,
-			mainRoot: workspace.mainRoot,
-		});
-		const resolved = {
-			...options,
-			branch: workspace.branch,
-			base: workspace.base,
-			head: workspace.head,
-			pr: workspace.prNumber,
-			worktreePath: workspace.worktreePath,
-		};
-		try {
-			const harness = await HuntHarness.from(engine, resolved, context.logger);
-			const result = await harness.run();
-			for (const message of result.messages) context.logger.info(message);
-			if (result.status === "failed") return 1;
-			if (options.failOnBlocking && result.blockers > 0) return 1;
-			return 0;
-		} finally {
-			engine.close();
-		}
-	}
-}

package/src/harness/README.md

@@ -1,15 +0,0 @@
-# `src/harness` — harness nativo do houndsman
-
-Este diretório é o **runtime de agentes do próprio houndsman** (`houndsman hunt`):
-tools read-only, investigação, máquina de estados e o agente revisor.
-
-> O **harness externo** (skill `/houndsman` para ClaudeCode/Copilot/agents) continua em
-> `src/skill/`. Os dois coexistem; o nativo é opt-in.
-
-Regras de dependência:
-
-- `harness/` pode importar `core/` (inclusive `core/ai`).
-- `core/` **nunca** importa `harness/`.
-- `cli/` importa ambos.
-
-Documentação detalhada: [`docs/HARNESS.md`](../../docs/HARNESS.md).

package/src/harness/agent/agent-context.ts

@@ -1,33 +0,0 @@
-/**
- * Contexto de um agente de revisão (um watchdog).
- */
-
-import type { AstAnalysis, AstImpact } from "../../core/ast/types";
-import type { DiffSource } from "../../core/diff-source";
-import type { Watchdog } from "../../core/domain/watchdog";
-import type { WatchdogRenderContext } from "../../core/types";
-import type { RuleAnalysis } from "../investigation/rule-analyzer";
-
-/** Dados imutáveis entregues ao agente. */
-export type AgentContext = {
-	watchdog: Watchdog;
-	projectName: string;
-	branch: string;
-	/** Arquivos do domínio (dentro do orçamento). */
-	files: readonly string[];
-	/** Arquivos do domínio fora do orçamento (não ler; registrar em skipped). */
-	overflow: readonly string[];
-	deleted: readonly string[];
-	docs: readonly string[];
-	context?: WatchdogRenderContext | null;
-	ast: ReadonlyMap<string, AstAnalysis>;
-	impact?: AstImpact;
-	/** Caminho de saída do findings (staging). */
-	outputPath: string;
-	maxSteps: number;
-	maxCalls: number;
-	repoRoot: string;
-	diff: DiffSource;
-	/** Análises determinísticas das regras do watchdog. */
-	rules: readonly RuleAnalysis[];
-};

package/src/harness/agent/agent-errors.ts

@@ -1,30 +0,0 @@
-/**
- * Erros do harness nativo.
- */
-
-/** Falha de configuração/execução do agente. */
-export class AgentError extends Error {
-	constructor(
-		message: string,
-		readonly watchdogId?: string,
-	) {
-		super(message);
-		this.name = "AgentError";
-	}
-}
-
-/** Orçamento de IA/tools esgotado durante a investigação. */
-export class AgentBudgetError extends AgentError {
-	constructor(message: string, watchdogId?: string) {
-		super(message, watchdogId);
-		this.name = "AgentBudgetError";
-	}
-}
-
-/** Saída do modelo inválida após as tentativas permitidas. */
-export class AgentOutputError extends AgentError {
-	constructor(message: string, watchdogId?: string) {
-		super(message, watchdogId);
-		this.name = "AgentOutputError";
-	}
-}

package/src/harness/agent/agent-factory.ts

@@ -1,46 +0,0 @@
-/**
- * Factory de agentes — injeta provider, tools e limites resolvidos.
- */
-
-import type { ModelProvider } from "../../core/ai";
-import type { AstService } from "../../core/ast/service";
-import type { HarnessConfig } from "../config/harness-config";
-import type { ToolPolicy } from "../tools/tool-policy";
-import type { ToolRegistry } from "../tools/tool-registry";
-import type { AgentContext } from "./agent-context";
-import type { AgentReporter } from "./agent-reporter";
-import { ReviewAgent } from "./review-agent";
-
-/** Dependências compartilhadas por todos os agentes. */
-export type AgentFactoryDeps = {
-	provider: ModelProvider;
-	registry: ToolRegistry;
-	policy?: ToolPolicy;
-	reporter: AgentReporter;
-	config: HarnessConfig;
-	ast: AstService;
-	readFile?: (path: string) => string | null;
-};
-
-/** Cria `ReviewAgent`s a partir do contexto de cada watchdog. */
-export class AgentFactory {
-	constructor(private readonly deps: AgentFactoryDeps) {}
-
-	/** Instancia um agente para o contexto. */
-	create(context: AgentContext): ReviewAgent {
-		const { config } = this.deps;
-		return new ReviewAgent({
-			context,
-			provider: this.deps.provider,
-			registry: this.deps.registry,
-			policy: this.deps.policy,
-			reporter: this.deps.reporter,
-			maxOutputTokens: config.maxOutputTokensFor(context.watchdog.id),
-			temperature: config.temperature,
-			providerOptions: config.providerOptions,
-			timeoutMs: config.timeoutMs,
-			ast: this.deps.ast,
-			readFile: this.deps.readFile,
-		});
-	}
-}

package/src/harness/agent/agent-reporter.ts

@@ -1,34 +0,0 @@
-/**
- * Reporter de progresso de um agente.
- *
- * O journal é sempre coletado (`harness-transcript.json`); o console é opcional.
- */
-
-import type { LoggerLike } from "../../core/logging";
-import { ReviewJournal } from "../investigation/review-journal";
-
-/** Interface de progresso. */
-export interface AgentReporter {
-	readonly journal: ReviewJournal;
-	progress(message: string): void;
-}
-
-/** Reporter silencioso (testes). */
-export class SilentReporter implements AgentReporter {
-	readonly journal = new ReviewJournal();
-
-	progress(): void {
-		// intencionalmente silencioso
-	}
-}
-
-/** Reporter apoiado no logger único do CLI. */
-export class LoggerReporter implements AgentReporter {
-	readonly journal = new ReviewJournal();
-
-	constructor(private readonly logger: LoggerLike) {}
-
-	progress(message: string): void {
-		this.logger.progress(message);
-	}
-}

package/src/harness/agent/agent-result.ts

@@ -1,16 +0,0 @@
-/**
- * Resultado de um agente (watchdog).
- */
-
-import type { AiUsage } from "../../core/ai";
-import type { WatchdogReport } from "../../core/report-builder";
-
-/** Resultado da execução de um watchdog. */
-export type AgentResult = {
-	watchdogId: string;
-	status: "done" | "skipped" | "failed";
-	report?: WatchdogReport;
-	usage: AiUsage;
-	error?: string;
-	reason?: string;
-};

package/src/harness/agent/agent-runner.ts

@@ -1,32 +0,0 @@
-/**
- * Executor de um agente — retry curto para falhas transitórias.
- *
- * 429/5xx/timeout são tentados uma vez mais; 4xx não. O resultado é sempre
- * estruturado (`failed` com motivo), nunca uma exceção solta.
- */
-
-import type { AgentContext } from "./agent-context";
-import type { AgentFactory } from "./agent-factory";
-import type { AgentResult } from "./agent-result";
-import type { ReviewAgentOutcome } from "./review-agent";
-
-/** Executor com retry. */
-export class AgentRunner {
-	constructor(private readonly factory: AgentFactory) {}
-
-	/** Executa um agente (com uma retentativa em falha transitória). */
-	async run(context: AgentContext): Promise<ReviewAgentOutcome> {
-		const first = await this.factory.create(context).run();
-		if (first.status !== "failed" || !isTransient(first.error)) return first;
-		const second = await this.factory.create(context).run();
-		return second;
-	}
-}
-
-/** Erro transitório (rate limit, 5xx, timeout). */
-function isTransient(message: string | undefined): boolean {
-	if (!message) return false;
-	return /429|5\d\d|timeout|temporar|ECONNRESET|ETIMEDOUT|abort/i.test(message);
-}
-
-export type { AgentResult };

package/src/harness/agent/agent-scheduler.ts

@@ -1,37 +0,0 @@
-/**
- * Scheduler de agentes — concorrência limitada (default 2).
- */
-
-import type { AgentContext } from "./agent-context";
-import type { AgentReporter } from "./agent-reporter";
-import type { AgentRunner } from "./agent-runner";
-import type { ReviewAgentOutcome } from "./review-agent";
-
-/** Executa agentes com concorrência limitada. */
-export class AgentScheduler {
-	constructor(
-		private readonly runner: AgentRunner,
-		private readonly concurrency: number,
-		private readonly reporter?: AgentReporter,
-	) {}
-
-	/** Executa todos os contextos e devolve os resultados na ordem original. */
-	async run(contexts: readonly AgentContext[]): Promise<ReviewAgentOutcome[]> {
-		const results = new Array<ReviewAgentOutcome>(contexts.length);
-		let cursor = 0;
-		const workers = Math.max(1, Math.min(this.concurrency, contexts.length));
-
-		const worker = async (): Promise<void> => {
-			while (cursor < contexts.length) {
-				const index = cursor++;
-				const context = contexts[index];
-				if (!context) return;
-				this.reporter?.progress(`[${context.watchdog.id}] investigando...`);
-				results[index] = await this.runner.run(context);
-			}
-		};
-
-		await Promise.all(Array.from({ length: workers }, () => worker()));
-		return results;
-	}
-}