@paubox/ui 1.19.0 → 1.19.1

package/index.esm.js

@@ -31063,11 +31063,17 @@ var formatDate = function(iso) {
     }
     return null;
 };
+// Stable empty-array reference for the `localCandidates` default. Using
+// `localCandidates = []` would allocate a fresh array on every render,
+// which churns the local-autocomplete effect's dep array and (combined
+// with non-memoized callbacks from the parent) drove an infinite render
+// loop on pages that don't pass `localCandidates`.
+var EMPTY_CANDIDATES = [];
 // ─── Component ──────────────────────────────────────────────────────────────
 var SearchOmnibox = function(param) {
     var bar = param.bar, _param_placeholder = param.placeholder, placeholder = _param_placeholder === void 0 ? 'Search' : _param_placeholder, _param_pbSearchBaseUrl = param.pbSearchBaseUrl, pbSearchBaseUrl = _param_pbSearchBaseUrl === void 0 ? '' : _param_pbSearchBaseUrl, _param_getAuthToken = param.getAuthToken, getAuthToken = _param_getAuthToken === void 0 ? function() {
         return '';
-    } : _param_getAuthToken, _param_mode = param.mode, mode = _param_mode === void 0 ? 'remote' : _param_mode, _param_withHistory = param.withHistory, withHistory = _param_withHistory === void 0 ? true : _param_withHistory, onResultClick = param.onResultClick, onSubmitFullSearch = param.onSubmitFullSearch, _param_localCandidates = param.localCandidates, localCandidates = _param_localCandidates === void 0 ? [] : _param_localCandidates, onLocalQueryChange = param.onLocalQueryChange, _param_testId = param.testId, testId = _param_testId === void 0 ? 'search-omnibox' : _param_testId, _param_initialQuery = param.initialQuery, initialQuery = _param_initialQuery === void 0 ? '' : _param_initialQuery;
+    } : _param_getAuthToken, _param_mode = param.mode, mode = _param_mode === void 0 ? 'remote' : _param_mode, _param_withHistory = param.withHistory, withHistory = _param_withHistory === void 0 ? true : _param_withHistory, onResultClick = param.onResultClick, onSubmitFullSearch = param.onSubmitFullSearch, _param_localCandidates = param.localCandidates, localCandidates = _param_localCandidates === void 0 ? EMPTY_CANDIDATES : _param_localCandidates, onLocalQueryChange = param.onLocalQueryChange, _param_testId = param.testId, testId = _param_testId === void 0 ? 'search-omnibox' : _param_testId, _param_initialQuery = param.initialQuery, initialQuery = _param_initialQuery === void 0 ? '' : _param_initialQuery;
     var _useState = _sliced_to_array$4(useState(initialQuery), 2), query = _useState[0], setQuery = _useState[1];
     var _useState1 = _sliced_to_array$4(useState(initialQuery), 2), debouncedQuery = _useState1[0], setDebouncedQuery = _useState1[1];
     var _useState2 = _sliced_to_array$4(useState(false), 2), focused = _useState2[0], setFocused = _useState2[1];
@@ -31273,32 +31279,63 @@ var SearchOmnibox = function(param) {
     // so synchronous notifications from clear / Enter / selectLocal aren't
     // echoed ~200ms later by the debounced local-autocomplete effect.
     var lastLocalNotifyRef = useRef(undefined);
+    // Hold the parent callbacks in refs so `notifyParent` is stable across
+    // renders. Otherwise any caller passing inline arrow functions for
+    // `onSubmitFullSearch` / `onLocalQueryChange` (the common case) would
+    // re-allocate `notifyParent` every render, triggering the local-
+    // autocomplete effect on every render, which in turn calls
+    // `setLocalMatches([])` — a new empty-array reference every time — and
+    // re-renders forever. Refs decouple the parent's reference identity
+    // from the effect's dep array.
+    var onSubmitFullSearchRef = useRef(onSubmitFullSearch);
+    var onLocalQueryChangeRef = useRef(onLocalQueryChange);
+    useEffect(function() {
+        onSubmitFullSearchRef.current = onSubmitFullSearch;
+    }, [
+        onSubmitFullSearch
+    ]);
+    useEffect(function() {
+        onLocalQueryChangeRef.current = onLocalQueryChange;
+    }, [
+        onLocalQueryChange
+    ]);
     // Route parent notifications to the mode-appropriate callback. In local
     // mode we dedupe so non-idempotent consumers don't see the same query
     // twice (once synchronously, once via debounce).
     var notifyParent = useCallback(function(q) {
         if (mode === 'local') {
+            var _onLocalQueryChangeRef_current;
             if (lastLocalNotifyRef.current === q) return;
             lastLocalNotifyRef.current = q;
-            onLocalQueryChange === null || onLocalQueryChange === void 0 ? void 0 : onLocalQueryChange(q);
+            (_onLocalQueryChangeRef_current = onLocalQueryChangeRef.current) === null || _onLocalQueryChangeRef_current === void 0 ? void 0 : _onLocalQueryChangeRef_current.call(onLocalQueryChangeRef, q);
         } else {
-            onSubmitFullSearch === null || onSubmitFullSearch === void 0 ? void 0 : onSubmitFullSearch(q);
+            var _onSubmitFullSearchRef_current;
+            (_onSubmitFullSearchRef_current = onSubmitFullSearchRef.current) === null || _onSubmitFullSearchRef_current === void 0 ? void 0 : _onSubmitFullSearchRef_current.call(onSubmitFullSearchRef, q);
         }
     }, [
-        mode,
-        onLocalQueryChange,
-        onSubmitFullSearch
+        mode
     ]);
-    // Local autocomplete: filter candidates client-side
+    // Local autocomplete: filter candidates client-side.
+    // The `setLocalMatches` calls are guarded against no-op writes — calling
+    // setState with a fresh `[]` literal every render is enough to cause a
+    // re-render even when the previous state was also `[]`, because React
+    // bails out only on Object.is equality.
     useEffect(function() {
         if (mode !== 'local') return;
         var q = debouncedQuery.trim().toLowerCase();
         if (!q) {
-            setLocalMatches([]);
+            setLocalMatches(function(prev) {
+                return prev.length === 0 ? prev : [];
+            });
         } else {
-            setLocalMatches(localCandidates.filter(function(c) {
+            var next = localCandidates.filter(function(c) {
                 return c.toLowerCase().includes(q);
-            }).slice(0, 5));
+            }).slice(0, 5);
+            setLocalMatches(function(prev) {
+                return prev.length === next.length && prev.every(function(v, i) {
+                    return v === next[i];
+                }) ? prev : next;
+            });
         }
         notifyParent(debouncedQuery);
     }, [

package/package.json

@@ -2,7 +2,7 @@
   "name": "@paubox/ui",
   "author": "Paubox, Inc.",
   "description": "Paubox Component Library",
-  "version": "1.19.0",
+  "version": "1.19.1",
   "type": "module",
   "private": false,
   "publishConfig": {