@patternfly/react-core 6.0.0-alpha.8 → 6.0.0-alpha.81

package/src/components/Breadcrumb/examples/BreadcrumbDropdown.tsx

@@ -12,7 +12,6 @@ import {
   MenuToggleElement
 } from '@patternfly/react-core';
 import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
-import CaretDownIcon from '@patternfly/react-icons/dist/esm/icons/caret-down-icon';
 
 const dropdownItems = [
   <DropdownItem
@@ -66,14 +65,17 @@ export const BreadcrumbDropdown: React.FunctionComponent = () => {
           onSelect={onSelect}
           onOpenChange={(isOpen: boolean) => setIsOpen(isOpen)}
           toggle={(toggleRef: React.Ref<MenuToggleElement>) => (
-            <MenuToggle ref={toggleRef} onClick={onToggle} isExpanded={isOpen} variant="plain">
-              <Badge isRead screenReaderText="additional items">
-                {dropdownItems.length}{' '}
-                <span>
-                  <CaretDownIcon />
-                </span>
-              </Badge>
-            </MenuToggle>
+            <MenuToggle
+              badge={
+                <Badge isRead screenReaderText="additional items">
+                  {dropdownItems.length}
+                </Badge>
+              }
+              ref={toggleRef}
+              onClick={onToggle}
+              isExpanded={isOpen}
+              variant="plainText"
+            />
           )}
           isOpen={isOpen}
         >

package/src/components/Button/Button.tsx

@@ -13,7 +13,8 @@ export enum ButtonVariant {
   warning = 'warning',
   link = 'link',
   plain = 'plain',
-  control = 'control'
+  control = 'control',
+  stateful = 'stateful'
 }
 
 export enum ButtonType {
@@ -28,6 +29,12 @@ export enum ButtonSize {
   lg = 'lg'
 }
 
+export enum ButtonState {
+  read = 'read',
+  unread = 'unread',
+  attention = 'attention'
+}
+
 export interface BadgeCountObject {
   /**  Adds styling to the badge to indicate it has been read */
   isRead?: boolean;
@@ -44,8 +51,8 @@ export interface ButtonProps extends Omit<React.HTMLProps<HTMLButtonElement>, 'r
   className?: string;
   /** Sets the base component to render. defaults to button */
   component?: React.ElementType<any> | React.ComponentType<any>;
-  /** Adds active styling to button. */
-  isActive?: boolean;
+  /** Adds clicked styling to button. */
+  isClicked?: boolean;
   /** Adds block styling to button */
   isBlock?: boolean;
   /** Adds disabled styling and disables the button using the disabled html attribute */
@@ -69,7 +76,11 @@ export interface ButtonProps extends Omit<React.HTMLProps<HTMLButtonElement>, 'r
   /** Sets button type */
   type?: 'button' | 'submit' | 'reset';
   /** Adds button variant styles */
-  variant?: 'primary' | 'secondary' | 'tertiary' | 'danger' | 'warning' | 'link' | 'plain' | 'control';
+  variant?: 'primary' | 'secondary' | 'tertiary' | 'danger' | 'warning' | 'link' | 'plain' | 'control' | 'stateful';
+  /** Sets state of the stateful button variant. Default is "unread" */
+  state?: 'read' | 'unread' | 'attention';
+  /** Applies no padding on a plain button variant. Use when plain button is placed inline with text */
+  hasNoPadding?: boolean;
   /** Sets position of the icon. Note: "left" and "right" are deprecated. Use "start" and "end" instead */
   iconPosition?: 'start' | 'end' | 'left' | 'right';
   /** Adds accessible text to the button. */
@@ -94,9 +105,7 @@ const ButtonBase: React.FunctionComponent<ButtonProps> = ({
   children = null,
   className = '',
   component = 'button',
-  // TODO: Update  eslint ignore when issue #9907 is resolved
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  isActive = false,
+  isClicked = false,
   isBlock = false,
   isDisabled = false,
   isAriaDisabled = false,
@@ -110,9 +119,12 @@ const ButtonBase: React.FunctionComponent<ButtonProps> = ({
   isInline = false,
   type = ButtonType.button,
   variant = ButtonVariant.primary,
+  state = ButtonState.unread,
+  hasNoPadding = false,
   iconPosition = 'start',
   'aria-label': ariaLabel = null,
   icon = null,
+  role,
   ouiaId,
   ouiaSafe = true,
   tabIndex = null,
@@ -149,20 +161,21 @@ const ButtonBase: React.FunctionComponent<ButtonProps> = ({
     <Component
       {...props}
       {...(isAriaDisabled ? preventedEvents : null)}
-      aria-disabled={isDisabled || isAriaDisabled}
+      aria-disabled={isAriaDisabled || (!isButtonElement && isDisabled)}
       aria-label={ariaLabel}
       className={css(
         styles.button,
         styles.modifiers[variant],
         isBlock && styles.modifiers.block,
-        isDisabled && styles.modifiers.disabled,
+        isDisabled && !isButtonElement && styles.modifiers.disabled,
         isAriaDisabled && styles.modifiers.ariaDisabled,
-        // TODO: Update when issue #9907 is resolved
-        // isActive && styles.modifiers.active,
+        isClicked && styles.modifiers.clicked,
         isInline && variant === ButtonVariant.link && styles.modifiers.inline,
         isDanger && (variant === ButtonVariant.secondary || variant === ButtonVariant.link) && styles.modifiers.danger,
         isLoading !== null && variant !== ButtonVariant.plain && styles.modifiers.progress,
         isLoading && styles.modifiers.inProgress,
+        hasNoPadding && variant === ButtonVariant.plain && styles.modifiers.noPadding,
+        variant === ButtonVariant.stateful && styles.modifiers[state],
         size === ButtonSize.sm && styles.modifiers.small,
         size === ButtonSize.lg && styles.modifiers.displayLg,
         className
@@ -170,7 +183,7 @@ const ButtonBase: React.FunctionComponent<ButtonProps> = ({
       disabled={isButtonElement ? isDisabled : null}
       tabIndex={tabIndex !== null ? tabIndex : getDefaultTabIdx()}
       type={isButtonElement || isInlineSpan ? type : null}
-      role={isInlineSpan ? 'button' : null}
+      role={isInlineSpan ? 'button' : role}
       ref={innerRef}
       {...ouiaProps}
     >
@@ -185,17 +198,18 @@ const ButtonBase: React.FunctionComponent<ButtonProps> = ({
           />
         </span>
       )}
-      {variant === ButtonVariant.plain && children === null && icon ? icon : null}
-      {variant !== ButtonVariant.plain && icon && (iconPosition === 'start' || iconPosition === 'left') && (
+      {icon && (iconPosition === 'start' || iconPosition === 'left') && (
         <span className={css(styles.buttonIcon, styles.modifiers.start)}>{icon}</span>
       )}
-      {children}
-      {variant !== ButtonVariant.plain && icon && (iconPosition === 'end' || iconPosition === 'right') && (
+      {children && <span className={css('pf-v6-c-button__text')}>{children}</span>}
+      {icon && (iconPosition === 'end' || iconPosition === 'right') && (
         <span className={css(styles.buttonIcon, styles.modifiers.end)}>{icon}</span>
       )}
       {countOptions && (
         <span className={css(styles.buttonCount, countOptions.className)}>
-          <Badge isRead={countOptions.isRead}>{countOptions.count}</Badge>
+          <Badge isRead={countOptions.isRead} isDisabled={isDisabled}>
+            {countOptions.count}
+          </Badge>
         </span>
       )}
     </Component>

package/src/components/Button/__tests__/Button.test.tsx

@@ -2,7 +2,7 @@ import React from 'react';
 
 import { render, screen } from '@testing-library/react';
 
-import { Button, ButtonVariant } from '../Button';
+import { Button, ButtonState, ButtonVariant } from '../Button';
 
 Object.values(ButtonVariant).forEach((variant) => {
   if (variant !== 'primary') {
@@ -28,14 +28,14 @@ test('Renders without children', () => {
   expect(screen.getByTestId('container').firstChild).toBeVisible();
 });
 
-test('Renders with class pf-v5-c-button by default', () => {
+test('Renders with class pf-v6-c-button by default', () => {
   render(<Button>Button</Button>);
-  expect(screen.getByRole('button')).toHaveClass('pf-v5-c-button');
+  expect(screen.getByRole('button')).toHaveClass('pf-v6-c-button');
 });
 
 test('Renders with class pf-m-primary by default', () => {
   render(<Button>Button</Button>);
-  expect(screen.getByText('Button')).toHaveClass('pf-m-primary');
+  expect(screen.getByText('Button').parentElement).toHaveClass('pf-m-primary');
 });
 
 test('Renders with custom class', () => {
@@ -55,15 +55,28 @@ test('Renders with class pf-m-block when isBlock = true', () => {
   expect(screen.getByRole('button')).toHaveClass('pf-m-block');
 });
 
-// TODO:  Reenable or remove with issue #9907
-xtest('Renders with class pf-m-active when isActive = true', () => {
-  render(<Button isActive>Active Button</Button>);
-  expect(screen.getByRole('button')).toHaveClass('pf-m-active');
+test('Renders with class pf-m-clicked when isClicked = true', () => {
+  render(<Button isClicked>Clicked Button</Button>);
+  expect(screen.getByRole('button')).toHaveClass('pf-m-clicked');
 });
 
-test('Renders with class pf-m-disabled when isDisabled = true', () => {
+test('Does not render with class pf-m-disabled by default when isDisabled = true', () => {
   render(<Button isDisabled>Disabled Button</Button>);
-  expect(screen.getByRole('button')).toHaveClass('pf-m-disabled');
+  expect(screen.getByRole('button')).not.toHaveClass('pf-m-disabled');
+});
+
+test('aria-disabled is set to false when isDisabled = true', () => {
+  render(<Button isDisabled>Disabled Button</Button>);
+  expect(screen.getByRole('button')).toHaveAttribute('aria-disabled', 'false');
+});
+
+test('Renders with class pf-m-disabled when isDisabled = true and component is not a button', () => {
+  render(
+    <Button isDisabled component="a">
+      Disabled Anchor Button
+    </Button>
+  );
+  expect(screen.getByText('Disabled Anchor Button').parentElement).toHaveClass('pf-m-disabled');
 });
 
 test('Renders with class pf-m-aria-disabled when isAriaDisabled = true', () => {
@@ -80,6 +93,22 @@ test('Does not disable button when isDisabled = true and component = a', () => {
   expect(screen.getByText('Disabled yet focusable button')).not.toHaveProperty('disabled');
 });
 
+test('Renders with class pf-m-unread by default when variant = stateful', () => {
+  render(<Button variant="stateful">Stateful Button</Button>);
+  expect(screen.getByRole('button')).toHaveClass('pf-m-stateful', 'pf-m-unread');
+});
+
+Object.values(ButtonState).forEach((state) => {
+  test(`Renders with class pf-m-${state} when state = ${state} and variant = stateful`, () => {
+    render(
+      <Button variant="stateful" state={state}>
+        Stateful Button - {state}
+      </Button>
+    );
+    expect(screen.getByRole('button')).toHaveClass('pf-m-stateful', `pf-m-${state}`);
+  });
+});
+
 test('Renders with class pf-m-danger when isDanger = true and variant = secondary', () => {
   render(
     <Button variant="secondary" isDanger>
@@ -177,14 +206,14 @@ test('Renders custom icon with class pf-m-in-progress when isLoading = true and
   );
 
   expect(screen.getByText('ICON')).toBeVisible();
-  expect(screen.getByText('ICON').parentElement).toHaveClass('pf-m-in-progress');
+  expect(screen.getByText('ICON').parentElement?.parentElement).toHaveClass('pf-m-in-progress');
 });
 
 test('Renders as custom component when component is passed', () => {
   const component = 'a';
   render(<Button component={component}>anchor button</Button>);
 
-  expect(screen.getByText('anchor button').tagName).toBe('A');
+  expect(screen.getByText('anchor button').parentElement?.tagName).toBe('A');
 });
 
 test('aria-disabled is set to true and tabIndex to -1 if component is not a button and is disabled', () => {
@@ -193,7 +222,9 @@ test('aria-disabled is set to true and tabIndex to -1 if component is not a butt
       Disabled Anchor Button
     </Button>
   );
-  expect(screen.getByText('Disabled Anchor Button')).toHaveAttribute('tabindex', '-1');
+  const anchor = screen.getByText('Disabled Anchor Button').parentElement;
+  expect(anchor).toHaveAttribute('tabindex', '-1');
+  expect(anchor).toHaveAttribute('aria-disabled', 'true');
 });
 
 test('setting tab index through props', () => {

package/src/components/Button/__tests__/__snapshots__/Button.test.tsx.snap

@@ -5,13 +5,17 @@ exports[`Renders basic button 1`] = `
   <button
     aria-disabled="false"
     aria-label="basic button"
-    class="pf-v5-c-button pf-m-primary"
-    data-ouia-component-id="OUIA-Generated-Button-primary-26"
-    data-ouia-component-type="PF5/Button"
+    class="pf-v6-c-button pf-m-primary"
+    data-ouia-component-id="OUIA-Generated-Button-primary-30"
+    data-ouia-component-type="PF6/Button"
     data-ouia-safe="true"
     type="button"
   >
-    Basic Button
+    <span
+      class="pf-v6-c-button__text"
+    >
+      Basic Button
+    </span>
   </button>
 </DocumentFragment>
 `;

package/src/components/Button/examples/Button.md

@@ -12,6 +12,8 @@ import ExternalLinkSquareAltIcon from '@patternfly/react-icons/dist/esm/icons/ex
 import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon';
 import ArrowRightIcon from '@patternfly/react-icons/dist/esm/icons/arrow-right-icon';
 import UploadIcon from '@patternfly/react-icons/dist/esm/icons/upload-icon';
+import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
+import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
 import { Link } from '@reach/router';
 
 ## Examples
@@ -33,6 +35,7 @@ PatternFly supports several button styling variants to be used in different scen
 | Link | Links are labeled, but have no background or border. Use for actions that require less emphasis, actions that navigate users to another page within the same window, and/or actions that navigate to external pages in a new window. Links may be placed inline with text using the `isInline` property.|
 | Plain | Plain buttons have no styling and are intended to be labeled with icons. |
 | Control | Control buttons can be labeled with text or icons. Primarily intended to be paired with other controls in an [input group](/components/input-group). |
+| Stateful | Stateful buttons are ideal for displaying the state of notifications. They have 3 states: `read`, `unread` and `attention`.
 
 ### Disabled buttons
 
@@ -105,5 +108,19 @@ Unlike normal disabled buttons, aria-disabled buttons can support tooltips. Furt
 
 Buttons can display a `count` in the form of a badge to indicate some value or number by passing in the `countOptions` prop as a `BadgeCountObject` object. The `BadgeCountObject` object will handle `count`, `isRead`, and `className` props for the badge count.
 
-```ts file="./ButtonWithCount.tsx" isBeta
+```ts file="./ButtonWithCount.tsx"
+```
+
+### Plain with no padding
+
+To display a plain/icon button inline with text, use `noPadding` prop in addition to `variant="plain"`.
+
+```ts file="./ButtonPlainHasNoPadding.tsx"
+```
+
+### Stateful
+
+Stateful buttons are ideal for displaying the state of notifications. Use `variant="stateful"` alongside with the `state` property, which can have these 3 values: `read`, `unread` (used as default) and `attention` (which means unread and requires attention).
+
+```ts file="./ButtonStateful.tsx"
 ```

package/src/components/Button/examples/ButtonAriaDisabled.tsx

@@ -1,52 +1,28 @@
 import React from 'react';
-import { Button, Tooltip } from '@patternfly/react-core';
-import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon';
+import { Button, Flex, Tooltip } from '@patternfly/react-core';
 import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
 
 export const ButtonAriaDisabled: React.FunctionComponent = () => (
-  <React.Fragment>
-    <Button isAriaDisabled>Primary aria disabled</Button>
-    <Button isAriaDisabled>Secondary aria disabled</Button>{' '}
-    <Button variant="secondary" isDanger isAriaDisabled>
-      Danger secondary aria disabled
-    </Button>{' '}
-    <Button isAriaDisabled variant="tertiary">
-      Tertiary aria disabled
-    </Button>{' '}
-    <Button isAriaDisabled variant="danger">
-      Danger disabled
-    </Button>{' '}
-    <Button isAriaDisabled variant="warning">
-      Warning disabled
-    </Button>
-    <br />
-    <br />
-    <Button isAriaDisabled variant="link" icon={<PlusCircleIcon />}>
-      Link aria disabled
-    </Button>{' '}
-    <Button isAriaDisabled variant="link" isInline>
-      Inline link aria disabled
-    </Button>{' '}
-    <Button variant="link" isDanger isAriaDisabled>
-      Danger link disabled
-    </Button>{' '}
-    <Button isAriaDisabled variant="plain" aria-label="Action">
-      <TimesIcon />
-    </Button>{' '}
-    <Button isAriaDisabled variant="control">
-      Control aria disabled
-    </Button>
-    <br />
-    <br />
-    <Tooltip content="Aria-disabled buttons are like disabled buttons, but focusable. Allows for tooltip support.">
-      <Button isAriaDisabled variant="secondary">
-        Secondary button to core docs
+  <>
+    <Flex columnGap={{ default: 'columnGapSm' }}>
+      <Button isAriaDisabled>Primary aria disabled</Button>
+      <Button isAriaDisabled variant="link" icon={<PlusCircleIcon />}>
+        Link aria disabled
       </Button>
-    </Tooltip>{' '}
-    <Tooltip content="Aria-disabled link as button with tooltip">
-      <Button component="a" isAriaDisabled href="https://pf4.patternfly.org/" target="_blank" variant="tertiary">
-        Tertiary link as button to core docs
+      <Button isAriaDisabled variant="link" isInline>
+        Inline link aria disabled
       </Button>
-    </Tooltip>
-  </React.Fragment>
+    </Flex>
+    <br />
+    <Flex columnGap={{ default: 'columnGapSm' }}>
+      <Tooltip content="Aria-disabled buttons are like disabled buttons, but focusable. Allows for tooltip support.">
+        <Button isAriaDisabled>Primary button with tooltip</Button>
+      </Tooltip>
+      <Tooltip content="Aria-disabled link as button with tooltip">
+        <Button component="a" isAriaDisabled href="https://www.patternfly.org/" target="_blank" variant="secondary">
+          Secondary link as button to PatternFly home
+        </Button>
+      </Tooltip>
+    </Flex>
+  </>
 );

package/src/components/Button/examples/ButtonCallToAction.tsx

@@ -1,22 +1,20 @@
 import React from 'react';
-import { Button } from '@patternfly/react-core';
+import { Button, Flex } from '@patternfly/react-core';
 import ArrowRightIcon from '@patternfly/react-icons/dist/esm/icons/arrow-right-icon';
 
 export const ButtonCallToAction: React.FunctionComponent = () => (
-  <React.Fragment>
+  <Flex columnGap={{ default: 'columnGapSm' }}>
     <Button variant="primary" size="lg">
       Call to action
-    </Button>{' '}
+    </Button>
     <Button variant="secondary" size="lg">
       Call to action
-    </Button>{' '}
+    </Button>
     <Button variant="tertiary" size="lg">
       Call to action
-    </Button>{' '}
-    <Button variant="link" size="lg">
-      Call to action <ArrowRightIcon />
     </Button>
-    <br />
-    <br />
-  </React.Fragment>
+    <Button variant="link" size="lg" icon={<ArrowRightIcon />} iconPosition="end">
+      Call to action
+    </Button>
+  </Flex>
 );

package/src/components/Button/examples/ButtonDisabled.tsx

@@ -1,39 +1,48 @@
 import React from 'react';
-import { Button } from '@patternfly/react-core';
+import { Button, Flex } from '@patternfly/react-core';
 import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon';
 import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
+import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon';
 
 export const ButtonDisabled: React.FunctionComponent = () => (
-  <React.Fragment>
-    <Button isDisabled>Primary disabled</Button> <Button isDisabled>Secondary disabled</Button>{' '}
-    <Button variant="secondary" isDanger isDisabled>
-      Danger secondary disabled
-    </Button>{' '}
-    <Button isDisabled variant="tertiary">
-      Tertiary disabled
-    </Button>{' '}
-    <Button isDisabled variant="danger">
-      Danger disabled
-    </Button>{' '}
-    <Button isDisabled variant="warning">
-      Warning disabled
-    </Button>
+  <>
+    <Flex columnGap={{ default: 'columnGapSm' }}>
+      <Button isDisabled>Primary</Button>
+      <Button variant="secondary" isDisabled>
+        Secondary
+      </Button>
+      <Button variant="secondary" isDanger isDisabled>
+        Danger secondary
+      </Button>
+      <Button isDisabled variant="tertiary">
+        Tertiary
+      </Button>
+      <Button isDisabled variant="danger">
+        Danger
+      </Button>
+      <Button isDisabled variant="warning">
+        Warning
+      </Button>
+    </Flex>
     <br />
+    <Flex columnGap={{ default: 'columnGapSm' }}>
+      <Button isDisabled variant="link" icon={<PlusCircleIcon />}>
+        Link
+      </Button>
+      <Button isDisabled variant="link" isInline>
+        Inline link
+      </Button>
+      <Button variant="link" isDanger isDisabled>
+        Danger link
+      </Button>
+      <Button isDisabled variant="plain" aria-label="Action" icon={<TimesIcon />} />
+    </Flex>
     <br />
-    <Button isDisabled variant="link" icon={<PlusCircleIcon />}>
-      Link disabled
-    </Button>{' '}
-    <Button isDisabled variant="link" isInline>
-      Inline link disabled
-    </Button>{' '}
-    <Button variant="link" isDanger isDisabled>
-      Danger link disabled
-    </Button>{' '}
-    <Button isDisabled variant="plain" aria-label="Action">
-      <TimesIcon />
-    </Button>{' '}
-    <Button isDisabled variant="control">
-      Control disabled
-    </Button>
-  </React.Fragment>
+    <Flex columnGap={{ default: 'columnGapSm' }}>
+      <Button isDisabled variant="control">
+        Control
+      </Button>
+      <Button isDisabled variant="control" aria-label="Copy" icon={<CopyIcon />} />
+    </Flex>
+  </>
 );

package/src/components/Button/examples/ButtonInlineSpanLink.tsx

@@ -1,10 +1,10 @@
 import React from 'react';
-import { Button } from '@patternfly/react-core';
+import { Button, KeyTypes } from '@patternfly/react-core';
 
 const handleKeydown = (event: React.KeyboardEvent<HTMLButtonElement>) => {
   const { key } = event;
-  const isEnterKey: boolean = key === 'Enter';
-  const isEnterOrSpaceKey: boolean = isEnterKey || key === 'Space';
+  const isEnterKey: boolean = key === KeyTypes.Enter;
+  const isEnterOrSpaceKey: boolean = isEnterKey || key === KeyTypes.Space;
 
   if (isEnterOrSpaceKey) {
     event.preventDefault();

package/src/components/Button/examples/ButtonLinks.tsx

@@ -1,19 +1,19 @@
 import React from 'react';
-import { Button } from '@patternfly/react-core';
+import { Button, Flex } from '@patternfly/react-core';
 
 export const ButtonLinks: React.FunctionComponent = () => (
-  <React.Fragment>
-    <Button component="a" href="https://pf4.patternfly.org/" target="_blank" variant="primary">
-      Link to core docs
-    </Button>{' '}
-    <Button component="a" href="https://pf4.patternfly.org/" target="_blank" variant="secondary">
-      Secondary link to core docs
-    </Button>{' '}
-    <Button isDisabled component="a" href="https://pf4.patternfly.org/" target="_blank" variant="tertiary">
-      Tertiary link to core docs
-    </Button>{' '}
-    <Button component="a" href="https://pf4.patternfly.org/contribution/#modifiers" variant="link">
-      Jump to modifiers in contribution guidelines
+  <Flex>
+    <Button component="a" href="https://www.patternfly.org/" target="_blank" variant="primary">
+      Link to PatternFly home
     </Button>
-  </React.Fragment>
+    <Button component="a" href="https://www.patternfly.org/" target="_blank" variant="secondary">
+      Secondary link to PatternFly home
+    </Button>
+    <Button isDisabled component="a" href="https://www.patternfly.org/" target="_blank" variant="tertiary">
+      Tertiary link to PatternFly home
+    </Button>
+    <Button component="a" href="https://www.patternfly.org/" variant="link">
+      Jump to PatternFly home
+    </Button>
+  </Flex>
 );

package/src/components/Button/examples/ButtonPlainHasNoPadding.tsx

@@ -0,0 +1,11 @@
+import React from 'react';
+import { Button } from '@patternfly/react-core';
+import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
+
+export const ButtonPlainHasNoPadding: React.FunctionComponent = () => (
+  <p>
+    This is an example of a button
+    <Button variant="plain" hasNoPadding aria-label="More info" icon={<QuestionCircleIcon />} />
+    which is placed inline with text
+  </p>
+);

package/src/components/Button/examples/ButtonProgress.tsx

@@ -1,5 +1,5 @@
 import React from 'react';
-import { Button } from '@patternfly/react-core';
+import { Button, Flex } from '@patternfly/react-core';
 import UploadIcon from '@patternfly/react-icons/dist/esm/icons/upload-icon';
 
 interface LoadingPropsType {
@@ -36,19 +36,24 @@ export const ButtonProgress: React.FunctionComponent = () => {
   uploadingProps.isLoading = isUploading;
 
   return (
-    <React.Fragment>
-      <Button
-        variant="primary"
-        id="primary-loading-button"
-        onClick={() => setIsPrimaryLoading(!isPrimaryLoading)}
-        {...primaryLoadingProps}
-      >
-        {isPrimaryLoading ? 'Click to stop loading' : 'Click to start loading'}
-      </Button>{' '}
-      <Button variant="secondary" onClick={() => setIsSecondaryLoading(!isSecondaryLoading)} {...secondaryLoadingProps}>
-        {isSecondaryLoading ? 'Click to stop loading' : 'Click to start loading'}
-      </Button>{' '}
-      <br />
+    <>
+      <Flex columnGap={{ default: 'columnGapSm' }}>
+        <Button
+          variant="primary"
+          id="primary-loading-button"
+          onClick={() => setIsPrimaryLoading(!isPrimaryLoading)}
+          {...primaryLoadingProps}
+        >
+          {isPrimaryLoading ? 'Click to stop loading' : 'Click to start loading'}
+        </Button>
+        <Button
+          variant="secondary"
+          onClick={() => setIsSecondaryLoading(!isSecondaryLoading)}
+          {...secondaryLoadingProps}
+        >
+          {isSecondaryLoading ? 'Click to stop loading' : 'Click to start loading'}
+        </Button>
+      </Flex>
       <br />
       <Button
         variant="plain"
@@ -56,12 +61,12 @@ export const ButtonProgress: React.FunctionComponent = () => {
         onClick={() => setIsUploading(!isUploading)}
         icon={<UploadIcon />}
         {...uploadingProps}
-      />{' '}
+      />
       <br />
       <br />
       <Button variant="link" isInline onClick={() => setIsInlineLoading(!isInlineLoading)} {...inlineLoadingProps}>
         {isInlineLoading ? 'Pause loading logs' : 'Resume loading logs'}
-      </Button>{' '}
-    </React.Fragment>
+      </Button>
+    </>
   );
 };