@patternfly/react-core 6.0.0-alpha.4 → 6.0.0-alpha.6

package/src/components/Popover/Popover.tsx

@@ -415,7 +415,7 @@ export const Popover: React.FunctionComponent<PopoverProps> = ({
       ref={popoverRef}
       active={focusTrapActive}
       focusTrapOptions={{
-        returnFocusOnDeactivate: true,
+        returnFocusOnDeactivate: propWithFocusTrap !== false,
         clickOutsideDeactivates: true,
         // FocusTrap's initialFocus can accept false as a value to prevent initial focus.
         // We want to prevent this in case false is ever passed in.

package/src/components/Select/examples/Select.md

@@ -13,72 +13,112 @@ import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
 
 ## Examples
 
-`Select` builds off of the Menu component suite to wrap commonly used properties and functions for a select menu. See the [Menu documentation](/components/menus/menu) for a full list of properties that may be passed through `Select` to further customize the select menu, or the [custom menu examples](/components/menus/custom-menus) for additional examples of fully functional menus.
+Select builds off of the menu component suite to adapt commonly used properties and functions to create a select menu. See the [menu documentation](/components/menus/menu) for a full list of properties that may be used to further customize a select menu. View the [custom menu examples](/components/menus/custom-menus) to see examples of fully functional select menus.
 
-### Single
+### Single select
+To let users select a single item from a list, use a single select menu.
+
+You can add multiple `<SelectOption>` components to build out a list of menu items. For each select option, pass a relevant option label to the `value` property.
+
+To disable the select menu toggle, use the `isDisabled` property. In the following example, select the checkbox to observe this behavior.
 
 ```ts file="./SelectBasic.tsx"
 
 ```
 
-### Option variations
+### Select option variants
+
+The following example showcases different option variants and customizations that are commonly used in a select menu. 
+
+To create these variants, you can pass different properties into a `<SelectOption>` component. 
 
-Showcases different option variants and customizations that are commonly used in a select menu. For a more complete list, see the [Menu documentation](/components/menus/menu).
+This example provides examples of: 
+
+- An option with a description, which is created by using the `description` property.
+- An option with a link, which is created by passing a URL into the `to` property. For external links, use the `isExternalLink` property so that the option is styled with an outbound link icon. 
+- An option with an icon, which is created by using the `icon` property. 
+- An option that is disabled by using the `isDisabled` property. 
 
 ```ts file="./SelectOptionVariations.tsx"
 
 ```
 
-### Grouped single
+### With grouped items
+To group related select options together, use 1 or more `<SelectGroup>` components and title each group using the `label` property.
 
 ```ts file="./SelectGrouped.tsx"
 
 ```
 
-### Checkbox
+### Checkbox select
+To let users select multiple list options via checkbox input, use a checkbox select. 
+
+To create a checkbox select, pass `role="menu"` to the `<Select>`, and `hasCheckbox` into each `<SelectOption>` component. To indicate that an option is selected, use the `isSelected` property.
+
+By default, the menu toggle will display a badge to indicate the number of items that a user has selected.
 
 ```ts file="./SelectCheckbox.tsx"
 
 ```
 
 ### Typeahead
+Typeahead is a select variant that replaces the typical button toggle for opening the select menu with a text input and button toggle combo. As a user enters characters into the text input, the menu options will be filtered to match.
+
+To make a typeahead, pass `variant=typeahead` into the `<MenuToggle>` component and link an `onClick` function to the `<TextInputGroupMain>` component.
 
 ```ts file="./SelectTypeahead.tsx"
 
 ```
 
 ### Typeahead with create option
+If a user enters a value into a typeahead select menu that does not exist, you can allow them to create an option of that value. 
+
+To enable the creation ability, pass a predetermined `value` into a `<SelectOption>` component. You can use the `placeholder` property to change the default text shown in the text input.
+
+The following example outlines the code implementation required to create a working typeahead menu that allows for creation.
 
 ```ts file="./SelectTypeaheadCreatable.tsx"
 
 ```
 
 ### Multiple typeahead with chips
+A multiple typeahead can be used to allow users to select multiple options from a list. Additionally, you can render a chip group to be placed in the select toggle.
+
+When more items than the allowed limit are selected, overflowing items will be hidden under a "more" button. The following example hides items after more than 3 are selected. To show hidden items, select the “more” button. Select "show less" to hide extra items again.
 
 ```ts file="./SelectMultiTypeahead.tsx"
 
 ```
 
 ### Multiple typeahead with create option
+If the text that is entered into a typeahead doesn't match a menu item, users can choose to create a new option that matches the text input. You can also combine this create functionality with a chip group to display created items as chips."
 
 ```ts file="./SelectMultiTypeaheadCreatable.tsx"
 
 ```
 
 ### Multiple typeahead with checkboxes
+By default, a multiple typeahead select allows you to select multiple menu items, placing a checkmark beside selected items. Like basic checkbox select menus, you can add checkboxes to your menu items. This approach may be more accurate and comprehensive for more complex menu scenarios like filtering.
 
 ```ts file="./SelectMultiTypeaheadCheckbox.tsx"
 
 ```
 
-### View more
+### With view more 
+
+To reduce the processing load for long select lists, you can add a "View more" action to load additional items.
+
+The following example shows 3 items before the "View more" link, but you can adjust the number of visible items for your use case.
 
 ```ts file="./SelectViewMore.tsx"
 
 ```
 
-### Footer
+### With a footer
+
+You can add a `<MenuFooter>` component to a select menu to hold additional actions that users can take on menu items, through elements such as link buttons. A footer will be placed beneath a divider at the end of the select menu.
+
 
 ```ts file="./SelectFooter.tsx"
 
-```
+```

package/src/demos/DataList/examples/DataListExpandableControlInToolbar.tsx

@@ -0,0 +1,397 @@
+import React from 'react';
+import {
+  Button,
+  DataList,
+  DataListItem,
+  DataListItemRow,
+  DataListCell,
+  DataListAction,
+  DataListToggle,
+  DataListContent,
+  DataListItemCells,
+  Dropdown,
+  DropdownItem,
+  DropdownList,
+  MenuToggle,
+  MenuToggleElement,
+  Toolbar,
+  ToolbarGroup,
+  ToolbarItem,
+  ToolbarExpandIconWrapper,
+  ToolbarContent,
+  SearchInput,
+  Tooltip,
+  Icon,
+  PageSection,
+  PageSectionVariants,
+  Text,
+  TextContent
+} from '@patternfly/react-core';
+
+import { DashboardWrapper } from '@patternfly/react-core/src/demos/DashboardWrapper';
+
+import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
+import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
+import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
+
+export const DataListExpandableControlInToolbar: React.FunctionComponent = () => {
+  const [expanded, setExpanded] = React.useState(['ex-toggle1', 'ex-toggle3']);
+  const [isOpen1, setIsOpen1] = React.useState(false);
+  const [isOpen2, setIsOpen2] = React.useState(false);
+  const [isOpen3, setIsOpen3] = React.useState(false);
+  const [allExpanded, setAllExpanded] = React.useState(false);
+
+  const onToggleAll = () => {
+    setAllExpanded((prevAllExpanded) => !prevAllExpanded);
+
+    if (!allExpanded) {
+      setExpanded(['ex-toggle1', 'ex-toggle2', 'ex-toggle3']);
+    } else {
+      setExpanded([]);
+    }
+  };
+
+  const onToggle1 = () => {
+    setIsOpen1(!isOpen1);
+  };
+
+  const onToggle2 = () => {
+    setIsOpen2(!isOpen2);
+  };
+
+  const onToggle3 = () => {
+    setIsOpen3(!isOpen3);
+  };
+
+  const onSelect1 = () => {
+    setIsOpen1(false);
+  };
+
+  const onSelect2 = () => {
+    setIsOpen2(false);
+  };
+
+  const onSelect3 = () => {
+    setIsOpen3(false);
+  };
+
+  const renderToolbar = () => (
+    <React.Fragment>
+      <Toolbar>
+        <ToolbarContent>
+          <ToolbarGroup>
+            <ToolbarItem variant="expand-all" isAllExpanded={allExpanded}>
+              <Tooltip
+                position="right"
+                content={
+                  <div>
+                    {allExpanded && 'Collapse all rows'}
+                    {!allExpanded && 'Expand all rows'}
+                  </div>
+                }
+              >
+                <Button
+                  onClick={onToggleAll}
+                  variant="plain"
+                  aria-label={allExpanded ? 'Collapse all rows' : 'Expand all rows'}
+                >
+                  <Icon shouldMirrorRTL>
+                    <ToolbarExpandIconWrapper>
+                      <AngleRightIcon />
+                    </ToolbarExpandIconWrapper>
+                  </Icon>
+                </Button>
+              </Tooltip>
+            </ToolbarItem>
+            <ToolbarItem>
+              <SearchInput aria-label="search input example" />
+            </ToolbarItem>
+            <ToolbarItem>
+              <Button variant="secondary">Action</Button>
+            </ToolbarItem>
+            <ToolbarItem variant="separator" />
+            <ToolbarItem>
+              <Button variant="primary">Action</Button>
+            </ToolbarItem>
+          </ToolbarGroup>
+        </ToolbarContent>
+      </Toolbar>
+    </React.Fragment>
+  );
+
+  const toggle = (id: string) => {
+    const index = expanded.indexOf(id);
+    const newExpanded =
+      index >= 0 ? [...expanded.slice(0, index), ...expanded.slice(index + 1, expanded.length)] : [...expanded, id];
+    setExpanded(newExpanded);
+    if (newExpanded.length === 3) {
+      setAllExpanded(true);
+    } else if (newExpanded.length === 0) {
+      setAllExpanded(false);
+    }
+  };
+
+  return (
+    <React.Fragment>
+      <DashboardWrapper mainContainerId="main-content-datalist-view-default-nav" breadcrumb={null}>
+        <PageSection variant={PageSectionVariants.light}>
+          <TextContent>
+            <Text component="h1">Projects</Text>
+            <Text component="p">This is a demo that showcases PatternFly Data List</Text>
+          </TextContent>
+        </PageSection>
+        <PageSection isFilled>
+          {renderToolbar()}
+
+          <DataList aria-label="Expandable data list example">
+            <DataListItem aria-labelledby="ex-item1" isExpanded={expanded.includes('ex-toggle1')}>
+              <DataListItemRow>
+                <DataListToggle
+                  onClick={() => toggle('ex-toggle1')}
+                  isExpanded={expanded.includes('ex-toggle1')}
+                  id="ex-toggle1"
+                  aria-controls="ex-expand1"
+                />
+                <DataListItemCells
+                  dataListCells={[
+                    <DataListCell isIcon key="icon">
+                      <CodeBranchIcon />
+                    </DataListCell>,
+                    <DataListCell key="primary content">
+                      <div id="ex-item1">Primary content</div>
+                      <span>Lorem ipsum dolor sit amet, consectetur adipiscing elit. </span>
+                      <a href="#">Link</a>
+                    </DataListCell>,
+                    <DataListCell key="secondary content">
+                      <span>Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
+                    </DataListCell>,
+                    <DataListCell key="secondary content 2">
+                      <span>Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
+                    </DataListCell>
+                  ]}
+                />
+                <DataListAction
+                  aria-labelledby="ex-item1 ex-action1"
+                  id="ex-action1"
+                  aria-label="Actions"
+                  isPlainButtonAction
+                >
+                  <Dropdown
+                    isOpen={isOpen1}
+                    onSelect={onSelect1}
+                    popperProps={{ position: 'right' }}
+                    onOpenChange={(isOpen: boolean) => setIsOpen1(isOpen)}
+                    toggle={(toggleRef: React.Ref<MenuToggleElement>) => (
+                      <MenuToggle
+                        ref={toggleRef}
+                        onClick={onToggle1}
+                        isExpanded={isOpen1}
+                        variant="plain"
+                        aria-label="Primary content kebab toggle"
+                      >
+                        <EllipsisVIcon aria-hidden="true" />
+                      </MenuToggle>
+                    )}
+                  >
+                    <DropdownList>
+                      <DropdownItem value={0} key="action1">
+                        Action
+                      </DropdownItem>
+                      <DropdownItem
+                        value={1}
+                        key="link1"
+                        to="#default-link2"
+                        // Prevent the default onClick functionality for example purposes
+                        onClick={(ev: React.MouseEvent) => ev.preventDefault()}
+                      >
+                        Link
+                      </DropdownItem>
+                      <DropdownItem value={2} isDisabled key="disabled action1">
+                        Disabled Action
+                      </DropdownItem>
+                      <DropdownItem value={3} isDisabled key="disabled link1" to="#default-link4">
+                        Disabled Link
+                      </DropdownItem>
+                    </DropdownList>
+                  </Dropdown>
+                </DataListAction>
+              </DataListItemRow>
+              <DataListContent
+                aria-label="Primary Content Details"
+                id="ex-expand1"
+                isHidden={!expanded.includes('ex-toggle1')}
+              >
+                <p>
+                  Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore
+                  et dolore magna aliqua.
+                </p>
+              </DataListContent>
+            </DataListItem>
+            <DataListItem aria-labelledby="ex-item2" isExpanded={expanded.includes('ex-toggle2')}>
+              <DataListItemRow>
+                <DataListToggle
+                  onClick={() => toggle('ex-toggle2')}
+                  isExpanded={expanded.includes('ex-toggle2')}
+                  id="ex-toggle2"
+                  aria-controls="ex-expand2"
+                />
+                <DataListItemCells
+                  dataListCells={[
+                    <DataListCell isIcon key="icon">
+                      <CodeBranchIcon />
+                    </DataListCell>,
+                    <DataListCell key="secondary content">
+                      <div id="ex-item2">Secondary content</div>
+                      <span>Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
+                    </DataListCell>,
+                    <DataListCell key="secondary content 2">
+                      <span>Lorem ipsum dolor sit amet.</span>
+                    </DataListCell>,
+                    <DataListCell key="secondary content3">
+                      <span>Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
+                    </DataListCell>
+                  ]}
+                />
+                <DataListAction
+                  aria-labelledby="ex-item2 ex-action2"
+                  id="ex-action2"
+                  aria-label="Actions"
+                  isPlainButtonAction
+                >
+                  <Dropdown
+                    isOpen={isOpen2}
+                    onSelect={onSelect2}
+                    popperProps={{ position: 'right' }}
+                    onOpenChange={(isOpen: boolean) => setIsOpen2(isOpen)}
+                    toggle={(toggleRef: React.Ref<MenuToggleElement>) => (
+                      <MenuToggle
+                        ref={toggleRef}
+                        onClick={onToggle2}
+                        isExpanded={isOpen2}
+                        variant="plain"
+                        aria-label="Secondary content kebab toggle"
+                      >
+                        <EllipsisVIcon aria-hidden="true" />
+                      </MenuToggle>
+                    )}
+                  >
+                    <DropdownList>
+                      <DropdownItem value={0} key="action2">
+                        Action
+                      </DropdownItem>
+                      <DropdownItem
+                        value={1}
+                        key="link2"
+                        to="#default-link2"
+                        // Prevent the default onClick functionality for example purposes
+                        onClick={(ev: React.MouseEvent) => ev.preventDefault()}
+                      >
+                        Link
+                      </DropdownItem>
+                      <DropdownItem value={2} isDisabled key="disabled action2">
+                        Disabled Action
+                      </DropdownItem>
+                      <DropdownItem value={3} isDisabled key="disabled link2" to="#default-link4">
+                        Disabled Link
+                      </DropdownItem>
+                    </DropdownList>
+                  </Dropdown>
+                </DataListAction>
+              </DataListItemRow>
+              <DataListContent
+                aria-label="Primary Content Details"
+                id="ex-expand2"
+                isHidden={!expanded.includes('ex-toggle2')}
+              >
+                <p>
+                  Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore
+                  et dolore magna aliqua.
+                </p>
+              </DataListContent>
+            </DataListItem>
+            <DataListItem aria-labelledby="ex-item3" isExpanded={expanded.includes('ex-toggle3')}>
+              <DataListItemRow>
+                <DataListToggle
+                  onClick={() => toggle('ex-toggle3')}
+                  isExpanded={expanded.includes('ex-toggle3')}
+                  id="ex-toggle3"
+                  aria-controls="ex-expand3"
+                />
+                <DataListItemCells
+                  dataListCells={[
+                    <DataListCell isIcon key="icon">
+                      <CodeBranchIcon />
+                    </DataListCell>,
+                    <DataListCell key="tertiary content">
+                      <div id="ex-item3">Tertiary content</div>
+                      <span>Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
+                    </DataListCell>,
+                    <DataListCell key="secondary content">
+                      <span>Lorem ipsum dolor sit amet.</span>
+                    </DataListCell>,
+                    <DataListCell key="secondary content 2">
+                      <span>Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
+                    </DataListCell>
+                  ]}
+                />
+                <DataListAction
+                  aria-labelledby="ex-item3 ex-action3"
+                  id="ex-action3"
+                  aria-label="Actions"
+                  isPlainButtonAction
+                >
+                  <Dropdown
+                    isOpen={isOpen3}
+                    onSelect={onSelect3}
+                    popperProps={{ position: 'right' }}
+                    onOpenChange={(isOpen: boolean) => setIsOpen3(isOpen)}
+                    toggle={(toggleRef: React.Ref<MenuToggleElement>) => (
+                      <MenuToggle
+                        ref={toggleRef}
+                        onClick={onToggle3}
+                        isExpanded={isOpen3}
+                        variant="plain"
+                        aria-label="Tertiary content kebab toggle"
+                      >
+                        <EllipsisVIcon aria-hidden="true" />
+                      </MenuToggle>
+                    )}
+                  >
+                    <DropdownList>
+                      <DropdownItem value={0} key="action3">
+                        Action
+                      </DropdownItem>
+                      <DropdownItem
+                        value={1}
+                        key="link3"
+                        to="#default-link2"
+                        // Prevent the default onClick functionality for example purposes
+                        onClick={(ev: React.MouseEvent) => ev.preventDefault()}
+                      >
+                        Link
+                      </DropdownItem>
+                      <DropdownItem value={2} isDisabled key="disabled action3">
+                        Disabled Action
+                      </DropdownItem>
+                      <DropdownItem value={3} isDisabled key="disabled link3" to="#default-link4">
+                        Disabled Link
+                      </DropdownItem>
+                    </DropdownList>
+                  </Dropdown>
+                </DataListAction>
+              </DataListItemRow>
+              <DataListContent
+                aria-label="Primary Content Details"
+                id="ex-expand3"
+                isHidden={!expanded.includes('ex-toggle3')}
+                hasNoPadding
+              >
+                This expanded section has no padding.
+              </DataListContent>
+            </DataListItem>
+          </DataList>
+        </PageSection>
+      </DashboardWrapper>
+    </React.Fragment>
+  );
+};