@patternfly/react-core 5.4.0-prerelease.30 → 5.4.0-prerelease.32

package/helpers/package.json

@@ -1 +1 @@
-{"name":"@patternfly/react-core-helpers","main":"../dist/js/helpers/index.js","module":"../dist/esm/helpers/index.js","typings":"../dist/esm/helpers/index.d.ts","version":"5.4.0-prerelease.29","private":true}
+{"name":"@patternfly/react-core-helpers","main":"../dist/js/helpers/index.js","module":"../dist/esm/helpers/index.js","typings":"../dist/esm/helpers/index.d.ts","version":"5.4.0-prerelease.31","private":true}

package/layouts/package.json

@@ -1 +1 @@
-{"name":"@patternfly/react-core-layouts","main":"../dist/js/layouts/index.js","module":"../dist/esm/layouts/index.js","typings":"../dist/esm/layouts/index.d.ts","version":"5.4.0-prerelease.29","private":true}
+{"name":"@patternfly/react-core-layouts","main":"../dist/js/layouts/index.js","module":"../dist/esm/layouts/index.js","typings":"../dist/esm/layouts/index.d.ts","version":"5.4.0-prerelease.31","private":true}

package/next/package.json

@@ -1 +1 @@
-{"name":"@patternfly/react-core-next","main":"../dist/js/next/index.js","module":"../dist/esm/next/index.js","typings":"../dist/esm/next/index.d.ts","version":"5.4.0-prerelease.29","private":true}
+{"name":"@patternfly/react-core-next","main":"../dist/js/next/index.js","module":"../dist/esm/next/index.js","typings":"../dist/esm/next/index.d.ts","version":"5.4.0-prerelease.31","private":true}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@patternfly/react-core",
-  "version": "5.4.0-prerelease.30",
+  "version": "5.4.0-prerelease.32",
   "description": "This library provides a set of common React components for use with the PatternFly reference implementation.",
   "main": "dist/js/index.js",
   "module": "dist/esm/index.js",
@@ -62,5 +62,5 @@
     "react": "^17 || ^18",
     "react-dom": "^17 || ^18"
   },
-  "gitHead": "184c55f8d10e1d94ffd72e09212db56c15387c5e"
+  "gitHead": "c28c94c1fab61a16d9db7073fea5029567ce6687"
 }

package/scripts/copyStyles.js

@@ -1,8 +1,6 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 const { copySync, readFileSync, writeFileSync } = require('fs-extra');
 const { resolve, dirname, join } = require('path');
 const { parse: parseCSS, stringify: stringifyCSS } = require('css');
-/* eslint-enable @typescript-eslint/no-var-requires */
 
 const stylesDir = resolve(__dirname, '../dist/styles');
 const pfDir = dirname(require.resolve('@patternfly/patternfly/patternfly.css'));

package/src/components/BackToTop/__tests__/BackToTop.test.tsx

@@ -115,7 +115,7 @@ test('Clicking backToTop scrolls back to top of the element passed via scrollabl
   const user = userEvent.setup();
   const wrapper = document.getElementById('backToTopWrapper');
   fireEvent.scroll(wrapper as HTMLElement, { target: { scrollY: 401 } });
-  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+
   wrapper!.scrollTo = jest.fn();
   await user.click(screen.getByRole(`button`).parentElement as Element);
 

package/src/components/Chip/Chip.tsx

@@ -70,7 +70,7 @@ class Chip extends React.Component<ChipProps, ChipState> {
     isOverflowChip: false,
     isReadOnly: false,
     tooltipPosition: 'top' as 'auto' | 'top' | 'bottom' | 'left' | 'right',
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
     onClick: (_e: React.MouseEvent) => undefined as any,
     component: 'div' as React.ReactNode
   };

package/src/components/Chip/ChipGroup.tsx

@@ -77,7 +77,7 @@ class ChipGroup extends React.Component<ChipGroupProps, ChipGroupState> {
     defaultIsOpen: false,
     numChips: 3,
     isClosable: false,
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
     onClick: (_e: React.MouseEvent) => undefined as any,
     onOverflowChipClick: (_e: React.MouseEvent) => undefined as any,
     closeBtnAriaLabel: 'Close chip group',

package/src/components/ClipboardCopy/ClipboardCopy.tsx

@@ -145,7 +145,6 @@ class ClipboardCopy extends React.Component<ClipboardCopyProps, ClipboardCopySta
     }
   };
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   expandContent = (_event: React.MouseEvent<Element, MouseEvent>) => {
     this.setState((prevState) => ({
       expanded: !prevState.expanded

package/src/components/DataList/DataListAction.tsx

@@ -35,7 +35,7 @@ export const DataListAction: React.FunctionComponent<DataListActionProps> = ({
   id,
   'aria-label': ariaLabel,
   'aria-labelledby': ariaLabelledBy,
-  /* eslint-disable @typescript-eslint/no-unused-vars */
+
   isPlainButtonAction,
   ...props
 }: DataListActionProps) => (

package/src/components/Drawer/DrawerActions.tsx

@@ -10,7 +10,6 @@ export interface DrawerActionsProps extends React.HTMLProps<HTMLDivElement> {
 }
 
 export const DrawerActions: React.FunctionComponent<DrawerActionsProps> = ({
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   className = '',
   children,
   ...props

package/src/components/Drawer/DrawerCloseButton.tsx

@@ -14,7 +14,6 @@ export interface DrawerCloseButtonProps extends React.HTMLProps<HTMLDivElement>
 }
 
 export const DrawerCloseButton: React.FunctionComponent<DrawerCloseButtonProps> = ({
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   className = '',
   onClose = () => undefined as any,
   'aria-label': ariaLabel = 'Close drawer panel',

package/src/components/Drawer/DrawerContent.tsx

@@ -16,7 +16,6 @@ export interface DrawerContentProps extends React.HTMLProps<HTMLDivElement> {
 }
 
 export const DrawerContent: React.FunctionComponent<DrawerContentProps> = ({
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   className = '',
   children,
   panelContent,

package/src/components/Drawer/DrawerContentBody.tsx

@@ -12,7 +12,6 @@ export interface DrawerContentBodyProps extends React.HTMLProps<HTMLDivElement>
 }
 
 export const DrawerContentBody: React.FunctionComponent<DrawerContentBodyProps> = ({
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   className = '',
   children,
   hasPadding = false,

package/src/components/Drawer/DrawerHead.tsx

@@ -13,7 +13,6 @@ export interface DrawerHeadProps extends React.HTMLProps<HTMLDivElement> {
 }
 
 export const DrawerHead: React.FunctionComponent<DrawerHeadProps> = ({
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   className = '',
   children,
   hasNoPadding = false,

package/src/components/Drawer/DrawerMain.tsx

@@ -10,7 +10,6 @@ export interface DrawerMainProps extends React.HTMLProps<HTMLDivElement> {
 }
 
 export const DrawerMain: React.FunctionComponent<DrawerMainProps> = ({
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   className = '',
   children,
   ...props

package/src/components/Drawer/DrawerPanelBody.tsx

@@ -12,7 +12,6 @@ export interface DrawerPanelBodyProps extends React.HTMLProps<HTMLDivElement> {
 }
 
 export const DrawerPanelBody: React.FunctionComponent<DrawerPanelBodyProps> = ({
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   className = '',
   children,
   hasNoPadding = false,

package/src/components/Drawer/DrawerSection.tsx

@@ -13,7 +13,6 @@ export interface DrawerSectionProps extends React.HTMLProps<HTMLDivElement> {
 }
 
 export const DrawerSection: React.FunctionComponent<DrawerSectionProps> = ({
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   className = '',
   children,
   colorVariant = DrawerColorVariant.default,

package/src/components/Dropdown/Dropdown.tsx

@@ -127,7 +127,7 @@ const DropdownBase: React.FunctionComponent<DropdownProps> = ({
             'li button:not(:disabled),li input:not(:disabled),li a:not([aria-disabled="true"])'
           );
           firstElement && (firstElement as HTMLElement).focus();
-        }, 5);
+        }, 0);
       }
 
       // If the event is not on the toggle and onOpenChange callback is provided, close the menu

package/src/components/DualListSelector/DualListSelector.tsx

@@ -500,11 +500,10 @@ class DualListSelector extends React.Component<DualListSelectorProps, DualListSe
     e: React.MouseEvent | React.ChangeEvent | React.KeyboardEvent,
     index: number,
     isChosen: boolean,
-    /* eslint-disable @typescript-eslint/no-unused-vars */
+
     id?: string,
     itemData?: any,
     parentData?: any
-    /* eslint-enable @typescript-eslint/no-unused-vars */
   ) => {
     this.setState((prevState) => {
       const originalArray = isChosen ? prevState.chosenOptionsSelected : prevState.availableOptionsSelected;

package/src/components/ExpandableSection/ExpandableSection.tsx

@@ -184,7 +184,7 @@ class ExpandableSection extends React.Component<ExpandableSectionProps, Expandab
   render() {
     const {
       onToggle: onToggleProp,
-      // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
       isActive,
       className,
       toggleText,

package/src/components/Label/LabelGroup.tsx

@@ -86,7 +86,7 @@ class LabelGroup extends React.Component<LabelGroupProps, LabelGroupState> {
     numLabels: 3,
     isClosable: false,
     isCompact: false,
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
     onClick: (_e: React.MouseEvent) => undefined as any,
     closeBtnAriaLabel: 'Close label group',
     tooltipPosition: 'top',

package/src/components/Page/PageToggleButton.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import * as React from 'react';
 import { Button, ButtonProps, ButtonVariant } from '../../components/Button';
 import { PageContextConsumer, PageContextProps } from './PageContext';

package/src/components/Popover/Popover.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import * as React from 'react';
 import { KeyTypes } from '../../helpers/constants';
 import styles from '@patternfly/react-styles/css/components/Popover/popover';

package/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap

@@ -134,7 +134,7 @@ exports[`SearchInput advanced search 1`] = `
       data-popper-escaped="true"
       data-popper-placement="bottom-start"
       data-popper-reference-hidden="true"
-      style="position: absolute; left: 0px; top: 0px; z-index: 9999; opacity: 0; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11); min-width: 0px; transform: translate(0px, 0px); display: none;"
+      style="position: absolute; left: 0px; top: 0px; z-index: 9999; opacity: 0; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11); min-width: 0px; transform: translate(0px, 0px);"
     />
   </div>
 </DocumentFragment>
@@ -590,7 +590,7 @@ exports[`SearchInput renders search input in strict mode 1`] = `
       data-popper-escaped="true"
       data-popper-placement="bottom-start"
       data-popper-reference-hidden="true"
-      style="position: absolute; left: 0px; top: 0px; z-index: 9999; opacity: 0; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11); min-width: 0px; transform: translate(0px, 0px); display: none;"
+      style="position: absolute; left: 0px; top: 0px; z-index: 9999; opacity: 0; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11); min-width: 0px; transform: translate(0px, 0px);"
     />
   </div>
 </DocumentFragment>

package/src/components/Select/Select.tsx

@@ -132,7 +132,7 @@ const SelectBase: React.FunctionComponent<SelectProps & OUIAProps> = ({
         setTimeout(() => {
           const firstElement = menuRef?.current?.querySelector('li button:not(:disabled),li input:not(:disabled)');
           firstElement && (firstElement as HTMLElement).focus();
-        }, 5);
+        }, 0);
       }
 
       // If the event is not on the toggle and onOpenChange callback is provided, close the menu

package/src/components/Spinner/Spinner.tsx

@@ -28,7 +28,6 @@ export interface SpinnerProps extends React.SVGProps<SVGSVGElement> {
 }
 
 export const Spinner: React.FunctionComponent<SpinnerProps> = ({
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   className = '',
   size = 'xl',
   'aria-valuetext': ariaValueText = 'Loading...',

package/src/components/Tabs/TabAction.tsx

@@ -26,7 +26,7 @@ const TabActionBase: React.FunctionComponent<TabActionProps> = ({
   isDisabled,
   'aria-label': ariaLabel = 'Tab action',
   innerRef,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
   ouiaId,
   ouiaSafe,
   ...props

package/src/components/Tabs/Tabs.tsx

@@ -190,7 +190,7 @@ class Tabs extends React.Component<TabsProps, TabsState> {
     unmountOnExit: false,
     ouiaSafe: true,
     variant: 'default',
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
     onToggle: (_event: React.MouseEvent, _isExpanded: boolean): void => undefined
   };
 

package/src/components/Tooltip/Tooltip.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/Tooltip/tooltip';
 import { css } from '@patternfly/react-styles';

package/src/demos/CustomMenus/examples/ApplicationLauncherDemo.tsx

@@ -203,7 +203,6 @@ export const ApplicationLauncherDemo: React.FunctionComponent = () => {
   }
 
   return (
-    // eslint-disable-next-line no-console
     <Dropdown
       isOpen={isOpen}
       onOpenChange={(isOpen) => setIsOpen(isOpen)}

package/src/demos/CustomMenus/examples/ComposableDateSelect.tsx

@@ -98,7 +98,6 @@ export const ComposableSimpleDropdown: React.FunctionComponent = () => {
     </MenuToggle>
   );
   const menu = (
-    // eslint-disable-next-line no-console
     <Menu ref={menuRef} onSelect={(_ev, itemId) => setSelected(itemId as number)} selected={selected}>
       <MenuContent>
         <MenuList>

package/src/demos/CustomMenus/examples/DateSelectDemo.tsx

@@ -57,7 +57,6 @@ export const DateSelectDemo: React.FunctionComponent = () => {
   };
 
   return (
-    // eslint-disable-next-line no-console
     <Select
       isOpen={isOpen}
       onOpenChange={(isOpen) => setIsOpen(isOpen)}

package/src/demos/CustomMenus/examples/FavoritesDemo.tsx

@@ -92,7 +92,6 @@ export const FavoritesDemo: React.FunctionComponent = () => {
   };
 
   return (
-    // eslint-disable-next-line no-console
     <Dropdown
       isOpen={isOpen}
       onOpenChange={(isOpen) => setIsOpen(isOpen)}

package/src/demos/Filters/examples/FilterAttributeSearch.tsx

@@ -533,7 +533,6 @@ export const FilterAttributeSearch: React.FunctionComponent = () => {
     </MenuToggle>
   );
   const attributeMenu = (
-    // eslint-disable-next-line no-console
     <Menu
       ref={attributeMenuRef}
       onSelect={(_ev, itemId) => {

package/src/deprecated/components/ApplicationLauncher/ApplicationLauncher.tsx

@@ -75,10 +75,10 @@ class ApplicationLauncher extends React.Component<ApplicationLauncherProps> {
     items: [] as React.ReactNode[],
     isOpen: false,
     position: DropdownPosition.left,
-    /* eslint-disable @typescript-eslint/no-unused-vars */
+
     onSelect: (_event: any): any => undefined,
     onToggle: (_event: any, _value: boolean): any => undefined,
-    /* eslint-enable @typescript-eslint/no-unused-vars */
+
     'aria-label': 'Application launcher',
     isGrouped: false,
     toggleIcon: <ThIcon />,

package/src/deprecated/components/ContextSelector/ContextSelectorItem.tsx

@@ -35,7 +35,6 @@ class ContextSelectorItem extends React.Component<ContextSelectorItemProps> {
   ref: React.RefObject<HTMLButtonElement & HTMLAnchorElement> = React.createRef();
 
   componentDidMount() {
-    /* eslint-disable-next-line */
     this.props.sendRef(this.props.index, this.ref.current);
   }
 

package/src/deprecated/components/Dropdown/DropdownMenu.tsx

@@ -67,7 +67,7 @@ class DropdownMenu extends React.Component<DropdownMenuProps> {
       );
       const focusTarget = focusTargetCollection && focusTargetCollection[0];
       if (focusTarget && focusTarget.focus) {
-        setTimeout(() => focusTarget.focus(), 5);
+        setTimeout(() => focusTarget.focus());
       }
     }
   }
@@ -79,7 +79,7 @@ class DropdownMenu extends React.Component<DropdownMenuProps> {
   static validToggleClasses = [styles.dropdownToggle, styles.dropdownToggleButton] as string[];
   static focusFirstRef = (refCollection: HTMLElement[]) => {
     if (refCollection && refCollection[0] && refCollection[0].focus) {
-      setTimeout(() => refCollection[0].focus(), 5);
+      setTimeout(() => refCollection[0].focus());
     }
   };
 

package/src/deprecated/components/Dropdown/DropdownToggle.tsx

@@ -67,9 +67,9 @@ export const DropdownToggle: React.FunctionComponent<DropdownToggleProps> = ({
   isPlain = false,
   isText = false,
   toggleVariant = 'default',
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
   isActive = false,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
   onToggle = (_evt: any, _isOpen: boolean) => undefined as any,
   icon = null,
   toggleIndicator: ToggleIndicator = CaretDownIcon,

package/src/deprecated/components/Dropdown/InternalDropdownItem.tsx

@@ -93,7 +93,7 @@ class InternalDropdownItem extends React.Component<InternalDropdownItemProps> {
       isDisabled,
       role === 'separator'
     );
-    autoFocus && setTimeout(() => customRef.focus(), 5);
+    autoFocus && setTimeout(() => customRef.focus());
   }
 
   componentDidUpdate() {

package/src/deprecated/components/OptionsMenu/OptionsMenuToggle.tsx

@@ -37,7 +37,7 @@ export const OptionsMenuToggle: React.FunctionComponent<OptionsMenuToggleProps>
   parentId = '',
   toggleTemplate = <React.Fragment />,
   hideCaret = false,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
   isActive = false,
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   isSplitButton = false,

package/src/deprecated/components/PageHeader/PageHeader.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import * as React from 'react';
 import styles from '@patternfly/react-styles/css/components/Page/page';
 import { css } from '@patternfly/react-styles';

package/src/deprecated/components/Select/SelectOption.tsx

@@ -187,7 +187,7 @@ class SelectOption extends React.Component<SelectOptionProps> {
       isLoad,
       isLoading,
       setViewMoreNextIndex,
-      // eslint-disable-next-line no-console
+
       isLastOptionBeforeFooter,
       isGrouped = false,
       ...props

package/src/deprecated/components/Select/SelectToggle.tsx

@@ -297,7 +297,6 @@ class SelectToggleBase extends React.Component<SelectToggleProps> {
             )}
             aria-label={ariaLabel}
             onBlur={onBlur}
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
             onClick={(event) => {
               onToggle(event, !isOpen);
               if (isOpen) {
@@ -324,7 +323,6 @@ class SelectToggleBase extends React.Component<SelectToggleProps> {
               className
             )}
             onBlur={onBlur}
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
             onClick={(event) => {
               if (!isDisabled) {
                 onToggle(event, !isOpen);

package/src/deprecated/components/Wizard/__tests__/Wizard.test.tsx

@@ -30,7 +30,6 @@ describe('Wizard', () => {
       { name: 'D', id: 'step-D', component: <p>Step 5</p> }
     ];
     const onBack: WizardStepFunctionType = (step) => {
-      // eslint-disable-next-line @typescript-eslint/no-unused-vars
       const name = { step };
     };
 
@@ -63,7 +62,6 @@ describe('Wizard', () => {
       { name: 'D', component: <p>Step 5</p> }
     ];
     const onBack: WizardStepFunctionType = (step) => {
-      // eslint-disable-next-line @typescript-eslint/no-unused-vars
       const name = { step };
     };
 

package/src/helpers/Popper/Popper.tsx

@@ -221,7 +221,6 @@ export const Popper: React.FunctionComponent<PopperProps> = ({
   const [popperContent, setPopperContent] = React.useState(null);
   const [ready, setReady] = React.useState(false);
   const [opacity, setOpacity] = React.useState(0);
-  const [display, setDisplay] = React.useState('none');
   const [internalIsVisible, setInternalIsVisible] = React.useState(isVisible);
   const transitionTimerRef = React.useRef(null);
   const showTimerRef = React.useRef(null);
@@ -470,18 +469,11 @@ export const Popper: React.FunctionComponent<PopperProps> = ({
     prevExitDelayRef.current = exitDelay;
   }, [exitDelay]);
 
-  React.useEffect(() => {
-    if (display !== 'none') {
-      forceUpdate && forceUpdate();
-    }
-  }, [display]);
-
   const show = () => {
     onShow();
     clearTimeouts([transitionTimerRef, hideTimerRef]);
     showTimerRef.current = setTimeout(() => {
       setInternalIsVisible(true);
-      setDisplay('');
       setOpacity(1);
       onShown();
     }, entryDelay);
@@ -496,7 +488,6 @@ export const Popper: React.FunctionComponent<PopperProps> = ({
         setInternalIsVisible(false);
         onHidden();
       }, animationDuration);
-      setDisplay('none');
     }, exitDelay);
   };
 
@@ -525,7 +516,6 @@ export const Popper: React.FunctionComponent<PopperProps> = ({
       ...popperStyles.popper,
       zIndex,
       opacity,
-      display,
       transition: getOpacityTransition(animationDuration)
     },
     ...attributes.popper

package/src/helpers/__tests__/util.test.ts

@@ -89,7 +89,6 @@ test('sideElementIsOutOfView Returns NONE when in view', () => {
 });
 
 test('fillTemplate interpolates strings correctly', () => {
-  // eslint-disable-next-line no-template-curly-in-string
   const templateString = 'My name is ${firstName} ${lastName}';
   const expected = 'My name is Jon Dough';
   const templatVars = {