@patternfly/react-core 5.2.0-prerelease.16 → 5.2.0-prerelease.18

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (199) hide show
  1. package/CHANGELOG.md +13 -0
  2. package/components/package.json +1 -1
  3. package/deprecated/package.json +1 -1
  4. package/dist/dynamic/components/AboutModal/package.json +1 -1
  5. package/dist/dynamic/components/Accordion/package.json +1 -1
  6. package/dist/dynamic/components/ActionList/package.json +1 -1
  7. package/dist/dynamic/components/Alert/package.json +1 -1
  8. package/dist/dynamic/components/Avatar/package.json +1 -1
  9. package/dist/dynamic/components/BackToTop/package.json +1 -1
  10. package/dist/dynamic/components/Backdrop/package.json +1 -1
  11. package/dist/dynamic/components/BackgroundImage/package.json +1 -1
  12. package/dist/dynamic/components/Badge/package.json +1 -1
  13. package/dist/dynamic/components/Banner/package.json +1 -1
  14. package/dist/dynamic/components/Brand/package.json +1 -1
  15. package/dist/dynamic/components/Breadcrumb/package.json +1 -1
  16. package/dist/dynamic/components/Button/package.json +1 -1
  17. package/dist/dynamic/components/CalendarMonth/package.json +1 -1
  18. package/dist/dynamic/components/Card/package.json +1 -1
  19. package/dist/dynamic/components/Checkbox/package.json +1 -1
  20. package/dist/dynamic/components/Chip/package.json +1 -1
  21. package/dist/dynamic/components/ClipboardCopy/package.json +1 -1
  22. package/dist/dynamic/components/CodeBlock/package.json +1 -1
  23. package/dist/dynamic/components/DataList/package.json +1 -1
  24. package/dist/dynamic/components/DatePicker/package.json +1 -1
  25. package/dist/dynamic/components/DescriptionList/package.json +1 -1
  26. package/dist/dynamic/components/Divider/package.json +1 -1
  27. package/dist/dynamic/components/DragDrop/package.json +1 -1
  28. package/dist/dynamic/components/Drawer/package.json +1 -1
  29. package/dist/dynamic/components/Dropdown/package.json +1 -1
  30. package/dist/dynamic/components/DualListSelector/package.json +1 -1
  31. package/dist/dynamic/components/EmptyState/package.json +1 -1
  32. package/dist/dynamic/components/ExpandableSection/package.json +1 -1
  33. package/dist/dynamic/components/FileUpload/package.json +1 -1
  34. package/dist/dynamic/components/Form/package.json +1 -1
  35. package/dist/dynamic/components/FormSelect/package.json +1 -1
  36. package/dist/dynamic/components/HelperText/package.json +1 -1
  37. package/dist/dynamic/components/Hint/package.json +1 -1
  38. package/dist/dynamic/components/Icon/package.json +1 -1
  39. package/dist/dynamic/components/InputGroup/package.json +1 -1
  40. package/dist/dynamic/components/JumpLinks/package.json +1 -1
  41. package/dist/dynamic/components/Label/package.json +1 -1
  42. package/dist/dynamic/components/List/package.json +1 -1
  43. package/dist/dynamic/components/LoginPage/package.json +1 -1
  44. package/dist/dynamic/components/Masthead/package.json +1 -1
  45. package/dist/dynamic/components/Menu/package.json +1 -1
  46. package/dist/dynamic/components/MenuToggle/package.json +1 -1
  47. package/dist/dynamic/components/Modal/package.json +1 -1
  48. package/dist/dynamic/components/MultipleFileUpload/package.json +1 -1
  49. package/dist/dynamic/components/Nav/package.json +1 -1
  50. package/dist/dynamic/components/NotificationBadge/package.json +1 -1
  51. package/dist/dynamic/components/NotificationDrawer/package.json +1 -1
  52. package/dist/dynamic/components/NumberInput/package.json +1 -1
  53. package/dist/dynamic/components/OverflowMenu/package.json +1 -1
  54. package/dist/dynamic/components/Page/package.json +1 -1
  55. package/dist/dynamic/components/Pagination/package.json +1 -1
  56. package/dist/dynamic/components/Panel/package.json +1 -1
  57. package/dist/dynamic/components/Popover/package.json +1 -1
  58. package/dist/dynamic/components/Progress/package.json +1 -1
  59. package/dist/dynamic/components/ProgressStepper/package.json +1 -1
  60. package/dist/dynamic/components/Radio/package.json +1 -1
  61. package/dist/dynamic/components/SearchInput/package.json +1 -1
  62. package/dist/dynamic/components/Select/package.json +1 -1
  63. package/dist/dynamic/components/Sidebar/package.json +1 -1
  64. package/dist/dynamic/components/SimpleList/package.json +1 -1
  65. package/dist/dynamic/components/Skeleton/package.json +1 -1
  66. package/dist/dynamic/components/SkipToContent/package.json +1 -1
  67. package/dist/dynamic/components/Slider/package.json +1 -1
  68. package/dist/dynamic/components/Spinner/package.json +1 -1
  69. package/dist/dynamic/components/Switch/package.json +1 -1
  70. package/dist/dynamic/components/Tabs/package.json +1 -1
  71. package/dist/dynamic/components/Text/package.json +1 -1
  72. package/dist/dynamic/components/TextArea/package.json +1 -1
  73. package/dist/dynamic/components/TextInput/package.json +1 -1
  74. package/dist/dynamic/components/TextInputGroup/package.json +1 -1
  75. package/dist/dynamic/components/Tile/package.json +1 -1
  76. package/dist/dynamic/components/TimePicker/package.json +1 -1
  77. package/dist/dynamic/components/Timestamp/package.json +1 -1
  78. package/dist/dynamic/components/Title/package.json +1 -1
  79. package/dist/dynamic/components/ToggleGroup/package.json +1 -1
  80. package/dist/dynamic/components/Toolbar/package.json +1 -1
  81. package/dist/dynamic/components/Tooltip/package.json +1 -1
  82. package/dist/dynamic/components/TreeView/package.json +1 -1
  83. package/dist/dynamic/components/Truncate/package.json +1 -1
  84. package/dist/dynamic/components/Wizard/hooks/package.json +1 -1
  85. package/dist/dynamic/components/Wizard/package.json +1 -1
  86. package/dist/dynamic/deprecated/components/ApplicationLauncher/package.json +1 -1
  87. package/dist/dynamic/deprecated/components/ContextSelector/package.json +1 -1
  88. package/dist/dynamic/deprecated/components/Dropdown/package.json +1 -1
  89. package/dist/dynamic/deprecated/components/OptionsMenu/package.json +1 -1
  90. package/dist/dynamic/deprecated/components/PageHeader/package.json +1 -1
  91. package/dist/dynamic/deprecated/components/Select/package.json +1 -1
  92. package/dist/dynamic/deprecated/components/Wizard/package.json +1 -1
  93. package/dist/dynamic/deprecated/components/package.json +1 -1
  94. package/dist/dynamic/helpers/FocusTrap/FocusTrap/package.json +1 -1
  95. package/dist/dynamic/helpers/GenerateId/GenerateId/package.json +1 -1
  96. package/dist/dynamic/helpers/KeyboardHandler/package.json +1 -1
  97. package/dist/dynamic/helpers/OUIA/ouia/package.json +1 -1
  98. package/dist/dynamic/helpers/Popper/Popper/package.json +1 -1
  99. package/dist/dynamic/helpers/constants/package.json +1 -1
  100. package/dist/dynamic/helpers/datetimeUtils/package.json +1 -1
  101. package/dist/dynamic/helpers/favorites/package.json +1 -1
  102. package/dist/dynamic/helpers/fileUtils/package.json +1 -1
  103. package/dist/dynamic/helpers/htmlConstants/package.json +1 -1
  104. package/dist/dynamic/helpers/package.json +1 -1
  105. package/dist/dynamic/helpers/resizeObserver/package.json +1 -1
  106. package/dist/dynamic/helpers/typeUtils/package.json +1 -1
  107. package/dist/dynamic/helpers/useInterval/package.json +1 -1
  108. package/dist/dynamic/helpers/useIsomorphicLayout/package.json +1 -1
  109. package/dist/dynamic/helpers/useUnmountEffect/package.json +1 -1
  110. package/dist/dynamic/helpers/util/package.json +1 -1
  111. package/dist/dynamic/layouts/Bullseye/package.json +1 -1
  112. package/dist/dynamic/layouts/Flex/package.json +1 -1
  113. package/dist/dynamic/layouts/Gallery/package.json +1 -1
  114. package/dist/dynamic/layouts/Grid/package.json +1 -1
  115. package/dist/dynamic/layouts/Level/package.json +1 -1
  116. package/dist/dynamic/layouts/Split/package.json +1 -1
  117. package/dist/dynamic/layouts/Stack/package.json +1 -1
  118. package/dist/dynamic/next/components/package.json +1 -1
  119. package/dist/esm/components/Drawer/DrawerPanelContent.js +4 -4
  120. package/dist/esm/components/Drawer/DrawerPanelContent.js.map +1 -1
  121. package/dist/esm/components/Dropdown/Dropdown.d.ts +2 -0
  122. package/dist/esm/components/Dropdown/Dropdown.d.ts.map +1 -1
  123. package/dist/esm/components/Dropdown/Dropdown.js.map +1 -1
  124. package/dist/esm/components/ExpandableSection/ExpandableSection.js +1 -1
  125. package/dist/esm/components/ExpandableSection/ExpandableSection.js.map +1 -1
  126. package/dist/esm/components/Menu/Menu.d.ts.map +1 -1
  127. package/dist/esm/components/Menu/Menu.js +2 -1
  128. package/dist/esm/components/Menu/Menu.js.map +1 -1
  129. package/dist/esm/components/Menu/MenuContainer.d.ts +2 -0
  130. package/dist/esm/components/Menu/MenuContainer.d.ts.map +1 -1
  131. package/dist/esm/components/Menu/MenuContainer.js.map +1 -1
  132. package/dist/esm/components/Nav/NavList.js +3 -3
  133. package/dist/esm/components/Nav/NavList.js.map +1 -1
  134. package/dist/esm/components/Select/Select.d.ts +2 -0
  135. package/dist/esm/components/Select/Select.d.ts.map +1 -1
  136. package/dist/esm/components/Select/Select.js.map +1 -1
  137. package/dist/esm/components/Slider/Slider.d.ts.map +1 -1
  138. package/dist/esm/components/Slider/Slider.js +2 -1
  139. package/dist/esm/components/Slider/Slider.js.map +1 -1
  140. package/dist/esm/components/Tabs/Tabs.js +3 -3
  141. package/dist/esm/components/Tabs/Tabs.js.map +1 -1
  142. package/dist/esm/helpers/Popper/Popper.d.ts +2 -1
  143. package/dist/esm/helpers/Popper/Popper.d.ts.map +1 -1
  144. package/dist/esm/helpers/Popper/Popper.js +3 -13
  145. package/dist/esm/helpers/Popper/Popper.js.map +1 -1
  146. package/dist/esm/helpers/util.d.ts +9 -0
  147. package/dist/esm/helpers/util.d.ts.map +1 -1
  148. package/dist/esm/helpers/util.js +18 -0
  149. package/dist/esm/helpers/util.js.map +1 -1
  150. package/dist/js/components/Drawer/DrawerPanelContent.js +3 -3
  151. package/dist/js/components/Drawer/DrawerPanelContent.js.map +1 -1
  152. package/dist/js/components/Dropdown/Dropdown.d.ts +2 -0
  153. package/dist/js/components/Dropdown/Dropdown.d.ts.map +1 -1
  154. package/dist/js/components/Dropdown/Dropdown.js.map +1 -1
  155. package/dist/js/components/ExpandableSection/ExpandableSection.js +1 -1
  156. package/dist/js/components/ExpandableSection/ExpandableSection.js.map +1 -1
  157. package/dist/js/components/Menu/Menu.d.ts.map +1 -1
  158. package/dist/js/components/Menu/Menu.js +2 -1
  159. package/dist/js/components/Menu/Menu.js.map +1 -1
  160. package/dist/js/components/Menu/MenuContainer.d.ts +2 -0
  161. package/dist/js/components/Menu/MenuContainer.d.ts.map +1 -1
  162. package/dist/js/components/Menu/MenuContainer.js.map +1 -1
  163. package/dist/js/components/Nav/NavList.js +2 -2
  164. package/dist/js/components/Nav/NavList.js.map +1 -1
  165. package/dist/js/components/Select/Select.d.ts +2 -0
  166. package/dist/js/components/Select/Select.d.ts.map +1 -1
  167. package/dist/js/components/Select/Select.js.map +1 -1
  168. package/dist/js/components/Slider/Slider.d.ts.map +1 -1
  169. package/dist/js/components/Slider/Slider.js +2 -1
  170. package/dist/js/components/Slider/Slider.js.map +1 -1
  171. package/dist/js/components/Tabs/Tabs.js +2 -2
  172. package/dist/js/components/Tabs/Tabs.js.map +1 -1
  173. package/dist/js/helpers/Popper/Popper.d.ts +2 -1
  174. package/dist/js/helpers/Popper/Popper.d.ts.map +1 -1
  175. package/dist/js/helpers/Popper/Popper.js +5 -16
  176. package/dist/js/helpers/Popper/Popper.js.map +1 -1
  177. package/dist/js/helpers/util.d.ts +9 -0
  178. package/dist/js/helpers/util.d.ts.map +1 -1
  179. package/dist/js/helpers/util.js +20 -1
  180. package/dist/js/helpers/util.js.map +1 -1
  181. package/dist/umd/react-core.min.js +1 -1
  182. package/helpers/package.json +1 -1
  183. package/layouts/package.json +1 -1
  184. package/next/package.json +1 -1
  185. package/package.json +2 -2
  186. package/src/components/Checkbox/__tests__/Checkbox.test.tsx +223 -69
  187. package/src/components/Checkbox/__tests__/__snapshots__/Checkbox.test.tsx.snap +3 -198
  188. package/src/components/Drawer/DrawerPanelContent.tsx +4 -4
  189. package/src/components/Dropdown/Dropdown.tsx +2 -0
  190. package/src/components/ExpandableSection/ExpandableSection.tsx +1 -1
  191. package/src/components/Menu/Menu.tsx +2 -1
  192. package/src/components/Menu/MenuContainer.tsx +2 -0
  193. package/src/components/Nav/NavList.tsx +3 -3
  194. package/src/components/Select/Select.tsx +2 -0
  195. package/src/components/Slider/Slider.tsx +2 -1
  196. package/src/components/Tabs/Tabs.tsx +3 -3
  197. package/src/helpers/Popper/Popper.tsx +6 -17
  198. package/src/helpers/__mocks__/util.ts +2 -0
  199. package/src/helpers/util.ts +22 -0
@@ -1 +1 @@
1
- {"name":"@patternfly/react-core-helpers","main":"../dist/js/helpers/index.js","module":"../dist/esm/helpers/index.js","typings":"../dist/esm/helpers/index.d.ts","version":"5.2.0-prerelease.15","private":true}
1
+ {"name":"@patternfly/react-core-helpers","main":"../dist/js/helpers/index.js","module":"../dist/esm/helpers/index.js","typings":"../dist/esm/helpers/index.d.ts","version":"5.2.0-prerelease.17","private":true}
@@ -1 +1 @@
1
- {"name":"@patternfly/react-core-layouts","main":"../dist/js/layouts/index.js","module":"../dist/esm/layouts/index.js","typings":"../dist/esm/layouts/index.d.ts","version":"5.2.0-prerelease.15","private":true}
1
+ {"name":"@patternfly/react-core-layouts","main":"../dist/js/layouts/index.js","module":"../dist/esm/layouts/index.js","typings":"../dist/esm/layouts/index.d.ts","version":"5.2.0-prerelease.17","private":true}
package/next/package.json CHANGED
@@ -1 +1 @@
1
- {"name":"@patternfly/react-core-next","main":"../dist/js/next/index.js","module":"../dist/esm/next/index.js","typings":"../dist/esm/next/index.d.ts","version":"5.2.0-prerelease.15","private":true}
1
+ {"name":"@patternfly/react-core-next","main":"../dist/js/next/index.js","module":"../dist/esm/next/index.js","typings":"../dist/esm/next/index.d.ts","version":"5.2.0-prerelease.17","private":true}
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@patternfly/react-core",
3
- "version": "5.2.0-prerelease.16",
3
+ "version": "5.2.0-prerelease.18",
4
4
  "description": "This library provides a set of common React components for use with the PatternFly reference implementation.",
5
5
  "main": "dist/js/index.js",
6
6
  "module": "dist/esm/index.js",
@@ -71,5 +71,5 @@
71
71
  "react": "^17 || ^18",
72
72
  "react-dom": "^17 || ^18"
73
73
  },
74
- "gitHead": "bbd82ab078a6512692d8f6253a80cf87242f775a"
74
+ "gitHead": "044826a3f3ee454f616c35c0cfd5652d6baa9614"
75
75
  }
@@ -6,91 +6,245 @@ import userEvent from '@testing-library/user-event';
6
6
  import { Checkbox } from '../Checkbox';
7
7
  import styles from '@patternfly/react-styles/css/components/Check/check';
8
8
 
9
- describe('Checkbox', () => {
10
- test('controlled', () => {
11
- const { asFragment } = render(<Checkbox isChecked id="check" aria-label="check" />);
12
- expect(asFragment()).toMatchSnapshot();
13
- });
9
+ test(`Renders with only the class ${styles.checkInput} on the check by default`, () => {
10
+ render(<Checkbox id="test-id" />);
14
11
 
15
- test('controlled - 3rd state', () => {
16
- const { asFragment } = render(<Checkbox isChecked={null} id="check" aria-label="check" />);
17
- expect(asFragment()).toMatchSnapshot();
18
- });
12
+ expect(screen.getByRole('checkbox')).toHaveClass(styles.checkInput, { exact: true });
13
+ });
19
14
 
20
- test('uncontrolled', () => {
21
- const { asFragment } = render(<Checkbox id="check" aria-label="check" />);
22
- expect(asFragment()).toMatchSnapshot();
23
- });
15
+ test(`Renders with only the classes ${styles.check} and ${styles.modifiers.standalone} on the check wrapper by default`, () => {
16
+ render(<Checkbox id="test-id" />);
24
17
 
25
- test('isDisabled', () => {
26
- const { asFragment } = render(<Checkbox id="check" isDisabled aria-label="check" />);
27
- expect(asFragment()).toMatchSnapshot();
18
+ expect(screen.getByRole('checkbox').parentElement).toHaveClass(`${styles.check} ${styles.modifiers.standalone}`, {
19
+ exact: true
28
20
  });
21
+ });
29
22
 
30
- test('label is string', () => {
31
- const { asFragment } = render(<Checkbox label="Label" id="check" isChecked aria-label="check" />);
32
- expect(asFragment()).toMatchSnapshot();
33
- });
23
+ test('Renders with additional classes passed via className', () => {
24
+ render(<Checkbox id="test-id" className="test-class" />);
34
25
 
35
- test('label is function', () => {
36
- const functionLabel = () => <h1>Header</h1>;
37
- const { asFragment } = render(<Checkbox label={functionLabel()} id="check" isChecked aria-label="check" />);
38
- expect(asFragment()).toMatchSnapshot();
39
- });
26
+ expect(screen.getByRole('checkbox').parentElement).toHaveClass('test-class');
27
+ });
40
28
 
41
- test('label is node', () => {
42
- const { asFragment } = render(<Checkbox label={<h1>Header</h1>} id="check" isChecked aria-label="check" />);
43
- expect(asFragment()).toMatchSnapshot();
44
- });
29
+ test('Renders with additional classes passed via inputClassName', () => {
30
+ render(<Checkbox id="test-id" inputClassName="test-class" />);
45
31
 
46
- test('passing class', () => {
47
- const { asFragment } = render(
48
- <Checkbox label="label" className="class-123" id="check" isChecked aria-label="check" />
49
- );
50
- expect(asFragment()).toMatchSnapshot();
51
- });
32
+ expect(screen.getByRole('checkbox')).toHaveClass('test-class');
33
+ });
52
34
 
53
- test('passing HTML attribute', () => {
54
- const { asFragment } = render(
55
- <Checkbox label="label" aria-labelledby="labelId" id="check" isChecked aria-label="check" />
56
- );
57
- expect(asFragment()).toMatchSnapshot();
58
- });
35
+ test('Does not set the checkbox as invalid by default', () => {
36
+ render(<Checkbox id="test-id" />);
59
37
 
60
- test('passing description', () => {
61
- render(<Checkbox id="check" label="checkbox" description="Text description..." />);
62
- expect(screen.getByText('Text description...')).toBeInTheDocument();
63
- });
38
+ expect(screen.getByRole('checkbox')).toBeValid();
39
+ });
64
40
 
65
- test('passing body', () => {
66
- render(<Checkbox id="check" label="checkbox" body="This is where custom content goes." />);
41
+ test('Sets the checkbox as invalid when isValid is false', () => {
42
+ render(<Checkbox id="test-id" isValid={false} />);
67
43
 
68
- expect(screen.getByText('This is where custom content goes.')).toBeInTheDocument();
69
- });
44
+ expect(screen.getByRole('checkbox')).toBeInvalid();
45
+ });
70
46
 
71
- test('checkbox onChange handler called when component is clicked', async () => {
72
- const onChangeHandler = jest.fn();
73
- const user = userEvent.setup();
47
+ test('Does not set the checkbox as disabled by default', () => {
48
+ render(<Checkbox id="test-id" />);
74
49
 
75
- render(<Checkbox id="check" onChange={onChangeHandler} aria-label="check" isChecked={false} />);
50
+ expect(screen.getByRole('checkbox')).not.toBeDisabled();
51
+ });
76
52
 
77
- await user.click(screen.getByLabelText('check'));
78
- expect(onChangeHandler).toHaveBeenCalled();
79
- });
53
+ test(`Sets the checkbox as disabled when isDisabled is passed`, () => {
54
+ render(<Checkbox id="test-id" isDisabled />);
80
55
 
81
- test('should throw console error when no id is given', () => {
82
- const myMock = jest.fn();
83
- global.console = { ...global.console, error: myMock };
56
+ expect(screen.getByRole('checkbox')).toBeDisabled();
57
+ });
84
58
 
85
- render(<Checkbox id={undefined} />);
86
- expect(myMock).toHaveBeenCalled();
87
- });
59
+ test('Sets the label as disabled when isDisabled and label are passed', () => {
60
+ render(<Checkbox id="test-id" isDisabled label="test label" />);
88
61
 
89
- test('renders component wrapper as span', () => {
90
- const { container } = render(
91
- <Checkbox component="span" label="label" aria-labelledby="labelId" id="check" isChecked aria-label="check" />
92
- );
93
- const span = container.querySelector('span');
94
- expect(span).toHaveClass(styles.check);
95
- });
62
+ expect(screen.getByLabelText('test label')).toBeDisabled();
63
+ });
64
+
65
+ test('Does not set the checkbox as required by default', () => {
66
+ render(<Checkbox id="test-id" />);
67
+
68
+ expect(screen.getByRole('checkbox')).not.toBeRequired();
69
+ });
70
+
71
+ test(`Sets the checkbox as required when isRequired is passed`, () => {
72
+ render(<Checkbox id="test-id" isRequired />);
73
+
74
+ expect(screen.getByRole('checkbox')).toBeRequired();
75
+ });
76
+
77
+ test('Does not set the checkbox as checked by default', () => {
78
+ render(<Checkbox id="test-id" />);
79
+
80
+ expect(screen.getByRole('checkbox')).not.toBeChecked();
81
+ });
82
+
83
+ test(`Sets the checkbox as checked when isChecked is passed`, () => {
84
+ render(<Checkbox id="test-id" isChecked />);
85
+
86
+ expect(screen.getByRole('checkbox')).toBeChecked();
87
+ });
88
+
89
+ test(`Sets the checkbox as checked when checked is passed`, () => {
90
+ render(<Checkbox id="test-id" checked />);
91
+
92
+ expect(screen.getByRole('checkbox')).toBeChecked();
93
+ });
94
+
95
+ test(`Calls onChange when the checkbox is clicked`, async () => {
96
+ const user = userEvent.setup();
97
+ const onChange = jest.fn();
98
+ render(<Checkbox id="test-id" onChange={onChange} />);
99
+
100
+ await user.click(screen.getByRole('checkbox'));
101
+
102
+ expect(onChange).toHaveBeenCalledTimes(1);
103
+ });
104
+
105
+ test('Does not call onChange when the checkbox is not clicked', () => {
106
+ const onChange = jest.fn();
107
+ render(<Checkbox id="test-id" onChange={onChange} />);
108
+
109
+ expect(onChange).not.toHaveBeenCalled();
110
+ });
111
+
112
+ test(`Calls onChange with the event and the checked value when the checkbox is clicked`, async () => {
113
+ const user = userEvent.setup();
114
+ const onChange = jest.fn();
115
+ render(<Checkbox id="test-id" onChange={onChange} />);
116
+
117
+ await user.click(screen.getByRole('checkbox'));
118
+
119
+ expect(onChange).toHaveBeenCalledWith(expect.objectContaining({ type: 'change' }), true);
120
+ });
121
+
122
+ test(`Calls onChange with the event and the checked value when the checkbox is clicked and isChecked is passed`, async () => {
123
+ const user = userEvent.setup();
124
+ const onChange = jest.fn();
125
+ render(<Checkbox id="test-id" isChecked onChange={onChange} />);
126
+
127
+ await user.click(screen.getByRole('checkbox'));
128
+
129
+ expect(onChange).toHaveBeenCalledWith(expect.objectContaining({ type: 'change' }), false);
130
+ });
131
+
132
+ test('Does not render a label by default', () => {
133
+ render(<Checkbox id="test-id" />);
134
+
135
+ expect(screen.queryByLabelText(/\w+/)).not.toBeInTheDocument();
136
+ });
137
+
138
+ test('Renders a label when label is passed', () => {
139
+ render(<Checkbox id="test-id" label="test label" />);
140
+
141
+ expect(screen.getByLabelText('test label')).toBeVisible();
142
+ });
143
+
144
+ test('Associates the label with the checkbox', () => {
145
+ render(<Checkbox id="test-id" label="test label" />);
146
+
147
+ expect(screen.getByRole('checkbox')).toHaveAccessibleName('test label');
148
+ });
149
+
150
+ test('Does not render an asterisk when a label is passed but isRequired is not', () => {
151
+ render(<Checkbox id="test-id" label="test label" />);
152
+
153
+ expect(screen.queryByText('*')).not.toBeInTheDocument();
154
+ });
155
+
156
+ test('Renders an asterisk when isRequired and a label are passed', () => {
157
+ render(<Checkbox id="test-id" isRequired label="test label" />);
158
+
159
+ expect(screen.getByText('*')).toBeVisible();
160
+ });
161
+
162
+ test(`Wraps the required asterisk in the ${styles.checkLabelRequired} className`, () => {
163
+ render(<Checkbox id="test-id" isRequired label="test label" />);
164
+
165
+ expect(screen.getByText('*')).toHaveClass(styles.checkLabelRequired, { exact: true });
166
+ });
167
+
168
+ test('Renders with the provided id', () => {
169
+ render(<Checkbox id="test-id" />);
170
+
171
+ expect(screen.getByRole('checkbox')).toHaveAttribute('id', 'test-id');
172
+ });
173
+
174
+ test('Does not render an aria-label by default', () => {
175
+ render(<Checkbox id="test-id" />);
176
+
177
+ expect(screen.getByRole('checkbox')).not.toHaveAttribute('aria-label');
178
+ });
179
+
180
+ test('Sets the name to the passed aria-label', () => {
181
+ render(<Checkbox id="test-id" aria-label="test aria-label" />);
182
+
183
+ expect(screen.getByRole('checkbox')).toHaveAccessibleName('test aria-label');
184
+ });
185
+
186
+ test('Does not render a description by default', () => {
187
+ render(<Checkbox id="test-id" />);
188
+
189
+ expect(screen.queryByText(/\w+/)).not.toBeInTheDocument();
190
+ });
191
+
192
+ test('Renders a description when description is passed', () => {
193
+ render(<Checkbox id="test-id" description="test description" />);
194
+
195
+ expect(screen.getByText('test description')).toBeVisible();
196
+ });
197
+
198
+ test(`Renders the passed description with the ${styles.checkDescription} className`, () => {
199
+ render(<Checkbox id="test-id" description="test description" />);
200
+
201
+ expect(screen.getByText('test description')).toHaveClass(styles.checkDescription, { exact: true });
202
+ });
203
+
204
+ test('Does not render a body by default', () => {
205
+ render(<Checkbox id="test-id" />);
206
+
207
+ expect(screen.queryByText(/\w+/)).not.toBeInTheDocument();
208
+ });
209
+
210
+ test('Renders a body when body is passed', () => {
211
+ render(<Checkbox id="test-id" body="test body" />);
212
+
213
+ expect(screen.getByText('test body')).toBeVisible();
214
+ });
215
+
216
+ test(`Renders the passed body with the ${styles.checkBody} className`, () => {
217
+ render(<Checkbox id="test-id" body="test body" />);
218
+
219
+ expect(screen.getByText('test body')).toHaveClass(styles.checkBody, { exact: true });
220
+ });
221
+
222
+ test('Renders the check wrapper as a div by default', () => {
223
+ render(<Checkbox id="test-id" />);
224
+
225
+ expect(screen.getByRole('checkbox').parentElement?.tagName).toBe('DIV');
226
+ });
227
+
228
+ test('Renders with the provided component', () => {
229
+ render(<Checkbox id="test-id" component="span" />);
230
+
231
+ expect(screen.getByRole('checkbox').parentElement?.tagName).toBe('SPAN');
232
+ });
233
+
234
+ test(`Spreads additional props`, () => {
235
+ render(<Checkbox id="test-id" data-testid="test-id" />);
236
+
237
+ expect(screen.getByTestId('test-id')).toBeInTheDocument();
238
+ });
239
+
240
+ test(`Sets the checkbox as checked by default when defaultChecked is passed`, () => {
241
+ render(<Checkbox id="test-id" defaultChecked />);
242
+
243
+ expect(screen.getByRole('checkbox')).toBeChecked();
244
+ });
245
+
246
+ test('Matches snapshot', () => {
247
+ const { asFragment } = render(<Checkbox id="test-id" ouiaId="ouia-id" />);
248
+
249
+ expect(asFragment()).toMatchSnapshot();
96
250
  });
@@ -1,212 +1,17 @@
1
1
  // Jest Snapshot v1, https://goo.gl/fbAQLP
2
2
 
3
- exports[`Checkbox controlled - 3rd state 1`] = `
3
+ exports[`Matches snapshot 1`] = `
4
4
  <DocumentFragment>
5
5
  <div
6
6
  class="pf-v5-c-check pf-m-standalone"
7
7
  >
8
8
  <input
9
9
  aria-invalid="false"
10
- aria-label="check"
11
10
  class="pf-v5-c-check__input"
12
- data-ouia-component-id="OUIA-Generated-Checkbox-2"
11
+ data-ouia-component-id="ouia-id"
13
12
  data-ouia-component-type="PF5/Checkbox"
14
13
  data-ouia-safe="true"
15
- id="check"
16
- type="checkbox"
17
- />
18
- </div>
19
- </DocumentFragment>
20
- `;
21
-
22
- exports[`Checkbox controlled 1`] = `
23
- <DocumentFragment>
24
- <div
25
- class="pf-v5-c-check pf-m-standalone"
26
- >
27
- <input
28
- aria-invalid="false"
29
- aria-label="check"
30
- checked=""
31
- class="pf-v5-c-check__input"
32
- data-ouia-component-id="OUIA-Generated-Checkbox-1"
33
- data-ouia-component-type="PF5/Checkbox"
34
- data-ouia-safe="true"
35
- id="check"
36
- type="checkbox"
37
- />
38
- </div>
39
- </DocumentFragment>
40
- `;
41
-
42
- exports[`Checkbox isDisabled 1`] = `
43
- <DocumentFragment>
44
- <div
45
- class="pf-v5-c-check pf-m-standalone"
46
- >
47
- <input
48
- aria-invalid="false"
49
- aria-label="check"
50
- class="pf-v5-c-check__input"
51
- data-ouia-component-id="OUIA-Generated-Checkbox-4"
52
- data-ouia-component-type="PF5/Checkbox"
53
- data-ouia-safe="true"
54
- disabled=""
55
- id="check"
56
- type="checkbox"
57
- />
58
- </div>
59
- </DocumentFragment>
60
- `;
61
-
62
- exports[`Checkbox label is function 1`] = `
63
- <DocumentFragment>
64
- <div
65
- class="pf-v5-c-check"
66
- >
67
- <input
68
- aria-invalid="false"
69
- aria-label="check"
70
- checked=""
71
- class="pf-v5-c-check__input"
72
- data-ouia-component-id="OUIA-Generated-Checkbox-6"
73
- data-ouia-component-type="PF5/Checkbox"
74
- data-ouia-safe="true"
75
- id="check"
76
- type="checkbox"
77
- />
78
- <label
79
- class="pf-v5-c-check__label"
80
- for="check"
81
- >
82
- <h1>
83
- Header
84
- </h1>
85
- </label>
86
- </div>
87
- </DocumentFragment>
88
- `;
89
-
90
- exports[`Checkbox label is node 1`] = `
91
- <DocumentFragment>
92
- <div
93
- class="pf-v5-c-check"
94
- >
95
- <input
96
- aria-invalid="false"
97
- aria-label="check"
98
- checked=""
99
- class="pf-v5-c-check__input"
100
- data-ouia-component-id="OUIA-Generated-Checkbox-7"
101
- data-ouia-component-type="PF5/Checkbox"
102
- data-ouia-safe="true"
103
- id="check"
104
- type="checkbox"
105
- />
106
- <label
107
- class="pf-v5-c-check__label"
108
- for="check"
109
- >
110
- <h1>
111
- Header
112
- </h1>
113
- </label>
114
- </div>
115
- </DocumentFragment>
116
- `;
117
-
118
- exports[`Checkbox label is string 1`] = `
119
- <DocumentFragment>
120
- <div
121
- class="pf-v5-c-check"
122
- >
123
- <input
124
- aria-invalid="false"
125
- aria-label="check"
126
- checked=""
127
- class="pf-v5-c-check__input"
128
- data-ouia-component-id="OUIA-Generated-Checkbox-5"
129
- data-ouia-component-type="PF5/Checkbox"
130
- data-ouia-safe="true"
131
- id="check"
132
- type="checkbox"
133
- />
134
- <label
135
- class="pf-v5-c-check__label"
136
- for="check"
137
- >
138
- Label
139
- </label>
140
- </div>
141
- </DocumentFragment>
142
- `;
143
-
144
- exports[`Checkbox passing HTML attribute 1`] = `
145
- <DocumentFragment>
146
- <div
147
- class="pf-v5-c-check"
148
- >
149
- <input
150
- aria-invalid="false"
151
- aria-label="check"
152
- aria-labelledby="labelId"
153
- checked=""
154
- class="pf-v5-c-check__input"
155
- data-ouia-component-id="OUIA-Generated-Checkbox-9"
156
- data-ouia-component-type="PF5/Checkbox"
157
- data-ouia-safe="true"
158
- id="check"
159
- type="checkbox"
160
- />
161
- <label
162
- class="pf-v5-c-check__label"
163
- for="check"
164
- >
165
- label
166
- </label>
167
- </div>
168
- </DocumentFragment>
169
- `;
170
-
171
- exports[`Checkbox passing class 1`] = `
172
- <DocumentFragment>
173
- <div
174
- class="pf-v5-c-check class-123"
175
- >
176
- <input
177
- aria-invalid="false"
178
- aria-label="check"
179
- checked=""
180
- class="pf-v5-c-check__input"
181
- data-ouia-component-id="OUIA-Generated-Checkbox-8"
182
- data-ouia-component-type="PF5/Checkbox"
183
- data-ouia-safe="true"
184
- id="check"
185
- type="checkbox"
186
- />
187
- <label
188
- class="pf-v5-c-check__label"
189
- for="check"
190
- >
191
- label
192
- </label>
193
- </div>
194
- </DocumentFragment>
195
- `;
196
-
197
- exports[`Checkbox uncontrolled 1`] = `
198
- <DocumentFragment>
199
- <div
200
- class="pf-v5-c-check pf-m-standalone"
201
- >
202
- <input
203
- aria-invalid="false"
204
- aria-label="check"
205
- class="pf-v5-c-check__input"
206
- data-ouia-component-id="OUIA-Generated-Checkbox-3"
207
- data-ouia-component-type="PF5/Checkbox"
208
- data-ouia-safe="true"
209
- id="check"
14
+ id="test-id"
210
15
  type="checkbox"
211
16
  />
212
17
  </div>
@@ -2,7 +2,7 @@ import * as React from 'react';
2
2
  import styles from '@patternfly/react-styles/css/components/Drawer/drawer';
3
3
  import { css } from '@patternfly/react-styles';
4
4
  import { DrawerColorVariant, DrawerContext } from './Drawer';
5
- import { formatBreakpointMods } from '../../helpers/util';
5
+ import { formatBreakpointMods, getLanguageDirection } from '../../helpers/util';
6
6
  import { GenerateId } from '../../helpers/GenerateId/GenerateId';
7
7
  import { FocusTrap } from '../../helpers/FocusTrap/FocusTrap';
8
8
  import cssPanelMdFlexBasis from '@patternfly/react-tokens/dist/esm/c_drawer__panel_md_FlexBasis';
@@ -111,7 +111,7 @@ export const DrawerPanelContent: React.FunctionComponent<DrawerPanelContentProps
111
111
  const calcValueNow = () => {
112
112
  let splitterPos;
113
113
  let drawerSize;
114
- const isRTL = window.getComputedStyle(panel.current).getPropertyValue('direction') === 'rtl';
114
+ const isRTL = getLanguageDirection(panel.current) === 'rtl';
115
115
 
116
116
  if (isInline && (position === 'end' || position === 'right')) {
117
117
  if (isRTL) {
@@ -198,7 +198,7 @@ export const DrawerPanelContent: React.FunctionComponent<DrawerPanelContentProps
198
198
  };
199
199
 
200
200
  const handleControlMove = (e: MouseEvent | TouchEvent, controlPosition: number) => {
201
- const isRTL = window.getComputedStyle(panel.current).getPropertyValue('direction') === 'rtl';
201
+ const isRTL = getLanguageDirection(panel.current) === 'rtl';
202
202
 
203
203
  e.stopPropagation();
204
204
  if (!isResizing) {
@@ -264,7 +264,7 @@ export const DrawerPanelContent: React.FunctionComponent<DrawerPanelContentProps
264
264
  const callbackMouseUp = React.useCallback(handleMouseup, []);
265
265
 
266
266
  const handleKeys = (e: React.KeyboardEvent) => {
267
- const isRTL = window.getComputedStyle(panel.current).getPropertyValue('direction') === 'rtl';
267
+ const isRTL = getLanguageDirection(panel.current) === 'rtl';
268
268
 
269
269
  const key = e.key;
270
270
  if (
@@ -19,6 +19,8 @@ export interface DropdownPopperProps {
19
19
  enableFlip?: boolean;
20
20
  /** The container to append the popper to. Defaults to 'inline'. */
21
21
  appendTo?: HTMLElement | (() => HTMLElement) | 'inline';
22
+ /** Flag to prevent the popper from overflowing its container and becoming partially obscured. */
23
+ preventOverflow?: boolean;
22
24
  }
23
25
 
24
26
  export interface DropdownToggleProps {
@@ -143,7 +143,7 @@ class ExpandableSection extends React.Component<ExpandableSectionProps, Expandab
143
143
  componentDidUpdate(prevProps: ExpandableSectionProps) {
144
144
  if (
145
145
  this.props.variant === ExpandableSectionVariant.truncate &&
146
- prevProps.truncateMaxLines !== this.props.truncateMaxLines
146
+ (prevProps.truncateMaxLines !== this.props.truncateMaxLines || prevProps.children !== this.props.children)
147
147
  ) {
148
148
  const expandableContent = this.expandableContentRef.current;
149
149
  setLineClamp(this.props.truncateMaxLines, expandableContent);
@@ -311,7 +311,8 @@ class MenuBase extends React.Component<MenuProps, MenuState> {
311
311
  noHorizontalArrowHandling={
312
312
  document.activeElement &&
313
313
  (document.activeElement.classList.contains(breadcrumbStyles.breadcrumbLink) ||
314
- document.activeElement.classList.contains(dropdownStyles.dropdownToggle))
314
+ document.activeElement.classList.contains(dropdownStyles.dropdownToggle) ||
315
+ document.activeElement.tagName === 'INPUT')
315
316
  }
316
317
  noEnterHandling
317
318
  noSpaceHandling
@@ -14,6 +14,8 @@ export interface MenuPopperProps {
14
14
  maxWidth?: string | 'trigger';
15
15
  /** Enable to flip the popper when it reaches the boundary */
16
16
  enableFlip?: boolean;
17
+ /** Flag to prevent the popper from overflowing its container and becoming partially obscured. */
18
+ preventOverflow?: boolean;
17
19
  }
18
20
  export interface MenuContainerProps {
19
21
  /** Menu to be rendered */
@@ -3,7 +3,7 @@ import styles from '@patternfly/react-styles/css/components/Nav/nav';
3
3
  import { css } from '@patternfly/react-styles';
4
4
  import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
5
5
  import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
6
- import { isElementInView } from '../../helpers/util';
6
+ import { getLanguageDirection, isElementInView } from '../../helpers/util';
7
7
  import { NavContext } from './Nav';
8
8
  import { PageSidebarContext } from '../Page/PageSidebar';
9
9
  import { getResizeObserver } from '../../helpers/resizeObserver';
@@ -112,7 +112,7 @@ class NavList extends React.Component<NavListProps> {
112
112
 
113
113
  componentDidMount() {
114
114
  this.observer = getResizeObserver(this.navList.current, this.handleScrollButtons, true);
115
- this.direction = getComputedStyle(this.navList.current).getPropertyValue('direction');
115
+ this.direction = getLanguageDirection(this.navList.current);
116
116
  this.handleScrollButtons();
117
117
  }
118
118
 
@@ -121,7 +121,7 @@ class NavList extends React.Component<NavListProps> {
121
121
  }
122
122
 
123
123
  componentDidUpdate() {
124
- this.direction = getComputedStyle(this.navList.current).getPropertyValue('direction');
124
+ this.direction = getLanguageDirection(this.navList.current);
125
125
  }
126
126
 
127
127
  render() {