@patternfly/react-core 5.0.0-alpha.42 → 5.0.0-alpha.43

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@patternfly/react-core",
-  "version": "5.0.0-alpha.42",
+  "version": "5.0.0-alpha.43",
   "description": "This library provides a set of common React components for use with the PatternFly reference implementation.",
   "main": "dist/js/index.js",
   "module": "dist/esm/index.js",
@@ -70,5 +70,5 @@
     "react": "^17 || ^18",
     "react-dom": "^17 || ^18"
   },
-  "gitHead": "966feee1c2aac99d2f7dfa6e59199cdd2f9db811"
+  "gitHead": "1c0a7e2579922f20207946a8f8beb0fe1217ed34"
 }

package/src/components/Dropdown/DropdownToggleCheckbox.tsx

@@ -21,7 +21,7 @@ export interface DropdownToggleCheckboxProps
   /** Alternate Flag to show if the checkbox is checked */
   checked?: boolean | null;
   /** A callback for when the checkbox selection changes */
-  onChange?: (checked: boolean, event: React.FormEvent<HTMLInputElement>) => void;
+  onChange?: (event: React.FormEvent<HTMLInputElement>, checked: boolean) => void;
   /** Element to be rendered inside the <span> */
   children?: React.ReactNode;
   /** Id of the checkbox */
@@ -55,7 +55,7 @@ export class DropdownToggleCheckbox extends React.Component<DropdownToggleCheckb
   }
 
   handleChange = (event: React.FormEvent<HTMLInputElement>) => {
-    this.props.onChange?.((event.target as HTMLInputElement).checked, event);
+    this.props.onChange?.(event, (event.target as HTMLInputElement).checked);
   };
 
   calculateChecked = () => {
@@ -111,7 +111,7 @@ export class DropdownToggleCheckbox extends React.Component<DropdownToggleCheckb
           {...props}
           {...(this.calculateChecked() !== undefined && { onChange: this.handleChange })}
           type="checkbox"
-          ref={elem => elem && (elem.indeterminate = isChecked === null)}
+          ref={(elem) => elem && (elem.indeterminate = isChecked === null)}
           aria-invalid={!isValid}
           disabled={isDisabled}
           checked={this.calculateChecked()}

package/src/components/Dropdown/__tests__/DropdownToggleCheckbox.test.tsx

@@ -56,10 +56,10 @@ describe('DropdownToggleCheckbox', () => {
 
   test('checkbox passes value and event to onChange handler', async () => {
     const user = userEvent.setup();
-    
+
     render(<DropdownToggleCheckbox id="check" {...props} aria-label="check" />);
 
     await user.click(screen.getByRole('checkbox'));
-    expect(props.onChange).toHaveBeenCalledWith(true, expect.any(Object));
+    expect(props.onChange).toHaveBeenCalledWith(expect.any(Object), true);
   });
 });

package/src/components/Dropdown/examples/DropdownSplitButtonProgressCheckbox.tsx

@@ -97,7 +97,7 @@ export const DropdownSplitButtonProgressCheckbox: React.FunctionComponent = () =
           <DropdownToggle
             splitButtonItems={[
               <DropdownToggleCheckbox
-                onChange={onChange1}
+                onChange={(_, checked) => onChange1(checked)}
                 isChecked={isChecked1}
                 isInProgress={!isTimedOut1}
                 id="split-button-progress-toggle-checkbox"
@@ -118,7 +118,7 @@ export const DropdownSplitButtonProgressCheckbox: React.FunctionComponent = () =
           <DropdownToggle
             splitButtonItems={[
               <DropdownToggleCheckbox
-                onChange={onChange2}
+                onChange={(_, checked) => onChange2(checked)}
                 isChecked={isChecked2}
                 isInProgress={!isTimedOut2}
                 id="split-button-progress-text-checkbox"