@patternfly/react-core 4.237.6 → 4.237.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@patternfly/react-core",
-  "version": "4.237.6",
+  "version": "4.237.7",
   "description": "This library provides a set of common React components for use with the PatternFly reference implementation.",
   "main": "dist/js/index.js",
   "module": "dist/esm/index.js",
@@ -44,9 +44,9 @@
     "generate": "node scripts/copyStyles.js"
   },
   "dependencies": {
-    "@patternfly/react-icons": "^4.88.6",
-    "@patternfly/react-styles": "^4.87.6",
-    "@patternfly/react-tokens": "^4.89.6",
+    "@patternfly/react-icons": "^4.88.7",
+    "@patternfly/react-styles": "^4.87.7",
+    "@patternfly/react-tokens": "^4.89.7",
     "focus-trap": "6.9.2",
     "react-dropzone": "9.0.0",
     "tippy.js": "5.1.2",
@@ -70,5 +70,5 @@
     "react": "^16.8.0 || ^17.0.0",
     "react-dom": "^16.8.0 || ^17.0.0"
   },
-  "gitHead": "55fff2303d14e704bf9c55a5d5f2866e16a83a05"
+  "gitHead": "6a8c488ab5de48d31ab8070271ebf17f9e6a625a"
 }

package/src/components/Button/examples/Button.md

@@ -96,21 +96,9 @@ Router links can be used for in-app linking in React environments to prevent pag
 
 Buttons that are aria-disabled are similar to normal disabled buttons, except they can receive focus. Every button variant can be aria-disabled using the `isAriaDisabled` property.
 
-```ts file="./ButtonAriaDisabled.tsx"
-```
-
-### Aria-disabled with tooltip
-
-Unlike normal disabled buttons, aria-disabled buttons can support tooltips.
-
-```ts file="./ButtonAriaDisabledTooltip.tsx"
-```
-
-### Aria-disabled link as button with tooltip
-
-Aria-disabled buttons can operate as links, which also support tooltips.
+Unlike normal disabled buttons, aria-disabled buttons can support tooltips. Furthermore, aria-disabled buttons can operate as links, which also support tooltips.
 
-```ts file="./ButtonAriaDisabledLinkTooltip.tsx"
+```ts file="./ButtonAriaDisabled.tsx"
 ```
 
 ### Button with count
@@ -118,4 +106,4 @@ Aria-disabled buttons can operate as links, which also support tooltips.
 Buttons can display a `count` in the form of a badge to indicate some value or number by passing in the `countOptions` prop as a `BadgeCountObject` object. The `BadgeCountObject` object will handle `count`, `isRead`, and `className` props for the badge count.
 
 ```ts file="./ButtonWithCount.tsx" isBeta
-```
+```

package/src/components/Button/examples/ButtonAriaDisabled.tsx

@@ -1,11 +1,12 @@
 import React from 'react';
-import { Button } from '@patternfly/react-core';
+import { Button, Tooltip } from '@patternfly/react-core';
 import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon';
 import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
 
 export const ButtonAriaDisabled: React.FunctionComponent = () => (
   <React.Fragment>
-    <Button isAriaDisabled>Primary aria disabled</Button> <Button isAriaDisabled>Secondary aria disabled</Button>{' '}
+    <Button isAriaDisabled>Primary aria disabled</Button>
+    <Button isAriaDisabled>Secondary aria disabled</Button>{' '}
     <Button variant="secondary" isDanger isAriaDisabled>
       Danger secondary aria disabled
     </Button>{' '}
@@ -35,5 +36,17 @@ export const ButtonAriaDisabled: React.FunctionComponent = () => (
     <Button isAriaDisabled variant="control">
       Control aria disabled
     </Button>
+    <br />
+    <br />
+    <Tooltip content="Aria-disabled buttons are like disabled buttons, but focusable. Allows for tooltip support.">
+      <Button isAriaDisabled variant="secondary">
+        Secondary button to core docs
+      </Button>
+    </Tooltip>{' '}
+    <Tooltip content="Aria-disabled link as button with tooltip">
+      <Button component="a" isAriaDisabled href="https://pf4.patternfly.org/" target="_blank" variant="tertiary">
+        Tertiary link as button to core docs
+      </Button>
+    </Tooltip>
   </React.Fragment>
 );

package/src/components/MenuToggle/MenuToggle.tsx

@@ -149,6 +149,7 @@ export class MenuToggleBase extends React.Component<MenuToggleProps> {
             aria-expanded={isExpanded}
             aria-label={ariaLabel}
             disabled={isDisabled}
+            onClick={onClick}
             {...otherProps}
           >
             {toggleControls}

package/src/components/MenuToggle/__tests__/MenuToggle.test.tsx

@@ -1,9 +1,11 @@
 import React from 'react';
-import { render } from '@testing-library/react';
 import { MenuToggle } from '../MenuToggle';
+import { MenuToggleCheckbox } from '../MenuToggleCheckbox';
 import { Badge } from '../../Badge';
 import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
 import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
+import userEvent from '@testing-library/user-event';
+import { fireEvent, render, screen } from '@testing-library/react';
 
 describe('menu toggle', () => {
   test('renders successfully', () => {
@@ -54,4 +56,28 @@ describe('menu toggle', () => {
     const { asFragment } = render(<MenuToggle badge={<Badge>badge</Badge>}>Toggle</MenuToggle>);
     expect(asFragment()).toMatchSnapshot();
   });
+
+  test('split toggle passes onClick', async () => {
+    const mockClick = jest.fn();
+    const user = userEvent.setup();
+
+    render(<MenuToggle
+      onClick={mockClick}
+      splitButtonOptions={{
+        items: [
+          <MenuToggleCheckbox
+            id="split-button-checkbox-with-text-disabled-example"
+            key="split-checkbox-with-text-disabled"
+            aria-label="Select all"
+          >
+            10 selected
+          </MenuToggleCheckbox>
+        ]
+      }}
+      aria-label="Menu toggle with checkbox split button and text"
+    />);
+
+    await user.click(screen.getByRole(`button`) as Element);
+    expect(mockClick).toHaveBeenCalled();
+  });
 });

package/src/components/Button/examples/ButtonAriaDisabledLinkTooltip.tsx

@@ -1,10 +0,0 @@
-import React from 'react';
-import { Button, Tooltip } from '@patternfly/react-core';
-
-export const ButtonAriaDisabledLinkTooltip: React.FunctionComponent = () => (
-  <Tooltip content="Aria-disabled link as button with tooltip">
-    <Button component="a" isAriaDisabled href="https://pf4.patternfly.org/" target="_blank" variant="tertiary">
-      Tertiary link as button to core docs
-    </Button>
-  </Tooltip>
-);

package/src/components/Button/examples/ButtonAriaDisabledTooltip.tsx

@@ -1,10 +0,0 @@
-import React from 'react';
-import { Button, Tooltip } from '@patternfly/react-core';
-
-export const ButtonAriaDisabledTooltip: React.FunctionComponent = () => (
-  <Tooltip content="Aria-disabled buttons are like disabled buttons, but focusable. Allows for tooltip support.">
-    <Button isAriaDisabled variant="secondary">
-      Secondary button to core docs
-    </Button>
-  </Tooltip>
-);