@patternfly/react-core 4.237.5 → 4.237.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@patternfly/react-core",
-  "version": "4.237.5",
+  "version": "4.237.8",
   "description": "This library provides a set of common React components for use with the PatternFly reference implementation.",
   "main": "dist/js/index.js",
   "module": "dist/esm/index.js",
@@ -44,16 +44,16 @@
     "generate": "node scripts/copyStyles.js"
   },
   "dependencies": {
-    "@patternfly/react-icons": "^4.88.5",
-    "@patternfly/react-styles": "^4.87.5",
-    "@patternfly/react-tokens": "^4.89.5",
+    "@patternfly/react-icons": "^4.88.8",
+    "@patternfly/react-styles": "^4.87.8",
+    "@patternfly/react-tokens": "^4.89.8",
     "focus-trap": "6.9.2",
     "react-dropzone": "9.0.0",
     "tippy.js": "5.1.2",
     "tslib": "^2.0.0"
   },
   "devDependencies": {
-    "@patternfly/patternfly": "4.214.1",
+    "@patternfly/patternfly": "4.215.0",
     "@rollup/plugin-commonjs": "^21.0.0",
     "@rollup/plugin-node-resolve": "^13.0.0",
     "@rollup/plugin-replace": "^3.0.0",
@@ -70,5 +70,5 @@
     "react": "^16.8.0 || ^17.0.0",
     "react-dom": "^16.8.0 || ^17.0.0"
   },
-  "gitHead": "418c3382f60536603adfb5b23d41dfbe03ddca39"
+  "gitHead": "655ddf36fb109c26211e803531627a92841587d1"
 }

package/src/components/Button/examples/Button.md

@@ -96,21 +96,9 @@ Router links can be used for in-app linking in React environments to prevent pag
 
 Buttons that are aria-disabled are similar to normal disabled buttons, except they can receive focus. Every button variant can be aria-disabled using the `isAriaDisabled` property.
 
-```ts file="./ButtonAriaDisabled.tsx"
-```
-
-### Aria-disabled with tooltip
-
-Unlike normal disabled buttons, aria-disabled buttons can support tooltips.
-
-```ts file="./ButtonAriaDisabledTooltip.tsx"
-```
-
-### Aria-disabled link as button with tooltip
-
-Aria-disabled buttons can operate as links, which also support tooltips.
+Unlike normal disabled buttons, aria-disabled buttons can support tooltips. Furthermore, aria-disabled buttons can operate as links, which also support tooltips.
 
-```ts file="./ButtonAriaDisabledLinkTooltip.tsx"
+```ts file="./ButtonAriaDisabled.tsx"
 ```
 
 ### Button with count
@@ -118,4 +106,4 @@ Aria-disabled buttons can operate as links, which also support tooltips.
 Buttons can display a `count` in the form of a badge to indicate some value or number by passing in the `countOptions` prop as a `BadgeCountObject` object. The `BadgeCountObject` object will handle `count`, `isRead`, and `className` props for the badge count.
 
 ```ts file="./ButtonWithCount.tsx" isBeta
-```
+```

package/src/components/Button/examples/ButtonAriaDisabled.tsx

@@ -1,11 +1,12 @@
 import React from 'react';
-import { Button } from '@patternfly/react-core';
+import { Button, Tooltip } from '@patternfly/react-core';
 import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon';
 import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
 
 export const ButtonAriaDisabled: React.FunctionComponent = () => (
   <React.Fragment>
-    <Button isAriaDisabled>Primary aria disabled</Button> <Button isAriaDisabled>Secondary aria disabled</Button>{' '}
+    <Button isAriaDisabled>Primary aria disabled</Button>
+    <Button isAriaDisabled>Secondary aria disabled</Button>{' '}
     <Button variant="secondary" isDanger isAriaDisabled>
       Danger secondary aria disabled
     </Button>{' '}
@@ -35,5 +36,17 @@ export const ButtonAriaDisabled: React.FunctionComponent = () => (
     <Button isAriaDisabled variant="control">
       Control aria disabled
     </Button>
+    <br />
+    <br />
+    <Tooltip content="Aria-disabled buttons are like disabled buttons, but focusable. Allows for tooltip support.">
+      <Button isAriaDisabled variant="secondary">
+        Secondary button to core docs
+      </Button>
+    </Tooltip>{' '}
+    <Tooltip content="Aria-disabled link as button with tooltip">
+      <Button component="a" isAriaDisabled href="https://pf4.patternfly.org/" target="_blank" variant="tertiary">
+        Tertiary link as button to core docs
+      </Button>
+    </Tooltip>
   </React.Fragment>
 );

package/src/components/Checkbox/Checkbox.tsx

@@ -3,20 +3,23 @@ import styles from '@patternfly/react-styles/css/components/Check/check';
 import { css } from '@patternfly/react-styles';
 import { PickOptional } from '../../helpers/typeUtils';
 import { getDefaultOUIAId, getOUIAProps, OUIAProps } from '../../helpers';
+import { ASTERISK } from '../../helpers/htmlConstants';
 
 export interface CheckboxProps
   extends Omit<React.HTMLProps<HTMLInputElement>, 'type' | 'onChange' | 'disabled' | 'label'>,
     OUIAProps {
-  /** Additional classes added to the Checkbox. */
+  /** Additional classes added to the checkbox. */
   className?: string;
-  /** Flag to show if the Checkbox selection is valid or invalid. */
+  /** Flag to show if the checkbox selection is valid or invalid. */
   isValid?: boolean;
-  /** Flag to show if the Checkbox is disabled. */
+  /** Flag to show if the checkbox is disabled. */
   isDisabled?: boolean;
-  /** Flag to show if the Checkbox is checked. If null, the checkbox will be indeterminate (partially checked). */
+  /** Flag to show if the checkbox is required. */
+  isRequired?: boolean;
+  /** Flag to show if the checkbox is checked. If null, the checkbox will be indeterminate (partially checked). */
   isChecked?: boolean | null;
   checked?: boolean;
-  /** A callback for when the Checkbox selection changes. */
+  /** A callback for when the checkbox selection changes. */
   onChange?: (checked: boolean, event: React.FormEvent<HTMLInputElement>) => void;
   /** Label text of the checkbox. */
   label?: React.ReactNode;
@@ -45,6 +48,7 @@ export class Checkbox extends React.Component<CheckboxProps, CheckboxState> {
     className: '',
     isValid: true,
     isDisabled: false,
+    isRequired: false,
     isChecked: false,
     onChange: defaultOnChange,
     ouiaSafe: true,
@@ -69,6 +73,7 @@ export class Checkbox extends React.Component<CheckboxProps, CheckboxState> {
       onChange,
       isValid,
       isDisabled,
+      isRequired,
       isChecked,
       label,
       checked,
@@ -106,6 +111,7 @@ export class Checkbox extends React.Component<CheckboxProps, CheckboxState> {
           aria-invalid={!isValid}
           aria-label={ariaLabel}
           disabled={isDisabled}
+          required={isRequired}
           ref={elem => elem && (elem.indeterminate = isChecked === null)}
           {...checkedProps}
           {...getOUIAProps(Checkbox.displayName, ouiaId !== undefined ? ouiaId : this.state.ouiaStateId, ouiaSafe)}
@@ -113,6 +119,11 @@ export class Checkbox extends React.Component<CheckboxProps, CheckboxState> {
         {label && (
           <label className={css(styles.checkLabel, isDisabled && styles.modifiers.disabled)} htmlFor={props.id}>
             {label}
+            {isRequired && (
+              <span className={css(styles.checkLabelRequired)} aria-hidden="true">
+                {ASTERISK}
+              </span>
+            )}
           </label>
         )}
         {description && <span className={css(styles.checkDescription)}>{description}</span>}

package/src/components/Checkbox/examples/Checkbox.md

@@ -43,3 +43,8 @@ import './checkbox.css';
 
 ```ts file='./CheckboxStandaloneInput.tsx'
 ```
+
+### Required input
+
+```ts file='./CheckboxRequired.tsx'
+```

package/src/components/Checkbox/examples/CheckboxRequired.tsx

@@ -0,0 +1,6 @@
+import React from 'react';
+import { Checkbox } from '@patternfly/react-core';
+
+export const CheckboxRequired: React.FunctionComponent = () => (
+  <Checkbox label="Required checkbox" isRequired id="required-check" name="required-check" />
+);

package/src/components/MenuToggle/MenuToggle.tsx

@@ -149,6 +149,7 @@ export class MenuToggleBase extends React.Component<MenuToggleProps> {
             aria-expanded={isExpanded}
             aria-label={ariaLabel}
             disabled={isDisabled}
+            onClick={onClick}
             {...otherProps}
           >
             {toggleControls}

package/src/components/MenuToggle/__tests__/MenuToggle.test.tsx

@@ -1,9 +1,11 @@
 import React from 'react';
-import { render } from '@testing-library/react';
 import { MenuToggle } from '../MenuToggle';
+import { MenuToggleCheckbox } from '../MenuToggleCheckbox';
 import { Badge } from '../../Badge';
 import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
 import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
+import userEvent from '@testing-library/user-event';
+import { fireEvent, render, screen } from '@testing-library/react';
 
 describe('menu toggle', () => {
   test('renders successfully', () => {
@@ -54,4 +56,28 @@ describe('menu toggle', () => {
     const { asFragment } = render(<MenuToggle badge={<Badge>badge</Badge>}>Toggle</MenuToggle>);
     expect(asFragment()).toMatchSnapshot();
   });
+
+  test('split toggle passes onClick', async () => {
+    const mockClick = jest.fn();
+    const user = userEvent.setup();
+
+    render(<MenuToggle
+      onClick={mockClick}
+      splitButtonOptions={{
+        items: [
+          <MenuToggleCheckbox
+            id="split-button-checkbox-with-text-disabled-example"
+            key="split-checkbox-with-text-disabled"
+            aria-label="Select all"
+          >
+            10 selected
+          </MenuToggleCheckbox>
+        ]
+      }}
+      aria-label="Menu toggle with checkbox split button and text"
+    />);
+
+    await user.click(screen.getByRole(`button`) as Element);
+    expect(mockClick).toHaveBeenCalled();
+  });
 });

package/src/components/TreeView/examples/TreeView.md

@@ -20,12 +20,15 @@ class DefaultTreeView extends React.Component {
   constructor(props) {
     super(props);
 
-    this.state = { activeItems: {}, allExpanded: null };
+    this.state = { activeItems: [], allExpanded: null };
 
     this.onSelect = (evt, treeViewItem) => {
-      this.setState({
-        activeItems: [treeViewItem]
-      });
+      // Ignore folders for selection
+      if (treeViewItem && !treeViewItem.children) {
+        this.setState({
+          activeItems: [treeViewItem]
+        });
+      }
     };
 
     this.onToggle = evt => {
@@ -288,9 +291,12 @@ class SearchTreeView extends React.Component {
     this.state = { activeItems: {}, filteredItems: this.options, isFiltered: null };
 
     this.onSelect = (evt, treeViewItem) => {
-      this.setState({
-        activeItems: [treeViewItem]
-      });
+      // Ignore folders for selection
+      if (treeViewItem && !treeViewItem.children) {
+        this.setState({
+          activeItems: [treeViewItem]
+        });
+      }
     };
 
     this.onSearch = evt => {
@@ -575,9 +581,12 @@ class IconTreeView extends React.Component {
     this.state = { activeItems: {} };
 
     this.onSelect = (evt, treeViewItem) => {
-      this.setState({
-        activeItems: [treeViewItem]
-      });
+      // Ignore folders for selection
+      if (treeViewItem && !treeViewItem.children) {
+        this.setState({
+          activeItems: [treeViewItem]
+        });
+      }
     };
   }
 
@@ -668,9 +677,12 @@ class BadgesTreeView extends React.Component {
     this.state = { activeItems: {} };
 
     this.onSelect = (evt, treeViewItem) => {
-      this.setState({
-        activeItems: [treeViewItem]
-      });
+      // Ignore folders for selection
+      if (treeViewItem && !treeViewItem.children) {
+        this.setState({
+          activeItems: [treeViewItem]
+        });
+      }
     };
   }
 
@@ -753,9 +765,12 @@ class CustomBadgesTreeView extends React.Component {
     this.state = { activeItems: {} };
 
     this.onSelect = (evt, treeViewItem) => {
-      this.setState({
-        activeItems: [treeViewItem]
-      });
+      // Ignore folders for selection
+      if (treeViewItem && !treeViewItem.children) {
+        this.setState({
+          activeItems: [treeViewItem]
+        });
+      }
     };
   }
 
@@ -853,9 +868,12 @@ class IconTreeView extends React.Component {
     this.state = { activeItems: {}, isOpen: false };
 
     this.onSelect = (evt, treeViewItem) => {
-      this.setState({
-        activeItems: [treeViewItem]
-      });
+      // Ignore folders for selection
+      if (treeViewItem && !treeViewItem.children) {
+        this.setState({
+          activeItems: [treeViewItem]
+        });
+      }
     };
 
     this.onToggle = isOpen => {

package/src/demos/Filters/FilterDemos.md

@@ -0,0 +1,48 @@
+---
+id: Filters
+section: demos
+---
+
+import {
+Popper,
+SearchInput,
+Toolbar,
+ToolbarContent,
+ToolbarItem,
+Menu,
+MenuContent,
+MenuList,
+MenuItem,
+MenuToggle,
+MenuToggleCheckbox,
+ToolbarGroup,
+ToolbarFilter,
+Badge,
+Pagination,
+EmptyState,
+EmptyStateIcon,
+Title,
+EmptyStateBody,
+EmptyStatePrimary,
+Button
+} from '@patternfly/react-core';
+import FilterIcon from '@patternfly/react-icons/dist/esm/icons/filter-icon';
+import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
+import { TableComposable, Thead, Tr, Th, Tbody, Td } from '@patternfly/react-table';
+
+## Demos
+
+### Filtering with a search input
+
+```ts file="./examples/FilterSearchInput.tsx"
+```
+
+### Filtering with a single select
+
+```ts file="./examples/FilterSingleSelect.tsx"
+```
+
+### Filtering with a checkbox select
+
+```ts file="./examples/FilterCheckboxSelect.tsx"
+```