@patternfly/react-core 4.236.5 → 4.236.8

package/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap

@@ -49,7 +49,7 @@ exports[`SearchInput advanced search 1`] = `
             aria-disabled="false"
             aria-label="Reset"
             class="pf-c-button pf-m-plain"
-            data-ouia-component-id="OUIA-Generated-Button-plain-15"
+            data-ouia-component-id="OUIA-Generated-Button-plain-17"
             data-ouia-component-type="PF4/Button"
             data-ouia-safe="true"
             type="button"
@@ -75,7 +75,7 @@ exports[`SearchInput advanced search 1`] = `
         aria-expanded="false"
         aria-label="Open advanced search"
         class="pf-c-button pf-m-control"
-        data-ouia-component-id="OUIA-Generated-Button-control-6"
+        data-ouia-component-id="OUIA-Generated-Button-control-10"
         data-ouia-component-type="PF4/Button"
         data-ouia-safe="true"
         type="button"
@@ -98,7 +98,7 @@ exports[`SearchInput advanced search 1`] = `
         aria-disabled="false"
         aria-label="Search"
         class="pf-c-button pf-m-control"
-        data-ouia-component-id="OUIA-Generated-Button-control-7"
+        data-ouia-component-id="OUIA-Generated-Button-control-11"
         data-ouia-component-type="PF4/Button"
         data-ouia-safe="true"
         type="submit"
@@ -172,7 +172,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
             aria-disabled="false"
             aria-label="Reset"
             class="pf-c-button pf-m-plain"
-            data-ouia-component-id="OUIA-Generated-Button-plain-16"
+            data-ouia-component-id="OUIA-Generated-Button-plain-18"
             data-ouia-component-type="PF4/Button"
             data-ouia-safe="true"
             type="button"
@@ -198,7 +198,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
         aria-expanded="true"
         aria-label="Open advanced search"
         class="pf-c-button pf-m-control pf-m-expanded"
-        data-ouia-component-id="OUIA-Generated-Button-control-8"
+        data-ouia-component-id="OUIA-Generated-Button-control-12"
         data-ouia-component-type="PF4/Button"
         data-ouia-safe="true"
         type="button"
@@ -221,7 +221,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
         aria-disabled="false"
         aria-label="Search"
         class="pf-c-button pf-m-control"
-        data-ouia-component-id="OUIA-Generated-Button-control-9"
+        data-ouia-component-id="OUIA-Generated-Button-control-13"
         data-ouia-component-type="PF4/Button"
         data-ouia-safe="true"
         type="submit"
@@ -436,6 +436,130 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
 </DocumentFragment>
 `;
 
+exports[`SearchInput renders search input in strict mode 1`] = `
+<DocumentFragment>
+  <div
+    class=""
+  >
+    <div>
+      <div
+        class="pf-c-input-group"
+      >
+        <div
+          class="pf-c-text-input-group"
+        >
+          <div
+            class="pf-c-text-input-group__main pf-m-icon"
+          >
+            <span
+              class="pf-c-text-input-group__text"
+            >
+              <span
+                class="pf-c-text-input-group__icon"
+              >
+                <svg
+                  aria-hidden="true"
+                  fill="currentColor"
+                  height="1em"
+                  role="img"
+                  style="vertical-align: -0.125em;"
+                  viewBox="0 0 512 512"
+                  width="1em"
+                >
+                  <path
+                    d="M505 442.7L405.3 343c-4.5-4.5-10.6-7-17-7H372c27.6-35.3 44-79.7 44-128C416 93.1 322.9 0 208 0S0 93.1 0 208s93.1 208 208 208c48.3 0 92.7-16.4 128-44v16.3c0 6.4 2.5 12.5 7 17l99.7 99.7c9.4 9.4 24.6 9.4 33.9 0l28.3-28.3c9.4-9.4 9.4-24.6.1-34zM208 336c-70.7 0-128-57.2-128-128 0-70.7 57.2-128 128-128 70.7 0 128 57.2 128 128 0 70.7-57.2 128-128 128z"
+                  />
+                </svg>
+              </span>
+              <input
+                aria-label="Search input"
+                class="pf-c-text-input-group__text-input"
+                type="text"
+                value="username:player firstname:john"
+              />
+            </span>
+          </div>
+          <div
+            class="pf-c-text-input-group__utilities"
+          >
+            <button
+              aria-disabled="false"
+              aria-label="Reset"
+              class="pf-c-button pf-m-plain"
+              data-ouia-component-id="OUIA-Generated-Button-plain-11"
+              data-ouia-component-type="PF4/Button"
+              data-ouia-safe="true"
+              type="button"
+            >
+              <svg
+                aria-hidden="true"
+                fill="currentColor"
+                height="1em"
+                role="img"
+                style="vertical-align: -0.125em;"
+                viewBox="0 0 352 512"
+                width="1em"
+              >
+                <path
+                  d="M242.72 256l100.07-100.07c12.28-12.28 12.28-32.19 0-44.48l-22.24-22.24c-12.28-12.28-32.19-12.28-44.48 0L176 189.28 75.93 89.21c-12.28-12.28-32.19-12.28-44.48 0L9.21 111.45c-12.28 12.28-12.28 32.19 0 44.48L109.28 256 9.21 356.07c-12.28 12.28-12.28 32.19 0 44.48l22.24 22.24c12.28 12.28 32.2 12.28 44.48 0L176 322.72l100.07 100.07c12.28 12.28 32.2 12.28 44.48 0l22.24-22.24c12.28-12.28 12.28-32.19 0-44.48L242.72 256z"
+                />
+              </svg>
+            </button>
+          </div>
+        </div>
+        <button
+          aria-disabled="false"
+          aria-expanded="false"
+          aria-label="Open advanced search"
+          class="pf-c-button pf-m-control"
+          data-ouia-component-id="OUIA-Generated-Button-control-5"
+          data-ouia-component-type="PF4/Button"
+          data-ouia-safe="true"
+          type="button"
+        >
+          <svg
+            aria-hidden="true"
+            fill="currentColor"
+            height="1em"
+            role="img"
+            style="vertical-align: -0.125em;"
+            viewBox="0 0 320 512"
+            width="1em"
+          >
+            <path
+              d="M31.3 192h257.3c17.8 0 26.7 21.5 14.1 34.1L174.1 354.8c-7.8 7.8-20.5 7.8-28.3 0L17.2 226.1C4.6 213.5 13.5 192 31.3 192z"
+            />
+          </svg>
+        </button>
+        <button
+          aria-disabled="false"
+          aria-label="Search"
+          class="pf-c-button pf-m-control"
+          data-ouia-component-id="OUIA-Generated-Button-control-7"
+          data-ouia-component-type="PF4/Button"
+          data-ouia-safe="true"
+          type="submit"
+        >
+          <svg
+            aria-hidden="true"
+            fill="currentColor"
+            height="1em"
+            role="img"
+            style="vertical-align: -0.125em;"
+            viewBox="0 0 448 512"
+            width="1em"
+          >
+            <path
+              d="M190.5 66.9l22.2-22.2c9.4-9.4 24.6-9.4 33.9 0L441 239c9.4 9.4 9.4 24.6 0 33.9L246.6 467.3c-9.4 9.4-24.6 9.4-33.9 0l-22.2-22.2c-9.5-9.5-9.3-25 .4-34.3L311.4 296H24c-13.3 0-24-10.7-24-24v-32c0-13.3 10.7-24 24-24h287.4L190.9 101.2c-9.8-9.3-10-24.8-.4-34.3z"
+            />
+          </svg>
+        </button>
+      </div>
+    </div>
+  </div>
+</DocumentFragment>
+`;
+
 exports[`SearchInput search input with hint 1`] = `
 <DocumentFragment>
   <div

package/src/components/Select/Select.tsx

@@ -180,6 +180,8 @@ export interface SelectProps
    * appended inline, e.g. `menuAppendTo="parent"`
    */
   isFlipEnabled?: boolean;
+  /** @beta Opt-in for updated popper that does not use findDOMNode. */
+  removeFindDomNode?: boolean;
 }
 
 export interface SelectState {
@@ -254,7 +256,8 @@ export class Select extends React.Component<SelectProps & OUIAProps, SelectState
     isInputFilterPersisted: false,
     isCreateSelectOptionObject: false,
     shouldResetOnSelect: true,
-    isFlipEnabled: false
+    isFlipEnabled: false,
+    removeFindDomNode: false
   };
 
   state: SelectState = {
@@ -1005,6 +1008,7 @@ export class Select extends React.Component<SelectProps & OUIAProps, SelectState
       isCreateSelectOptionObject,
       shouldResetOnSelect,
       isFlipEnabled,
+      removeFindDomNode,
       ...props
     } = this.props;
     const {
@@ -1448,6 +1452,7 @@ export class Select extends React.Component<SelectProps & OUIAProps, SelectState
                 direction={direction}
                 appendTo={menuAppendTo === 'parent' ? getParentElement() : menuAppendTo}
                 isVisible={isOpen}
+                removeFindDomNode={removeFindDomNode}
               />
             )}
           </SelectContext.Provider>

package/src/components/Select/__tests__/Select.test.tsx

@@ -81,6 +81,27 @@ describe('Select', () => {
       );
       expect(asFragment()).toMatchSnapshot();
     });
+
+    test('renders expanded in strict mode successfully', () => {
+      const consoleError = jest.spyOn(console, 'error');
+      const { asFragment } = render(
+        <React.StrictMode>
+          <Select
+            removeFindDomNode
+            variant={SelectVariant.single}
+            onSelect={jest.fn()}
+            onToggle={jest.fn()}
+            isOpen
+            ouiaId="test-id"
+          >
+            {selectOptions}
+          </Select>
+        </React.StrictMode>
+      );
+      expect(consoleError).not.toHaveBeenCalled();
+      expect(asFragment()).toMatchSnapshot();
+    });
+
     test('renders expanded successfully with custom objects', () => {
       const { asFragment } = render(
         <Select variant={SelectVariant.single} onSelect={jest.fn()} onToggle={jest.fn()} isOpen ouiaId="test-id">
@@ -525,14 +546,9 @@ describe('select with placeholder', () => {
 
 test('applies focus styling to the create option when reached via keyboard navigation', async () => {
   const user = userEvent.setup();
-  
+
   render(
-    <Select
-      variant={SelectVariant.typeahead}
-      onToggle={() => {}}
-      isOpen
-      isCreatable
-    >
+    <Select variant={SelectVariant.typeahead} onToggle={() => {}} isOpen isCreatable>
       {selectOptions}
     </Select>
   );