@patternfly/react-core 4.226.2 → 4.227.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@patternfly/react-core",
-  "version": "4.226.2",
+  "version": "4.227.2",
   "description": "This library provides a set of common React components for use with the PatternFly reference implementation.",
   "main": "dist/js/index.js",
   "module": "dist/esm/index.js",
@@ -34,9 +34,9 @@
     "generate": "node scripts/copyStyles.js"
   },
   "dependencies": {
-    "@patternfly/react-icons": "^4.77.2",
-    "@patternfly/react-styles": "^4.76.2",
-    "@patternfly/react-tokens": "^4.78.2",
+    "@patternfly/react-icons": "^4.78.2",
+    "@patternfly/react-styles": "^4.77.2",
+    "@patternfly/react-tokens": "^4.79.2",
     "focus-trap": "6.9.2",
     "react-dropzone": "9.0.0",
     "tippy.js": "5.1.2",
@@ -60,5 +60,5 @@
     "react": "^16.8.0 || ^17.0.0",
     "react-dom": "^16.8.0 || ^17.0.0"
   },
-  "gitHead": "fb67d6b2dfbfd2b4080e1313101f4d663a0a09c3"
+  "gitHead": "cf751b0d9ad160595567d4d13942ba2d06813f29"
 }

package/src/components/Dropdown/DropdownToggle.tsx

@@ -120,6 +120,7 @@ export const DropdownToggle: React.FunctionComponent<DropdownToggleProps> = ({
           styles.modifiers.splitButton,
           splitButtonVariant === 'action' && styles.modifiers.action,
           (toggleVariant === 'primary' || isPrimary) && splitButtonVariant === 'action' && styles.modifiers.primary,
+          toggleVariant === 'secondary' && splitButtonVariant === 'action' && styles.modifiers.secondary,
           isDisabled && styles.modifiers.disabled
         )}
       >

package/src/components/Dropdown/__tests__/DropdownToggle.test.tsx

@@ -184,6 +184,24 @@ describe('DropdownToggle', () => {
       expect(asFragment()).toMatchSnapshot();
     });
 
+    test('action split button - renders secondary variant', () => {
+      const { asFragment } = render(
+        <DropdownToggle
+          id="Dropdown Toggle"
+          toggleVariant="secondary"
+          splitButtonItems={[<div key="1">test</div>]}
+          splitButtonVariant="action"
+          parentRef={document.createElement('div')}
+        >
+          Dropdown
+        </DropdownToggle>
+      );
+
+      const dropdownToggle = screen.getByRole('button').parentElement;
+
+      expect(dropdownToggle).toHaveClass('pf-m-secondary');
+    });
+
     test('class changes', () => {
       const { asFragment } = render(
         <DropdownContext.Provider

package/src/components/Dropdown/__tests__/__snapshots__/DropdownToggle.test.tsx.snap

@@ -198,7 +198,7 @@ exports[`DropdownToggle state class changes 1`] = `
   <button
     aria-expanded="false"
     class="pf-c-dropdown__toggle"
-    data-ouia-component-id="OUIA-Generated-DropdownToggle-13"
+    data-ouia-component-id="OUIA-Generated-DropdownToggle-14"
     data-ouia-component-type="PF4/DropdownToggle"
     data-ouia-safe="true"
     id="Dropdown Toggle"

package/src/components/Dropdown/examples/Dropdown.md

@@ -113,6 +113,11 @@ import avatarImg from '../../Avatar/examples/avatarImg.svg';
 ```ts file="./DropdownSplitButtonActionPrimary.tsx"
 ```
 
+### Split button secondary action
+
+```ts file="./DropdownSplitButtonActionSecondary.tsx"
+```
+
 ### Basic panel
 
 ```ts file="./DropdownBasicPanel.tsx"

package/src/components/Dropdown/examples/DropdownSplitButtonActionSecondary.tsx

@@ -0,0 +1,107 @@
+import React from 'react';
+import { Dropdown, DropdownToggle, DropdownToggleAction, DropdownItem } from '@patternfly/react-core';
+import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
+import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
+import CubesIcon from '@patternfly/react-icons/dist/esm/icons/cubes-icon';
+
+export const DropdownSplitButtonActionSecondary: React.FunctionComponent = () => {
+  const [isActionOpen, setIsActionOpen] = React.useState(false);
+  const [isCogOpen, setIsCogOpen] = React.useState(false);
+
+  const onActionToggle = (isActionOpen: boolean) => {
+    setIsActionOpen(isActionOpen);
+  };
+  const onCogToggle = (isCogOpen: boolean) => {
+    setIsCogOpen(isCogOpen);
+  };
+
+  const onActionClick = () => {
+    window.alert('You selected an action button!');
+  };
+  const onCogClick = () => {
+    window.alert('You selected the Cog!');
+  };
+
+  const onActionFocus = () => {
+    const element = document.getElementById('toggle-split-button-action-secondary');
+    element.focus();
+  };
+  const onCogFocus = () => {
+    const element = document.getElementById('toggle-split-button-cog-secondary');
+    element.focus();
+  };
+
+  const onActionSelect = () => {
+    setIsActionOpen(false);
+    onActionFocus();
+  };
+  const onCogSelect = () => {
+    setIsCogOpen(false);
+    onCogFocus();
+  };
+
+  const dropdownItems = [
+    <DropdownItem key="action" component="button" onClick={onActionClick}>
+      Action
+    </DropdownItem>,
+    <DropdownItem key="disabled link" component="button" isDisabled onClick={onActionClick}>
+      Disabled action
+    </DropdownItem>,
+    <DropdownItem key="other action" component="button" onClick={onActionClick}>
+      Other action
+    </DropdownItem>
+  ];
+
+  const dropdownIconItems = [
+    <DropdownItem key="action" component="button" icon={<CogIcon />} onClick={onActionClick}>
+      Action
+    </DropdownItem>,
+    <DropdownItem key="disabled link" component="button" icon={<BellIcon />} isDisabled onClick={onActionClick}>
+      Disabled action
+    </DropdownItem>,
+    <DropdownItem key="other action" component="button" icon={<CubesIcon />} onClick={onActionClick}>
+      Other action
+    </DropdownItem>
+  ];
+
+  return (
+    <React.Fragment>
+      <Dropdown
+        onSelect={onActionSelect}
+        toggle={
+          <DropdownToggle
+            id="toggle-split-button-action-secondary"
+            splitButtonItems={[
+              <DropdownToggleAction key="action" onClick={onActionClick}>
+                Action
+              </DropdownToggleAction>
+            ]}
+            toggleVariant="secondary"
+            splitButtonVariant="action"
+            onToggle={onActionToggle}
+          />
+        }
+        isOpen={isActionOpen}
+        dropdownItems={dropdownItems}
+      />{' '}
+      <Dropdown
+        onSelect={onCogSelect}
+        toggle={
+          <DropdownToggle
+            id="toggle-split-button-cog-secondary"
+            splitButtonItems={[
+              <DropdownToggleAction key="cog-action" aria-label="Action" onClick={onCogClick}>
+                <CogIcon />
+              </DropdownToggleAction>
+            ]}
+            toggleVariant="secondary"
+            splitButtonVariant="action"
+            onToggle={onCogToggle}
+          />
+        }
+        isOpen={isCogOpen}
+        dropdownItems={dropdownIconItems}
+      />
+    </React.Fragment>
+  );
+};

package/src/components/Page/examples/Page.md

@@ -89,7 +89,7 @@ class VerticalPage extends React.Component {
         <MastheadContent>{headerToolbar}</MastheadContent>
       </Masthead>
     );
-    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-sidebar" />;
 
     return (
       <Page header={Header} sidebar={Sidebar}>
@@ -262,7 +262,7 @@ class FillPage extends React.Component {
         <MastheadContent>{headerToolbar}</MastheadContent>
       </Masthead>
     );
-    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="fill-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="fill-sidebar" />;
 
     return (
       <Page header={Header} sidebar={Sidebar}>
@@ -344,7 +344,7 @@ class VerticalPage extends React.Component {
         <MastheadContent>{headerToolbar}</MastheadContent>
       </Masthead>
     );
-    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="main-padding-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="main-padding-sidebar" />;
 
     return (
       <Page header={Header} sidebar={Sidebar}>
@@ -410,7 +410,7 @@ class UncontrolledNavPage extends React.Component {
         <MastheadContent>{headerToolbar}</MastheadContent>
       </Masthead>
     );
-    const Sidebar = <PageSidebar nav="Navigation" id="uncontrolled-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" id="uncontrolled-sidebar" />;
 
     return (
       <Page isManagedSidebar header={Header} sidebar={Sidebar}>
@@ -497,7 +497,7 @@ class GroupPage extends React.Component {
         <MastheadContent>{headerToolbar}</MastheadContent>
       </Masthead>
     );
-    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="group-section-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="group-section-sidebar" />;
 
     return (
       <Page header={Header} sidebar={Sidebar}>
@@ -505,13 +505,21 @@ class GroupPage extends React.Component {
           <PageNavigation>
             <Nav aria-label="Group section navigation" variant="tertiary">
               <NavList>
-                <NavItem itemId={0} isActive>
+                <NavItem href="#" itemId={0} isActive>
                   System panel
                 </NavItem>
-                <NavItem itemId={1}>Policy</NavItem>
-                <NavItem itemId={2}>Authentication</NavItem>
-                <NavItem itemId={3}>Network services</NavItem>
-                <NavItem itemId={4}>Server</NavItem>
+                <NavItem href="#" itemId={1}>
+                  Policy
+                </NavItem>
+                <NavItem href="#" itemId={2}>
+                  Authentication
+                </NavItem>
+                <NavItem href="#" itemId={3}>
+                  Network services
+                </NavItem>
+                <NavItem href="#" itemId={4}>
+                  Server
+                </NavItem>
               </NavList>
             </Nav>
           </PageNavigation>
@@ -582,7 +590,7 @@ class VerticalPage extends React.Component {
         navToggleId="vertical-pageheader-toggle"
       />
     );
-    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-pageheader-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-pageheader-sidebar" />;
 
     return (
       <Page header={Header} sidebar={Sidebar}>
@@ -630,7 +638,12 @@ CenterAlignedPageSection = () => {
   const Header = (
     <Masthead>
       <MastheadToggle>
-        <PageToggleButton variant="plain" aria-label="Global navigation" onNavToggle={this.onNavToggle} id="centered-nav-toggle">
+        <PageToggleButton
+          variant="plain"
+          aria-label="Global navigation"
+          onNavToggle={this.onNavToggle}
+          id="centered-nav-toggle"
+        >
           <BarsIcon />
         </PageToggleButton>
       </MastheadToggle>

package/src/components/ProgressStepper/examples/ProgressStepper.md

@@ -15,387 +15,44 @@ Progress steppers have default icons associated with the `variant` property, and
 
 ### Basic
 
-```js
-import React from 'react';
-import { ProgressStepper, ProgressStep } from '@patternfly/react-core';
-
-<ProgressStepper>
-  <ProgressStep
-    variant="success"
-    id="basic-step1"
-    titleId="basic-step1-title"
-    aria-label="completed step, step with success"
-  >
-    First step
-  </ProgressStep>
-  <ProgressStep
-    variant="info"
-    isCurrent
-    id="basic-step2"
-    titleId="basic-step2-title"
-    aria-label="step with info"
-  >
-    Second step
-  </ProgressStep>
-  <ProgressStep variant="pending" id="basic-step3" titleId="basic-step3-title" aria-label="pending step">
-    Third step
-  </ProgressStep>
-</ProgressStepper>;
+```ts file="ProgressStepperBasic.tsx"
 ```
 
-### Basic with descriptions
-
-```js
-import React from 'react';
-import { ProgressStepper, ProgressStep } from '@patternfly/react-core';
+### With step descriptions
 
-<ProgressStepper>
-  <ProgressStep
-    variant="success"
-    description="This is the first thing to happen"
-    id="basic-desc-step1"
-    titleId="basic-desc-step1-title"
-    aria-label="completed step, step with success"
-  >
-    First step
-  </ProgressStep>
-  <ProgressStep
-    variant="info"
-    isCurrent
-    description="This is the second thing to happen"
-    id="basic-desc-step2"
-    titleId="basic-desc-step2-title"
-    aria-label="step with info"
-  >
-    Second step
-  </ProgressStep>
-  <ProgressStep
-    variant="pending"
-    description="This is the last thing to happen"
-    id="basic-desc-step3"
-    titleId="basic-desc-step3-title"
-    aria-label="pending step"
-  >
-    Third step
-  </ProgressStep>
-</ProgressStepper>;
+```ts file="ProgressStepperBasicWithDescription.tsx"
 ```
 
-### Center aligned with descriptions
-
-```js
-import React from 'react';
-import { ProgressStepper, ProgressStep } from '@patternfly/react-core';
-
-<ProgressStepper isCenterAligned>
-  <ProgressStep
-    variant="success"
-    description="This is the first thing to happen"
-    id="center-desc-step1"
-    titleId="center-desc-step1-title"
-    aria-label="completed step, step with success"
-  >
-    First step
-  </ProgressStep>
-  <ProgressStep
-    variant="info"
-    isCurrent
-    description="This is the second thing to happen"
-    id="center-desc-step2"
-    titleId="center-desc-step2-title"
-    aria-label="step with info"
-  >
-    Second step
-  </ProgressStep>
-  <ProgressStep
-    variant="pending"
-    description="This is the last thing to happen"
-    id="center-desc-step3"
-    titleId="center-desc-step3-title"
-    aria-label="pending step"
-  >
-    Third step
-  </ProgressStep>
-</ProgressStepper>;
-```
-
-### Vertical with descriptions
-
-```js
-import React from 'react';
-import { ProgressStepper, ProgressStep } from '@patternfly/react-core';
+### With alignment
 
-<ProgressStepper isVertical>
-  <ProgressStep
-    variant="success"
-    description="This is the first thing to happen"
-    id="vertical-desc-step1"
-    titleId="vertical-desc-step1-title"
-    aria-label="completed step, step with success"
-  >
-    First step
-  </ProgressStep>
-  <ProgressStep
-    variant="info"
-    isCurrent
-    description="This is the second thing to happen"
-    id="vertical-desc-step2"
-    titleId="vertical-desc-step2-title"
-    aria-label="step with info"
-  >
-    Second step
-  </ProgressStep>
-  <ProgressStep
-    variant="pending"
-    description="This is the last thing to happen"
-    id="vertical-desc-step3"
-    titleId="vertical-desc-step3-title"
-    aria-label="pending step"
-  >
-    Third step
-  </ProgressStep>
-</ProgressStepper>;
+```ts file="ProgressStepperBasicWithAlignment.tsx"
 ```
 
 ### Compact
 
 Compact progress steppers will only display the current step's `title`, and will not display any steps' `description` texts.
 
-```js
-import React from 'react';
-import { ProgressStepper, ProgressStep } from '@patternfly/react-core';
-
-<ProgressStepper isCompact>
-  <ProgressStep
-    variant="success"
-    id="compact-step1"
-    titleId="compact-step1-title"
-    aria-label="completed step, step with success"
-  >
-    First step
-  </ProgressStep>
-  <ProgressStep
-    variant="info"
-    isCurrent
-    id="compact-step2"
-    titleId="compact-step2-title"
-    aria-label="step with info"
-  >
-    Second step
-  </ProgressStep>
-  <ProgressStep variant="pending" id="compact-step3" titleId="compact-step3-title" aria-label="pending step">
-    Third step
-  </ProgressStep>
-</ProgressStepper>;
+```ts file="ProgressStepperCompact.tsx"
 ```
 
-### Basic with an issue
-
-```js
-import React from 'react';
-import { ProgressStepper, ProgressStep } from '@patternfly/react-core';
+### With an issue
 
-<ProgressStepper>
-  <ProgressStep
-    variant="success"
-    id="basic-with-issue-step1"
-    titleId="basic-with-issue-step1-title"
-    aria-label="completed step, step with success"
-  >
-    First step
-  </ProgressStep>
-  <ProgressStep
-    variant="success"
-    id="basic-with-issue-step2"
-    titleId="basic-with-issue-step2-title"
-    aria-label="completed step, step with success"
-  >
-    Second step
-  </ProgressStep>
-  <ProgressStep
-    variant="warning"
-    id="basic-with-issue-step3"
-    titleId="basic-with-issue-step3-title"
-    aria-label="completed step, step with warning"
-  >
-    Third step
-  </ProgressStep>
-  <ProgressStep
-    variant="info"
-    isCurrent
-    id="basic-with-issue-step4"
-    titleId="basic-with-issue-step4-title"
-    aria-label="step with info"
-  >
-    Fourth step
-  </ProgressStep>
-  <ProgressStep
-    variant="pending"
-    id="basic-with-issue-step5"
-    titleId="basic-with-issue-step5-title"
-    aria-label="pending step"
-  >
-    Fifth step
-  </ProgressStep>
-</ProgressStepper>;
+```ts file="ProgressStepperBasicIssue.tsx"
 ```
 
-### Basic with a failure
+### With a failure
 
-```js
-import React from 'react';
-import { ProgressStepper, ProgressStep } from '@patternfly/react-core';
-
-<ProgressStepper>
-  <ProgressStep
-    variant="success"
-    id="basic-with-failure-step1"
-    titleId="basic-with-failure-step1-title"
-    aria-label="completed step, step with success"
-  >
-    First step
-  </ProgressStep>
-  <ProgressStep
-    variant="success"
-    id="basic-with-failure-step2"
-    titleId="basic-with-failure-step2-title"
-    aria-label="completed step, step with success"
-  >
-    Second step
-  </ProgressStep>
-  <ProgressStep
-    variant="success"
-    id="basic-with-failure-step3"
-    titleId="basic-with-failure-step3-title"
-    aria-label="completed step, step with success"
-  >
-    Third step
-  </ProgressStep>
-  <ProgressStep
-    variant="danger"
-    isCurrent
-    id="basic-with-failure-step4"
-    titleId="basic-with-failure-step4-title"
-    aria-label="step with danger"
-  >
-    Fourth step
-  </ProgressStep>
-  <ProgressStep
-    variant="pending"
-    id="basic-with-failure-step5"
-    titleId="basic-with-failure-step5-title"
-    aria-label="pending step"
-  >
-    Fifth step
-  </ProgressStep>
-</ProgressStepper>;
+```ts file="ProgressStepperBasicFailure.tsx"
 ```
 
-### Basic with Patternfly icons
+### With custom icons
 
-```js
-import React from 'react';
-import { ProgressStepper, ProgressStep } from '@patternfly/react-core';
-import InProgressIcon from '@patternfly/react-icons/dist/esm/icons/in-progress-icon';
-import PendingIcon from '@patternfly/react-icons/dist/esm/icons/pending-icon';
-
-<ProgressStepper>
-  <ProgressStep
-    variant="success"
-    id="custom-step1"
-    titleId="custom-step1-title"
-    aria-label="completed step, step with success"
-  >
-    Successful completion
-  </ProgressStep>
-  <ProgressStep
-    isCurrent
-    icon={<InProgressIcon />}
-    id="custom-step2"
-    titleId="custom-step2-title"
-    aria-label="in progress"
-  >
-    In process
-  </ProgressStep>
-  <ProgressStep
-    variant="pending"
-    icon={<PendingIcon />}
-    id="custom-step3"
-    titleId="custom-step3-title"
-    aria-label="pending step"
-  >
-    Pending
-  </ProgressStep>
-</ProgressStepper>;
+```ts file="ProgressStepperCustomIcons.tsx"
 ```
 
 ### With help popover
 
 To add a popover to a progress step, set the `popoverRender` properties on the `ProgressStep` component.
 
-```js
-import React from 'react';
-import { ProgressStepper, ProgressStep, Popover } from '@patternfly/react-core';
-
-PopoverProgressStep = () => {
-  return (
-    <ProgressStepper>
-      <ProgressStep
-        variant="success"
-        id="popover-step1"
-        titleId="popover-step1-title"
-        aria-label="completed step with popover, step with success"
-        popoverRender={( stepRef ) => (
-          <Popover
-            aria-label="First step help"
-            headerContent={<div>First step popover</div>}
-            bodyContent={<div>Additional info or help text content.</div>}
-            reference={stepRef}
-            position="right"
-          />
-           )}
-      >
-        First step
-      </ProgressStep>
-      <ProgressStep
-        variant="danger"
-        id="popover-step2"
-        titleId="popover-step2-title"
-        aria-label="completed step with popover, step with danger"
-        popoverRender={( stepRef ) => (
-          <Popover
-            aria-label="Second step help"
-            headerContent={<div>Second step popover</div>}
-            bodyContent={<div>Additional info or help text content.</div>}
-            reference={stepRef}
-            position="right"
-          />
-        )}
-      >
-        Second step
-      </ProgressStep>
-      <ProgressStep
-        variant="info"
-        id="popover-step3"
-        titleId="popover-step3-title"
-        aria-label="step with popover"
-        popoverRender={(stepRef) => (
-          <Popover
-            aria-label="Third step help"
-            headerContent={<div>Third step popover</div>}
-            bodyContent={<div>Additional info or help text content.</div>}
-            reference={stepRef}
-            position="right"
-          />
-        )}
-        isCurrent
-      >
-        Third step
-      </ProgressStep>
-      <ProgressStep variant="pending" id="popover-step4" titleId="popover-step4-title" aria-label="pending step">
-        Fourth step
-      </ProgressStep>
-    </ProgressStepper>
-  );
-};
+```ts file="ProgressStepperHelpPopover.tsx"
 ```