@patternfly/react-core 4.226.1 → 4.227.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@patternfly/react-core",
-  "version": "4.226.1",
+  "version": "4.227.1",
   "description": "This library provides a set of common React components for use with the PatternFly reference implementation.",
   "main": "dist/js/index.js",
   "module": "dist/esm/index.js",
@@ -34,16 +34,16 @@
     "generate": "node scripts/copyStyles.js"
   },
   "dependencies": {
-    "@patternfly/react-icons": "^4.77.1",
-    "@patternfly/react-styles": "^4.76.1",
-    "@patternfly/react-tokens": "^4.78.1",
+    "@patternfly/react-icons": "^4.78.1",
+    "@patternfly/react-styles": "^4.77.1",
+    "@patternfly/react-tokens": "^4.79.1",
     "focus-trap": "6.9.2",
     "react-dropzone": "9.0.0",
     "tippy.js": "5.1.2",
     "tslib": "^2.0.0"
   },
   "devDependencies": {
-    "@patternfly/patternfly": "4.204.2",
+    "@patternfly/patternfly": "4.204.3",
     "@rollup/plugin-commonjs": "^21.0.0",
     "@rollup/plugin-node-resolve": "^13.0.0",
     "@rollup/plugin-replace": "^3.0.0",
@@ -60,5 +60,5 @@
     "react": "^16.8.0 || ^17.0.0",
     "react-dom": "^16.8.0 || ^17.0.0"
   },
-  "gitHead": "a8c0fc47245d670f26681e0c58769f91302d85a7"
+  "gitHead": "7bfaee093d3c85392a9d21a34ff661ffe29b0f47"
 }

package/src/components/CalendarMonth/CalendarMonth.tsx

@@ -57,6 +57,11 @@ export interface CalendarProps extends CalendarFormat, Omit<React.HTMLProps<HTML
   onSelectToggle?: (open: boolean) => void;
   /** Flag to set browser focus on the passed date **/
   isDateFocused?: boolean;
+  /** Callback when month or year is changed */
+  onMonthChange?: (
+    newDate?: Date,
+    event?: React.MouseEvent | React.ChangeEvent | React.FormEvent<HTMLInputElement>
+  ) => void;
 }
 
 // Must be numeric given current header design
@@ -114,6 +119,7 @@ export const CalendarMonth = ({
   validators = [() => true],
   className,
   onSelectToggle = () => {},
+  onMonthChange = () => {},
   rangeStart,
   prevMonthAriaLabel = 'Previous month',
   nextMonthAriaLabel = 'Next month',
@@ -162,10 +168,11 @@ export const CalendarMonth = ({
     }
   }, [focusedDate, isDateFocused, focusedDateValidated, focusRef]);
 
-  const onMonthClick = (newDate: Date) => {
+  const onMonthClick = (newDate: Date, ev: React.MouseEvent) => {
     setFocusedDate(newDate);
     setHoveredDate(newDate);
     setShouldFocus(false);
+    onMonthChange(newDate, ev);
   };
 
   const onKeyDown = (ev: React.KeyboardEvent<HTMLTableSectionElement>) => {
@@ -222,7 +229,11 @@ export const CalendarMonth = ({
     <div className={css(styles.calendarMonth, className)} {...props}>
       <div className={styles.calendarMonthHeader}>
         <div className={css(styles.calendarMonthHeaderNavControl, styles.modifiers.prevMonth)}>
-          <Button variant="plain" aria-label={prevMonthAriaLabel} onClick={() => onMonthClick(prevMonth)}>
+          <Button
+            variant="plain"
+            aria-label={prevMonthAriaLabel}
+            onClick={(ev: React.MouseEvent) => onMonthClick(prevMonth, ev)}
+          >
             <AngleLeftIcon aria-hidden={true} />
           </Button>
         </div>
@@ -240,7 +251,7 @@ export const CalendarMonth = ({
                 setIsSelectOpen(!isSelectOpen);
                 onSelectToggle(!isSelectOpen);
               }}
-              onSelect={(_ev, monthNum) => {
+              onSelect={(ev, monthNum) => {
                 // When we put CalendarMonth in a Popover we want the Popover's onDocumentClick
                 // to see the SelectOption as a child so it doesn't close the Popover.
                 setTimeout(() => {
@@ -251,6 +262,7 @@ export const CalendarMonth = ({
                   setFocusedDate(newDate);
                   setHoveredDate(newDate);
                   setShouldFocus(false);
+                  onMonthChange(newDate, ev);
                 }, 0);
               }}
               variant="single"
@@ -268,18 +280,23 @@ export const CalendarMonth = ({
               aria-label={yearInputAriaLabel}
               type="number"
               value={yearFormatted}
-              onChange={year => {
+              onChange={(year: string, ev: React.FormEvent<HTMLInputElement>) => {
                 const newDate = new Date(focusedDate);
                 newDate.setFullYear(+year);
                 setFocusedDate(newDate);
                 setHoveredDate(newDate);
                 setShouldFocus(false);
+                onMonthChange(newDate, ev);
               }}
             />
           </div>
         </InputGroup>
         <div className={css(styles.calendarMonthHeaderNavControl, styles.modifiers.nextMonth)}>
-          <Button variant="plain" aria-label={nextMonthAriaLabel} onClick={() => onMonthClick(nextMonth)}>
+          <Button
+            variant="plain"
+            aria-label={nextMonthAriaLabel}
+            onClick={(ev: React.MouseEvent) => onMonthClick(nextMonth, ev)}
+          >
             <AngleRightIcon aria-hidden={true} />
           </Button>
         </div>

package/src/components/CalendarMonth/examples/CalendarMonth.md

@@ -8,11 +8,6 @@ beta: true
 
 ## Examples
 
-### Default
-
-```ts file="./CalendarMonthDefault.tsx"
-```
-
 ### Selectable date
 
 ```ts file="./CalendarMonthSelectableDate.tsx"

package/src/components/CalendarMonth/examples/CalendarMonthSelectableDate.tsx

@@ -4,10 +4,15 @@ import { CalendarMonth } from '@patternfly/react-core';
 export const CalendarMonthSelectableDate: React.FunctionComponent = () => {
   const [date, setDate] = React.useState(new Date(2020, 10, 24));
 
+  const onMonthChange = (newDate: Date) => {
+    // eslint-disable-next-line no-console
+    console.log(`updated month: ${newDate.getMonth()}, updated year: ${newDate.getFullYear()}`);
+  };
+
   return (
     <React.Fragment>
       <pre>Selected date: {date.toString()}</pre>
-      <CalendarMonth date={date} onChange={setDate} />
+      <CalendarMonth date={date} onChange={setDate} onMonthChange={onMonthChange} />
     </React.Fragment>
   );
 };

package/src/components/Dropdown/DropdownToggle.tsx

@@ -120,6 +120,7 @@ export const DropdownToggle: React.FunctionComponent<DropdownToggleProps> = ({
           styles.modifiers.splitButton,
           splitButtonVariant === 'action' && styles.modifiers.action,
           (toggleVariant === 'primary' || isPrimary) && splitButtonVariant === 'action' && styles.modifiers.primary,
+          toggleVariant === 'secondary' && splitButtonVariant === 'action' && styles.modifiers.secondary,
           isDisabled && styles.modifiers.disabled
         )}
       >

package/src/components/Dropdown/__tests__/DropdownToggle.test.tsx

@@ -184,6 +184,24 @@ describe('DropdownToggle', () => {
       expect(asFragment()).toMatchSnapshot();
     });
 
+    test('action split button - renders secondary variant', () => {
+      const { asFragment } = render(
+        <DropdownToggle
+          id="Dropdown Toggle"
+          toggleVariant="secondary"
+          splitButtonItems={[<div key="1">test</div>]}
+          splitButtonVariant="action"
+          parentRef={document.createElement('div')}
+        >
+          Dropdown
+        </DropdownToggle>
+      );
+
+      const dropdownToggle = screen.getByRole('button').parentElement;
+
+      expect(dropdownToggle).toHaveClass('pf-m-secondary');
+    });
+
     test('class changes', () => {
       const { asFragment } = render(
         <DropdownContext.Provider

package/src/components/Dropdown/__tests__/__snapshots__/DropdownToggle.test.tsx.snap

@@ -198,7 +198,7 @@ exports[`DropdownToggle state class changes 1`] = `
   <button
     aria-expanded="false"
     class="pf-c-dropdown__toggle"
-    data-ouia-component-id="OUIA-Generated-DropdownToggle-13"
+    data-ouia-component-id="OUIA-Generated-DropdownToggle-14"
     data-ouia-component-type="PF4/DropdownToggle"
     data-ouia-safe="true"
     id="Dropdown Toggle"

package/src/components/Dropdown/examples/Dropdown.md

@@ -113,6 +113,11 @@ import avatarImg from '../../Avatar/examples/avatarImg.svg';
 ```ts file="./DropdownSplitButtonActionPrimary.tsx"
 ```
 
+### Split button secondary action
+
+```ts file="./DropdownSplitButtonActionSecondary.tsx"
+```
+
 ### Basic panel
 
 ```ts file="./DropdownBasicPanel.tsx"

package/src/components/Dropdown/examples/DropdownSplitButtonActionSecondary.tsx

@@ -0,0 +1,107 @@
+import React from 'react';
+import { Dropdown, DropdownToggle, DropdownToggleAction, DropdownItem } from '@patternfly/react-core';
+import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
+import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
+import CubesIcon from '@patternfly/react-icons/dist/esm/icons/cubes-icon';
+
+export const DropdownSplitButtonActionSecondary: React.FunctionComponent = () => {
+  const [isActionOpen, setIsActionOpen] = React.useState(false);
+  const [isCogOpen, setIsCogOpen] = React.useState(false);
+
+  const onActionToggle = (isActionOpen: boolean) => {
+    setIsActionOpen(isActionOpen);
+  };
+  const onCogToggle = (isCogOpen: boolean) => {
+    setIsCogOpen(isCogOpen);
+  };
+
+  const onActionClick = () => {
+    window.alert('You selected an action button!');
+  };
+  const onCogClick = () => {
+    window.alert('You selected the Cog!');
+  };
+
+  const onActionFocus = () => {
+    const element = document.getElementById('toggle-split-button-action-secondary');
+    element.focus();
+  };
+  const onCogFocus = () => {
+    const element = document.getElementById('toggle-split-button-cog-secondary');
+    element.focus();
+  };
+
+  const onActionSelect = () => {
+    setIsActionOpen(false);
+    onActionFocus();
+  };
+  const onCogSelect = () => {
+    setIsCogOpen(false);
+    onCogFocus();
+  };
+
+  const dropdownItems = [
+    <DropdownItem key="action" component="button" onClick={onActionClick}>
+      Action
+    </DropdownItem>,
+    <DropdownItem key="disabled link" component="button" isDisabled onClick={onActionClick}>
+      Disabled action
+    </DropdownItem>,
+    <DropdownItem key="other action" component="button" onClick={onActionClick}>
+      Other action
+    </DropdownItem>
+  ];
+
+  const dropdownIconItems = [
+    <DropdownItem key="action" component="button" icon={<CogIcon />} onClick={onActionClick}>
+      Action
+    </DropdownItem>,
+    <DropdownItem key="disabled link" component="button" icon={<BellIcon />} isDisabled onClick={onActionClick}>
+      Disabled action
+    </DropdownItem>,
+    <DropdownItem key="other action" component="button" icon={<CubesIcon />} onClick={onActionClick}>
+      Other action
+    </DropdownItem>
+  ];
+
+  return (
+    <React.Fragment>
+      <Dropdown
+        onSelect={onActionSelect}
+        toggle={
+          <DropdownToggle
+            id="toggle-split-button-action-secondary"
+            splitButtonItems={[
+              <DropdownToggleAction key="action" onClick={onActionClick}>
+                Action
+              </DropdownToggleAction>
+            ]}
+            toggleVariant="secondary"
+            splitButtonVariant="action"
+            onToggle={onActionToggle}
+          />
+        }
+        isOpen={isActionOpen}
+        dropdownItems={dropdownItems}
+      />{' '}
+      <Dropdown
+        onSelect={onCogSelect}
+        toggle={
+          <DropdownToggle
+            id="toggle-split-button-cog-secondary"
+            splitButtonItems={[
+              <DropdownToggleAction key="cog-action" aria-label="Action" onClick={onCogClick}>
+                <CogIcon />
+              </DropdownToggleAction>
+            ]}
+            toggleVariant="secondary"
+            splitButtonVariant="action"
+            onToggle={onCogToggle}
+          />
+        }
+        isOpen={isCogOpen}
+        dropdownItems={dropdownIconItems}
+      />
+    </React.Fragment>
+  );
+};

package/src/components/Page/examples/Page.md

@@ -89,7 +89,7 @@ class VerticalPage extends React.Component {
         <MastheadContent>{headerToolbar}</MastheadContent>
       </Masthead>
     );
-    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-sidebar" />;
 
     return (
       <Page header={Header} sidebar={Sidebar}>
@@ -262,7 +262,7 @@ class FillPage extends React.Component {
         <MastheadContent>{headerToolbar}</MastheadContent>
       </Masthead>
     );
-    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="fill-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="fill-sidebar" />;
 
     return (
       <Page header={Header} sidebar={Sidebar}>
@@ -344,7 +344,7 @@ class VerticalPage extends React.Component {
         <MastheadContent>{headerToolbar}</MastheadContent>
       </Masthead>
     );
-    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="main-padding-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="main-padding-sidebar" />;
 
     return (
       <Page header={Header} sidebar={Sidebar}>
@@ -410,7 +410,7 @@ class UncontrolledNavPage extends React.Component {
         <MastheadContent>{headerToolbar}</MastheadContent>
       </Masthead>
     );
-    const Sidebar = <PageSidebar nav="Navigation" id="uncontrolled-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" id="uncontrolled-sidebar" />;
 
     return (
       <Page isManagedSidebar header={Header} sidebar={Sidebar}>
@@ -497,7 +497,7 @@ class GroupPage extends React.Component {
         <MastheadContent>{headerToolbar}</MastheadContent>
       </Masthead>
     );
-    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="group-section-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="group-section-sidebar" />;
 
     return (
       <Page header={Header} sidebar={Sidebar}>
@@ -505,13 +505,21 @@ class GroupPage extends React.Component {
           <PageNavigation>
             <Nav aria-label="Group section navigation" variant="tertiary">
               <NavList>
-                <NavItem itemId={0} isActive>
+                <NavItem href="#" itemId={0} isActive>
                   System panel
                 </NavItem>
-                <NavItem itemId={1}>Policy</NavItem>
-                <NavItem itemId={2}>Authentication</NavItem>
-                <NavItem itemId={3}>Network services</NavItem>
-                <NavItem itemId={4}>Server</NavItem>
+                <NavItem href="#" itemId={1}>
+                  Policy
+                </NavItem>
+                <NavItem href="#" itemId={2}>
+                  Authentication
+                </NavItem>
+                <NavItem href="#" itemId={3}>
+                  Network services
+                </NavItem>
+                <NavItem href="#" itemId={4}>
+                  Server
+                </NavItem>
               </NavList>
             </Nav>
           </PageNavigation>
@@ -582,7 +590,7 @@ class VerticalPage extends React.Component {
         navToggleId="vertical-pageheader-toggle"
       />
     );
-    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-pageheader-sidebar"/>;
+    const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-pageheader-sidebar" />;
 
     return (
       <Page header={Header} sidebar={Sidebar}>
@@ -630,7 +638,12 @@ CenterAlignedPageSection = () => {
   const Header = (
     <Masthead>
       <MastheadToggle>
-        <PageToggleButton variant="plain" aria-label="Global navigation" onNavToggle={this.onNavToggle} id="centered-nav-toggle">
+        <PageToggleButton
+          variant="plain"
+          aria-label="Global navigation"
+          onNavToggle={this.onNavToggle}
+          id="centered-nav-toggle"
+        >
           <BarsIcon />
         </PageToggleButton>
       </MastheadToggle>

package/src/components/Pagination/examples/Pagination.md

@@ -28,9 +28,9 @@ class PaginationTop extends React.Component {
       });
     };
 
-    this.onPerPageSelect = (_event, perPage) => {
+    this.onPerPageSelect = (_event, perPage, page) => {
       this.setState({
-        perPage
+        page, perPage
       });
     };
   }
@@ -68,9 +68,9 @@ class PaginationBottom extends React.Component {
         page: pageNumber
       });
     };
-    this.onPerPageSelect = (_event, perPage) => {
+    this.onPerPageSelect = (_event, perPage, page) => {
       this.setState({
-        perPage
+        page, perPage
       });
     };
   }
@@ -149,9 +149,9 @@ class PaginationDisabled extends React.Component {
       });
     };
 
-    this.onPerPageSelect = (_event, perPage) => {
+    this.onPerPageSelect = (_event, perPage, page) => {
       this.setState({
-        perPage
+        page, perPage
       });
     };
   }
@@ -193,9 +193,9 @@ class PaginationTop extends React.Component {
       });
     };
 
-    this.onPerPageSelect = (_event, perPage) => {
+    this.onPerPageSelect = (_event, perPage, page) => {
       this.setState({
-        perPage
+        page, perPage
       });
     };
   }
@@ -236,9 +236,9 @@ class PaginationTop extends React.Component {
       });
     };
 
-    this.onPerPageSelect = (_event, perPage) => {
+    this.onPerPageSelect = (_event, perPage, page) => {
       this.setState({
-        perPage
+        page, perPage
       });
     };
   }
@@ -279,9 +279,9 @@ class PaginationTop extends React.Component {
       });
     };
 
-    this.onPerPageSelect = (_event, perPage) => {
+    this.onPerPageSelect = (_event, perPage, page) => {
       this.setState({
-        perPage
+        page, perPage
       });
     };
   }
@@ -330,9 +330,9 @@ class PaginationSticky extends React.Component {
       });
     };
 
-    this.onPerPageSelect = (_event, perPage) => {
+    this.onPerPageSelect = (_event, perPage, page) => {
       this.setState({
-        perPage
+        page, perPage
       });
     };
   }

package/src/components/Toolbar/examples/Toolbar.md

@@ -1169,9 +1169,9 @@ class ToolbarStacked extends React.Component {
       });
     };
 
-    this.onPerPageSelect = (_event, perPage) => {
+    this.onPerPageSelect = (_event, perPage, page) => {
       this.setState({
-        perPage
+        page, perPage
       });
     };
 

package/src/components/Wizard/Wizard.tsx

@@ -367,6 +367,12 @@ export class Wizard extends React.Component<WizardProps, WizardState> {
     }
   }
 
+  componentDidUpdate(prevProps: Readonly<WizardProps>) {
+    if (prevProps.startAtStep !== this.props.startAtStep) {
+      this.setState({ currentStep: this.props.startAtStep });
+    }
+  }
+
   render() {
     const {
       /* eslint-disable @typescript-eslint/no-unused-vars */

package/src/components/Wizard/__tests__/Wizard.test.tsx

@@ -342,3 +342,34 @@ describe('Wizard', () => {
 
     expect(screen.getByRole('button',{ name: "A-2" })).toBeDisabled();
   });
+
+test('startAtStep can be used to externally control the current step of the wizard', () => {
+  const WizardTest = () => {
+    const [step, setStep] = React.useState(1);
+
+    const incrementStep = () => {
+      setStep(prevStep => prevStep + 1);
+    };
+
+    const steps: WizardStep[] = [
+      { name: 'A', component: <p>Step 1</p> },
+      { name: 'B', component: <p>Step 2</p> },
+      { name: 'C', component: <p>Step 3</p> }
+    ];
+
+    return (
+      <>
+        <Wizard steps={steps} startAtStep={step} />
+        <button onClick={() => incrementStep()}>Increment step</button>
+      </>
+    );
+  };
+
+  render(<WizardTest />);
+
+  expect(screen.queryByText('Step 2')).not.toBeInTheDocument();
+
+  userEvent.click(screen.getByRole('button', { name: 'Increment step'}))
+
+  expect(screen.getByText('Step 2')).toBeVisible();
+});

package/src/components/CalendarMonth/examples/CalendarMonthDefault.tsx

@@ -1,4 +0,0 @@
-import React from 'react';
-import { CalendarMonth } from '@patternfly/react-core';
-
-export const CalendarMonthDefault: React.FunctionComponent = () => <CalendarMonth date={new Date()} />;