@patternfly/react-core 4.199.2 → 4.199.3

package/src/components/Checkbox/__tests__/Checkbox.test.tsx

@@ -1,86 +1,82 @@
-import * as React from 'react';
-import { render } from '@testing-library/react';
-import { shallow } from 'enzyme';
+import React from 'react';
+
+import { render, screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import '@testing-library/jest-dom';
+
 import { Checkbox } from '../Checkbox';
 
-const props = {
-  onChange: jest.fn(),
-  isChecked: false
-};
+describe('Checkbox', () => {
+  test('controlled', () => {
+    render(<Checkbox isChecked id="check" aria-label="check" />);
+    expect(screen.getByRole('checkbox').outerHTML).toMatchSnapshot();
+  });
 
-test('controlled', () => {
-  const view = render(<Checkbox isChecked id="check" aria-label="check" />);
-  expect(view.container).toMatchSnapshot();
-});
+  test('controlled - 3rd state', () => {
+    render(<Checkbox isChecked={null} id="check" aria-label="check" />);
+    expect(screen.getByRole('checkbox').outerHTML).toMatchSnapshot();
+  });
 
-test('controlled - 3rd state', () => {
-  const view = render(<Checkbox isChecked={null} id="check" aria-label="check" />);
-  expect(view.container).toMatchSnapshot();
-});
+  test('uncontrolled', () => {
+    render(<Checkbox id="check" aria-label="check" />);
+    expect(screen.getByRole('checkbox').outerHTML).toMatchSnapshot();
+  });
 
-test('uncontrolled', () => {
-  const view = render(<Checkbox id="check" aria-label="check" />);
-  expect(view.container).toMatchSnapshot();
-});
+  test('isDisabled', () => {
+    render(<Checkbox id="check" isDisabled aria-label="check" />);
+    expect(screen.getByRole('checkbox').outerHTML).toMatchSnapshot();
+  });
 
-test('isDisabled', () => {
-  const view = render(<Checkbox id="check" isDisabled aria-label="check" />);
-  expect(view.container).toMatchSnapshot();
-});
+  test('label is string', () => {
+    render(<Checkbox label="Label" id="check" isChecked aria-label="check" />);
+    expect(screen.getByRole('checkbox').outerHTML).toMatchSnapshot();
+  });
 
-test('label is string', () => {
-  const view = render(<Checkbox label="Label" id="check" isChecked aria-label="check" />);
-  expect(view.container).toMatchSnapshot();
-});
+  test('label is function', () => {
+    const functionLabel = () => <h1>Header</h1>;
+    render(<Checkbox label={functionLabel()} id="check" isChecked aria-label="check" />);
+    expect(screen.getByRole('checkbox').outerHTML).toMatchSnapshot();
+  });
 
-test('label is function', () => {
-  const functionLabel = () => <h1>Header</h1>;
-  const view = render(<Checkbox label={functionLabel()} id="check" isChecked aria-label="check" />);
-  expect(view.container).toMatchSnapshot();
-});
+  test('label is node', () => {
+    render(<Checkbox label={<h1>Header</h1>} id="check" isChecked aria-label="check" />);
+    expect(screen.getByRole('checkbox').outerHTML).toMatchSnapshot();
+  });
 
-test('label is node', () => {
-  const view = render(<Checkbox label={<h1>Header</h1>} id="check" isChecked aria-label="check" />);
-  expect(view.container).toMatchSnapshot();
-});
+  test('passing class', () => {
+    render(<Checkbox label="label" className="class-123" id="check" isChecked aria-label="check" />);
+    expect(screen.getByRole('checkbox').outerHTML).toMatchSnapshot();
+  });
 
-test('passing class', () => {
-  const view = render(<Checkbox label="label" className="class-123" id="check" isChecked aria-label="check" />);
-  expect(view.container).toMatchSnapshot();
-});
+  test('passing HTML attribute', () => {
+    render(<Checkbox label="label" aria-labelledby="labelId" id="check" isChecked aria-label="check" />);
+    expect(screen.getByRole('checkbox').outerHTML).toMatchSnapshot();
+  });
 
-test('passing HTML attribute', () => {
-  const view = render(<Checkbox label="label" aria-labelledby="labelId" id="check" isChecked aria-label="check" />);
-  expect(view.container).toMatchSnapshot();
-});
+  test('passing description', () => {
+    render(<Checkbox id="check" label="checkbox" description="Text description..." />);
+    expect(screen.getByText('Text description...')).toBeInTheDocument();
+  });
 
-test('passing description', () => {
-  const view = shallow(<Checkbox id="check" label="checkbox" description="Text description..." />);
-  const descriptionEl = view.find('span[className="pf-c-check__description"]');
-  expect(descriptionEl.length).toBe(1);
-  expect(descriptionEl.text()).toBe('Text description...');
-});
+  test('passing body', () => {
+    render(<Checkbox id="check" label="checkbox" body="This is where custom content goes." />);
 
-test('passing body', () => {
-  const view = shallow(<Checkbox id="check" label="checkbox" body="This is where custom content goes." />);
-  const bodyEl = view.find('span[className="pf-c-check__body"]');
-  expect(bodyEl.length).toBe(1);
-  expect(bodyEl.text()).toBe('This is where custom content goes.');
-});
+    expect(screen.getByText('This is where custom content goes.')).toBeInTheDocument();
+  });
 
-test('checkbox passes value and event to onChange handler', () => {
-  const newValue = true;
-  const event = {
-    currentTarget: { checked: newValue }
-  };
-  const view = shallow(<Checkbox id="check" {...props} aria-label="check" />);
-  view.find('input').simulate('change', event);
-  expect(props.onChange).toBeCalledWith(newValue, event);
-});
+  test('checkbox onChange handler called when component is clicked', () => {
+    const onChangeHandler = jest.fn();
+    render(<Checkbox id="check" onChange={onChangeHandler} aria-label="check" isChecked={false} />);
+
+    userEvent.click(screen.getByLabelText('check'));
+    expect(onChangeHandler).toBeCalled();
+  });
+
+  test('should throw console error when no id is given', () => {
+    const myMock = jest.fn();
+    global.console = { ...global.console, error: myMock };
 
-test('should throw console error when no id is given', () => {
-  const myMock = jest.fn();
-  global.console = { ...global.console, error: myMock };
-  render(<Checkbox {...props} />);
-  expect(myMock).toBeCalled();
+    render(<Checkbox id={undefined} />);
+    expect(myMock).toBeCalled();
+  });
 });

package/src/components/Checkbox/__tests__/__snapshots__/Checkbox.test.tsx.snap

@@ -1,214 +1,19 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`controlled - 3rd state 1`] = `
-<div>
-  <div
-    class="pf-c-check pf-m-standalone"
-  >
-    <input
-      aria-invalid="false"
-      aria-label="check"
-      class="pf-c-check__input"
-      data-ouia-component-id="OUIA-Generated-Checkbox-2"
-      data-ouia-component-type="PF4/Checkbox"
-      data-ouia-safe="true"
-      id="check"
-      type="checkbox"
-    />
-  </div>
-</div>
-`;
+exports[`Checkbox controlled - 3rd state 1`] = `"<input id=\\"check\\" class=\\"pf-c-check__input\\" type=\\"checkbox\\" aria-invalid=\\"false\\" aria-label=\\"check\\" data-ouia-component-type=\\"PF4/Checkbox\\" data-ouia-safe=\\"true\\" data-ouia-component-id=\\"OUIA-Generated-Checkbox-2\\">"`;
 
-exports[`controlled 1`] = `
-<div>
-  <div
-    class="pf-c-check pf-m-standalone"
-  >
-    <input
-      aria-invalid="false"
-      aria-label="check"
-      checked=""
-      class="pf-c-check__input"
-      data-ouia-component-id="OUIA-Generated-Checkbox-1"
-      data-ouia-component-type="PF4/Checkbox"
-      data-ouia-safe="true"
-      id="check"
-      type="checkbox"
-    />
-  </div>
-</div>
-`;
+exports[`Checkbox controlled 1`] = `"<input id=\\"check\\" class=\\"pf-c-check__input\\" type=\\"checkbox\\" aria-invalid=\\"false\\" aria-label=\\"check\\" data-ouia-component-type=\\"PF4/Checkbox\\" data-ouia-safe=\\"true\\" data-ouia-component-id=\\"OUIA-Generated-Checkbox-1\\" checked=\\"\\">"`;
 
-exports[`isDisabled 1`] = `
-<div>
-  <div
-    class="pf-c-check pf-m-standalone"
-  >
-    <input
-      aria-invalid="false"
-      aria-label="check"
-      class="pf-c-check__input"
-      data-ouia-component-id="OUIA-Generated-Checkbox-4"
-      data-ouia-component-type="PF4/Checkbox"
-      data-ouia-safe="true"
-      disabled=""
-      id="check"
-      type="checkbox"
-    />
-  </div>
-</div>
-`;
+exports[`Checkbox isDisabled 1`] = `"<input id=\\"check\\" class=\\"pf-c-check__input\\" type=\\"checkbox\\" aria-invalid=\\"false\\" aria-label=\\"check\\" disabled=\\"\\" data-ouia-component-type=\\"PF4/Checkbox\\" data-ouia-safe=\\"true\\" data-ouia-component-id=\\"OUIA-Generated-Checkbox-4\\">"`;
 
-exports[`label is function 1`] = `
-<div>
-  <div
-    class="pf-c-check"
-  >
-    <input
-      aria-invalid="false"
-      aria-label="check"
-      checked=""
-      class="pf-c-check__input"
-      data-ouia-component-id="OUIA-Generated-Checkbox-6"
-      data-ouia-component-type="PF4/Checkbox"
-      data-ouia-safe="true"
-      id="check"
-      type="checkbox"
-    />
-    <label
-      class="pf-c-check__label"
-      for="check"
-    >
-      <h1>
-        Header
-      </h1>
-    </label>
-  </div>
-</div>
-`;
+exports[`Checkbox label is function 1`] = `"<input id=\\"check\\" class=\\"pf-c-check__input\\" type=\\"checkbox\\" aria-invalid=\\"false\\" aria-label=\\"check\\" data-ouia-component-type=\\"PF4/Checkbox\\" data-ouia-safe=\\"true\\" data-ouia-component-id=\\"OUIA-Generated-Checkbox-6\\" checked=\\"\\">"`;
 
-exports[`label is node 1`] = `
-<div>
-  <div
-    class="pf-c-check"
-  >
-    <input
-      aria-invalid="false"
-      aria-label="check"
-      checked=""
-      class="pf-c-check__input"
-      data-ouia-component-id="OUIA-Generated-Checkbox-7"
-      data-ouia-component-type="PF4/Checkbox"
-      data-ouia-safe="true"
-      id="check"
-      type="checkbox"
-    />
-    <label
-      class="pf-c-check__label"
-      for="check"
-    >
-      <h1>
-        Header
-      </h1>
-    </label>
-  </div>
-</div>
-`;
+exports[`Checkbox label is node 1`] = `"<input id=\\"check\\" class=\\"pf-c-check__input\\" type=\\"checkbox\\" aria-invalid=\\"false\\" aria-label=\\"check\\" data-ouia-component-type=\\"PF4/Checkbox\\" data-ouia-safe=\\"true\\" data-ouia-component-id=\\"OUIA-Generated-Checkbox-7\\" checked=\\"\\">"`;
 
-exports[`label is string 1`] = `
-<div>
-  <div
-    class="pf-c-check"
-  >
-    <input
-      aria-invalid="false"
-      aria-label="check"
-      checked=""
-      class="pf-c-check__input"
-      data-ouia-component-id="OUIA-Generated-Checkbox-5"
-      data-ouia-component-type="PF4/Checkbox"
-      data-ouia-safe="true"
-      id="check"
-      type="checkbox"
-    />
-    <label
-      class="pf-c-check__label"
-      for="check"
-    >
-      Label
-    </label>
-  </div>
-</div>
-`;
+exports[`Checkbox label is string 1`] = `"<input id=\\"check\\" class=\\"pf-c-check__input\\" type=\\"checkbox\\" aria-invalid=\\"false\\" aria-label=\\"check\\" data-ouia-component-type=\\"PF4/Checkbox\\" data-ouia-safe=\\"true\\" data-ouia-component-id=\\"OUIA-Generated-Checkbox-5\\" checked=\\"\\">"`;
 
-exports[`passing HTML attribute 1`] = `
-<div>
-  <div
-    class="pf-c-check"
-  >
-    <input
-      aria-invalid="false"
-      aria-label="check"
-      aria-labelledby="labelId"
-      checked=""
-      class="pf-c-check__input"
-      data-ouia-component-id="OUIA-Generated-Checkbox-9"
-      data-ouia-component-type="PF4/Checkbox"
-      data-ouia-safe="true"
-      id="check"
-      type="checkbox"
-    />
-    <label
-      class="pf-c-check__label"
-      for="check"
-    >
-      label
-    </label>
-  </div>
-</div>
-`;
+exports[`Checkbox passing HTML attribute 1`] = `"<input aria-labelledby=\\"labelId\\" id=\\"check\\" class=\\"pf-c-check__input\\" type=\\"checkbox\\" aria-invalid=\\"false\\" aria-label=\\"check\\" data-ouia-component-type=\\"PF4/Checkbox\\" data-ouia-safe=\\"true\\" data-ouia-component-id=\\"OUIA-Generated-Checkbox-9\\" checked=\\"\\">"`;
 
-exports[`passing class 1`] = `
-<div>
-  <div
-    class="pf-c-check class-123"
-  >
-    <input
-      aria-invalid="false"
-      aria-label="check"
-      checked=""
-      class="pf-c-check__input"
-      data-ouia-component-id="OUIA-Generated-Checkbox-8"
-      data-ouia-component-type="PF4/Checkbox"
-      data-ouia-safe="true"
-      id="check"
-      type="checkbox"
-    />
-    <label
-      class="pf-c-check__label"
-      for="check"
-    >
-      label
-    </label>
-  </div>
-</div>
-`;
+exports[`Checkbox passing class 1`] = `"<input id=\\"check\\" class=\\"pf-c-check__input\\" type=\\"checkbox\\" aria-invalid=\\"false\\" aria-label=\\"check\\" data-ouia-component-type=\\"PF4/Checkbox\\" data-ouia-safe=\\"true\\" data-ouia-component-id=\\"OUIA-Generated-Checkbox-8\\" checked=\\"\\">"`;
 
-exports[`uncontrolled 1`] = `
-<div>
-  <div
-    class="pf-c-check pf-m-standalone"
-  >
-    <input
-      aria-invalid="false"
-      aria-label="check"
-      class="pf-c-check__input"
-      data-ouia-component-id="OUIA-Generated-Checkbox-3"
-      data-ouia-component-type="PF4/Checkbox"
-      data-ouia-safe="true"
-      id="check"
-      type="checkbox"
-    />
-  </div>
-</div>
-`;
+exports[`Checkbox uncontrolled 1`] = `"<input id=\\"check\\" class=\\"pf-c-check__input\\" type=\\"checkbox\\" aria-invalid=\\"false\\" aria-label=\\"check\\" data-ouia-component-type=\\"PF4/Checkbox\\" data-ouia-safe=\\"true\\" data-ouia-component-id=\\"OUIA-Generated-Checkbox-3\\">"`;