@pattern-stack/codegen 0.4.3 → 0.4.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pattern-stack/codegen",
-  "version": "0.4.3",
+  "version": "0.4.4",
   "description": "Entity-driven code generation for full-stack TypeScript applications",
   "license": "MIT",
   "type": "module",

package/runtime/subsystems/jobs/job-orchestrator.memory-backend.ts

@@ -596,10 +596,14 @@ export class MemoryJobOrchestrator implements IJobOrchestrator {
     // ModuleRef so `@Inject` constructor params work. ModuleRef is
     // @Optional() — zero-dep test stubs that construct this orchestrator
     // manually still hit the legacy `new HandlerClass()` path.
+    // `get({ strict: false })` (not `create()`) — the handler must be a
+    // provider in its owning module so cross-module @Inject dependencies
+    // resolve. See job-worker.ts for the full rationale.
     const handler = this.moduleRef
-      ? ((await this.moduleRef.create(
+      ? (this.moduleRef.get(
           HandlerClass as unknown as new (...args: unknown[]) => unknown,
-        )) as JobHandlerBase<unknown>)
+          { strict: false },
+        ) as JobHandlerBase<unknown>)
       : new HandlerClass();
 
     const ctx: JobContext<unknown> = {

package/runtime/subsystems/jobs/job-worker.module.ts

@@ -177,8 +177,16 @@ export class JobWorkerOrchestrator implements OnModuleInit, OnModuleDestroy {
             `the resolved pool config. Configured pools: [${[...poolConfig.keys()].join(', ')}].`,
         );
       }
+      // `pool` here is the logical pool name (e.g. 'crm_sync') — the same
+      // value the orchestrator persists into `job_run.pool` from
+      // `@JobHandler.meta.pool`, and therefore the value the worker's
+      // claim query filters on. `def.queue` is a display/routing alias
+      // (e.g. 'jobs-crm-sync') used by BullMQ-style backends for queue
+      // naming; it MUST NOT be passed as the claim-filter pool, or the
+      // worker will never match any row and the pool silently never
+      // drains. See v0.4.4 fix notes.
       const workerOptions: JobWorkerOptions = {
-        pool: def.queue,
+        pool: poolName,
         concurrency: def.concurrency,
         shutdownTimeoutMs:
           this.options.shutdownTimeoutMs ?? DEFAULT_SHUTDOWN_TIMEOUT_MS,
@@ -192,7 +200,7 @@ export class JobWorkerOrchestrator implements OnModuleInit, OnModuleDestroy {
       worker.onModuleInit();
       this.workers.push(worker);
       this.logger.log(
-        `JobWorker started: pool='${def.queue}' concurrency=${def.concurrency}`,
+        `JobWorker started: pool='${poolName}' (queue='${def.queue}') concurrency=${def.concurrency}`,
       );
     }
   }

package/runtime/subsystems/jobs/job-worker.ts

@@ -421,16 +421,22 @@ export class JobWorker implements OnModuleInit, OnModuleDestroy {
     const meta = registryEntry.meta as JobHandlerMeta<unknown>;
     const HandlerClass = registryEntry.handlerClass;
 
-    // (c) Build JobContext. Instantiate handler via Nest's ModuleRef so
-    //     `@Inject` constructor params resolve. `create({ strict: false })`
-    //     walks the whole module graph for providers (handlers don't need to
-    //     be registered as providers themselves; the @JobHandler decorator
-    //     is the only registration required). A fresh instance per run
-    //     mirrors the contract handlers were authored against and keeps
-    //     run-scoped state from leaking across claims.
-    const handler = (await this.moduleRef.create(
+    // (c) Build JobContext. Resolve the handler instance from Nest's DI
+    //     graph so its `@Inject` constructor params (which may come from
+    //     any module in the app graph) are satisfied. `moduleRef.create()`
+    //     would otherwise instantiate a fresh class within JobWorkerModule's
+    //     scope only — which blows up with "not a provider of the current
+    //     module" for any handler that consumes a service from a peer
+    //     module (e.g. CrmSyncJob injecting CrmSyncFactory from CrmModule).
+    //     Consequence: handlers MUST be registered as providers in their
+    //     owning module (@Injectable + `providers: [HandlerClass]`). The
+    //     @JobHandler decorator handles registry registration only, not DI.
+    //     See the jobs skill's handler-authoring.md for the registration
+    //     rule.
+    const handler = this.moduleRef.get(
       HandlerClass as unknown as new (...args: unknown[]) => unknown,
-    )) as JobHandlerBase<unknown>;
+      { strict: false },
+    ) as JobHandlerBase<unknown>;
     const ctx: JobContext<unknown> = {
       input: claimed.input,
       run: claimed as JobRun,