@patronage/software-factory 1.0.0-alpha.39 → 1.0.0-alpha.40

package/dist/schemas.js

@@ -305,6 +305,11 @@ const authoritativePolicyResolutionSchema = z.object({
 const unresolvedPolicyResolutionSchema = z.object({
 	/** The base ref whose policy could not be read. */
 	baseRefName: z.string().min(1),
+	cause: z.enum([
+		"no-pull-request",
+		"lookup-failed",
+		"policy-unreadable"
+	]).optional(),
 	/** Why the authority is unresolved. */
 	reason: z.string().min(1),
 	status: z.literal("unresolved")
@@ -318,16 +323,92 @@ const REVIEW_PROMPT_SECTION_PROVENANCES = [
 	"prior-review-ledger",
 	"issue-review-focus"
 ];
-const nonBlankString$1 = z.string().refine((value) => value.trim().length > 0, { message: "must not be blank" });
+const nonBlankString$2 = z.string().refine((value) => value.trim().length > 0, { message: "must not be blank" });
 const reviewPromptSectionSchema = z.object({
 	provenance: z.enum(REVIEW_PROMPT_SECTION_PROVENANCES),
-	source: nonBlankString$1,
-	text: nonBlankString$1
+	source: nonBlankString$2,
+	text: nonBlankString$2
 }).strict();
 const promptSectionRank = (section) => REVIEW_PROMPT_SECTION_PROVENANCES.indexOf(section.provenance);
 const hasDuplicateProvenance = (sections) => new Set(sections.map((section) => section.provenance)).size !== sections.length;
 const isOutOfAssemblyOrder = (sections) => sections.some((section, index) => index > 0 && promptSectionRank(section) < promptSectionRank(sections[index - 1]));
 const reviewPromptSectionsSchema = z.array(reviewPromptSectionSchema).min(1).refine((sections) => !hasDuplicateProvenance(sections) && !isOutOfAssemblyOrder(sections), { message: "prompt sections must be in assembly order without duplicates" });
+new Uint32Array([
+	1116352408,
+	1899447441,
+	3049323471,
+	3921009573,
+	961987163,
+	1508970993,
+	2453635748,
+	2870763221,
+	3624381080,
+	310598401,
+	607225278,
+	1426881987,
+	1925078388,
+	2162078206,
+	2614888103,
+	3248222580,
+	3835390401,
+	4022224774,
+	264347078,
+	604807628,
+	770255983,
+	1249150122,
+	1555081692,
+	1996064986,
+	2554220882,
+	2821834349,
+	2952996808,
+	3210313671,
+	3336571891,
+	3584528711,
+	113926993,
+	338241895,
+	666307205,
+	773529912,
+	1294757372,
+	1396182291,
+	1695183700,
+	1986661051,
+	2177026350,
+	2456956037,
+	2730485921,
+	2820302411,
+	3259730800,
+	3345764771,
+	3516065817,
+	3600352804,
+	4094571909,
+	275423344,
+	430227734,
+	506948616,
+	659060556,
+	883997877,
+	958139571,
+	1322822218,
+	1537002063,
+	1747873779,
+	1955562222,
+	2024104815,
+	2227730452,
+	2361852424,
+	2428436474,
+	2756734187,
+	3204031479,
+	3329325298
+]);
+new Uint32Array([
+	1779033703,
+	3144134277,
+	1013904242,
+	2773480762,
+	1359893119,
+	2600822924,
+	528734635,
+	1541459225
+]);
 //#endregion
 //#region src/review-ladder-policy.ts
 const REVIEW_CATEGORIES = [
@@ -343,11 +424,7 @@ const OCCURRENCE_ADDRESS_PATTERN = /^c[1-9][0-9]*f[1-9][0-9]*$/u;
 const occurrenceAddress = (cycle, finding) => `c${cycle}f${finding}`;
 /** The 1-based recording position an address names. */
 const cycleOfAddress = (address) => Number(/^c(?<cycle>\d+)f/u.exec(address)?.groups?.cycle);
-const POLICY_DECLARATION_RULES = [
-	"cycle-2-severity-floor",
-	"identity-repeat",
-	"schema-2-import"
-];
+const POLICY_DECLARATION_RULES = ["cycle-2-severity-floor", "identity-repeat"];
 const definedAttributes = (finding) => Object.fromEntries([
 	"blockingAfterCap",
 	"category",
@@ -452,117 +529,6 @@ const foldLedger = (cycles, refs) => {
 		occurrences: [...occurrences.values()]
 	};
 };
-new Uint32Array([
-	1116352408,
-	1899447441,
-	3049323471,
-	3921009573,
-	961987163,
-	1508970993,
-	2453635748,
-	2870763221,
-	3624381080,
-	310598401,
-	607225278,
-	1426881987,
-	1925078388,
-	2162078206,
-	2614888103,
-	3248222580,
-	3835390401,
-	4022224774,
-	264347078,
-	604807628,
-	770255983,
-	1249150122,
-	1555081692,
-	1996064986,
-	2554220882,
-	2821834349,
-	2952996808,
-	3210313671,
-	3336571891,
-	3584528711,
-	113926993,
-	338241895,
-	666307205,
-	773529912,
-	1294757372,
-	1396182291,
-	1695183700,
-	1986661051,
-	2177026350,
-	2456956037,
-	2730485921,
-	2820302411,
-	3259730800,
-	3345764771,
-	3516065817,
-	3600352804,
-	4094571909,
-	275423344,
-	430227734,
-	506948616,
-	659060556,
-	883997877,
-	958139571,
-	1322822218,
-	1537002063,
-	1747873779,
-	1955562222,
-	2024104815,
-	2227730452,
-	2361852424,
-	2428436474,
-	2756734187,
-	3204031479,
-	3329325298
-]);
-new Uint32Array([
-	1779033703,
-	3144134277,
-	1013904242,
-	2773480762,
-	1359893119,
-	2600822924,
-	528734635,
-	1541459225
-]);
-//#endregion
-//#region src/review-ladder.ts
-const LADDER_NEXT_ACTION_KINDS = [
-	"run-interior-cycle",
-	"advance-to-gate",
-	"run-gate-cycle",
-	"accept-nonblocking-findings",
-	"escalate-to-triage",
-	"ready-for-human"
-];
-const LADDER_STAGES = [
-	"interior",
-	"interior-complete",
-	"gate"
-];
-const LADDER_FORCED_TRANSITION_KINDS = ["gate-cap-exhausted", "interior-cap-reached"];
-const ladderCycleRefsFor = (cycles) => {
-	let interior = 0;
-	let gate = 0;
-	return cycles.map((entry) => {
-		if (entry.stage === "interior") {
-			if (gate > 0) throw new TypeError("Invalid ladder history: interior cycle recorded after the gate stage began.");
-			interior += 1;
-			return {
-				cycle: interior,
-				stage: "interior"
-			};
-		}
-		gate += 1;
-		return {
-			cycle: gate,
-			stage: "gate"
-		};
-	});
-};
 //#endregion
 //#region src/review-recording-schema.ts
 const ABSENT_PROOF_DIGEST = "absent";
@@ -591,7 +557,7 @@ const recordsShape = {
 		repeatOf: occurrenceAddressSchema$1.optional()
 	}).strict())
 };
-const reviewCycleRecordingSchema = z.union([z.object({
+const reviewCycleRecordingSchema = z.object({
 	...recordsShape,
 	appliedTo: z.union([z.string().regex(sha256Pattern), z.literal(ABSENT_PROOF_DIGEST)]),
 	base: z.object({
@@ -601,13 +567,7 @@ const reviewCycleRecordingSchema = z.union([z.object({
 	dispositionsDigest: z.string().regex(sha256Pattern).optional(),
 	findingsDigest: z.string().regex(sha256Pattern),
 	recordingId: z.string().regex(sha256Pattern)
-}).strict(), z.object({
-	...recordsShape,
-	imported: z.object({
-		proofDigest: z.string().regex(sha256Pattern),
-		schemaVersion: z.literal(2)
-	}).strict()
-}).strict()]);
+}).strict();
 //#endregion
 //#region src/review-recording.ts
 const occurrenceAddressSchema = z.string().regex(OCCURRENCE_ADDRESS_PATTERN);
@@ -628,50 +588,150 @@ z.array(z.union([z.object({
 	}).strict(),
 	reference: z.string().min(1).optional()
 }).strict()]));
-//#endregion
-//#region src/review-proof-import.ts
-const legacyFindingSchema = z.object({
+const REVIEW_LOWER_FINDING_PRIORITIES = [
+	"P2",
+	"P3",
+	"P4"
+];
+const nonBlankString$1 = z.string().trim().min(1);
+const reviewFindingSchema = z.object({
 	blockingAfterCap: z.boolean().optional(),
-	category: z.string().optional(),
-	citedSpan: z.string().optional(),
-	file: z.string().optional(),
-	prescribedAction: z.string().optional(),
-	priority: z.string().optional(),
+	body: nonBlankString$1,
+	category: nonBlankString$1.optional(),
+	citedSpan: nonBlankString$1.optional(),
+	file: nonBlankString$1.optional(),
+	line: z.number().int().positive().optional(),
+	prescribedAction: nonBlankString$1.optional(),
+	priority: nonBlankString$1.optional(),
 	supersedes: z.object({
-		file: z.string().optional(),
-		title: z.string()
-	}).passthrough().optional(),
-	title: z.string()
-}).passthrough();
-const legacyDeclarationSchema = z.object({
-	disposition: z.enum([
-		"fixed-in-thread",
-		"follow-up-filed",
-		"waived"
+		file: nonBlankString$1.optional(),
+		title: nonBlankString$1
+	}).strict().optional(),
+	title: nonBlankString$1
+}).strict();
+const findingsReviewSchema = z.object({
+	findings: z.array(reviewFindingSchema),
+	issuesFlagged: z.number().int().nonnegative(),
+	kind: z.enum(["correctness", "security"]),
+	lowerFindings: z.array(reviewFindingSchema.extend({ priority: z.enum(REVIEW_LOWER_FINDING_PRIORITIES) })).optional(),
+	outcome: z.enum(["passed", "failed"]),
+	summary: nonBlankString$1
+}).strict().superRefine((review, context) => {
+	for (const [index, finding] of review.findings.entries()) if (REVIEW_LOWER_FINDING_PRIORITIES.some((priority) => priority === finding.priority?.trim().toUpperCase())) context.addIssue({
+		code: "custom",
+		message: "Below-floor finding: move it to lowerFindings",
+		path: [
+			"findings",
+			index,
+			"priority"
+		]
+	});
+	if (review.issuesFlagged !== review.findings.length) context.addIssue({
+		code: "custom",
+		message: "issuesFlagged must match findings length",
+		path: ["issuesFlagged"]
+	});
+	if (review.outcome === "passed" && review.findings.length > 0) context.addIssue({
+		code: "custom",
+		message: "passed reviews must not include findings",
+		path: ["findings"]
+	});
+	if (review.outcome === "failed" && review.findings.length === 0) context.addIssue({
+		code: "custom",
+		message: "failed reviews must include findings",
+		path: ["findings"]
+	});
+});
+const reviewResolutionSchema = z.object({
+	reference: nonBlankString$1,
+	target: z.string().regex(OCCURRENCE_ADDRESS_PATTERN)
+}).strict();
+z.object({
+	model: nonBlankString$1,
+	patchId: nonBlankString$1,
+	producer: nonBlankString$1.optional(),
+	resolutions: z.array(reviewResolutionSchema).optional(),
+	reviews: z.array(findingsReviewSchema),
+	rung: z.enum(EVIDENCE_REVIEW_RUNGS).optional(),
+	schemaVersion: z.union([
+		z.literal(1),
+		z.literal(2),
+		z.literal(3)
 	]),
-	finding: z.object({
-		file: z.string().optional(),
-		title: z.string()
-	}).passthrough(),
-	findingReport: legacyFindingSchema.optional(),
-	reference: z.string().optional()
-}).passthrough();
-const legacyCycleSchema = z.object({
-	correlatedRerun: z.boolean().optional(),
-	dispositions: z.array(legacyDeclarationSchema).optional(),
-	engine: z.string().optional(),
-	findings: z.array(legacyFindingSchema),
-	historical: z.literal(true).optional(),
-	identity: z.object({
-		headSha: z.string(),
-		patchId: z.string()
-	}).passthrough().optional(),
-	model: z.string().optional(),
-	session: z.record(z.string(), z.unknown()).optional(),
-	stage: z.enum(["interior", "gate"]),
-	usage: z.record(z.string(), z.unknown()).optional()
-}).passthrough();
-z.object({ cycles: z.array(legacyCycleSchema) }).passthrough();
+	sessionId: nonBlankString$1
+}).strict().superRefine((file, context) => {
+	if (file.schemaVersion === 1) {
+		if (file.producer !== void 0) context.addIssue({
+			code: "custom",
+			message: "producer is a schemaVersion 2 field",
+			path: ["producer"]
+		});
+		if (file.rung !== void 0) context.addIssue({
+			code: "custom",
+			message: "rung is a schemaVersion 2 field",
+			path: ["rung"]
+		});
+	} else {
+		if (file.producer === void 0) context.addIssue({
+			code: "custom",
+			message: `schemaVersion ${file.schemaVersion} findings require producer`,
+			path: ["producer"]
+		});
+		if (file.rung === void 0) context.addIssue({
+			code: "custom",
+			message: `schemaVersion ${file.schemaVersion} findings require rung`,
+			path: ["rung"]
+		});
+	}
+	const seen = /* @__PURE__ */ new Set();
+	for (const [index, review] of file.reviews.entries()) {
+		if (seen.has(review.kind)) context.addIssue({
+			code: "custom",
+			message: `duplicate review kind: ${review.kind}`,
+			path: [
+				"reviews",
+				index,
+				"kind"
+			]
+		});
+		seen.add(review.kind);
+	}
+});
+//#endregion
+//#region src/review-ladder.ts
+const LADDER_NEXT_ACTION_KINDS = [
+	"run-interior-cycle",
+	"advance-to-gate",
+	"run-gate-cycle",
+	"accept-nonblocking-findings",
+	"escalate-to-triage",
+	"ready-for-human"
+];
+const LADDER_STAGES = [
+	"interior",
+	"interior-complete",
+	"gate"
+];
+const LADDER_FORCED_TRANSITION_KINDS = ["gate-cap-exhausted", "interior-cap-reached"];
+const ladderCycleRefsFor = (cycles) => {
+	let interior = 0;
+	let gate = 0;
+	return cycles.map((entry) => {
+		if (entry.stage === "interior") {
+			if (gate > 0) throw new TypeError("Invalid ladder history: interior cycle recorded after the gate stage began.");
+			interior += 1;
+			return {
+				cycle: interior,
+				stage: "interior"
+			};
+		}
+		gate += 1;
+		return {
+			cycle: gate,
+			stage: "gate"
+		};
+	});
+};
 //#endregion
 //#region src/pr-readiness/ladder-proof-state.ts
 const persistedCycleSchema = z.custom((cycle) => typeof cycle === "object" && cycle !== null, "ladder cycle must be an object").superRefine((cycle, context) => {
@@ -721,6 +781,7 @@ const prReviewResultSchema = z.object({
 	findings: z.array(prReviewFindingSchema),
 	issuesFlagged: z.number().int().nonnegative(),
 	kind: z.enum(["correctness", "security"]),
+	lowerFindings: z.array(z.intersection(prReviewFindingSchema, z.object({ priority: z.enum(REVIEW_LOWER_FINDING_PRIORITIES) }))).optional(),
 	model: nonBlankString.optional(),
 	outcome: z.enum([
 		"passed",
@@ -766,35 +827,23 @@ const prReviewResultSchema = z.object({
 		path: [review.producer === void 0 ? "producer" : "rung"]
 	});
 });
+const convertedProofMessage = (value) => {
+	if (typeof value !== "object" || value === null) return;
+	const { importedFrom, recoveryRequired } = value;
+	if (importedFrom === void 0 && recoveryRequired === void 0) return;
+	const proofDigest = importedFrom?.proofDigest;
+	return `Unsupported pr:review proof: it was converted from schema 2 by the retired import, and its schema-2 recovery is no longer read. The original schema-2 bytes are retained at .factory-memory/review-proof-imports/${typeof proofDigest === "string" && /^[0-9a-f]{64}$/u.test(proofDigest) ? proofDigest : "<digest>"}.json; move this proof aside unedited and record a fresh review at the current head.`;
+};
 const prReviewProofSchema = z.object({
 	base: z.string(),
 	changedFiles: z.array(z.string()),
 	cleanedPaths: z.array(z.string()),
 	findingProvenanceVersion: z.literal(1),
 	headSha: z.string().regex(/^[0-9a-f]{40}$/u),
-	importedFrom: z.object({
-		proofDigest: z.string().regex(/^[0-9a-f]{64}$/u),
-		schemaVersion: z.literal(2)
-	}).strict().optional(),
 	ladder: prReviewLadderStateSchema.optional(),
 	maxReviewCycles: z.number().int().positive().optional(),
 	patchId: z.string().regex(/^[0-9a-f]{40,64}$/u),
 	policyResolution: policyResolutionSchema.optional(),
-	recoveryRequired: z.array(z.object({
-		candidates: z.array(z.string().regex(OCCURRENCE_ADDRESS_PATTERN)),
-		cycle: z.number().int().positive(),
-		declaration: z.object({
-			disposition: z.enum([
-				"fixed-in-thread",
-				"follow-up-filed",
-				"waived"
-			]),
-			file: z.string().optional(),
-			reference: z.string().optional(),
-			title: z.string()
-		}).strict(),
-		reason: z.string().min(1)
-	}).strict()).optional(),
 	reviewCycle: z.number().int().positive().optional(),
 	reviewRequirement: z.object({
 		reason: z.enum(["no-applicable-mode", "faithful-merge"]),
@@ -803,10 +852,11 @@ const prReviewProofSchema = z.object({
 	reviews: z.array(prReviewResultSchema),
 	schemaVersion: z.literal(3)
 }).passthrough().superRefine((proof, context) => {
-	if (proof.importedFrom !== void 0 && proof.recoveryRequired === void 0) context.addIssue({
+	const converted = convertedProofMessage(proof);
+	if (converted !== void 0) context.addIssue({
 		code: "custom",
-		message: "a proof converted from schema 2 (importedFrom) must carry recoveryRequired, an array that may be empty",
-		path: ["recoveryRequired"]
+		message: converted,
+		path: ["importedFrom" in proof ? "importedFrom" : "recoveryRequired"]
 	});
 	if (proof.reviewRequirement && proof.reviews.length > 0) context.addIssue({
 		code: "custom",
@@ -1448,11 +1498,7 @@ const boundaryCheckProofSchema = z.object({
 });
 const readinessRepairSchema = z.object({
 	action: z.string().min(1),
-	code: z.enum([
-		"undraft-pr",
-		"render-pr-body-sections",
-		"await-post-undraft-checks"
-	]),
+	code: z.enum(["undraft-pr", "await-post-undraft-checks"]),
 	command: z.string().min(1)
 });
 const reviewStateSchema = z.object({
@@ -1465,18 +1511,6 @@ const reviewStateSchema = z.object({
 });
 const verifyCommandSchema = z.literal("patronage-factory pr:verify");
 const verifiedShaSchema = z.string().min(1);
-const historicalPostReadinessCommentSchema = z.object({
-	author: z.string().min(1),
-	createdAt: z.string().min(1),
-	summary: z.string().min(1),
-	url: z.string().min(1)
-});
-const historicalHandledHumanCommentSchema = z.object({
-	clearedAt: z.string().min(1).optional(),
-	sessionId: z.string().min(1).optional(),
-	source: z.enum(["check-run", "cli"]),
-	url: z.string().min(1)
-});
 const managedReadinessLedgerSchema = z.object({
 	baseSha: z.string().regex(/^[0-9a-f]{40}$/u),
 	blockingReasons: z.array(z.string()),
@@ -1493,7 +1527,6 @@ const managedReadinessLedgerSchema = z.object({
 			"out-of-scope"
 		])
 	})).optional(),
-	finalReviewPoint: z.boolean().optional(),
 	github: z.object({
 		draft: z.boolean(),
 		mergeStateStatus: z.string(),
@@ -1508,16 +1541,9 @@ const managedReadinessLedgerSchema = z.object({
 		reviewDecision: z.string().nullable().optional(),
 		unresolvedReviewThreads: z.number().int().nonnegative()
 	}),
-	handledCommentsProducer: z.object({
-		identity: z.string().min(1),
-		mode: z.enum(["app", "commit-status"])
-	}).optional(),
-	handledHumanComments: z.array(historicalHandledHumanCommentSchema).optional(),
 	headSha: z.string().regex(/^[0-9a-f]{40}$/u),
 	mergeBaseSha: z.string().regex(/^[0-9a-f]{40}$/u).optional(),
 	patchId: z.string().regex(/^[0-9a-f]{40,64}$/u),
-	postReadinessHumanComments: z.array(historicalPostReadinessCommentSchema).optional(),
-	postReadinessHumanReviews: z.array(historicalPostReadinessCommentSchema).optional(),
 	pr: z.number().int().positive(),
 	repairs: z.array(readinessRepairSchema).default([]),
 	reviewCycleState: z.object({
@@ -1570,12 +1596,6 @@ const managedReadinessLedgerSchema = z.object({
 		security: reviewStateSchema.optional()
 	}),
 	schemaVersion: z.literal(2),
-	stackRole: z.enum([
-		"single",
-		"slice",
-		"rollup",
-		"merge-gate prerequisite"
-	]).optional(),
 	verification: z.discriminatedUnion("prVerify", [
 		z.object({
 			command: verifyCommandSchema,
@@ -1641,11 +1661,7 @@ const prReadyProofSchema = z.object({
 	repairs: z.array(readinessRepairSchema).default([]),
 	repository: z.string().regex(/^[^/\s]+\/[^/\s]+$/u).optional(),
 	schemaVersion: prReadySchemaVersionSchema,
-	status: z.enum([
-		"ready",
-		"blocked",
-		"slice-ready/not-final"
-	]),
+	status: z.enum(["ready", "blocked"]),
 	waivedDemands: z.array(waivedDemandSchema).optional()
 }).superRefine((proof, context) => {
 	for (const issue of blockedReasonIssues({ ...proof })) context.addIssue(issue);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@patronage/software-factory",
-  "version": "1.0.0-alpha.39",
+  "version": "1.0.0-alpha.40",
   "description": "Shared Patronage software factory CLI and project-profile validation tools",
   "license": "MIT",
   "repository": {
@@ -23,10 +23,6 @@
       "types": "./dist/index.d.ts",
       "default": "./dist/index.js"
     },
-    "./oxlint-jev": {
-      "types": "./dist/oxlint-jev/index.d.ts",
-      "default": "./dist/oxlint-jev/index.js"
-    },
     "./schemas": {
       "types": "./dist/schemas.d.ts",
       "default": "./dist/schemas.js"
@@ -37,15 +33,13 @@
     "tag": "next"
   },
   "dependencies": {
-    "@typesafe-ai/sdk": "0.6.0",
     "commander": "14.0.3",
     "picomatch": "^4.0.5",
     "yaml": "^2.9.0",
     "zod": "4.4.3",
-    "@patronage/factory-ci": "1.0.0-alpha.39"
+    "@patronage/factory-ci": "1.0.0-alpha.40"
   },
   "devDependencies": {
-    "@oxlint/plugins": "1.76.0",
     "@types/node": "24.13.3",
     "@types/picomatch": "^4.0.3",
     "@vitest/coverage-v8": "4.1.10",