@patronage/software-factory 1.0.0-alpha.21 → 1.0.0-alpha.22

package/README.md

@@ -66,7 +66,7 @@ Generated production workflows may call `psf production:impact --before <sha> --
 
 Generated pull-request workflows may call `psf candidate:impact --base <sha> --head <sha> --github-output <path>` to route Candidate verification surfaces. The command evaluates the same profile impact declarations and pnpm dependency graph from the exact base/head identity, diffed from their merge base; it is the candidate-named sibling of `production:impact` and replaces repository-owned path filters, never adds a second matcher. The `head` commit must be the checked-out `HEAD`, and both commits must be reachable (`fetch-depth: 0`). Every doubt path — unreadable identity, malformed or unsupported graph data, an unowned profile change, a working-tree profile that differs from the head commit, or classifier refusal — fails closed and leaves every declared target demanded. `production:impact` keeps its merge-push `before`/`after` contract unchanged.
 
-For factory workflow, install the four canonical skills from the repository:
+For factory workflow, install the four canonical skills as the `patronage-software-factory` host plugin (Claude Code, Codex, or Cursor; see [`skills/README.md`](../skills/README.md)). Cloud agents that cannot load host plugins fall back to:
 
 ```bash
 npx skills add https://github.com/patronage/software-factory -g --all

package/dist/index.d.ts

@@ -1423,9 +1423,9 @@ declare const managedReadinessLedgerSchema: z.ZodObject<{
       reviewedHeadSha: z.ZodOptional<z.ZodString>;
       reviewedPatchId: z.ZodOptional<z.ZodString>;
       status: z.ZodEnum<{
+        blocked: "blocked";
         "not-required": "not-required";
         stale: "stale";
-        blocked: "blocked";
         current: "current";
         missing: "missing";
       }>;
@@ -1435,9 +1435,9 @@ declare const managedReadinessLedgerSchema: z.ZodObject<{
       reviewedHeadSha: z.ZodOptional<z.ZodString>;
       reviewedPatchId: z.ZodOptional<z.ZodString>;
       status: z.ZodEnum<{
+        blocked: "blocked";
         "not-required": "not-required";
         stale: "stale";
-        blocked: "blocked";
         current: "current";
         missing: "missing";
       }>;
@@ -2415,9 +2415,9 @@ declare const loadEvidenceEnvelopes: (cwd: string) => LoadedEvidenceEnvelope[];
 //#region src/review-proof-applicability.d.ts
 declare const REVIEW_STATUS_VALUES: readonly ["not-required", "current", "stale", "missing", "blocked"];
 declare const reviewStatusSchema: z.ZodEnum<{
+  blocked: "blocked";
   "not-required": "not-required";
   stale: "stale";
-  blocked: "blocked";
   current: "current";
   missing: "missing";
 }>;
@@ -2566,8 +2566,8 @@ declare const boundaryCheckProofSchema: z.ZodObject<{
     value: z.ZodString;
   }, z.core.$strip>>;
   status: z.ZodEnum<{
-    ready: "ready";
     blocked: "blocked";
+    ready: "ready";
   }>;
 }, z.core.$strip>;
 type BoundaryCheckProofRecord = z.infer<typeof boundaryCheckProofSchema>;
@@ -2582,6 +2582,14 @@ interface BoundaryCheckGithub {
 interface BoundaryCheckArgs {
   cwd?: string;
   epic: number;
+  /**
+   * Closeout-final mode (#853): a manifest-declared issue whose closing-PR
+   * set is empty is a blocking reason, not a notice. Off by default so the
+   * interior boundary review (run before the terminal release PR exists,
+   * e.g. epic #842's own review of #844) keeps working; the epic closeout
+   * step turns this on as the last check before factory:closeout.
+   */
+  final?: boolean;
   json?: boolean;
   output?: string;
   repo?: string;
@@ -4147,13 +4155,13 @@ declare const evaluateReadiness: (input: EvaluationInput) => {
     reviews: {
       correctness: {
         required: boolean;
-        status: "not-required" | "stale" | "blocked" | "current" | "missing";
+        status: "blocked" | "not-required" | "stale" | "current" | "missing";
         reviewedHeadSha?: string | undefined;
         reviewedPatchId?: string | undefined;
       };
       security?: {
         required: boolean;
-        status: "not-required" | "stale" | "blocked" | "current" | "missing";
+        status: "blocked" | "not-required" | "stale" | "current" | "missing";
         reviewedHeadSha?: string | undefined;
         reviewedPatchId?: string | undefined;
       } | undefined;

package/dist/index.js

@@ -17,7 +17,7 @@ import { parse } from "yaml";
 import { FACTORY_PROOF_GATE_APP_ID, FACTORY_PROOF_GATE_STEP_NAME, GitHubApiError, mintInstallationToken, previewProofInventory, productionImpactTargetOutput, readVitestProfileDocument } from "@patronage/factory-ci";
 import { promisify } from "node:util";
 //#region package.json
-var version = "1.0.0-alpha.21";
+var version = "1.0.0-alpha.22";
 //#endregion
 //#region src/review-rungs.ts
 const EVIDENCE_REVIEW_RUNGS$1 = [
@@ -162,10 +162,11 @@ const DEFAULT_TERMINAL_BASE = "main";
 *
 * A PR that closed without merging contributes NO closing link (#821): it
 * carried nothing into the boundary, so it is not a member and cannot fail
-* one. The dropped link is recorded on the issue. Closeout blocks only on
-* that flavor: an issue whose carriers all closed without merging. A declared
-* issue that never had any closing link is reported as a notice, not a
-* blocking reason (open question: #853).
+* one. The dropped link is recorded on the issue. Closeout blocks by default
+* only on that flavor: an issue whose carriers all closed without merging. A
+* declared issue that never had any closing link is reported as a notice,
+* not a blocking reason — except under boundary:check --final, which blocks
+* on that flavor too (#853).
 */
 const buildBoundaryMembershipGraph = (manifest, fetchClosingPullRequests) => {
 	const memberships = [];
@@ -5439,10 +5440,12 @@ function runBoundaryCheck(args, dependencies = {}) {
 			selected
 		});
 		const uncoveredIssueReasons = graph.unlinkedIssues.flatMap((entry) => entry.closedWithoutMerge === void 0 ? [] : [`issue #${entry.issue} (wave ${entry.wave}) is uncovered: its only closing link(s) ${entry.closedWithoutMerge.map((pr) => `PR #${pr}`).join(", ")} closed without merging`]);
+		const finalUncoveredIssueReasons = args.final ? graph.unlinkedIssues.flatMap((entry) => entry.closedWithoutMerge === void 0 ? [`issue #${entry.issue} (wave ${entry.wave}) has no linked closing PR; --final requires every declared issue to be covered before closeout`] : []) : [];
 		blockingReasons.unshift(...boundaryTopologyReasons({
 			manifest: parsed.manifest,
 			pullRequests: computed.pullRequests
-		}), ...uncoveredIssueReasons);
+		}), ...uncoveredIssueReasons, ...finalUncoveredIssueReasons);
+		const specHashNotices = selected?.proof.specHash !== void 0 && selected.proof.specHash.value !== specHash ? [`boundary-review proof spec sha256 ${selected.proof.specHash.value} does not match current epic spec sha256 ${specHash}; use the specHash from the blocked boundary:check record instead of hashing shell-rendered output`] : [];
 		record = {
 			blockingReasons,
 			boundary: parsed.manifest.boundary,
@@ -5454,7 +5457,7 @@ function runBoundaryCheck(args, dependencies = {}) {
 				algo: "sha256",
 				value: parsed.manifestHash
 			},
-			notices: computed.notices,
+			notices: [...computed.notices, ...specHashNotices],
 			repo,
 			...selected ? { reviewProof: {
 				...selected.commentId === void 0 ? {} : { commentId: selected.commentId },
@@ -6203,7 +6206,7 @@ const renderReport = (record) => {
 	return `${lines.join("\n")}\n`;
 };
 function createBoundaryCheckCommand(output, action) {
-	return markCwdOptionDefault(new Command("boundary:check").description("Boundary readiness gate (T8): require a membership-fresh boundary-review proof at the declared closeout rung. Blocks closeout/enablement, never merge.").requiredOption("--epic <number>", "issue number carrying the factory-boundary manifest, which may be the work issue itself (#789)", positiveInteger$1("--epic")).option("--repo <owner/name>", "GitHub repository (default: resolved from --cwd)").option("--cwd <path>", "repository working directory", collectCwdOption).option("--output <path>", "write an additional proof copy to this path").option("--profile <path>", "path to the project profile JSON file").option("--json", "print the full proof record as JSON").action(withGateTiming({
+	return markCwdOptionDefault(new Command("boundary:check").description("Boundary readiness gate (T8): require a membership-fresh boundary-review proof at the declared closeout rung. Blocks closeout/enablement, never merge.").requiredOption("--epic <number>", "issue number carrying the factory-boundary manifest, which may be the work issue itself (#789)", positiveInteger$1("--epic")).option("--repo <owner/name>", "GitHub repository (default: resolved from --cwd)").option("--cwd <path>", "repository working directory", collectCwdOption).option("--output <path>", "write an additional proof copy to this path").option("--profile <path>", "path to the project profile JSON file").option("--json", "print the full proof record as JSON").option("--final", "closeout-final mode (#853): a declared issue with no closing PR blocks instead of only noticing. Run as the last check before factory:closeout.").action(withGateTiming({
 		gate: "boundary:check",
 		resolveLedgerRoot: (options) => resolveCwdOption(options.cwd),
 		stderr: output.stderr
@@ -6213,7 +6216,8 @@ function createBoundaryCheckCommand(output, action) {
 			epic: options.epic,
 			...options.repo ? { repo: options.repo } : {},
 			...options.output ? { output: options.output } : {},
-			...options.json ? { json: true } : {}
+			...options.json ? { json: true } : {},
+			...options.final ? { final: true } : {}
 		};
 		const record = action ? action(args) : runBoundaryCheck(args);
 		output.stdout.write(options.json ? `${JSON.stringify(record, null, 2)}\n` : renderReport(record));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@patronage/software-factory",
-  "version": "1.0.0-alpha.21",
+  "version": "1.0.0-alpha.22",
   "description": "Shared Patronage software factory CLI and project-profile validation tools",
   "license": "MIT",
   "repository": {
@@ -37,7 +37,7 @@
     "picomatch": "^4.0.5",
     "yaml": "^2.9.0",
     "zod": "4.4.3",
-    "@patronage/factory-ci": "1.0.0-alpha.21"
+    "@patronage/factory-ci": "1.0.0-alpha.22"
   },
   "devDependencies": {
     "@types/node": "24.13.3",
@@ -52,8 +52,7 @@
     "tsx": "4.23.1",
     "typescript": "5.9.3",
     "ultracite": "7.10.5",
-    "vitest": "4.1.10",
-    "vitest-evals": "0.14.0"
+    "vitest": "4.1.10"
   },
   "engines": {
     "node": "^24.0.0"
@@ -70,10 +69,6 @@
     "precoverage": "bash ../scripts/ensure-worktree-bootstrap.sh",
     "coverage": "vitest run --coverage",
     "docs:reference": "tsx scripts/update-command-reference.ts",
-    "eval:review": "tsx evals/review-prompts/track-b/reviewRunner.ts",
-    "eval:review:report": "tsx evals/review-prompts/track-b/reviewReport.ts",
-    "eval:review:rescore": "tsx evals/review-prompts/track-b/rescore.ts",
-    "eval:review:run": "vitest run --config evals/review-prompts/vitest.eval.config.ts",
     "pack:smoke": "bash scripts/pack-smoke.sh",
     "profile:schema": "tsx scripts/generate-profile-schema.ts",
     "pretest": "bash ../scripts/ensure-worktree-bootstrap.sh",