@patronage/software-factory 0.30.0-alpha.1 → 0.30.0-beta.3

package/dist/schemas.js

@@ -19,34 +19,28 @@ const DEMAND_KEYS = {
 	boundaryWave: "boundary-wave",
 	/** The PR is still a draft. */
 	draft: "draft",
-	/** The candidate is not the intended final human review point. */
-	finalReviewPoint: "final-review-point",
 	/** GitHub's own check rollup for the candidate head. */
 	githubChecks: "github-checks",
 	/** Local HEAD and the GitHub PR head must be the same commit. */
 	headIdentity: "head-identity",
-	/** An unhandled post-readiness human comment or review submission. */
+	/** GitHub's live aggregate review decision is CHANGES_REQUESTED. */
 	humanBlocker: "human-blocker",
 	/** The repository-wide merge freeze. */
 	mergeFreeze: "merge-freeze",
 	/** GitHub's mergeability / merge-state rollup. */
 	mergeState: "merge-state",
 	/**
-	* A native GitHub approval, demanded when the boundary wave in force does
-	* not authorize machine merge (#477). "Green = authorized to merge" is then
-	* a property of the branded required check itself.
+	* Retired readiness demand, retained solely to parse historical v3 proofs
+	* and their HQ payloads. No current command emits it: GitHub approval is
+	* neither a review-rung authority nor a scheduling requirement.
 	*/
 	nativeApproval: "native-approval",
-	/** The PR body's required rendered sections. */
-	prBodySections: "pr-body-sections",
 	/** A current, head-bound, passing typed `pr:verify` proof. */
 	prVerify: "pr-verify",
 	/** The profile-resolved review ladder policy. */
 	reviewLadder: "review-ladder",
 	/** Unresolved GitHub review threads. */
-	reviewThreads: "review-threads",
-	/** An explicit trivial waiver that the diff does not support. */
-	trivialWaiver: "trivial-waiver"
+	reviewThreads: "review-threads"
 };
 /** The families whose instances are named by a resolved value. */
 const QUALIFIED_DEMAND_FAMILIES = [
@@ -188,29 +182,18 @@ const blockedReasonIssue = (message) => [{
 * wire schema so it is one rule rather than two that can drift. It is the
 * producer's state machine, written down:
 *
-* - `ready` refused nothing, so it carries neither projection, and it is the
-*   final review point;
-* - `slice-ready/not-final` was held back by exactly one demand — being a
-*   slice — and names it;
-* - `blocked` refused something other than being a slice, and says so;
+* - `ready` refused nothing, so it carries neither projection;
+* - `blocked` refused something and says so;
 * - whichever it is, `blockedReasons` names every refusal listed in
 *   `blockingReasons`, in the same order, as the bounded form of that sentence.
 *
-* Naming the slice demand and the ledger's `finalReviewPoint` are the same
-* fact, so a proof that says one and not the other is refused.
 */
 const blockedReasonIssues = (proof) => {
 	const named = proof.blockedReasons ?? [];
 	const reasons = proof.blockingReasons ?? [];
-	const slice = DEMAND_KEYS.finalReviewPoint;
-	const namesSlice = named.some((reason) => reason.code === slice);
 	if (proof.status === "ready") {
 		if (named.length > 0 || reasons.length > 0) return blockedReasonIssue("a ready pr:ready proof must carry no blocking reasons");
-	} else if (proof.status === "slice-ready/not-final") {
-		if (named.length !== 1 || !namesSlice) return blockedReasonIssue(`a slice-ready/not-final pr:ready proof is held back by exactly one demand, ${slice}`);
 	} else if (reasons.length === 0) return blockedReasonIssue("a blocked pr:ready proof must record what blocked it");
-	else if (named.length > 0 && !named.some((r) => r.code !== slice)) return blockedReasonIssue(`a blocked pr:ready proof must name a demand other than ${slice}`);
-	if (proof.finalReviewPoint !== void 0 && namesSlice === proof.finalReviewPoint) return blockedReasonIssue(`naming ${slice} and the ledger's finalReviewPoint are the same fact; this proof says both`);
 	if (named.length !== reasons.length) return blockedReasonIssue(`blockedReasons must name every blocking reason: ${reasons.length} reason(s), ${named.length} named`);
 	const drifted = named.findIndex((reason, index) => reason.detail !== blockedReasonDetail(reasons[index]));
 	return drifted === -1 ? [] : blockedReasonIssue(`blockedReasons[${drifted}] does not carry blocking reason ${drifted}; the two projections must tell one story`);
@@ -228,7 +211,7 @@ const demandWaiverSchema = z.object({
 	operator: z.string().trim().min(1),
 	rationale: z.string().trim().min(1),
 	recordedAt: z.iso.datetime(),
-	session: z.string().trim().min(1)
+	session: z.string().trim().min(1).optional()
 });
 z.object({
 	command: z.literal("patronage-factory demand:waive"),
@@ -240,9 +223,12 @@ const waivedDemandSchema = z.object({
 	operator: z.string().trim().min(1),
 	rationale: z.string().trim().min(1),
 	recordedAt: z.iso.datetime(),
-	session: z.string().trim().min(1),
+	session: z.string().trim().min(1).optional(),
 	unmetReasons: z.array(z.string().min(1)).min(1)
 });
+const LEGACY_CLOSEOUT_SCHEMA_VERSION = 3;
+/** Current writer plus retained reader versions accepted at ingest. */
+const SUPPORTED_CLOSEOUT_SCHEMA_VERSIONS = [LEGACY_CLOSEOUT_SCHEMA_VERSION, 4];
 const MAX_CLOSEOUT_ROWS = 1e3;
 const IdentifierSchema = z.string().min(1).max(500);
 const NarrativeSchema = z.string().min(1).max(1e4);
@@ -254,11 +240,15 @@ const CloseoutLandingSpotSchema = z.enum([
 	"skill",
 	"ADR"
 ]);
-const CloseoutSourceSchema = z.object({
+const CurrentCloseoutSourceSchema = z.object({
+	detail: NarrativeSchema,
+	kind: z.literal("boundary-thermo-attestation")
+}).strict();
+const LegacyCloseoutSourceSchema = z.object({
 	detail: NarrativeSchema,
 	kind: z.enum(["interior-telemetry", "boundary-thermo-attestation"])
 }).strict();
-const CloseoutScopingSchema = z.object({
+const LegacyCloseoutScopingSchema = z.object({
 	epic: IdentifierSchema,
 	issueFilter: z.number().int().positive().optional(),
 	prFilter: z.number().int().positive().optional(),
@@ -270,9 +260,13 @@ const CloseoutScopingSchema = z.object({
 	}).strict()
 }).strict();
 const CloseoutBudgetSchema = z.object({
+	note: NarrativeSchema,
+	tier: z.literal("overseer")
+}).strict();
+const LegacyCloseoutBudgetSchema = z.object({
 	interiorSourcesConsumed: z.number().int().nonnegative(),
 	note: NarrativeSchema,
-	scoping: CloseoutScopingSchema.optional(),
+	scoping: LegacyCloseoutScopingSchema.optional(),
 	tier: z.literal("overseer")
 }).strict();
 const BoundaryThermoAttestationSchema = z.object({
@@ -284,7 +278,23 @@ const BoundaryThermoAttestationSchema = z.object({
 const CloseoutMetricRowSchema = z.object({
 	label: IdentifierSchema,
 	metric: IdentifierSchema,
-	source: CloseoutSourceSchema,
+	source: CurrentCloseoutSourceSchema,
+	unit: z.enum([
+		"count",
+		"boolean",
+		"text"
+	]),
+	value: z.union([
+		z.number(),
+		NarrativeSchema,
+		z.boolean(),
+		z.null()
+	])
+}).strict();
+const LegacyCloseoutMetricRowSchema = z.object({
+	label: IdentifierSchema,
+	metric: IdentifierSchema,
+	source: LegacyCloseoutSourceSchema,
 	unit: z.enum([
 		"tokens",
 		"usd",
@@ -305,14 +315,21 @@ const CloseoutLessonSchema = z.object({
 	landingSpot: CloseoutLandingSpotSchema,
 	lesson: NarrativeSchema,
 	rationale: NarrativeSchema.optional(),
-	source: CloseoutSourceSchema.optional()
+	source: CurrentCloseoutSourceSchema.optional()
+}).strict();
+const LegacyCloseoutLessonSchema = z.object({
+	id: IdentifierSchema,
+	landingSpot: CloseoutLandingSpotSchema,
+	lesson: NarrativeSchema,
+	rationale: NarrativeSchema.optional(),
+	source: LegacyCloseoutSourceSchema.optional()
 }).strict();
 const CloseoutBlindspotSchema = z.object({
 	id: IdentifierSchema,
 	note: NarrativeSchema,
 	reason: NarrativeSchema.optional()
 }).strict();
-const CloseoutLedgerRowSchema = z.object({
+const closeoutLedgerRowSchema = (schemaVersion) => z.object({
 	detail: NarrativeSchema.optional(),
 	epic: IdentifierSchema,
 	generatedAt: z.iso.datetime(),
@@ -324,7 +341,7 @@ const CloseoutLedgerRowSchema = z.object({
 		"lesson",
 		"blindspot"
 	]),
-	schemaVersion: z.literal(3),
+	schemaVersion: z.literal(schemaVersion),
 	source: NarrativeSchema,
 	unit: IdentifierSchema.optional(),
 	value: z.union([
@@ -333,19 +350,38 @@ const CloseoutLedgerRowSchema = z.object({
 		z.null()
 	])
 }).strict();
-/** Strict, bounded runtime transport contract emitted by factory:closeout. */
-const closeoutArtifactSchema = z.object({
+const CloseoutLedgerRowSchema = closeoutLedgerRowSchema(4);
+const LegacyCloseoutLedgerRowSchema = closeoutLedgerRowSchema(LEGACY_CLOSEOUT_SCHEMA_VERSION);
+const closeoutArtifactShape = (input) => z.object({
 	boundaryThermo: BoundaryThermoAttestationSchema,
-	budget: CloseoutBudgetSchema,
+	budget: input.budget,
 	couldNotSee: z.array(CloseoutBlindspotSchema).min(1).max(MAX_CLOSEOUT_ROWS),
 	epic: IdentifierSchema,
 	generatedAt: z.iso.datetime(),
-	ledgerRows: z.array(CloseoutLedgerRowSchema).max(MAX_CLOSEOUT_ROWS),
-	lessons: z.array(CloseoutLessonSchema).max(MAX_CLOSEOUT_ROWS),
-	metrics: z.array(CloseoutMetricRowSchema).max(MAX_CLOSEOUT_ROWS),
+	ledgerRows: z.array(input.ledgerRows).max(MAX_CLOSEOUT_ROWS),
+	lessons: z.array(input.lessons).max(MAX_CLOSEOUT_ROWS),
+	metrics: z.array(input.metrics).max(MAX_CLOSEOUT_ROWS),
 	repo: RepoSchema,
-	schemaVersion: z.literal(3)
+	schemaVersion: z.literal(input.schemaVersion)
 }).strict();
+/** Strict, bounded runtime transport contract emitted by factory:closeout. */
+const closeoutArtifactSchema = closeoutArtifactShape({
+	budget: CloseoutBudgetSchema,
+	ledgerRows: CloseoutLedgerRowSchema,
+	lessons: CloseoutLessonSchema,
+	metrics: CloseoutMetricRowSchema,
+	schemaVersion: 4
+});
+/** Reader-only compatibility for closeout artifacts written before #554. */
+const legacyCloseoutArtifactSchema = closeoutArtifactShape({
+	budget: LegacyCloseoutBudgetSchema,
+	ledgerRows: LegacyCloseoutLedgerRowSchema,
+	lessons: LegacyCloseoutLessonSchema,
+	metrics: LegacyCloseoutMetricRowSchema,
+	schemaVersion: LEGACY_CLOSEOUT_SCHEMA_VERSION
+});
+/** Accept current output and retained v3 artifacts when reading or replaying. */
+const closeoutArtifactReadSchema = z.union([closeoutArtifactSchema, legacyCloseoutArtifactSchema]);
 //#endregion
 //#region src/retro-envelope.ts
 /**
@@ -523,11 +559,6 @@ const RetroCycleCountersSchema = z.object({
 	thermoFixRounds: nonNegInt
 }).strict();
 const RetroOutcomeSchema = z.object({
-	mergeCheck: z.enum([
-		"pass",
-		"fail",
-		"not-run"
-	]).optional(),
 	status: z.enum([
 		"success",
 		"blocked",
@@ -731,11 +762,7 @@ const PR_REVIEW_SCHEMA_VERSION = 2;
 const PR_REVIEW_FINDING_PROVENANCE_VERSION = 1;
 const nonBlankString = z.string().refine((value) => value.trim().length > 0, { message: "must not be blank" });
 const parseableDateString = z.string().refine((value) => Number.isFinite(Date.parse(value)), { message: "must be a parseable date string" });
-const reviewPromptSectionProvenances = [
-	"prior-review-ledger",
-	"profile-standing-checklist",
-	"issue-review-focus"
-];
+const reviewPromptSectionProvenances = ["prior-review-ledger", "issue-review-focus"];
 const reviewPromptSectionSchema = z.object({
 	provenance: z.enum(reviewPromptSectionProvenances),
 	source: nonBlankString,
@@ -1009,6 +1036,18 @@ const reviewStateSchema = z.object({
 	reviewedPatchId: z.string().optional(),
 	status: z.enum(REVIEW_STATUS_VALUES)
 });
+const historicalPostReadinessCommentSchema = z.object({
+	author: z.string().min(1),
+	createdAt: z.string().min(1),
+	summary: z.string().min(1),
+	url: z.string().min(1)
+});
+const historicalHandledHumanCommentSchema = z.object({
+	clearedAt: z.string().min(1).optional(),
+	sessionId: z.string().min(1).optional(),
+	source: z.enum(["check-run", "cli"]),
+	url: z.string().min(1)
+});
 const managedReadinessLedgerSchema = z.object({
 	baseSha: z.string().regex(/^[0-9a-f]{40}$/u),
 	blockingReasons: z.array(z.string()),
@@ -1026,9 +1065,8 @@ const managedReadinessLedgerSchema = z.object({
 			"out-of-scope"
 		])
 	})).optional(),
-	finalReviewPoint: z.boolean(),
+	finalReviewPoint: z.boolean().optional(),
 	github: z.object({
-		currentWithBase: z.boolean(),
 		draft: z.boolean(),
 		mergeStateStatus: z.string(),
 		mergeable: z.string(),
@@ -1039,47 +1077,20 @@ const managedReadinessLedgerSchema = z.object({
 			"none",
 			"unknown"
 		]),
+		reviewDecision: z.string().nullable().optional(),
 		unresolvedReviewThreads: z.number().int().nonnegative()
 	}),
 	handledCommentsProducer: z.object({
 		identity: z.string().min(1),
 		mode: z.enum(["app", "commit-status"])
 	}).optional(),
-	handledHumanComments: z.array(z.object({
-		clearedAt: z.string().min(1).optional(),
-		sessionId: z.string().min(1).optional(),
-		source: z.enum(["check-run", "cli"]),
-		url: z.string().min(1)
-	})).optional(),
+	handledHumanComments: z.array(historicalHandledHumanCommentSchema).optional(),
 	headSha: z.string().regex(/^[0-9a-f]{40}$/u),
 	mergeBaseSha: z.string().regex(/^[0-9a-f]{40}$/u).optional(),
 	patchId: z.string().regex(/^[0-9a-f]{40,64}$/u),
-	postReadinessHumanComments: z.array(z.object({
-		author: z.string().min(1),
-		createdAt: z.string().min(1),
-		summary: z.string().min(1),
-		url: z.string().min(1)
-	})).optional(),
+	postReadinessHumanComments: z.array(historicalPostReadinessCommentSchema).optional(),
+	postReadinessHumanReviews: z.array(historicalPostReadinessCommentSchema).optional(),
 	pr: z.number().int().positive(),
-	previewDeploy: z.object({
-		adminUrl: z.string().optional(),
-		apiHealthUrl: z.string().optional(),
-		headSha: z.string().optional(),
-		localPreviewProof: z.unknown().optional(),
-		localProofPath: z.string().optional(),
-		proofSource: z.enum(["github-actions", "local-self-certified"]).optional(),
-		publicUrl: z.string().optional(),
-		seedStatus: z.enum([
-			"passed",
-			"failed",
-			"skipped",
-			"unknown"
-		]),
-		stage: z.string().optional(),
-		timingsMs: z.record(z.string(), z.number().optional()).optional(),
-		workflowRunUrl: z.string().optional()
-	}).optional(),
-	previewDeployRequired: z.boolean(),
 	repairs: z.array(readinessRepairSchema).default([]),
 	reviewCycleState: z.object({
 		autoBlockingFindings: z.number().int().nonnegative(),
@@ -1152,7 +1163,7 @@ const managedReadinessLedgerSchema = z.object({
 		"slice",
 		"rollup",
 		"merge-gate prerequisite"
-	]),
+	]).optional(),
 	verification: z.object({
 		command: z.literal("patronage-factory pr:verify"),
 		docsOnlyDeltaAccepted: z.boolean().optional(),
@@ -1217,10 +1228,7 @@ const prReadyProofSchema = z.object({
 		});
 		return;
 	}
-	for (const issue of blockedReasonIssues({
-		...proof,
-		finalReviewPoint: proof.ledger.finalReviewPoint
-	})) context.addIssue(issue);
+	for (const issue of blockedReasonIssues({ ...proof })) context.addIssue(issue);
 });
 //#endregion
-export { BLOCKED_REASONS_MAX, BLOCKED_REASON_DETAIL_MAX, BOUNDARY_CHECK_SCHEMA_VERSION, BOUNDARY_REVIEW_PROOF_KIND, EVIDENCE_ENVELOPE_SCHEMA_VERSION, PR_READY_SCHEMA_VERSION, PR_REVIEW_SCHEMA_VERSION, RETRO_ENVELOPE_SCHEMA_VERSION, RETRO_ENVELOPE_VALIDATORS, RETRO_ENVELOPE_WIRE_BOUNDS, SUPPORTED_PR_READY_SCHEMA_VERSIONS, SUPPORTED_PR_VERIFY_SCHEMA_VERSIONS, SUPPORTED_RETRO_ENVELOPE_SCHEMA_VERSIONS, blockedReasonSchema, blockedReasonsSchema, boundaryCheckProofSchema, boundaryReviewProofSchema, closeoutArtifactSchema, evidenceEnvelopeSchema, prReadyProofSchema, prReviewProofSchema, prVerifyProofSchema, retroEnvelopeV1Schema, retroEpicReference, waivedDemandSchema };
+export { BLOCKED_REASONS_MAX, BLOCKED_REASON_DETAIL_MAX, BOUNDARY_CHECK_SCHEMA_VERSION, BOUNDARY_REVIEW_PROOF_KIND, EVIDENCE_ENVELOPE_SCHEMA_VERSION, PR_READY_SCHEMA_VERSION, PR_REVIEW_SCHEMA_VERSION, RETRO_ENVELOPE_SCHEMA_VERSION, RETRO_ENVELOPE_VALIDATORS, RETRO_ENVELOPE_WIRE_BOUNDS, SUPPORTED_CLOSEOUT_SCHEMA_VERSIONS, SUPPORTED_PR_READY_SCHEMA_VERSIONS, SUPPORTED_PR_VERIFY_SCHEMA_VERSIONS, SUPPORTED_RETRO_ENVELOPE_SCHEMA_VERSIONS, blockedReasonSchema, blockedReasonsSchema, boundaryCheckProofSchema, boundaryReviewProofSchema, closeoutArtifactReadSchema, closeoutArtifactSchema, evidenceEnvelopeSchema, legacyCloseoutArtifactSchema, prReadyProofSchema, prReviewProofSchema, prVerifyProofSchema, retroEnvelopeV1Schema, retroEpicReference, waivedDemandSchema };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@patronage/software-factory",
-  "version": "0.30.0-alpha.1",
+  "version": "0.30.0-beta.3",
   "description": "Shared Patronage software factory CLI and project-profile validation tools",
   "license": "MIT",
   "repository": {