@patronage/software-factory 0.25.0 → 0.30.0-beta.1

package/dist/schemas.js

@@ -10,30 +10,37 @@ Object.fromEntries(EVIDENCE_REVIEW_RUNGS$1.map((rung, index) => [rung, index]));
 //#region src/demand-keys.ts
 /** The demands that exist at most once per candidate. */
 const DEMAND_KEYS = {
+	/**
+	* The boundary wave that authorizes this candidate's merge schedule (#477).
+	* In force exactly when GitHub already has auto-merge enabled: a live
+	* schedule with no wave demand resolved is an unauthorized merge waiting to
+	* happen.
+	*/
+	boundaryWave: "boundary-wave",
 	/** The PR is still a draft. */
 	draft: "draft",
-	/** The candidate is not the intended final human review point. */
-	finalReviewPoint: "final-review-point",
 	/** GitHub's own check rollup for the candidate head. */
 	githubChecks: "github-checks",
 	/** Local HEAD and the GitHub PR head must be the same commit. */
 	headIdentity: "head-identity",
-	/** An unhandled post-readiness human comment or review submission. */
+	/** GitHub's live aggregate review decision is CHANGES_REQUESTED. */
 	humanBlocker: "human-blocker",
 	/** The repository-wide merge freeze. */
 	mergeFreeze: "merge-freeze",
 	/** GitHub's mergeability / merge-state rollup. */
 	mergeState: "merge-state",
-	/** The PR body's required rendered sections. */
-	prBodySections: "pr-body-sections",
+	/**
+	* Retired readiness demand, retained solely to parse historical v3 proofs
+	* and their HQ payloads. No current command emits it: GitHub approval is
+	* neither a review-rung authority nor a scheduling requirement.
+	*/
+	nativeApproval: "native-approval",
 	/** A current, head-bound, passing typed `pr:verify` proof. */
 	prVerify: "pr-verify",
 	/** The profile-resolved review ladder policy. */
 	reviewLadder: "review-ladder",
 	/** Unresolved GitHub review threads. */
-	reviewThreads: "review-threads",
-	/** An explicit trivial waiver that the diff does not support. */
-	trivialWaiver: "trivial-waiver"
+	reviewThreads: "review-threads"
 };
 /** The families whose instances are named by a resolved value. */
 const QUALIFIED_DEMAND_FAMILIES = [
@@ -54,7 +61,7 @@ const percentEncode = (character) => {
 * demand nobody waived, and make HQ count two causes as one.
 *
 * Deterministic in both directions of use: the key a `pr:ready` proof records
-* is the key a `pr:merge-check` waiver matches.
+* is the key a `pr:ready` waiver matches.
 */
 const demandQualifier = (value) => value.replaceAll(/[^A-Za-z0-9._/-]/gu, percentEncode);
 const FIXED_DEMAND_KEYS = Object.values(DEMAND_KEYS);
@@ -132,7 +139,7 @@ const demandKeySchema = z.string().refine((value) => {
 * reason codes must come from. A waiver store is durable operator evidence
 * written before today's vocabulary existed, so tightening its validation
 * would make an existing record parse as no waiver and let the next write drop
-* it. A waiver naming a key nobody resolves is already inert — `pr:merge-check`
+* it. A waiver naming a key nobody resolves is already inert — `pr:ready`
 * reports it as an unapplied waiver — so nothing is admitted by accepting it.
 */
 const waiverDemandKeySchema = z.string().regex(/^[a-z][a-z0-9-]*(?::[A-Za-z0-9._%/-]+)?$/u, "A demand key is a lowercase family, optionally qualified by its resolved value (e.g. review-rung:human).");
@@ -175,29 +182,18 @@ const blockedReasonIssue = (message) => [{
 * wire schema so it is one rule rather than two that can drift. It is the
 * producer's state machine, written down:
 *
-* - `ready` refused nothing, so it carries neither projection, and it is the
-*   final review point;
-* - `slice-ready/not-final` was held back by exactly one demand — being a
-*   slice — and names it;
-* - `blocked` refused something other than being a slice, and says so;
+* - `ready` refused nothing, so it carries neither projection;
+* - `blocked` refused something and says so;
 * - whichever it is, `blockedReasons` names every refusal listed in
 *   `blockingReasons`, in the same order, as the bounded form of that sentence.
 *
-* Naming the slice demand and the ledger's `finalReviewPoint` are the same
-* fact, so a proof that says one and not the other is refused.
 */
 const blockedReasonIssues = (proof) => {
 	const named = proof.blockedReasons ?? [];
 	const reasons = proof.blockingReasons ?? [];
-	const slice = DEMAND_KEYS.finalReviewPoint;
-	const namesSlice = named.some((reason) => reason.code === slice);
 	if (proof.status === "ready") {
 		if (named.length > 0 || reasons.length > 0) return blockedReasonIssue("a ready pr:ready proof must carry no blocking reasons");
-	} else if (proof.status === "slice-ready/not-final") {
-		if (named.length !== 1 || !namesSlice) return blockedReasonIssue(`a slice-ready/not-final pr:ready proof is held back by exactly one demand, ${slice}`);
 	} else if (reasons.length === 0) return blockedReasonIssue("a blocked pr:ready proof must record what blocked it");
-	else if (named.length > 0 && !named.some((r) => r.code !== slice)) return blockedReasonIssue(`a blocked pr:ready proof must name a demand other than ${slice}`);
-	if (proof.finalReviewPoint !== void 0 && namesSlice === proof.finalReviewPoint) return blockedReasonIssue(`naming ${slice} and the ledger's finalReviewPoint are the same fact; this proof says both`);
 	if (named.length !== reasons.length) return blockedReasonIssue(`blockedReasons must name every blocking reason: ${reasons.length} reason(s), ${named.length} named`);
 	const drifted = named.findIndex((reason, index) => reason.detail !== blockedReasonDetail(reasons[index]));
 	return drifted === -1 ? [] : blockedReasonIssue(`blockedReasons[${drifted}] does not carry blocking reason ${drifted}; the two projections must tell one story`);
@@ -215,7 +211,7 @@ const demandWaiverSchema = z.object({
 	operator: z.string().trim().min(1),
 	rationale: z.string().trim().min(1),
 	recordedAt: z.iso.datetime(),
-	session: z.string().trim().min(1)
+	session: z.string().trim().min(1).optional()
 });
 z.object({
 	command: z.literal("patronage-factory demand:waive"),
@@ -227,7 +223,7 @@ const waivedDemandSchema = z.object({
 	operator: z.string().trim().min(1),
 	rationale: z.string().trim().min(1),
 	recordedAt: z.iso.datetime(),
-	session: z.string().trim().min(1),
+	session: z.string().trim().min(1).optional(),
 	unmetReasons: z.array(z.string().min(1)).min(1)
 });
 const MAX_CLOSEOUT_ROWS = 1e3;
@@ -510,11 +506,6 @@ const RetroCycleCountersSchema = z.object({
 	thermoFixRounds: nonNegInt
 }).strict();
 const RetroOutcomeSchema = z.object({
-	mergeCheck: z.enum([
-		"pass",
-		"fail",
-		"not-run"
-	]).optional(),
 	status: z.enum([
 		"success",
 		"blocked",
@@ -718,11 +709,7 @@ const PR_REVIEW_SCHEMA_VERSION = 2;
 const PR_REVIEW_FINDING_PROVENANCE_VERSION = 1;
 const nonBlankString = z.string().refine((value) => value.trim().length > 0, { message: "must not be blank" });
 const parseableDateString = z.string().refine((value) => Number.isFinite(Date.parse(value)), { message: "must be a parseable date string" });
-const reviewPromptSectionProvenances = [
-	"prior-review-ledger",
-	"profile-standing-checklist",
-	"issue-review-focus"
-];
+const reviewPromptSectionProvenances = ["prior-review-ledger", "issue-review-focus"];
 const reviewPromptSectionSchema = z.object({
 	provenance: z.enum(reviewPromptSectionProvenances),
 	source: nonBlankString,
@@ -979,67 +966,7 @@ const boundaryCheckProofSchema = z.object({
 	}).optional(),
 	status: z.enum(["ready", "blocked"])
 });
-const mergeGuardIdentitySchema = z.discriminatedUnion("kind", [
-	z.object({
-		headSha: z.string().regex(/^[0-9a-f]{40}$/u),
-		kind: z.literal("match")
-	}),
-	z.object({
-		kind: z.literal("diverged"),
-		liveHeadSha: z.string().regex(/^[0-9a-f]{40}$/u),
-		postProofCommits: z.array(z.object({
-			sha: z.string().min(1),
-			subject: z.string()
-		})).optional(),
-		proofHeadSha: z.string().regex(/^[0-9a-f]{40}$/u)
-	}),
-	z.object({
-		kind: z.literal("live-head-invalid"),
-		pr: z.number().int().positive(),
-		received: z.string()
-	}),
-	z.object({
-		errorDetail: z.string().optional(),
-		kind: z.literal("ready-proof-missing"),
-		readyProofPath: z.string().min(1)
-	}),
-	z.object({
-		kind: z.literal("ready-proof-pr-mismatch"),
-		proofPr: z.number().int().positive(),
-		requestedPr: z.number().int().positive()
-	}),
-	z.object({
-		blockingReasons: z.array(z.string()),
-		kind: z.literal("ready-proof-not-ready"),
-		status: z.string().min(1)
-	})
-]);
-const PR_MERGE_CHECK_SCHEMA_VERSION = 1;
-const prMergeCheckProofSchema = z.object({
-	blockingReasons: z.array(z.string()),
-	command: z.literal("patronage-factory pr:merge-check"),
-	followUp: followUpActionSchema.optional(),
-	identity: mergeGuardIdentitySchema,
-	liveHeadSha: z.string().regex(/^[0-9a-f]{40}$/u).optional(),
-	notices: z.array(z.string()).optional(),
-	pr: z.number().int().positive(),
-	schemaVersion: z.literal(1),
-	status: z.enum(["pass", "fail"]),
-	waivedDemands: z.array(waivedDemandSchema).optional(),
-	worktreeHeldBranch: z.object({
-		branch: z.string().min(1),
-		worktreePath: z.string().min(1)
-	}).optional()
-});
-const requiredCheckScopeSchema = z.object({
-	classifications: z.array(z.enum(DIFF_CLASSIFICATIONS)).min(1).optional(),
-	labels: z.array(z.string().min(1)).min(1).optional()
-}).strict().superRefine((scope, context) => {
-	if (scope.labels === void 0 && scope.classifications === void 0) context.addIssue({
-		code: "custom",
-		message: "requiredChecks scope must declare at least one condition (labels and/or classifications)."
-	});
-});
+const requiredCheckScopeSchema = z.object({ classifications: z.array(z.enum(DIFF_CLASSIFICATIONS)).min(1) }).strict();
 const readinessRepairSchema = z.object({
 	action: z.string().min(1),
 	code: z.enum([
@@ -1056,6 +983,18 @@ const reviewStateSchema = z.object({
 	reviewedPatchId: z.string().optional(),
 	status: z.enum(REVIEW_STATUS_VALUES)
 });
+const historicalPostReadinessCommentSchema = z.object({
+	author: z.string().min(1),
+	createdAt: z.string().min(1),
+	summary: z.string().min(1),
+	url: z.string().min(1)
+});
+const historicalHandledHumanCommentSchema = z.object({
+	clearedAt: z.string().min(1).optional(),
+	sessionId: z.string().min(1).optional(),
+	source: z.enum(["check-run", "cli"]),
+	url: z.string().min(1)
+});
 const managedReadinessLedgerSchema = z.object({
 	baseSha: z.string().regex(/^[0-9a-f]{40}$/u),
 	blockingReasons: z.array(z.string()),
@@ -1073,9 +1012,8 @@ const managedReadinessLedgerSchema = z.object({
 			"out-of-scope"
 		])
 	})).optional(),
-	finalReviewPoint: z.boolean(),
+	finalReviewPoint: z.boolean().optional(),
 	github: z.object({
-		currentWithBase: z.boolean(),
 		draft: z.boolean(),
 		mergeStateStatus: z.string(),
 		mergeable: z.string(),
@@ -1086,47 +1024,20 @@ const managedReadinessLedgerSchema = z.object({
 			"none",
 			"unknown"
 		]),
+		reviewDecision: z.string().nullable().optional(),
 		unresolvedReviewThreads: z.number().int().nonnegative()
 	}),
 	handledCommentsProducer: z.object({
 		identity: z.string().min(1),
 		mode: z.enum(["app", "commit-status"])
 	}).optional(),
-	handledHumanComments: z.array(z.object({
-		clearedAt: z.string().min(1).optional(),
-		sessionId: z.string().min(1).optional(),
-		source: z.enum(["check-run", "cli"]),
-		url: z.string().min(1)
-	})).optional(),
+	handledHumanComments: z.array(historicalHandledHumanCommentSchema).optional(),
 	headSha: z.string().regex(/^[0-9a-f]{40}$/u),
 	mergeBaseSha: z.string().regex(/^[0-9a-f]{40}$/u).optional(),
 	patchId: z.string().regex(/^[0-9a-f]{40,64}$/u),
-	postReadinessHumanComments: z.array(z.object({
-		author: z.string().min(1),
-		createdAt: z.string().min(1),
-		summary: z.string().min(1),
-		url: z.string().min(1)
-	})).optional(),
+	postReadinessHumanComments: z.array(historicalPostReadinessCommentSchema).optional(),
+	postReadinessHumanReviews: z.array(historicalPostReadinessCommentSchema).optional(),
 	pr: z.number().int().positive(),
-	previewDeploy: z.object({
-		adminUrl: z.string().optional(),
-		apiHealthUrl: z.string().optional(),
-		headSha: z.string().optional(),
-		localPreviewProof: z.unknown().optional(),
-		localProofPath: z.string().optional(),
-		proofSource: z.enum(["github-actions", "local-self-certified"]).optional(),
-		publicUrl: z.string().optional(),
-		seedStatus: z.enum([
-			"passed",
-			"failed",
-			"skipped",
-			"unknown"
-		]),
-		stage: z.string().optional(),
-		timingsMs: z.record(z.string(), z.number().optional()).optional(),
-		workflowRunUrl: z.string().optional()
-	}).optional(),
-	previewDeployRequired: z.boolean(),
 	repairs: z.array(readinessRepairSchema).default([]),
 	reviewCycleState: z.object({
 		autoBlockingFindings: z.number().int().nonnegative(),
@@ -1199,7 +1110,7 @@ const managedReadinessLedgerSchema = z.object({
 		"slice",
 		"rollup",
 		"merge-gate prerequisite"
-	]),
+	]).optional(),
 	verification: z.object({
 		command: z.literal("patronage-factory pr:verify"),
 		docsOnlyDeltaAccepted: z.boolean().optional(),
@@ -1214,21 +1125,36 @@ const managedReadinessLedgerSchema = z.object({
 		verifiedHeadSha: z.string().optional()
 	})
 });
-const PR_READY_SCHEMA_VERSION = 2;
+const PR_READY_SCHEMA_VERSION = 3;
 /**
-* The pr:ready proof versions a reader still accepts. `pr:ready` emits v2 only
-* (#391) — one current contract — but v1 events were spooled before the bump
-* and HQ must ingest them without degrading, so the wire schema parses both.
+* The pr:ready proof versions a reader still accepts. `pr:ready` emits v3 only
+* (#477) — one current contract — but v1 and v2 events were spooled before the
+* bumps and HQ must ingest them without degrading, so the wire schema parses
+* all three.
 */
-const SUPPORTED_PR_READY_SCHEMA_VERSIONS = [1, 2];
+const SUPPORTED_PR_READY_SCHEMA_VERSIONS = [
+	1,
+	2,
+	3
+];
 const prReadySchemaVersionSchema = z.number().refine((value) => SUPPORTED_PR_READY_SCHEMA_VERSIONS.includes(value), { message: `schemaVersion must be one of: ${SUPPORTED_PR_READY_SCHEMA_VERSIONS.join(", ")}` });
 const prReadyProofSchema = z.object({
+	arming: z.object({
+		detail: z.string().min(1).optional(),
+		headSha: z.string().regex(/^[0-9a-f]{40}$/u),
+		outcome: z.enum([
+			"armed",
+			"merged",
+			"not-armed"
+		])
+	}).optional(),
 	blockedReasons: blockedReasonsSchema.optional(),
 	blockingReasons: z.array(z.string()),
 	command: z.literal("patronage-factory pr:ready"),
 	followUp: followUpActionSchema.optional(),
 	humanBlockingReasons: z.array(z.string()).default([]),
 	ledger: managedReadinessLedgerSchema,
+	notices: z.array(z.string().min(1)).optional(),
 	profileBlobSha: z.string().regex(/^[0-9a-f]{40}$/u).optional(),
 	profilePath: z.string().min(1).optional(),
 	repairs: z.array(readinessRepairSchema).default([]),
@@ -1238,7 +1164,8 @@ const prReadyProofSchema = z.object({
 		"ready",
 		"blocked",
 		"slice-ready/not-final"
-	])
+	]),
+	waivedDemands: z.array(waivedDemandSchema).optional()
 }).superRefine((proof, context) => {
 	if (proof.schemaVersion < 2) {
 		if (proof.blockedReasons !== void 0) context.addIssue({
@@ -1248,10 +1175,7 @@ const prReadyProofSchema = z.object({
 		});
 		return;
 	}
-	for (const issue of blockedReasonIssues({
-		...proof,
-		finalReviewPoint: proof.ledger.finalReviewPoint
-	})) context.addIssue(issue);
+	for (const issue of blockedReasonIssues({ ...proof })) context.addIssue(issue);
 });
 //#endregion
-export { BLOCKED_REASONS_MAX, BLOCKED_REASON_DETAIL_MAX, BOUNDARY_CHECK_SCHEMA_VERSION, BOUNDARY_REVIEW_PROOF_KIND, EVIDENCE_ENVELOPE_SCHEMA_VERSION, PR_MERGE_CHECK_SCHEMA_VERSION, PR_READY_SCHEMA_VERSION, PR_REVIEW_SCHEMA_VERSION, RETRO_ENVELOPE_SCHEMA_VERSION, RETRO_ENVELOPE_VALIDATORS, RETRO_ENVELOPE_WIRE_BOUNDS, SUPPORTED_PR_READY_SCHEMA_VERSIONS, SUPPORTED_PR_VERIFY_SCHEMA_VERSIONS, SUPPORTED_RETRO_ENVELOPE_SCHEMA_VERSIONS, blockedReasonSchema, blockedReasonsSchema, boundaryCheckProofSchema, boundaryReviewProofSchema, closeoutArtifactSchema, evidenceEnvelopeSchema, prMergeCheckProofSchema, prReadyProofSchema, prReviewProofSchema, prVerifyProofSchema, retroEnvelopeV1Schema, retroEpicReference, waivedDemandSchema };
+export { BLOCKED_REASONS_MAX, BLOCKED_REASON_DETAIL_MAX, BOUNDARY_CHECK_SCHEMA_VERSION, BOUNDARY_REVIEW_PROOF_KIND, EVIDENCE_ENVELOPE_SCHEMA_VERSION, PR_READY_SCHEMA_VERSION, PR_REVIEW_SCHEMA_VERSION, RETRO_ENVELOPE_SCHEMA_VERSION, RETRO_ENVELOPE_VALIDATORS, RETRO_ENVELOPE_WIRE_BOUNDS, SUPPORTED_PR_READY_SCHEMA_VERSIONS, SUPPORTED_PR_VERIFY_SCHEMA_VERSIONS, SUPPORTED_RETRO_ENVELOPE_SCHEMA_VERSIONS, blockedReasonSchema, blockedReasonsSchema, boundaryCheckProofSchema, boundaryReviewProofSchema, closeoutArtifactSchema, evidenceEnvelopeSchema, prReadyProofSchema, prReviewProofSchema, prVerifyProofSchema, retroEnvelopeV1Schema, retroEpicReference, waivedDemandSchema };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@patronage/software-factory",
-  "version": "0.25.0",
+  "version": "0.30.0-beta.1",
   "description": "Shared Patronage software factory CLI and project-profile validation tools",
   "license": "MIT",
   "repository": {