@patricktobias86/node-red-telegram-account 1.1.7 → 1.1.8

package/CHANGELOG.md

@@ -9,3 +9,7 @@ All notable changes to this project will be documented in this file.
 ### Changed
 - Session management now tracks active clients in a `Map` for safer reuse.
 
+## [1.1.8] - 2025-07-22
+### Fixed
+- Receiver and Command nodes now remove their event listeners when closed to prevent duplicate messages after redeploys.
+

package/README.md

@@ -18,8 +18,8 @@ See [docs/NODES.md](docs/NODES.md) for a detailed description of every node. Bel
 
 - **config** – stores your API credentials and caches sessions for reuse.
 - **auth** – interactive login that outputs a `stringSession`.
-- **receiver** – emits messages for every incoming update (with optional ignore list).
-- **command** – triggers when an incoming message matches a command or regex.
+- **receiver** – emits messages for every incoming update (with optional ignore list). Event listeners are cleaned up on node close so redeploys won't duplicate messages.
+- **command** – triggers when an incoming message matches a command or regex. Event listeners are removed on redeploy to prevent duplicates.
 - **send-message** – sends text or media messages with rich options.
 - **send-files** – uploads one or more files with captions and buttons.
 - **get-entity** – resolves usernames, IDs or t.me links into Telegram entities.

package/docs/NODES.md

@@ -8,8 +8,8 @@ Below is a short description of each node. For a full list of configuration opti
 |------|-------------|
 | **config** | Configuration node storing API credentials and connection options. Other nodes reference this to share a Telegram client and reuse the session. Connections are tracked in a Map with a reference count so multiple nodes can wait for the same connection. |
 | **auth** | Starts an interactive login flow. Produces a `stringSession` that can be reused with the `config` node. |
-| **receiver** | Emits an output message for every incoming Telegram message. Can ignore specific user IDs. |
-| **command** | Listens for new messages and triggers when a message matches a configured command or regular expression. |
+| **receiver** | Emits an output message for every incoming Telegram message. Can ignore specific user IDs. Event handlers are automatically removed when the node is closed. |
+| **command** | Listens for new messages and triggers when a message matches a configured command or regular expression. The event listener is cleaned up on node close to avoid duplicates. |
 | **send-message** | Sends text messages or media files to a chat. Supports parse mode, buttons, scheduling, and more. |
 | **send-files** | Uploads one or more files to a chat with optional caption, thumbnails and other parameters. |
 | **get-entity** | Resolves a username, user ID or t.me URL into a Telegram entity object. |

package/nodes/command.js

@@ -9,44 +9,46 @@ module.exports = function (RED) {
     /** @type {TelegramClient} */
     const client =  this.config.client;
 
-    
-
-    try {
-      client.addEventHandler((update) => {
-        const message = update.message.message
+    const event = new NewMessage();
+    const handler = (update) => {
+        const message = update.message.message;
         if (message) {
             if (config.regex) {
                 const regex = new RegExp(config.command);
 
                 if (regex.test(message)) {
-                    
                     var msg = {
                         payload: {
                             update
                         }
                     };
-
-                    
                     node.send(msg);
                 }
             } else if (message === config.command) {
-                
                 var msg = {
                     payload: {
                         update
                     }
                 };
-
-                
                 node.send(msg);
             }
         }
-      }, new NewMessage());
-      
+    };
+
+    try {
+      client.addEventHandler(handler, event);
     } catch (err) {
       node.error('Authorization error: ' + err.message);
     }
 
+    this.on('close', () => {
+      try {
+        client.removeEventHandler(handler, event);
+      } catch (err) {
+        node.error('Handler removal error: ' + err.message);
+      }
+    });
+
   }
 
   RED.nodes.registerType('command', Command);

package/nodes/receiver.js

@@ -8,24 +8,31 @@ module.exports = function (RED) {
     const client =  this.config.client;
     const ignore = config.ignore.split(/\n/);
 
-  
-    try {
-      client.addEventHandler((update) => {
-        if(update.message.fromId != null && !ignore.includes(update.message.fromId.userId.toString())){
-          
-          node.send({
-            payload:{
-              update
-            }
-          } )
+    const event = new NewMessage();
+    const handler = (update) => {
+        if (update.message.fromId != null && !ignore.includes(update.message.fromId.userId.toString())) {
+            node.send({
+                payload: {
+                    update
+                }
+            });
         }
-        
-      }, new NewMessage());
-      
+    };
+
+    try {
+      client.addEventHandler(handler, event);
     } catch (err) {
       node.error('Authorization error: ' + err.message);
     }
 
+    this.on('close', () => {
+      try {
+        client.removeEventHandler(handler, event);
+      } catch (err) {
+        node.error('Handler removal error: ' + err.message);
+      }
+    });
+
   }
 
   RED.nodes.registerType('receiver', Receiver);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@patricktobias86/node-red-telegram-account",
-  "version": "1.1.7",
+  "version": "1.1.8",
   "description": "Node-RED nodes to communicate with GramJS.",
   "main": "nodes/config.js",
   "keywords": [

package/test/command.test.js

@@ -0,0 +1,43 @@
+const assert = require('assert');
+const proxyquire = require('proxyquire').noPreserveCache();
+
+function load() {
+  const addCalls = [];
+  const removeCalls = [];
+  class TelegramClientStub {
+    addEventHandler(fn, event) { addCalls.push({fn, event}); }
+    removeEventHandler(fn, event) { removeCalls.push({fn, event}); }
+  }
+  class NewMessageStub {}
+
+  let NodeCtor;
+  const configNode = { client: new TelegramClientStub() };
+  const RED = {
+    nodes: {
+      createNode(node) {
+        node._events = {};
+        node.on = (e, fn) => { node._events[e] = fn; };
+      },
+      registerType(name, ctor) { NodeCtor = ctor; },
+      getNode() { return configNode; }
+    }
+  };
+
+  proxyquire('../nodes/command.js', {
+    'telegram/events': { NewMessage: NewMessageStub }
+  })(RED);
+
+  return { NodeCtor, addCalls, removeCalls };
+}
+
+describe('Command node', function() {
+  it('removes event handler on close', function() {
+    const { NodeCtor, addCalls, removeCalls } = load();
+    const node = new NodeCtor({config:'c', command:'cmd', regex:false});
+    assert.strictEqual(addCalls.length, 1);
+    node._events.close();
+    assert.strictEqual(removeCalls.length, 1);
+    assert.strictEqual(removeCalls[0].fn, addCalls[0].fn);
+    assert.strictEqual(removeCalls[0].event, addCalls[0].event);
+  });
+});

package/test/receiver.test.js

@@ -0,0 +1,43 @@
+const assert = require('assert');
+const proxyquire = require('proxyquire').noPreserveCache();
+
+function load() {
+  const addCalls = [];
+  const removeCalls = [];
+  class TelegramClientStub {
+    addEventHandler(fn, event) { addCalls.push({fn, event}); }
+    removeEventHandler(fn, event) { removeCalls.push({fn, event}); }
+  }
+  class NewMessageStub {}
+
+  let NodeCtor;
+  const configNode = { client: new TelegramClientStub() };
+  const RED = {
+    nodes: {
+      createNode(node) {
+        node._events = {};
+        node.on = (e, fn) => { node._events[e] = fn; };
+      },
+      registerType(name, ctor) { NodeCtor = ctor; },
+      getNode() { return configNode; }
+    }
+  };
+
+  proxyquire('../nodes/receiver.js', {
+    'telegram/events': { NewMessage: NewMessageStub }
+  })(RED);
+
+  return { NodeCtor, addCalls, removeCalls };
+}
+
+describe('Receiver node', function() {
+  it('removes event handler on close', function() {
+    const { NodeCtor, addCalls, removeCalls } = load();
+    const node = new NodeCtor({config:'c', ignore:''});
+    assert.strictEqual(addCalls.length, 1);
+    node._events.close();
+    assert.strictEqual(removeCalls.length, 1);
+    assert.strictEqual(removeCalls[0].fn, addCalls[0].fn);
+    assert.strictEqual(removeCalls[0].event, addCalls[0].event);
+  });
+});