@patimweb/pi-abap-fs 1.1.0 → 1.2.1

package/README.md

@@ -1,15 +1,14 @@
 # pi ABAP FS
 
-An [ABAP remote filesystem](https://github.com/marcellourbani/vscode_abap_remote_fs)-style
-extension for the [pi coding agent](https://github.com/earendil-works/pi-coding-agent).
+ABAP remote filesystem access for the [pi coding agent](https://github.com/earendil-works/pi-coding-agent).
 
-It gives the pi agent **live access to an SAP system** via the ADT (ABAP Development
-Tools) protocol: search and read real objects, edit and activate source code, run ABAP
-unit tests, and query live tables — all through plain-language prompts.
+Gives the pi agent **live, read/write access to an SAP S/4HANA system** over the ADT
+(ABAP Development Tools) protocol — search and read real objects, edit and activate
+source code, run unit tests and ATC, analyze dumps and performance traces, and query
+live tables, all through plain-language prompts. No VS Code or IDE required.
 
-This is a port of the core `vscode_abap_remote_fs` capabilities to pi. It is built on
-[`abap-adt-api`](https://www.npmjs.com/package/abap-adt-api), the same ADT client
-library the VS Code extension uses.
+Built on [`abap-adt-api`](https://www.npmjs.com/package/abap-adt-api), a standalone
+Node.js client for the ADT REST interface.
 
 ## Requirements
 
@@ -87,6 +86,12 @@ pi -e ./index.ts
 - "Add method `calculate` to `ZCL_MY_CLASS` and activate it."
 - "Run the unit tests for `ZCL_MY_CLASS` and explain the failures."
 - "Show me the first 20 rows of table `SFLIGHT` where `CARRID = 'LH'`."
+- "Run ATC on `ZCL_MY_CLASS` and summarize the findings."
+- "Are there any recent runtime dumps in the system?"
+- "List my open transport requests, then show the objects in `DEVK900123`."
+- "Analyze the latest performance trace and find the hot spots."
+- "Create a new class `ZCL_ORDER_HELPER` in package `Z_MY_PACKAGE`."
+- "Read the text symbols of report `Z_MY_REPORT`."
 
 ## Development
 

package/docs/architecture.md

@@ -0,0 +1,101 @@
+# Architecture
+
+The extension bridges two worlds: the agent speaks tool calls, SAP speaks
+ADT-REST. In between lie four layers with clear responsibilities.
+
+## Layers
+
+```mermaid
+flowchart TB
+    agent["pi coding agent<br/><small>LLM · tool runtime</small>"]
+    index["index.ts<br/><small>loadConfig() + 27 × registerTool</small>"]
+    tools["src/tools/*.ts<br/><small>27 modules: typebox schema + execute()</small>"]
+    client["src/client.ts<br/><small>withClient() · resolveObject() · toError()</small>"]
+    api["abap-adt-api<br/><small>ADTClient, stateless/stateful</small>"]
+    sap[("SAP S/4HANA<br/><small>/sap/bc/adt/…</small>")]
+
+    config["src/config.ts<br/><small>profiles + active profile</small>"]
+    file[/"~/.pi/abap-config.json<br/><small>0600 · atomic rename</small>"/]
+    fmt["src/formatting/formatters.ts<br/><small>pure: data → text</small>"]
+
+    agent -->|"loads extension at startup"| index
+    index -->|"registerTool × 27"| tools
+    tools -->|"withClient(profile, fn)"| client
+    client -->|"login → operation → dropSession"| api
+    api -->|"HTTP(S), Basic Auth, client + language"| sap
+    sap -.->|"response (XML/JSON)"| client
+
+    config -->|"resolveConfig(profile)"| tools
+    config <-->|"load / persist"| file
+    client -->|"raw data"| fmt
+    fmt -.->|"formatted text"| tools
+```
+
+The downward path is the call path; the dashed edges are the return path: raw
+ADT responses pass through the pure formatters and leave the tool as text plus a
+structured `details` object. `src/types.ts` deliberately sits beside the flow,
+which is why it is absent from the diagram — it holds only data shapes and error
+classes, no behavior.
+
+## Flow of a write operation (`abap_write`)
+
+Writing requires a lock, and the lock only holds within *one* stateful session.
+Hence `stateful: true`, and hence `unLock` sits in a `finally`.
+
+```mermaid
+sequenceDiagram
+    autonumber
+    participant A as Agent
+    participant T as abap_write
+    participant C as client.ts
+    participant S as SAP · ADT
+
+    A->>T: abap_write(name, source, transport?)
+    T->>T: resolveConfig(profile)
+    T->>C: withClient(fn, { stateful: true })
+
+    rect rgba(13,108,118,0.08)
+    note over C,S: one session
+    C->>S: login()
+    C->>S: searchObject → objectStructure
+    note right of C: resolveObject: best name match, mainInclude
+    C->>S: lock(objectUrl, "MODIFY")
+    S-->>C: LOCK_HANDLE
+    C->>S: setObjectSource(mainInclude, source, handle, transport?)
+    C->>S: unLock()  «finally»
+    C->>S: dropSession()
+    end
+
+    T-->>A: "Source written …" + details
+```
+
+If a `lockHandle` from an earlier `abap_lock` is supplied, `lock` and `unLock`
+are skipped — the lock then belongs to the caller and stays in place. Activation
+is never automatic: `abap_activate` is a separate call.
+
+## Tools by task
+
+| Group | Tools |
+|---|---|
+| Connection | `abap_setup`, `abap_status`, `abap_profile`, `abap_test_connection` |
+| Search & read | `abap_search`, `abap_object_types`, `abap_node_contents`, `abap_object_structure`, `abap_read`, `abap_where_used`, `abap_text_elements` |
+| Modify | `abap_lock`, `abap_unlock`, `abap_write`, `abap_activate`, `abap_create_object`, `abap_set_text_elements` |
+| Check & test | `abap_syntax_check`, `abap_unit_test`, `abap_atc` |
+| Data | `abap_query`, `abap_table` |
+| Operations & transport | `abap_transports`, `abap_transport_details`, `abap_dumps`, `abap_traces`, `abap_trace_hitlist` |
+
+## Decisions
+
+- **Session per call** (`withClient`) — fresh client, login, `dropSession` in the
+  `finally`. No shared connection state between tools.
+- **stateless as the default** — only locking operations run `stateful`.
+- **Errors are normalized** (`toError`) — the model sees the SAP message
+  directly; dedicated error classes say what to do next (e.g. "run `abap_setup`
+  first").
+- **Profile file written atomically** — temp file with `0600` and `rename`,
+  because `writeFileSync` with `mode` does not change the permissions of an
+  existing file.
+- **Side-effect-free formatters** — data in, string out; which is why most of
+  the code is testable without an SAP system.
+- **No build step** — pi loads `index.ts` via jiti; `tsc` only runs as a
+  `--noEmit` typecheck.

package/graph-out/GRAPH_REPORT.md

@@ -0,0 +1,61 @@
+# Mind Place Report
+
+Generated from `/Users/patrickweppelmann/Documents/Workspaces/pi-abap-fs`
+
+## Corpus
+
+- **Files scanned:** 39
+- **Languages:** 35 .ts, 3 .json, 1 .cjs
+
+## Graph Statistics
+
+| Metric | Value |
+|--------|-------|
+| Nodes | 107 |
+| Edges | 118 |
+| Communities | 9 |
+| Avg. Degree | 2.2 |
+
+## God Nodes
+
+The most-connected entities - these are the architectural pillars:
+
+| # | Node | Type | Connections | File |
+|---|------|------|-------------|------|
+| 1 | **index.ts** | file | 28 | `index.ts` |
+| 2 | **src/formatting/formatters.ts** | file | 20 | `src/formatting/formatters.ts` |
+| 3 | **package.json** | file | 15 | `package.json` |
+| 4 | **src/config.ts** | file | 15 | `src/config.ts` |
+| 5 | **src/client.ts** | file | 10 | `src/client.ts` |
+
+## Communities
+
+The graph was partitioned into these subsystems:
+
+| Community | Size | Key Members |
+|-----------|------|-------------|
+| **AbapProfileNotFoundError.constructor** | 63 | index.ts, src/client.ts, createClient |
+| **formatTextElements** | 20 | src/formatting/formatters.ts, formatSearchResults, formatObjectStructure |
+| **devDependencies** | 16 | package.json, name, version |
+| **include** | 3 | tsconfig.json, compilerOptions, include |
+| **release.config.cjs** | 1 | release.config.cjs |
+| **isClassStructure** | 1 | isClassStructure |
+| **tests/config.test.ts** | 1 | tests/config.test.ts |
+| **tests/formatters.test.ts** | 1 | tests/formatters.test.ts |
+| **tests/smoke.test.ts** | 1 | tests/smoke.test.ts |
+
+## Surprising Connections
+
+- **src/formatting/formatters.ts** → `contains` → **isClassStructure**: Cross-community bridge between "src/formatting/formatters.ts" and "isClassStructure"
+
+## Suggested Questions
+
+- How does **index.ts** connect to **src/formatting/formatters.ts**?
+- What calls **index.ts** and what does it depend on?
+- Trace the data flow between **index.ts** and **src/formatting/formatters.ts**
+- Which modules have the most dependencies?
+- Show me the architecture of the `index.ts` subsystem
+- What is the most heavily connected module in the codebase?
+
+---
+_Report generated by pi-mindplace · Use `mindplace_query` to explore the graph_