@patch-adams/core 1.5.7 → 1.5.9

package/dist/cli.js

@@ -948,12 +948,30 @@ function generateLrsBridgeCode(options) {
       });
     }
 
-    // Decode HTML entities (e.g., " " & ') to clean text
+    // Clean HTML entities from text \u2014 handles both proper (") and broken (quot;) forms
+    // Rise strips the & from entities in SCORM interaction IDs, so we need both
     function decodeEntities(str) {
       if (!str || typeof str !== 'string') return str;
-      var txt = document.createElement('textarea');
-      txt.innerHTML = str;
-      return txt.value;
+      // 1. Replace known broken entities (without &) that Rise leaves behind
+      str = str
+        .replace(/quot;/g, '"')
+        .replace(/apos;/g, "'")
+        .replace(/amp;/g, '&')
+        .replace(/lt;/g, '<')
+        .replace(/gt;/g, '>')
+        .replace(/nbsp;/g, ' ');
+      // 2. Replace numeric entities like &#34; &#39; &#x22; etc.
+      str = str.replace(/&#(x?[0-9a-fA-F]+);/g, function(match, code) {
+        var num = code.charAt(0) === 'x' ? parseInt(code.substring(1), 16) : parseInt(code, 10);
+        return isNaN(num) ? match : String.fromCharCode(num);
+      });
+      // 3. Catch any remaining standard &entities; via textarea decode
+      try {
+        var txt = document.createElement('textarea');
+        txt.innerHTML = str;
+        str = txt.value;
+      } catch (e) {}
+      return str;
     }
 
     LRS.sessionId = generateUUID();
@@ -3016,15 +3034,37 @@ function generateLrsBridgeCode(options) {
      * Build activity object for questions in Xyleme format
      * Name format: "Assessment Name - Q#: Question text..."
      */
+    /**
+     * Simple string hash for generating short, stable IDs from long strings.
+     * Returns a hex string (8 chars). Not cryptographic \u2014 just for uniqueness.
+     */
+    function hashString(str) {
+      var hash = 0;
+      for (var i = 0; i < str.length; i++) {
+        var ch = str.charCodeAt(i);
+        hash = ((hash << 5) - hash) + ch;
+        hash = hash & hash; // Convert to 32-bit integer
+      }
+      return Math.abs(hash).toString(16).padStart(8, '0');
+    }
+
     function buildQuestionActivityObject(questionInfo) {
-      var questionGuid = questionInfo.questionGuid || questionInfo.id || generateUUID();
+      var rawGuid = questionInfo.questionGuid || questionInfo.id || generateUUID();
+
+      // Ensure the object ID stays under 255 chars total to avoid Bravais aggregation failures.
+      // Rise SCORM interaction IDs can be very long (full slugified question text).
+      // Use a truncated prefix + hash to keep it short but unique and stable.
+      var questionGuid = rawGuid;
+      if (rawGuid.length > 80) {
+        questionGuid = rawGuid.substring(0, 60) + '_' + hashString(rawGuid);
+      }
 
       // Build human-readable display name
       var displayName = (questionInfo.assessmentName || 'Knowledge Check');
       if (questionInfo.questionNumber) {
         displayName += ' - Q' + questionInfo.questionNumber;
       }
-      var questionText = questionInfo.text || questionInfo.questionText || '';
+      var questionText = decodeEntities(questionInfo.text || questionInfo.questionText || '');
       if (questionText.length > 50) {
         displayName += ': ' + questionText.substring(0, 47) + '...';
       } else if (questionText.length > 0) {
@@ -4401,10 +4441,12 @@ function generateLrsBridgeCode(options) {
         var interactionId = interaction.id || ('interaction-' + idx);
 
         // Try to make a readable question text from the interaction ID
-        var questionText = interactionId
-          .replace(/_\\d+$/, '')  // remove trailing _0
-          .replace(/_/g, ' ')     // underscores to spaces
-          .substring(0, 200);
+        var questionText = decodeEntities(
+          interactionId
+            .replace(/_\\d+$/, '')  // remove trailing _0
+            .replace(/_/g, ' ')     // underscores to spaces
+            .substring(0, 200)
+        );
 
         // Get lesson context
         var lessonInfo = getCachedLessonInfo();