@patch-adams/core 1.5.20 → 1.5.22

package/dist/cli.js

@@ -1774,8 +1774,8 @@ function generateLrsBridgeCode(options) {
             ', bravaisUserId=' + employeeData.bravaisUserId + ', tenantUrl=' + employeeData.tenantUrl
             : 'NO DATA'));
         if (employeeData && employeeData.email) {
-          actor.mbox = 'mailto:' + employeeData.email;
-          log('Enhanced actor with email:', employeeData.email);
+          actor.mbox = 'mailto:' + employeeData.email.toLowerCase();
+          log('Enhanced actor with email:', employeeData.email.toLowerCase());
 
           // Also update name if we got a better one
           if (employeeData.name && (!actor.name || actor.name === 'Unknown Learner')) {
@@ -1940,6 +1940,18 @@ function generateLrsBridgeCode(options) {
       return n === 'anonymous learner' || n === 'unknown learner' || n === 'anonymous' || n === 'unknown';
     }
 
+    /**
+     * Normalize actor IFI fields for consistent matching in Bravais Analytics.
+     * Lowercases mbox email (RFC 5321: local-part is case-insensitive in practice).
+     */
+    function normalizeActor(actor) {
+      if (!actor) return actor;
+      if (actor.mbox && actor.mbox.indexOf('mailto:') === 0) {
+        actor.mbox = 'mailto:' + actor.mbox.substring(7).toLowerCase();
+      }
+      return actor;
+    }
+
     /**
      * Persist actor to localStorage for cross-frame sharing.
      * Only stores non-anonymous actors.
@@ -1971,23 +1983,29 @@ function generateLrsBridgeCode(options) {
 
     /**
      * Get the best available actor for statement building.
-     * Priority: LRS.actor (if non-anonymous) > localStorage shared actor > LRS.actor > extractActor()
+     * ALWAYS checks localStorage because the skin overlay in another frame
+     * may have updated the actor AFTER this bridge instance initialized.
+     * (e.g., user enters email in skin overlay \u2192 actor persisted to localStorage,
+     *  but the bridge in scormcontent/index.html already loaded a stale actor at init)
      */
     function getActor() {
-      // If current actor is non-anonymous, use it
-      if (LRS.actor && !isAnonymousActor(LRS.actor)) {
-        return LRS.actor;
-      }
-      // Check localStorage for actor set by another frame (e.g., skin overlay)
+      // Always check localStorage for the freshest actor \u2014 it may have been
+      // updated by the skin overlay in another frame since our init
       var shared = loadSharedActor();
       if (shared) {
-        // Update local actor so future calls are fast
-        LRS.actor = shared;
-        log('Actor loaded from cross-frame storage:', shared.name);
-        return shared;
+        // Only update if different from current (avoid unnecessary log spam)
+        if (!LRS.actor || LRS.actor.name !== shared.name ||
+            (LRS.actor.account && shared.account && LRS.actor.account.name !== shared.account.name)) {
+          log('Actor updated from cross-frame storage:', shared.name);
+        }
+        LRS.actor = normalizeActor(shared);
+        return LRS.actor;
       }
       // Fallback to current actor or re-extract
-      return LRS.actor || extractActor();
+      if (LRS.actor && !isAnonymousActor(LRS.actor)) {
+        return normalizeActor(LRS.actor);
+      }
+      return normalizeActor(LRS.actor || extractActor());
     }
 
     /**
@@ -1997,7 +2015,9 @@ function generateLrsBridgeCode(options) {
     LRS.setActor = function(actor) {
       LRS.actor = actor;
       persistActor(actor);
-      // Also try to propagate to other frames in the hierarchy
+
+      // Propagate to ALL frames: walk UP parent chain AND DOWN into child iframes
+      // UP: parent frames (e.g., if skin is in a child iframe)
       try {
         var w = window;
         for (var i = 0; i < 10; i++) {
@@ -2010,9 +2030,29 @@ function generateLrsBridgeCode(options) {
           w = w.parent;
         }
       } catch (e) {}
+
+      // DOWN: child iframes (e.g., scormcontent/index.html has its own bridge)
+      function setActorInChildren(win) {
+        try {
+          var frames = win.frames;
+          for (var j = 0; j < frames.length; j++) {
+            try {
+              if (frames[j].pa_patcher && frames[j].pa_patcher.lrs) {
+                frames[j].pa_patcher.lrs.actor = actor;
+                log('Actor propagated to child frame', j);
+              }
+              // Recurse into nested iframes
+              setActorInChildren(frames[j]);
+            } catch (e) { /* cross-origin child */ }
+          }
+        } catch (e) {}
+      }
+      setActorInChildren(window);
+
       if (window.console && window.console.info) {
         console.info('[PA-LRS] Actor set:', actor.name,
           actor.mbox ? '(' + actor.mbox + ')' : '',
+          actor.account ? '(account: ' + actor.account.name + ')' : '',
           '\u2014 shared across frames');
       }
     };
@@ -2027,9 +2067,9 @@ function generateLrsBridgeCode(options) {
       function finalizeActor(actor) {
         // Try to enhance actor with email if missing
         enhanceActorWithEmail(actor, function(enhancedActor) {
-          LRS.actor = enhancedActor;
-          persistActor(enhancedActor);
-          callback(enhancedActor);
+          LRS.actor = normalizeActor(enhancedActor);
+          persistActor(LRS.actor);
+          callback(LRS.actor);
         });
       }