npm - @patch-adams/core - Versions diffs - 1.4.26 → 1.4.28 - Mend

@patch-adams/core 1.4.26 → 1.4.28

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (9) hide show

package/dist/cli.cjs CHANGED Viewed

@@ -4422,6 +4422,19 @@ function generateLrsBridgeCode(options) {
       // Setup connection
       var bridgeReady = setupBridge();
+      // Track async readiness: both actor and doc metadata must resolve before sending statements
+      var actorReady = false;
+      var docReady = false;
+      var launchEventsSent = false;
+      function tryLaunchEvents() {
+        if (launchEventsSent) return;
+        if (!actorReady || !docReady) return;
+        launchEventsSent = true;
+        log('Both actor and doc metadata ready, sending launch events');
+        setTimeout(sendLaunchEvents, 50);
+      }
       if (bridgeReady) {
         LRS.initialized = true;
@@ -4432,14 +4445,23 @@ function generateLrsBridgeCode(options) {
         log('Actor:', LRS.actor);
         log('Course:', LRS.courseInfo);
-        // Then try async actor extraction from Bravais session
-        // This will update the actor with real user info if available
+        // Then try async actor extraction (employee lookup, Bravais session)
+        // Launch events will NOT be sent until this completes
         extractActorAsync(function(actor) {
           log('Actor updated after async fetch:', actor);
+          actorReady = true;
+          // Log final actor state for diagnostics
+          if (window.console && window.console.info) {
+            console.info('[PA-LRS] Actor resolved: name=' + (actor ? actor.name : 'none') +
+              ', mbox=' + (actor ? actor.mbox : 'none') +
+              ', account=' + (actor && actor.account ? actor.account.name : 'none'));
+          }
+          tryLaunchEvents();
         });
       } else {
         warn('Bridge setup failed - operating in offline mode');
         LRS.mode = 'offline';
+        actorReady = true; // No actor to wait for in offline mode
       }
       // Always-visible bridge summary (not gated by DEBUG)
@@ -4484,13 +4506,17 @@ function generateLrsBridgeCode(options) {
         }
       }
-      function fetchDocDataAndSend(docId) {
+      function onDocReady() {
+        docReady = true;
+        tryLaunchEvents();
+      }
+      function fetchDocDataAndReady(docId) {
         fetchDocumentMetadata(docId, function(docData) {
           if (docData) {
             updateCourseInfoFromApi(docData);
           }
-          // Send launch events after API fetch (success or failure)
-          setTimeout(sendLaunchEvents, 100);
+          onDocReady();
         });
       }
@@ -4510,20 +4536,20 @@ function generateLrsBridgeCode(options) {
             } else {
               warn('Could not fetch document data from shared API - statements may fail aggregation');
             }
-            setTimeout(sendLaunchEvents, 100);
+            onDocReady();
           });
         } else if (documentId) {
           // No shared link token, try with extracted document ID (requires auth)
           log('No shared link token, fetching document data with ID:', documentId);
-          fetchDocDataAndSend(documentId);
+          fetchDocDataAndReady(documentId);
         } else {
           // No identifiers available
           warn('No shared link token or document ID - statements may fail aggregation');
-          setTimeout(sendLaunchEvents, 500);
+          onDocReady();
         }
       } else {
-        // Already have GUID - send after short delay
-        setTimeout(sendLaunchEvents, 500);
+        // Already have GUID
+        onDocReady();
       }
       // Setup beforeunload to send terminated
@@ -4553,6 +4579,32 @@ function generateLrsBridgeCode(options) {
         }, 1000);
       }
+      // If actor is still Unknown Learner, poll for SCORM API availability
+      // The SCORM API may not be available during <head> init but appears later
+      // (e.g., scorm-calls.js finds and initializes it after DOM ready)
+      if (!LRS.actor || LRS.actor.name === 'Unknown Learner' || !LRS.actor.account || LRS.actor.account.name === 'unknown') {
+        var actorRetryCount = 0;
+        var actorMaxRetries = 15;
+        var actorRetryInterval = setInterval(function() {
+          actorRetryCount++;
+          // Check if SCORM API has become available (injected by scorm-calls.js or LMS)
+          var hasScormApi = LRS.scormApi ||
+            (typeof window.API !== 'undefined' && window.API) ||
+            (typeof window.API_1484_11 !== 'undefined' && window.API_1484_11);
+          if (hasScormApi) {
+            log('SCORM API now available (attempt ' + actorRetryCount + '), refreshing actor...');
+            clearInterval(actorRetryInterval);
+            LRS.refreshActor(function(actor) {
+              log('Actor refreshed after SCORM API detected:', actor ? actor.name : 'none');
+            });
+          } else if (actorRetryCount >= actorMaxRetries) {
+            log('SCORM API not found after ' + actorMaxRetries + ' attempts, actor stays as-is');
+            clearInterval(actorRetryInterval);
+          }
+        }, 1000);
+      }
       log('LRS bridge setup complete');
     }