@passioncode-ai/passioncode 0.2.46 → 0.2.48

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # Changelog
 
+## 0.2.48 - 2026-10-28
+
+### Fixed
+
+- `doctor` on Windows no longer tells you to run `setup --with <app>` for an MCP entry whose app is
+  not installed: `setup` installs apps only on macOS, so the fix names the app's download page (or
+  removing the entry). The `setting-up-passioncode` skill says the same (PC-88).
+
+## 0.2.47 - 2026-10-28
+
+### Fixed
+
+- **`update` on Windows moves `current` to the new release** (PC-85, the Windows acceptance of 2026-10-28): Windows
+  refuses a rename over a directory link (`EPERM ... rename 'current.<pid>.lnk' -> 'current'`), so an update stopped
+  halfway, kept the old release and left a `current.<pid>.lnk` per attempt. There the old link is now removed first
+  (the link itself, never what it points at) and put back if the rename fails again; the temporary link never outlives
+  the call, and the ones a failed update left are removed by the next one.
+- **`doctor` checks the apps on Windows** (PC-86): it reads each app's uninstall entry (`reg query`, the name and
+  version its installer wrote) or finds it in `%LOCALAPPDATA%\Programs\<name>`, `%LOCALAPPDATA%\<name>` or Program
+  Files, and says which version is installed and whether a newer one is out, instead of "app checks run on macOS".
+  Setup still installs apps on macOS only.
+
 ## 0.2.46 - 2026-10-28
 
 ### Changed

package/README.md

@@ -47,7 +47,7 @@ secret into a product's own hidden prompt, starting Docker for Fabric, and resta
    one question per app; `--yes` accepts the plan, `--with`/`--without <ids>` choose apps
    (`switchboard`, `dashboards`, `observatory`, `inbox`, `fabric`), `--no-apps` sets up the skills
    and MCP only, `--dry-run` shows the plan. Apps are installed on macOS; on other systems setup
-   names each download page. Skills only: `npx @passioncode-ai/passioncode@latest update`.
+   names each download page, and on Windows `doctor` reads which version of each app is installed. Skills only: `npx @passioncode-ai/passioncode@latest update`.
 2. **Configure:** nothing to set, no account and no key. Background updates are on by default;
    `npx @passioncode-ai/passioncode@latest config set update.auto off` turns them off. Each app's
    own onboarding (sign-ins, Fabric Inbox's server, Observatory's projects) is listed by `setup`.

package/SECURITY.md

@@ -32,7 +32,8 @@ returns a nonzero exit code. See the [CLI recovery contract](docs/reference/cli.
 `doctor` reads: `~/.claude.json`, `~/.codex/config.toml`, `~/.gemini/settings.json`,
 `~/.kimi-code/mcp.json` (entry names, commands and arguments; environment values are passed to
 the server it starts and never printed), the Fabric service descriptors (never their token
-files), the apps' `Info.plist`, and the GitHub releases API. It starts each registered stdio MCP
+files), the apps' `Info.plist` (on Windows, the apps' uninstall entries through `reg query` and their install folders),
+and the GitHub releases API. It starts each registered stdio MCP
 server for one proving call and stops it (never Fabric's, which enrols a session as it starts), and writes only `~/.passioncode/doctor.json` and a
 release cache.
 

package/lib/doctor.js

@@ -3,7 +3,8 @@
  * `passioncode doctor`: reads the whole PassionCode.ai setup of this machine and names, for every
  * check, its state, the exact fix and what setup may repair (ADR-0004). It changes nothing: the only
  * processes it starts are the registered stdio MCP servers for one proving call each (never Fabric's,
- * which enrols a session when it starts), stopped when the call returns. `doctor --fix` is setup's
+ * which enrols a session when it starts), stopped when the call returns, and on Windows three
+ * read-only `reg query` calls for the apps' uninstall entries (PC-86). `doctor --fix` is setup's
  * repair half (lib/setup.js), not this module.
  */
 const fs = require('fs');
@@ -12,6 +13,7 @@ const path = require('path');
 const L = require('./launcher');
 const catalog = require('./catalog');
 const releases = require('./releases');
+const W = require('./windows-apps');
 const { probe } = require('./mcp-probe');
 
 const PKG = (() => { try { return require('../package.json').version; } catch (_) { return '0.0.0'; } })();
@@ -123,12 +125,32 @@ async function collect({ home, platform, claude, online }) {
   const cacheFile = path.join(p.state, 'releases-cache.json');
   const probes = new Map();
   let docker = null;
+  let windowsEntries = null; // the uninstall entries, read once (three `reg query` calls)
   for (const pr of catalog.PRODUCTS) {
     const at = catalog.appPath(pr);
     const installed = platform === 'darwin' && fs.existsSync(at);
     const label = `${pr.name}${pr.preview ? ' (early preview)' : ''}`;
-    if (platform !== 'darwin') {
-      add({ id: `app.${pr.id}`, area: 'apps', product: pr.id, state: 'info', detail: `${label}: app checks run on macOS; on this system download it from ${pr.page}` });
+    if (platform === 'win32') {
+      // PC-86: presence and version from the installer's own records; setup installs nothing here.
+      if (!windowsEntries) {
+        windowsEntries = W.readUninstallEntries(releases.run);
+        for (const u of windowsEntries.unread) add({ id: `apps.registry.${u.hive.split('\\')[0].toLowerCase()}${u.hive.includes('WOW6432Node') ? '-wow64' : ''}`, area: 'apps', state: 'warn', detail: `could not read ${u.hive} (${u.why}); an app installed for every user may show as not installed` });
+      }
+      const found = W.findWindowsApp(pr, { entries: windowsEntries.entries, home });
+      if (!found) {
+        add({ id: `app.${pr.id}`, area: 'apps', product: pr.id, state: 'info', detail: `${label}: not installed`, fix: `download it from ${pr.page}` });
+      } else {
+        let latest = null, latestErr = null;
+        if (online) { try { latest = await releases.latestRelease(pr, { cacheFile }); } catch (error) { latestErr = error.message; } }
+        const outdated = latest && found.version && newer(latest.version, found.version);
+        add({
+          id: `app.${pr.id}`, area: 'apps', product: pr.id, state: outdated || (!latest && online) ? 'warn' : 'ok',
+          detail: `${label} ${found.version || '(version unknown)'}${found.at ? ` in ${found.at}` : ''}${latest ? (outdated ? `; ${latest.version} is out` : found.version ? ' (latest)' : `; the latest is ${latest.version}`) : online ? `; latest unknown (${latestErr})` : '; latest not checked (--offline)'}`,
+          fix: outdated ? `install ${latest.version} from ${pr.page} (or accept the update ${pr.name} offers)` : null,
+        });
+      }
+    } else if (platform !== 'darwin') {
+      add({ id: `app.${pr.id}`, area: 'apps', product: pr.id, state: 'info', detail: `${label}: app checks run on macOS and Windows; on this system download it from ${pr.page}` });
     } else if (!installed) {
       add({ id: `app.${pr.id}`, area: 'apps', product: pr.id, state: 'info', detail: `${label}: not installed`, fix: `${NPX} setup --with ${pr.id}` });
     } else {
@@ -179,7 +201,7 @@ async function collect({ home, platform, claude, online }) {
         continue;
       }
       if (path.isAbsolute(entry.command) && !fs.existsSync(entry.command)) {
-        add({ id, area: 'mcp', product: pr.id, state: 'fail', detail: `${agent.name}: ${m.name} points at ${entry.command}, which does not exist`, fix: installed ? `remove that entry from ${agent.name}, then ${NPX} doctor --fix` : `${NPX} setup --with ${pr.id}` });
+        add({ id, area: 'mcp', product: pr.id, state: 'fail', detail: `${agent.name}: ${m.name} points at ${entry.command}, which does not exist`, fix: installed ? `remove that entry from ${agent.name}, then ${NPX} doctor --fix` : platform === 'darwin' ? `${NPX} setup --with ${pr.id}` : `download ${pr.name} from ${pr.page}, or remove that entry from ${agent.name}` }); // PC-88: setup installs apps only on macOS
         continue;
       }
       if (pr.mcp.spawn === false) {

package/lib/launcher.js

@@ -65,13 +65,42 @@ function readState(file, { tolerant = false } = {}) {
   }
 }
 
-/** Replace a symlink atomically (create beside it, rename over it). */
-function symlinkAtomic(target, at) {
+/**
+ * Replace a symlink atomically (create beside it, rename over it). Windows refuses any rename over
+ * a directory link (EPERM, PC-85), so there the old link is removed first: unlink takes the link
+ * itself, never what it points at, and the old link is put back if the rename fails again. The
+ * temporary link never outlives the call, and the ones an earlier failed update left are removed.
+ * On Windows the swap is therefore not atomic: between the unlink and the rename `at` is absent,
+ * and a run killed there leaves no `current` until the next update (status reports it missing).
+ */
+function symlinkAtomic(target, at, { platform = process.platform, rename = fs.renameSync, unlink = fs.unlinkSync } = {}) {
   fs.mkdirSync(path.dirname(at), { recursive: true });
   const tmp = `${at}.${process.pid}.lnk`;
-  try { fs.unlinkSync(tmp); } catch (_) { /* none */ }
+  const dropTmp = () => { try { fs.unlinkSync(tmp); } catch (_) { /* none */ } };
+  dropTmp();
   fs.symlinkSync(target, tmp);
-  fs.renameSync(tmp, at);
+  try {
+    rename(tmp, at);
+  } catch (error) {
+    const old = lstat(at);
+    if (platform !== 'win32' || !['EPERM', 'EACCES', 'EEXIST'].includes(error.code) || !old || !old.isSymbolicLink()) { dropTmp(); throw error; }
+    const previous = linkTarget(at);
+    try { unlink(at); } catch (unlinkError) { dropTmp(); throw unlinkError; }
+    try { rename(tmp, at); } catch (again) {
+      dropTmp();
+      try { fs.symlinkSync(previous, at); } catch (back) { throw new Error(`${again.message}; and putting back ${at} → ${previous} failed (${back.message})`); }
+      throw again;
+    }
+  }
+  if (platform !== 'win32') return; // only a refused rename on Windows ever left one (PC-85)
+  const base = path.basename(at);
+  let siblings = [];
+  try { siblings = fs.readdirSync(path.dirname(at)); } catch (_) { /* nothing to sweep */ }
+  for (const name of siblings) {
+    if (!name.startsWith(`${base}.`) || !/^\.\d+\.lnk$/.test(name.slice(base.length))) continue;
+    const left = path.join(path.dirname(at), name);
+    if (lstat(left)?.isSymbolicLink()) { try { fs.unlinkSync(left); } catch (_) { /* the next update sweeps it */ } }
+  }
 }
 
 // --- one update at a time (lifecycle contract LC-03) ---------------------------------------
@@ -854,5 +883,5 @@ module.exports = {
   restore: (opts = {}) => withUpdateLock(opts.home, () => restore(opts)),
   uninstall: (opts = {}) => withUpdateLock(opts.home, () => uninstall(opts)),
   status, setConfig, paths, CHANNELS, MARKETPLACE, payloadManifest, marketplaceAddArg,
-  acquireUpdateLock, UpdateRunning, staleReleases, claudeRunner, bundledMcpServers, mcpFileTargets, readSettings, tomlTableRange, tomlTableCommand, tomlTableArgs, tomlMentions,
+  acquireUpdateLock, UpdateRunning, staleReleases, symlinkAtomic, claudeRunner, bundledMcpServers, mcpFileTargets, readSettings, tomlTableRange, tomlTableCommand, tomlTableArgs, tomlMentions,
 };

package/lib/releases.js

@@ -16,9 +16,10 @@ const catalog = require('./catalog');
 const API = () => (process.env.PASSIONCODE_GITHUB_API || 'https://api.github.com').replace(/\/$/, '');
 const CACHE_TTL_MS = 30 * 60 * 1000;
 
-function run(cmd, args, { timeout = 60000, input } = {}) {
-  const r = spawnSync(cmd, args, { encoding: 'utf8', timeout, input });
+function run(cmd, args, { timeout = 60000, input, maxBuffer = 1024 * 1024 } = {}) {
+  const r = spawnSync(cmd, args, { encoding: 'utf8', timeout, input, maxBuffer });
   if (r.error && r.error.code === 'ENOENT') return { code: 127, out: '', err: `${cmd} not found` };
+  if (r.error && r.error.code === 'ENOBUFS') return { code: 1, out: '', err: `${cmd} wrote more than ${maxBuffer} bytes` };
   if (r.error && r.error.code === 'ETIMEDOUT') return { code: 124, out: r.stdout || '', err: `${cmd} timed out after ${Math.round(timeout / 1000)} s` };
   return { code: r.status === null ? 1 : r.status, out: r.stdout || '', err: r.stderr || '' };
 }

package/lib/setup.js

@@ -76,7 +76,8 @@ async function setup({
   const claude = L.claudeRunner();
   const before = D.sortChecks(await D.collect({ home, platform, claude, online }));
   const fresh = !before.some((c) => c.id === 'skills.installed' && c.state !== 'fail')
-    && !catalog.PRODUCTS.some((pr) => platform === 'darwin' && fs.existsSync(catalog.appPath(pr)));
+    // An app doctor found (ok or warn: on Windows from the installer's records, PC-86) makes it existing.
+    && !before.some((c) => /^app\.[^.]+$/.test(c.id) && (c.state === 'ok' || c.state === 'warn'));
   const items = plan(before, { platform, withIds, withoutIds, noApps, repairOnly });
   const result = {
     version: D.PKG, platform, mode: fresh ? 'new' : 'existing', at: new Date().toISOString(), plan: items,

package/lib/windows-apps.js

@@ -0,0 +1,74 @@
+'use strict';
+/**
+ * Where a PassionCode.ai app is installed on Windows and which version it is, read without
+ * starting it (PC-86): the uninstall entry its installer wrote (electron-builder and Tauri both
+ * write DisplayName and DisplayVersion; Tauri also InstallLocation), else the folder a per-user
+ * installer uses (%LOCALAPPDATA%\Programs\<name> for electron-builder, %LOCALAPPDATA%\<name> for
+ * Tauri) or a per-machine one under Program Files, with the program in it.
+ */
+const fs = require('fs');
+const path = require('path');
+
+const HIVES = [
+  'HKCU\\Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall',
+  'HKLM\\Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall',
+  'HKLM\\Software\\WOW6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall',
+];
+
+/** `reg query <hive> /s` output → [{ key, DisplayName, DisplayVersion, InstallLocation, UninstallString }]. */
+function parseUninstall(text) {
+  const entries = [];
+  let entry = null;
+  for (const line of String(text || '').split(/\r?\n/)) {
+    if (/^HKEY_/.test(line)) { entry = { key: line.trim() }; entries.push(entry); continue; }
+    const m = /^\s+(\S+)\s+REG_(?:SZ|EXPAND_SZ)\s+(.*)$/.exec(line);
+    if (m && entry) entry[m[1]] = m[2].trim();
+  }
+  return entries.filter((e) => e.DisplayName);
+}
+
+/**
+ * Every uninstall entry on this machine, and the hives `reg` could not read (a missing hive is
+ * normal: HKLM's WOW6432Node exists only on 64-bit Windows), so a reader can say an app it did not
+ * find may still be there.
+ */
+function readUninstallEntries(run) {
+  const entries = [], unread = [];
+  for (const hive of HIVES) {
+    const r = run('reg', ['query', hive, '/s'], { timeout: 15000, maxBuffer: 32 * 1024 * 1024 });
+    if (r.code === 0) entries.push(...parseUninstall(r.out));
+    else if (!/unable to find/i.test(`${r.err || ''}${r.out || ''}`)) unread.push({ hive, why: (r.err || r.out || `exit ${r.code}`).trim().split(/\r?\n/)[0] });
+  }
+  return { entries, unread };
+}
+
+/** electron-builder names its entry "<name> <version>", Tauri "<name>"; "Fabric" never matches "Fabric Inbox". */
+function names(entry, name) {
+  return entry.DisplayName === name || (!!entry.DisplayVersion && entry.DisplayName === `${name} ${entry.DisplayVersion}`);
+}
+
+/** The install folder an entry names, or null: an MSI entry's `MsiExec.exe /X{...}` names none. */
+function folderOf(entry) {
+  if (entry.InstallLocation) return entry.InstallLocation.replace(/^"|"$/g, '').replace(/\\$/, '');
+  const m = /^"([^"]+)"|^(\S+\.exe)/i.exec(entry.UninstallString || '');
+  const exe = m && (m[1] || m[2]);
+  if (!exe || !exe.includes('\\') || /(^|\\)msiexec\.exe$/i.test(exe)) return null;
+  return exe.slice(0, exe.lastIndexOf('\\'));
+}
+
+function folders(name, { env, home }) {
+  const local = env.LOCALAPPDATA || path.join(home, 'AppData', 'Local');
+  return [path.join(local, 'Programs', name), path.join(local, name), env.ProgramFiles && path.join(env.ProgramFiles, name)].filter(Boolean);
+}
+
+function hasProgram(dir) { try { return fs.readdirSync(dir).some((n) => /\.exe$/i.test(n)); } catch (_) { return false; } }
+
+/** { at, version, source: 'registry' | 'folder' } or null when the app is not installed. */
+function findWindowsApp(product, { entries, env = process.env, home }) {
+  const dir = folders(product.name, { env, home }).find(hasProgram);
+  const hit = entries.find((e) => names(e, product.name));
+  if (hit) return { at: folderOf(hit) || dir || null, version: hit.DisplayVersion || null, source: 'registry' };
+  return dir ? { at: dir, version: null, source: 'folder' } : null;
+}
+
+module.exports = { parseUninstall, readUninstallEntries, findWindowsApp, HIVES };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@passioncode-ai/passioncode",
-  "version": "0.2.46",
+  "version": "0.2.48",
   "description": "Set up PassionCode.ai on a computer with one command — the apps from their verified releases, their MCP servers for every coding agent and the PassionCode.ai skills — and check and repair it with the same command or `doctor`.",
   "bin": {
     "passioncode": "bin/passioncode.js"

package/payload/.claude-plugin/marketplace.json

@@ -35,7 +35,7 @@
       "name": "passioncode",
       "displayName": "PassionCode.ai",
       "source": "./plugins/passioncode",
-      "version": "0.2.46",
+      "version": "0.2.48",
       "description": "Set up and check PassionCode.ai on a computer with one command (setting-up-passioncode), the organisation's working rules for every contributor's agent (working-in-passioncode), and a once-a-day check that keeps the PassionCode.ai set current.",
       "author": {
         "name": "PassionCode.ai",

package/payload/manifest.json

@@ -1,6 +1,6 @@
 {
   "family": "passioncode",
-  "version": "0.2.46",
+  "version": "0.2.48",
   "release": true,
   "members": [
     {
@@ -62,9 +62,9 @@
       "name": "passioncode",
       "displayName": "PassionCode.ai",
       "repo": "passioncode-ai/passioncode",
-      "ref": "v0.2.46",
+      "ref": "v0.2.48",
       "commit": null,
-      "version": "0.2.46",
+      "version": "0.2.48",
       "via": "this repository",
       "skills": [
         "setting-up-passioncode",
@@ -72,7 +72,7 @@
       ],
       "legacyPluginIds": [],
       "legacyMarketplaces": [],
-      "contentHash": "sha256:26a83f55d769e493d16987ae596bb26288fa03f2b2f81231d22d5298ccd603bc",
+      "contentHash": "sha256:18c44b353312024f0735136631c2df0ac416bb8f3881406958e5aed0e710375a",
       "description": "Set up and check PassionCode.ai on a computer with one command (setting-up-passioncode), the organisation's working rules for every contributor's agent (working-in-passioncode), and a once-a-day check that keeps the PassionCode.ai set current.",
       "author": {
         "name": "PassionCode.ai",

package/payload/plugins/passioncode/.claude-plugin/plugin.json

@@ -2,7 +2,7 @@
   "$schema": "https://json.schemastore.org/claude-code-plugin-manifest.json",
   "name": "passioncode",
   "displayName": "PassionCode.ai",
-  "version": "0.2.46",
+  "version": "0.2.48",
   "description": "Set up and check PassionCode.ai on a computer with one command (setting-up-passioncode), the organisation's working rules for every contributor's agent (working-in-passioncode), and a once-a-day check at session start that keeps the PassionCode.ai skill set current.",
   "author": {
     "name": "PassionCode.ai",

package/payload/plugins/passioncode/skills/setting-up-passioncode/SKILL.md

@@ -97,7 +97,8 @@ Reply in the person's language, briefly:
 - **The command fails to start** (npm error, registry down): report the error with its exit code
   and stop. Do not fall back to manual installs.
 - **Not macOS**: the result names each app's download page; the person installs apps from there,
-  then runs `setup` again for the MCP servers.
+  then runs `setup` again for the MCP servers. On Windows `doctor` reads which apps are installed
+  and their versions; a fix that names a download page is the person's install, not a command.
 
 ## Gotchas