@passioncode-ai/fabric-agent-adapter 0.78.0 → 0.80.2

package/plugins/fabric-agent-adapter/skills/working-with-fabric/scripts/fabric_session_env.py

@@ -58,7 +58,7 @@ SESSION_ID = re.compile(r"[A-Za-z0-9._:-]{1,128}")
 LOOPBACK_ORIGIN = re.compile(r"http://127\.0\.0\.1:(\d{1,5})")
 
 
-VERSION = "0.78.0"
+VERSION = "0.80.2"
 
 
 HOSTS = {"claude": "Claude Code", "codex": "Codex", "kimi": "Kimi Code",
@@ -98,7 +98,7 @@ UNREAD_LINE = ("%d unread on the project board: com.list; answer what waits on y
 #: them once: at most MAX_NUDGES lines, each one line of at most MAX_NUDGE_CHARS characters.
 NUDGES_FILE = "nudges.json"
 #: Each nudge's line names its source, so the agent sees Fabric's words, data to act on through its tools, never the
-#: person's request. Fabric 0.3.14 starts every `says` with "Fabric:" (board e94ec9c0, release/0.3.14 b63dedb6); a
+#: person's request. Fabric 0.3.14 starts every `says` with "Fabric:" (board e94ec9c0; tag v0.3.14 7e43dc03, FAA-143); a
 #: line that does not gets this tag.
 NUDGE_PREFIX = "Fabric reminder: "
 
@@ -280,7 +280,9 @@ def read_small(path: Path, cap: int = READ_CAP) -> Optional[str]:
         return None
 
 
-def pid_alive(pid: int) -> bool:
+def pid_alive(pid: int) -> Optional[bool]:
+    """True: a process of this OS account runs under `pid`; False: none does. None (falsy): a process of another
+    account does (EPERM), as when the id hub.json names was reused: not verified, never called running (FAA-254)."""
     if pid <= 0:
         return False
     if sys.platform == "win32":
@@ -298,7 +300,7 @@ def pid_alive(pid: int) -> bool:
     try:
         os.kill(pid, 0)
     except PermissionError:
-        return True
+        return None
     except OSError:
         return False
     return True
@@ -324,7 +326,11 @@ def locate_hub(root: Path, alive=pid_alive) -> Dict[str, Any]:
     pid = doc.get("pid")
     if not isinstance(pid, int) or isinstance(pid, bool) or pid <= 0:
         return {"state": "not-a-hub", "reason": "hub.json names no process"}
-    if not alive(pid):
+    live = alive(pid)
+    if live is None:  # FAA-254: another account's process under that id, so not this account's Fabric
+        return {"state": "not-a-hub", "reason": "hub.json names process %d, which runs under another OS account: "
+                "not verified" % pid}
+    if not live:
         return {"state": "not-running", "reason": "hub.json names process %d, which is not running" % pid}
     features = doc.get("features")
     features = [f for f in features if isinstance(f, str)] if isinstance(features, list) else []
@@ -351,13 +357,47 @@ def _stdio_entry(entry: Any) -> Optional[Dict[str, Any]]:
             "fabricMcp": name in ("fabric-mcp", "fabric-mcp.cmd")}
 
 
+#: Claude Code's own variable for its folder, and Fabric Switchboard's for the person's folder a Switchboard home is
+#: built from (0.7.14 and later); a home of an earlier Switchboard lies in its data folder (FAA-218).
+CLAUDE_CONFIG_ENV = "CLAUDE_CONFIG_DIR"
+SWITCHBOARD_SOURCE_ENV = "SWITCHBOARD_CLAUDE_SOURCE_DIR"
+SWITCHBOARD_DATA = "ai.passioncode.fabric-switchboard"
+
+
+def claude_folders(env: Optional[Dict[str, str]] = None) -> Dict[str, Optional[Path]]:
+    """The launcher's `claudeFolders` (passioncode lib/launcher.js, PC-129; FAA-218): `read` is where the session's
+    Claude Code files are, CLAUDE_CONFIG_DIR when set, else ~/.claude; `write` is where settings, plugins and user MCP
+    servers are written, None for Claude Code's default (~/.claude with ~/.claude.json). In a Switchboard home `write`
+    is SWITCHBOARD_CLAUDE_SOURCE_DIR when it is absolute, ~/.claude's default for a home of an earlier Switchboard."""
+    env = os.environ if env is None else env
+    home = _home(env)
+    value = env.get(CLAUDE_CONFIG_ENV) or ""
+    config = Path(os.path.abspath(value)) if value else None
+    named = env.get(SWITCHBOARD_SOURCE_ENV) or ""
+    source: Optional[Path] = None
+    if config is not None:
+        if named and os.path.isabs(named):
+            source = Path(os.path.abspath(named))
+        elif SWITCHBOARD_DATA in re.split(r"[\\/]", str(config)):
+            source = home / ".claude"
+    write = (None if source == home / ".claude" else source) if source is not None else config
+    return {"read": config or home / ".claude", "write": write}
+
+
+def claude_json(env: Optional[Dict[str, str]] = None) -> Path:
+    """The `.claude.json` Claude Code reads in this environment: inside CLAUDE_CONFIG_DIR when it is set (Claude Code
+    2.1.299 reads and `claude mcp add` writes it there, FAA-234), else ~/.claude.json. In a Switchboard home that is the
+    home's own, the servers Switchboard carried into it."""
+    env = os.environ if env is None else env
+    return (claude_folders(env)["read"] if env.get(CLAUDE_CONFIG_ENV) else _home(env)) / ".claude.json"
+
+
 def claude_registration(cwd: Path, env: Optional[Dict[str, str]] = None) -> Optional[Dict[str, Any]]:
     """Claude Code's MCP server `fabric` for this folder: local, then project (.mcp.json), then user scope.
     Only command and args are returned, with the folder a local or project entry was found in; an entry's env is never
     read out."""
-    home = _home(env)
     config: Dict[str, Any] = {}
-    text = read_small(home / ".claude.json", CONFIG_CAP)
+    text = read_small(claude_json(env), CONFIG_CAP)
     if text:
         try:
             loaded = json.loads(text)
@@ -365,9 +405,18 @@ def claude_registration(cwd: Path, env: Optional[Dict[str, str]] = None) -> Opti
         except ValueError:
             config = {}
     projects = config.get("projects") if isinstance(config.get("projects"), dict) else {}
-    for folder in _ancestors(cwd):
-        servers = (projects.get(str(folder)) or {}).get("mcpServers") if isinstance(projects.get(str(folder)), dict) else None
-        found = _stdio_entry((servers or {}).get("fabric")) if isinstance(servers, dict) else None
+    # FAA-235: Claude Code keys a local entry by the git root of the folder it was added in, or that folder outside a
+    # checkout, and applies it only there (Claude Code 2.1.299; docs/evidence/runs/2026-11-12-faa-235-local-scope-key.md):
+    # one key, never an ancestor's. A hook's cwd moves with the session (a submodule, a worktree under .claude/), while
+    # Claude Code keeps the entry of the folder the session started in, which it hands hooks as CLAUDE_PROJECT_DIR:
+    # that folder's key is read too (the 0.80.0 seam reading)
+    started = (env if env is not None else os.environ).get("CLAUDE_PROJECT_DIR") or ""
+    keys = [cwd] + ([Path(started)] if started else [])
+    for place in keys:
+        folder = checkout_root(place, env) or _ancestors(place)[0]
+        project = projects.get(str(folder))
+        servers = project.get("mcpServers") if isinstance(project, dict) else None
+        found = _stdio_entry(servers.get("fabric")) if isinstance(servers, dict) else None
         if found:
             return dict(found, scope="local", folder=str(folder))
     for folder in _ancestors(cwd):
@@ -385,21 +434,86 @@ def claude_registration(cwd: Path, env: Optional[Dict[str, str]] = None) -> Opti
     return dict(found, scope="user") if found else None
 
 
-def codex_registered(env: Optional[Dict[str, str]] = None) -> bool:
+_CODEX_FABRIC = re.compile(r'^\s*\[\s*"?mcp_servers"?\s*\.\s*"?fabric"?\s*\]\s*$', re.MULTILINE)
+_TOML_HEADER = re.compile(r"^\s*\[", re.MULTILINE)
+#: one `command = "..."` line of a table (a basic or literal string), up to the line's end: a lookahead, not `$` (R1)
+_TOML_COMMAND = re.compile(r"""^[ \t]*command[ \t]*=[ \t]*("(?:[^"\\\n]|\\.)*"|'[^'\n]*')[ \t]*(?:#[^\n]*)?(?=\r?\n|\Z)""",
+                           re.MULTILINE)
+
+
+def _codex_config(env: Optional[Dict[str, str]] = None) -> str:
     env = os.environ if env is None else env
     codex_home = Path(env.get("CODEX_HOME") or str(_home(env) / ".codex"))
-    text = read_small(codex_home / "config.toml", CONFIG_CAP) or ""
-    return re.search(r'^\s*\[\s*"?mcp_servers"?\s*\.\s*"?fabric"?\s*\]\s*$', text, re.MULTILINE) is not None
+    return read_small(codex_home / "config.toml", CONFIG_CAP) or ""
 
 
-def kimi_registered(env: Optional[Dict[str, str]] = None) -> bool:
-    """Kimi Code keeps its MCP servers in ~/.kimi-code/mcp.json (`mcpServers`, Claude's shape)."""
+def codex_registered(env: Optional[Dict[str, str]] = None) -> bool:
+    return _CODEX_FABRIC.search(_codex_config(env)) is not None
+
+
+def codex_command(env: Optional[Dict[str, str]] = None) -> Optional[str]:
+    """The `command` of `[mcp_servers.fabric]` in Codex's config.toml (FAA-233), a basic or literal TOML string, or
+    None. Read with a pattern, not a TOML parser (Python 3.9 has none): the table runs to the next header."""
+    text = _codex_config(env)
+    header = _CODEX_FABRIC.search(text)
+    if header is None:
+        return None
+    rest = text[header.end():]
+    following = _TOML_HEADER.search(rest)
+    found = _TOML_COMMAND.search(rest[:following.start()] if following else rest)
+    if not found:
+        return None
+    value = found.group(1)
+    if value.startswith("'"):
+        return value[1:-1]
+    try:
+        decoded = json.loads(value)
+    except ValueError:
+        return None
+    return decoded if isinstance(decoded, str) else None
+
+
+def kimi_registration(env: Optional[Dict[str, str]] = None) -> Optional[Dict[str, Any]]:
+    """Kimi Code keeps its MCP servers in ~/.kimi-code/mcp.json (`mcpServers`, Claude's shape): the `fabric` entry's
+    command and args, or None."""
     text = read_small(_home(env) / ".kimi-code" / "mcp.json", CONFIG_CAP)
     try:
         servers = json.loads(text).get("mcpServers") if text else None
-    except (ValueError, AttributeError):
+    except (ValueError, AttributeError, RecursionError):
+        return None
+    return _stdio_entry(servers.get("fabric")) if isinstance(servers, dict) else None
+
+
+def kimi_registered(env: Optional[Dict[str, str]] = None) -> bool:
+    return kimi_registration(env) is not None
+
+
+def registered_command(host: str, cwd: Path, env: Optional[Dict[str, str]] = None) -> Optional[str]:
+    """The command the host runs as `fabric` (FAA-232, FAA-233): Claude Code's entry for this folder, Codex's
+    config.toml, Kimi Code's mcp.json; None when the host registers none, or registers it in a file read elsewhere."""
+    if host == "claude":
+        entry = claude_registration(cwd, env)
+        return entry["command"] if entry else None
+    if host == "codex":
+        return codex_command(env)
+    if host == "kimi":
+        entry = kimi_registration(env)
+        return entry["command"] if entry else None
+    return None
+
+
+def foreign_command(command: Optional[str], platform: str = sys.platform, env: Optional[Dict[str, str]] = None,
+                    lookup: bool = True) -> bool:
+    """Whether a registered command runs another user's copy (FAA-229): never one relative to a folder (`./`), and a
+    bare name only with `lookup` (a PATH lookup, which status makes and the session hooks do not)."""
+    if not command or re.split(r"[\\/]", command)[-1].lower() not in ("fabric-mcp", "fabric-mcp.cmd"):
+        return False
+    if command.startswith(("./", ".\\")):  # Path() drops a leading ./, which would read as a PATH name
         return False
-    return isinstance(servers, dict) and _stdio_entry(servers.get("fabric")) is not None
+    path = Path(command)
+    if not lookup and not path.is_absolute():
+        return False
+    return another_users_copy(path, platform, env)
 
 
 def host_registered(host: str, cwd: Path, env: Optional[Dict[str, str]] = None) -> bool:
@@ -416,7 +530,11 @@ def services_dir(platform: str = sys.platform, env: Optional[Dict[str, str]] = N
     """Where fabric-service/0.1 descriptors live: FABRIC_SERVICES_DIR, else Fabric's folder per OS + /services."""
     env = os.environ if env is None else env
     if env.get("FABRIC_SERVICES_DIR"):
-        return Path(env["FABRIC_SERVICES_DIR"])
+        value = env["FABRIC_SERVICES_DIR"]
+        if value == "~" or value[:2] in ("~/", "~\\"):  # `~` as the kit, Fabric and Fabric Dashboards expand it (FAA-189)
+            home = env.get("HOME") or env.get("USERPROFILE") or str(Path.home())
+            return Path(home) / value[2:] if len(value) > 2 else Path(home)
+        return Path(value)
     return fabric_root(platform, env) / "services"
 
 
@@ -632,6 +750,15 @@ def _write_private(path: Path, text: str) -> None:
     os.replace(str(tmp), str(path))
 
 
+#: FAA-152: the turn's git branch goes to Fabric (contract DEC-0140 PR-3: shown on this machine's screens, never stored
+#: or shared) unless the person turns it off with FABRIC_SESSION_NO_BRANCH set to anything but "" or "0".
+NO_BRANCH_ENV = "FABRIC_SESSION_NO_BRANCH"
+
+
+def branch_off(env: Optional[Dict[str, str]] = None) -> bool:
+    return (os.environ if env is None else env).get(NO_BRANCH_ENV, "") not in ("", "0")
+
+
 def repositories_off(env: Optional[Dict[str, str]] = None) -> bool:
     """Whether the person turned the transcript read off (FAA-160): FABRIC_SESSION_NO_REPOSITORIES set to anything but
     "" or "0", or the file NO_REPOSITORIES_MARK in the hooks' own folder."""
@@ -699,7 +826,7 @@ def prune_dispatch_records(env: Optional[Dict[str, str]] = None, now: Optional[f
         records = []
     for record in records:
         try:
-            if now - record.stat().st_mtime > SESSION_STALE_S:
+            if now - record.lstat().st_mtime > SESSION_STALE_S:  # the link's own age: a dangling one goes too (FAA-208)
                 record.unlink()
                 removed += 1
         except OSError:

package/plugins/fabric-agent-adapter/skills/working-with-fabric/scripts/fabric_session_mcp.py

@@ -104,6 +104,26 @@ def git_facts(cwd: Path, budget_s: Optional[float] = None, until: Optional[float
     return facts
 
 
+#: The branch Fabric's fabric_session_observe takes (0.3.16, CO-459, its own pattern): a name outside it is not sent.
+BRANCH = re.compile(r"[A-Za-z0-9._@+/-]{1,200}")
+
+
+def git_branch(cwd: Path, until: Optional[float] = None) -> Optional[str]:
+    """The branch HEAD names (FAA-152), or None: a detached head, no checkout, or no answer before `until`."""
+    name = (_git(cwd, ("symbolic-ref", "--short", "-q", "HEAD"), until) or "").strip()
+    return name or None
+
+
+def stored_branch(entry: Dict[str, Any]) -> Tuple[bool, Optional[str]]:
+    """Whether a spool entry carries a branch to send, and which: a name BRANCH takes, or None for a detached head."""
+    if "branch" not in entry:
+        return False, None
+    value = entry["branch"]
+    if value is None:
+        return True, None
+    return (True, value) if isinstance(value, str) and BRANCH.fullmatch(value) else (False, None)
+
+
 def _count_status(z: str) -> int:
     records, count, skip = z.split("\0"), 0, False
     for record in records:
@@ -249,6 +269,9 @@ def turn_paths(transcript: Any, cwd: Path, until: Optional[float] = None) -> Lis
                 calls.append(block)
     found: List[str] = []
     left = BASH_BYTES
+    # FAA-184: Claude Code keeps the Bash folder between calls while it stays inside the session's folder, so a call is
+    # read against the folder the one before it ended in; one outside, or one not known, is the session's folder again
+    folder = cwd
     for block in reversed(calls):
         if until is not None and time.monotonic() >= until:
             break
@@ -256,11 +279,16 @@ def turn_paths(transcript: Any, cwd: Path, until: Optional[float] = None) -> Lis
         if name in CHANGING_TOOLS:
             value = arguments.get(CHANGING_TOOLS[name])
             named = [os.path.normpath(os.path.join(str(cwd), value))] if isinstance(value, str) and value else []
-        elif name == "Bash" and isinstance(arguments.get("command"), str) and left > 0 \
-                and any(word in arguments["command"].lower() for word in ("cd", "git", "pushd")):  # GIT.EXE on Windows
+        elif name == "Bash" and isinstance(arguments.get("command"), str) \
+                and any(word in arguments["command"].lower() for word in ("cd", "git", "pushd", "popd")):  # GIT.EXE on Windows
+            if left <= 0:
+                folder = cwd  # not read: where it left the shell is not known
+                continue
             command = arguments["command"][:left]
             left -= len(command)
-            named = bash_paths(command, cwd)
+            ends: List[Optional[str]] = []
+            named = bash_paths(command, folder, ends=ends)
+            folder = Path(ends[-1]) if ends and ends[-1] and _inside(ends[-1], cwd) else cwd
         else:
             continue
         for path in named:
@@ -271,6 +299,15 @@ def turn_paths(transcript: Any, cwd: Path, until: Optional[float] = None) -> Lis
     return found
 
 
+def _inside(folder: str, root: Path) -> bool:
+    """Whether `folder` is `root` or under it, as the host's paths compare (case-blind on Windows)."""
+    try:
+        common = os.path.commonpath([os.path.normcase(folder), os.path.normcase(str(root))])
+    except ValueError:  # another drive, or a relative path
+        return False
+    return common == os.path.normcase(str(root))
+
+
 def _existing_folder(path: str) -> Optional[str]:
     """The path when it is a folder, else the nearest existing folder above it (a file's own folder)."""
     current = path
@@ -738,6 +775,11 @@ def deliver(directory: Path, env: Optional[Dict[str, str]] = None, deadline_s: f
                                      observedAt=entry.get("observedAt"), idempotencyKey=key)
                     if event == "end":
                         arguments["reason"] = reason
+                    rule = _input_rule(client, OBSERVE_TOOL, "branch") if event == "turn" else None
+                    carried, branch = stored_branch(entry)
+                    # FAA-152: only where the tool declares it, never on the end, null only where its schema allows it
+                    if rule is not None and carried and _allows(rule, branch):
+                        arguments["branch"] = branch
                     repositories = stored_repositories(entry) if event == "turn" else []
                     fitted = [r for r in repositories if _fits(r, _repository_rules(client))][:takes] if takes else []
                     if fitted:
@@ -853,6 +895,39 @@ def _input_fields(client: McpStdio, tool: str) -> List[str]:
     return []
 
 
+def _input_rule(client: McpStdio, tool: str, field: str) -> Optional[Dict[str, Any]]:
+    """The schema a listed tool's input declares for one property, or None when it declares none."""
+    for listed in client.tools:
+        if listed.get("name") == tool:
+            schema = listed.get("inputSchema")
+            props = schema.get("properties") if isinstance(schema, dict) else None
+            rule = props.get(field) if isinstance(props, dict) else None
+            return rule if isinstance(rule, dict) else None
+    return None
+
+
+def _allows(rule: Dict[str, Any], value: Optional[str], depth: int = 0) -> bool:
+    """Whether a string or null meets a property's schema as far as it is read here: `type` (a name or a list),
+    `pattern`, `maxLength`, `minLength`, `enum`, and `anyOf`/`oneOf` of such. Anything else unread: allowed."""
+    if depth > 4 or not isinstance(rule, dict):
+        return False
+    for key in ("anyOf", "oneOf"):
+        if isinstance(rule.get(key), list):
+            return any(_allows(option, value, depth + 1) for option in rule[key])
+    kinds = rule.get("type")
+    kinds = [kinds] if isinstance(kinds, str) else kinds if isinstance(kinds, list) else None
+    if value is None:
+        return kinds is not None and "null" in kinds
+    if kinds is not None and "string" not in kinds:
+        return False
+    try:
+        return not (len(value) > rule.get("maxLength", len(value)) or len(value) < rule.get("minLength", 0)
+                    or ("enum" in rule and value not in rule["enum"])
+                    or ("pattern" in rule and not re.search(rule["pattern"], value)))
+    except (TypeError, re.error):
+        return False
+
+
 def _fits(item: Dict[str, str], props: Dict[str, Any]) -> bool:
     """Whether one {host, owner, name} meets what the schema says of each field (type, length, pattern, enum): an item
     that does not is left out, so Fabric's check never refuses the whole turn for it (seam reading 4)."""

package/plugins/fabric-agent-adapter/skills/working-with-fabric/scripts/fabric_session_paths.py

@@ -33,7 +33,8 @@ KEYWORDS = frozenset(("{", "!", "then", "do", "else", "elif", "if", "while", "un
 ASSIGNMENT = re.compile(r"[A-Za-z_][A-Za-z0-9_]*=")
 
 
-def bash_paths(command: str, cwd: Path, windows: Optional[bool] = None) -> List[str]:
+def bash_paths(command: str, cwd: Path, windows: Optional[bool] = None,
+               ends: Optional[List[Optional[str]]] = None) -> List[str]:
     """The folders a Bash command names as `cd <absolute path>` or `git -C <path>`, in order. A relative `-C` is read
     against the folder the command last changed into with an absolute `cd`, else `cwd`; after a `cd` to a relative or
     unknown folder it is dropped (FAA-166). A `cd` inside `( )`, a pipeline's stage or a list sent to the background
@@ -42,7 +43,8 @@ def bash_paths(command: str, cwd: Path, windows: Optional[bool] = None) -> List[
     else of the command is kept; a command that does not split is [] (FAA-140). On Windows (`windows`, default
     `sys.platform == "win32"`) paths are read as Git Bash writes them, with its quoting: an unquoted `C:\\work` is
     `C:work` there too, so a native path counts when it is quoted (FAA-175); Cygwin and MSYS2 Pythons read their own
-    POSIX paths (FAA-177)."""
+    POSIX paths (FAA-177). With `ends`, the folder the command leaves the shell in is appended to it: an absolute path,
+    or None when it is not known (a relative cd, popd, an unclosed subshell, a command that does not split; FAA-184)."""
     import shlex  # only a Stop hook with a transcript needs it
     windows = sys.platform == "win32" if windows is None else windows
     if windows:
@@ -59,6 +61,8 @@ def bash_paths(command: str, cwd: Path, windows: Optional[bool] = None) -> List[
         lexer.whitespace_split = True
         tokens = list(lexer)
     except ValueError:
+        if ends is not None:
+            ends.append(None)
         return []
 
     def absolute(token: str) -> Optional[str]:
@@ -187,4 +191,7 @@ def bash_paths(command: str, cwd: Path, windows: Optional[bool] = None) -> List[
                 found.append(at)
         start = False
         index += 1
+    if ends is not None:
+        end_pipeline()
+        ends.append(None if stack else base)
     return found