npm - @pasko70/pibo - Versions diffs - 3.4.3 → 3.4.4 - Mend

@pasko70/pibo 3.4.3 → 3.4.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (21) hide show

package/dist/apps/chat-vscode-web/index.html CHANGED Viewed

@@ -5,7 +5,7 @@
 		<meta name="viewport" content="width=device-width, initial-scale=1.0" />
 		<meta name="theme-color" content="#101d22" />
 		<title>Pibo</title>
-		<script type="module" crossorigin src="/apps/chat-vscode/assets/index-0oTGFHni.js"></script>
+		<script type="module" crossorigin src="/apps/chat-vscode/assets/index-CMwTB8o8.js"></script>
 		<link rel="stylesheet" crossorigin href="/apps/chat-vscode/assets/index-b18ZkEo0.css">
 	</head>
 	<body>

package/dist/gateway/cli.js CHANGED Viewed

@@ -1,5 +1,6 @@
 import { spawn, execFile } from "node:child_process";
-import { existsSync, mkdirSync, openSync, readFileSync, readdirSync } from "node:fs";
+import { createHash } from "node:crypto";
+import { appendFileSync, existsSync, mkdirSync, openSync, readFileSync, readdirSync } from "node:fs";
 import { homedir } from "node:os";
 import { join } from "node:path";
 import { promisify } from "node:util";
@@ -205,11 +206,14 @@ function runtimeTelemetryHint(value) {
 }
 function runtimeStatus(value) {
     const obj = objectValue(value);
-    if (!obj)
+    if (!obj || !stringValue(obj.piboSessionId) || typeof obj.processing !== "boolean" || typeof obj.streaming !== "boolean"
+        || !Number.isInteger(obj.queuedMessages) || Number(obj.queuedMessages) < 0)
         return undefined;
     return {
         piboSessionId: stringValue(obj.piboSessionId),
         queuedMessages: numberValue(obj.queuedMessages),
+        activeEventId: stringValue(obj.activeEventId),
+        queuedEventIds: Array.isArray(obj.queuedEventIds) && obj.queuedEventIds.every((id) => typeof id === "string") ? obj.queuedEventIds : undefined,
         processing: booleanValue(obj.processing),
         streaming: booleanValue(obj.streaming),
         activeTelemetry: runtimeTelemetryHint(obj.activeTelemetry),
@@ -217,13 +221,14 @@ function runtimeStatus(value) {
 }
 function activeRun(value) {
     const obj = objectValue(value);
-    if (!obj)
+    if (!obj || !stringValue(obj.runId) || !stringValue(obj.status)
+        || !(stringValue(obj.controllerPiboSessionId) || stringValue(obj.piboSessionId)))
         return undefined;
     return {
         runId: stringValue(obj.runId),
         status: stringValue(obj.status),
         toolName: stringValue(obj.toolName),
-        piboSessionId: stringValue(obj.piboSessionId),
+        piboSessionId: stringValue(obj.controllerPiboSessionId) ?? stringValue(obj.piboSessionId),
     };
 }
 function parseGatewaySafetyPayload(payload, reachable) {
@@ -231,7 +236,9 @@ function parseGatewaySafetyPayload(payload, reachable) {
     const mode = obj && (obj.mode === "dev" || obj.mode === "prod" || obj.mode === "fallback") ? obj.mode : "unknown";
     const runtimeStatuses = Array.isArray(obj?.runtimeStatuses) ? obj.runtimeStatuses.map(runtimeStatus).filter((item) => Boolean(item)) : [];
     const activeRuns = Array.isArray(obj?.activeRuns) ? obj.activeRuns.map(activeRun).filter((item) => Boolean(item)) : [];
-    return { reachable, mode, health: obj?.health, runtimeStatuses, activeRuns, ambiguous: booleanValue(obj?.ambiguous) };
+    const incomplete = !Array.isArray(obj?.runtimeStatuses) || !Array.isArray(obj?.activeRuns)
+        || runtimeStatuses.length !== obj.runtimeStatuses.length || activeRuns.length !== obj.activeRuns.length;
+    return { reachable, mode, generation: stringValue(obj?.generation), health: obj?.health, runtimeStatuses, activeRuns, ambiguous: incomplete || booleanValue(obj?.ambiguous) };
 }
 export function checkActiveWork(status, target = "web") {
     const reasons = [];
@@ -249,7 +256,7 @@ export function checkActiveWork(status, target = "web") {
             reasons.push(`${id} is processing`);
         if (session.streaming === true)
             reasons.push(`${id} is streaming`);
-        if ((session.queuedMessages ?? 0) > 0)
+        if ((session.queuedMessages ?? 0) > 0 || (session.activeTelemetry?.queueDepth ?? 0) > 0)
             reasons.push(`${id} has queued messages`);
         if (session.activeTelemetry?.isStale === true) {
             const phase = session.activeTelemetry.activePhase ? ` in ${session.activeTelemetry.activePhase}` : "";
@@ -260,6 +267,58 @@ export function checkActiveWork(status, target = "web") {
         reasons.push(`${run.runId ?? "yielded run"} is ${run.status ?? "active"}`);
     return { unsafe: reasons.length > 0, reasons };
 }
+function blockingSessions(status) {
+    return status.runtimeStatuses.filter((session) => session.processing || session.streaming
+        || (session.queuedMessages ?? 0) > 0 || (session.activeTelemetry?.queueDepth ?? 0) > 0 || session.activeTelemetry?.isStale);
+}
+export function restartConfirmationToken(status) {
+    if (!status.reachable || status.error || status.ambiguous || status.mode !== "prod" || !status.generation)
+        return undefined;
+    const sessions = blockingSessions(status);
+    if (status.runtimeStatuses.some((session) => !session.piboSessionId || typeof session.processing !== "boolean"
+        || typeof session.streaming !== "boolean" || !Number.isInteger(session.queuedMessages) || session.queuedMessages < 0))
+        return undefined;
+    if (sessions.some((session) => ((session.processing || session.streaming || session.activeTelemetry?.isStale)
+        && !(session.activeEventId || session.activeTelemetry?.activeTurnId))
+        || (session.queuedMessages > 0 && (session.queuedEventIds?.length !== session.queuedMessages || session.queuedEventIds?.some((id) => !id)))
+        || (session.activeTelemetry?.queueDepth ?? 0) > (session.queuedMessages ?? 0)))
+        return undefined;
+    if (status.activeRuns.some((run) => !run.runId || !run.piboSessionId || !run.status))
+        return undefined;
+    // Exclude clock/progress counters: approval describes work identities, not polling time.
+    const snapshot = {
+        generation: status.generation,
+        target: "web", port: targetPort("web"), service: gatewayServiceName("web"), home: managedGatewayHome("web"),
+        sessions: sessions.map((session) => ({
+            id: session.piboSessionId, activeEventId: session.activeEventId,
+            processing: session.processing, streaming: session.streaming,
+            queuedEventIds: [...(session.queuedEventIds ?? [])], queuedMessages: session.queuedMessages,
+            telemetryTurnId: session.activeTelemetry?.activeTurnId,
+            stale: session.activeTelemetry?.isStale === true,
+        })).sort((a, b) => a.id.localeCompare(b.id)),
+        runs: [...status.activeRuns].sort((a, b) => a.runId.localeCompare(b.runId)),
+    };
+    return `${RESTART_CONFIRMATION_TOKEN}:${createHash("sha256").update(JSON.stringify(snapshot)).digest("hex")}`;
+}
+function printRestartApproval(status) {
+    const token = restartConfirmationToken(status);
+    if (token) {
+        console.log("Review the listed work and obtain user approval before running:");
+        console.log(`  pibo gateway web restart --force --confirm ${token}`);
+    }
+    else
+        console.log("Snapshot approval unavailable: status must identify the gateway generation and all active work. Inspect: pibo gateway web doctor");
+}
+function auditRestart(status, decision, force, reason) {
+    const home = managedGatewayHome("web");
+    mkdirSync(home, { recursive: true });
+    appendFileSync(join(home, "gateway-restart-audit.jsonl"), `${JSON.stringify({
+        at: new Date().toISOString(), decision, force, reason, snapshot: restartConfirmationToken(status),
+        generation: status.generation,
+        sessionIds: [...new Set([...blockingSessions(status).map((session) => session.piboSessionId), ...status.activeRuns.map((run) => run.piboSessionId)].filter(Boolean))],
+        runIds: status.activeRuns.map((run) => run.runId), reasons: checkActiveWork(status).reasons,
+    })}\n`, { mode: 0o600 });
+}
 async function readGatewaySafetyStatus(target) {
     const port = targetPort(target);
     const reachable = await isPortReachable("127.0.0.1", port, 1500);
@@ -281,6 +340,10 @@ function printSafetyStatus(target, status) {
     console.log(`  runtime sessions: ${status.runtimeStatuses.length}`);
     for (const session of status.runtimeStatuses) {
         console.log(`    ${session.piboSessionId ?? "unknown"}: processing=${session.processing === true} streaming=${session.streaming === true} queued=${session.queuedMessages ?? 0}`);
+        if (session.activeEventId)
+            console.log(`      active event: ${session.activeEventId}`);
+        if (session.queuedEventIds?.length)
+            console.log(`      queued events: ${session.queuedEventIds.join(", ")}`);
         if (session.activeTelemetry) {
             const parts = [
                 session.activeTelemetry.activePhase ? `phase=${session.activeTelemetry.activePhase}` : undefined,
@@ -295,7 +358,7 @@ function printSafetyStatus(target, status) {
     }
     console.log(`  active yielded runs: ${status.activeRuns.length}`);
     for (const run of status.activeRuns)
-        console.log(`    ${run.runId ?? "unknown"}: ${run.status ?? "active"}${run.toolName ? ` (${run.toolName})` : ""}`);
+        console.log(`    ${run.runId ?? "unknown"}: ${run.status ?? "active"}${run.toolName ? ` (${run.toolName})` : ""} session=${run.piboSessionId ?? "unknown"}`);
 }
 function managerRequiresShell(command) {
     return process.platform === "win32" && /\.(?:cmd|bat)$/i.test(command);
@@ -332,6 +395,7 @@ async function runManagedGatewayCommand(target, command, args, argv = process.ar
             }
             else
                 console.log("  restart safety: idle");
+            printRestartApproval(status);
         }
         if (command === "doctor")
             process.exitCode = status.reachable && !status.error && status.mode === expectedMode(target) ? 0 : 1;
@@ -380,19 +444,43 @@ async function runManagedGatewayCommand(target, command, args, argv = process.ar
         const force = args.includes("--force");
         const confirmIndex = args.indexOf("--confirm");
         const confirmation = confirmIndex >= 0 ? args[confirmIndex + 1] : undefined;
-        if (force && confirmation !== RESTART_CONFIRMATION_TOKEN) {
+        if (target === "dev" && force && confirmation !== RESTART_CONFIRMATION_TOKEN) {
             console.error(`Force restart requires: --confirm ${RESTART_CONFIRMATION_TOKEN}`);
             process.exitCode = 1;
             return true;
         }
-        if (target === "web" && !force) {
-            const active = checkActiveWork(await readGatewaySafetyStatus(target), target);
-            if (active.unsafe) {
-                console.error("Restart blocked: active agent work is running.");
-                console.error("Do not restart the gateway now.");
-                console.error("Ask the user before interrupting active sessions.");
+        if (target === "web") {
+            // Both normal and delayed/forced commands inspect again at execution time.
+            let current = await readGatewaySafetyStatus(target);
+            for (let inspection = 0; inspection < 2; inspection += 1) {
+                const active = checkActiveWork(current, target);
+                const token = restartConfirmationToken(current);
+                printSafetyStatus(target, current);
                 for (const reason of active.reasons)
                     console.error(`- ${reason}`);
+                const blocked = force ? !token || confirmation !== token : active.unsafe;
+                if (blocked) {
+                    const reason = force ? "Snapshot approval is missing, unavailable, or changed." : "Active work or unavailable gateway status.";
+                    console.error(`Restart blocked: ${reason}`);
+                    console.error("Ask the user before interrupting active sessions. Obtain fresh approval with: pibo gateway web status");
+                    printRestartApproval(current);
+                    try {
+                        auditRestart(current, "blocked", force, reason);
+                    }
+                    catch (error) {
+                        console.error(`Restart audit failed: ${error instanceof Error ? error.message : String(error)}`);
+                    }
+                    process.exitCode = 1;
+                    return true;
+                }
+                if (inspection === 0)
+                    current = await readGatewaySafetyStatus(target);
+            }
+            try {
+                auditRestart(current, "approved", force, force ? "Unchanged snapshot explicitly approved" : "Gateway idle");
+            }
+            catch (error) {
+                console.error(`Restart blocked: cannot record restart audit: ${error instanceof Error ? error.message : String(error)}`);
                 process.exitCode = 1;
                 return true;
             }
@@ -642,8 +730,8 @@ Commands:
   dev doctor       Check dev gateway health
 Options:
-  --force --confirm ${RESTART_CONFIRMATION_TOKEN}
-                 Force a production restart after explicit confirmation
+  --force --confirm <snapshot-token>
+                 Restart only the work explicitly approved from web status
 Next:
   pibo gateway web status

package/dist/session-ui/terminalRows.js CHANGED Viewed

@@ -41,14 +41,7 @@ function applyToolDisplayMode(rows, mode) {
         const slimRow = {
             ...row,
             lines: row.lines.slice(0, 1),
-            input: undefined,
-            output: undefined,
-            error: undefined,
-            markdown: undefined,
-            expandable: false,
             singleLine: true,
-            previewOmission: undefined,
-            detailItems: undefined,
         };
         if (mode !== "intent")
             return [slimRow];
@@ -60,6 +53,13 @@ function applyToolDisplayMode(rows, mode) {
                         prefix: "bullet",
                         tokens: [token(intent, row.status === "error" ? "red" : row.status === "done" ? "green" : "cyan", "semibold")],
                     }],
+                input: undefined,
+                output: undefined,
+                error: undefined,
+                markdown: undefined,
+                expandable: false,
+                previewOmission: undefined,
+                detailItems: undefined,
             }];
     });
 }

package/dist/sessions/pibo-data-store.js CHANGED Viewed

@@ -1,4 +1,4 @@
-import { ChatDataIngestService } from "../data/ingest-service.js";
+import { ChatDataIngestService, outputIdempotencyKey } from "../data/ingest-service.js";
 import { PiboDataStore } from "../data/pibo-store.js";
 import { PIBO_AGENT_OBSERVATION_AUTO_CURSOR_MAX_SCOPES, createPiboSession, matchesFindInput, } from "./store.js";
 import { createLegacyPiRuntimeSessionBinding, nextRuntimeSessionBinding, RuntimeSessionBindingConflictError, } from "./runtime-binding.js";
@@ -469,9 +469,26 @@ export class PiboDataSessionStore {
         const at = input.at ?? new Date().toISOString();
         const runsBySession = groupRunsByController(input.recoveredRuns ?? []);
         return this.dataStore.transaction(() => {
+            // Durable terminal output wins over stale telemetry. Do not send a different
+            // recovery payload through the same output identity during startup.
+            const terminalErrors = new Map();
             const recoveredTurns = this.dataStore.telemetry.recoverInterruptedTurns({
                 at,
-                resolveOutcome: (turn) => recoveryOutcomeForTurn(turn, runsBySession.get(turn.piboSessionId) ?? []),
+                resolveOutcome: (turn) => {
+                    const identity = { type: "session_error", piboSessionId: turn.piboSessionId, eventId: recoveryEventId(turn), error: "" };
+                    const existing = this.dataStore.eventLog.findByIdempotencyKey(outputIdempotencyKey(identity));
+                    if (existing) {
+                        const event = {
+                            ...identity,
+                            error: typeof existing.attributes.error === "string" ? existing.attributes.error : existing.previewText ?? "Runtime error",
+                            errorDetails: existing.attributes.errorDetails,
+                        };
+                        terminalErrors.set(turn.turnId, event);
+                        const details = event.errorDetails;
+                        return { status: details?.code === "timeout" ? "timeout" : details?.errorClass === "runtime_abort" ? "aborted" : "error", summary: event.error };
+                    }
+                    return recoveryOutcomeForTurn(turn, runsBySession.get(turn.piboSessionId) ?? []);
+                },
             });
             if (recoveredTurns.length === 0)
                 return [];
@@ -482,7 +499,8 @@ export class PiboDataSessionStore {
                 if (!session)
                     continue;
                 const row = this.db.prepare("SELECT room_id FROM sessions WHERE id = ?").get(session.id);
-                const event = {
+                const existingError = terminalErrors.get(recovered.turn.turnId);
+                const event = existingError ?? {
                     type: "session_error",
                     piboSessionId: session.id,
                     eventId: recoveryEventId(recovered.turn),
@@ -512,13 +530,14 @@ export class PiboDataSessionStore {
 						updated_at = ?
 					WHERE session_id = ?
 				`).run(at, at, at, session.id);
-                ingest.ingestOutputEvent({
-                    session,
-                    roomId: row?.room_id ?? undefined,
-                    actorId: session.id,
-                    event,
-                    createdAt: at,
-                });
+                if (!existingError)
+                    ingest.ingestOutputEvent({
+                        session,
+                        roomId: row?.room_id ?? undefined,
+                        actorId: session.id,
+                        event,
+                        createdAt: at,
+                    });
                 results.push({
                     turnId: recovered.turn.turnId,
                     piboSessionId: session.id,

package/dist/web/channel.js CHANGED Viewed

@@ -1,3 +1,4 @@
+import { randomUUID } from "node:crypto";
 import { createServer } from "node:http";
 import { PiboAuthError } from "../auth/types.js";
 import { handleSimpleAgentApiRequest } from "../api/simple-agent-api.js";
@@ -190,11 +191,12 @@ function createGatewayRuntimeStatuses(channelContext) {
         }
     });
 }
-function createGatewayStatusResponse(channelContext, options) {
+function createGatewayStatusResponse(channelContext, options, generation) {
     const mode = gatewayMode(options);
     return responseJson({
         status: "ok",
         mode,
+        generation,
         health: { status: "ok", mode },
         runtimeStatuses: createGatewayRuntimeStatuses(channelContext),
         activeRuns: collectActiveRuns(channelContext),
@@ -238,6 +240,7 @@ async function waitForServerClose(closePromise, timeoutMs) {
     });
 }
 export function createWebHostChannel(options = {}) {
+    const generation = randomUUID();
     const host = options.host ?? DEFAULT_WEB_CHANNEL_HOST;
     const port = options.port ?? DEFAULT_WEB_CHANNEL_PORT;
     const shutdownDrainTimeoutMs = options.shutdownDrainTimeoutMs ?? DEFAULT_SHUTDOWN_DRAIN_TIMEOUT_MS;
@@ -319,7 +322,7 @@ export function createWebHostChannel(options = {}) {
                 return;
             }
             if (url.pathname === "/gateway/status") {
-                await sendResponse(nodeResponse, createGatewayStatusResponse(requireContext(), options));
+                await sendResponse(nodeResponse, createGatewayStatusResponse(requireContext(), options, generation));
                 return;
             }
             if (url.pathname.startsWith("/api/auth/")) {

package/npm-shrinkwrap.json CHANGED Viewed

@@ -1,12 +1,12 @@
 {
   "name": "@pasko70/pibo",
-  "version": "3.4.3",
+  "version": "3.4.4",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@pasko70/pibo",
-      "version": "3.4.3",
+      "version": "3.4.4",
       "workspaces": [
         "packages/workflows"
       ],

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@pasko70/pibo",
-  "version": "3.4.3",
+  "version": "3.4.4",
   "type": "module",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",