@pasko70/pibo 1.9.13 → 1.10.1

package/dist/debug/pty.js

@@ -8,92 +8,92 @@ const DEFAULT_IDLE_TIMEOUT_MS = 10_000;
 const DEFAULT_INPUT_DELAY_MS = 40;
 const DEFAULT_REAL_PROVIDER_MAX_ITERATIONS = 10;
 const ARTIFACT_SCHEMA_VERSION = 1;
-const PYTHON_PTY_DRIVER = String.raw `
-import os, sys, pty, select, subprocess, signal, termios, fcntl, struct, time
-rows = int(os.environ.get("PIBO_PTY_ROWS", "24"))
-cols = int(os.environ.get("PIBO_PTY_COLS", "100"))
-cmd = sys.argv[1:]
-if cmd and cmd[0] == "--":
-    cmd = cmd[1:]
-if not cmd:
-    print("missing command", file=sys.stderr)
-    sys.exit(64)
-master, slave = pty.openpty()
-try:
-    fcntl.ioctl(slave, termios.TIOCSWINSZ, struct.pack("HHHH", rows, cols, 0, 0))
-except Exception:
-    pass
-proc = subprocess.Popen(cmd, stdin=slave, stdout=slave, stderr=slave, close_fds=True, start_new_session=True)
-os.close(slave)
-os.set_blocking(master, False)
-os.set_blocking(sys.stdin.fileno(), False)
-stdin_open = True
-
-def terminate(signum, frame):
-    try:
-        os.killpg(proc.pid, signum)
-    except Exception:
-        try:
-            proc.terminate()
-        except Exception:
-            pass
-signal.signal(signal.SIGTERM, terminate)
-signal.signal(signal.SIGINT, terminate)
-
-def drain_once():
-    try:
-        data = os.read(master, 4096)
-    except OSError:
-        return False
-    if not data:
-        return False
-    os.write(sys.stdout.fileno(), data)
-    sys.stdout.flush()
-    return True
-
-exit_code = None
-while True:
-    fds = [master]
-    if stdin_open:
-        fds.append(sys.stdin.fileno())
-    try:
-        readable, _, _ = select.select(fds, [], [], 0.05)
-    except OSError:
-        readable = []
-    if master in readable:
-        if not drain_once():
-            break
-    if stdin_open and sys.stdin.fileno() in readable:
-        try:
-            data = os.read(sys.stdin.fileno(), 4096)
-        except BlockingIOError:
-            data = b""
-        except OSError:
-            stdin_open = False
-            data = b""
-        if data:
-            try:
-                os.write(master, data)
-            except OSError:
-                pass
-        else:
-            stdin_open = False
-    polled = proc.poll()
-    if polled is not None:
-        exit_code = polled
-        deadline = time.time() + 0.2
-        while time.time() < deadline and drain_once():
-            pass
-        break
-if exit_code is None:
-    exit_code = proc.poll()
-if exit_code is None:
-    try:
-        proc.terminate()
-    except Exception:
-        pass
-    exit_code = proc.wait(timeout=1)
-sys.exit(exit_code if exit_code is not None else 1)
+const PYTHON_PTY_DRIVER = String.raw `
+import os, sys, pty, select, subprocess, signal, termios, fcntl, struct, time
+rows = int(os.environ.get("PIBO_PTY_ROWS", "24"))
+cols = int(os.environ.get("PIBO_PTY_COLS", "100"))
+cmd = sys.argv[1:]
+if cmd and cmd[0] == "--":
+    cmd = cmd[1:]
+if not cmd:
+    print("missing command", file=sys.stderr)
+    sys.exit(64)
+master, slave = pty.openpty()
+try:
+    fcntl.ioctl(slave, termios.TIOCSWINSZ, struct.pack("HHHH", rows, cols, 0, 0))
+except Exception:
+    pass
+proc = subprocess.Popen(cmd, stdin=slave, stdout=slave, stderr=slave, close_fds=True, start_new_session=True)
+os.close(slave)
+os.set_blocking(master, False)
+os.set_blocking(sys.stdin.fileno(), False)
+stdin_open = True
+
+def terminate(signum, frame):
+    try:
+        os.killpg(proc.pid, signum)
+    except Exception:
+        try:
+            proc.terminate()
+        except Exception:
+            pass
+signal.signal(signal.SIGTERM, terminate)
+signal.signal(signal.SIGINT, terminate)
+
+def drain_once():
+    try:
+        data = os.read(master, 4096)
+    except OSError:
+        return False
+    if not data:
+        return False
+    os.write(sys.stdout.fileno(), data)
+    sys.stdout.flush()
+    return True
+
+exit_code = None
+while True:
+    fds = [master]
+    if stdin_open:
+        fds.append(sys.stdin.fileno())
+    try:
+        readable, _, _ = select.select(fds, [], [], 0.05)
+    except OSError:
+        readable = []
+    if master in readable:
+        if not drain_once():
+            break
+    if stdin_open and sys.stdin.fileno() in readable:
+        try:
+            data = os.read(sys.stdin.fileno(), 4096)
+        except BlockingIOError:
+            data = b""
+        except OSError:
+            stdin_open = False
+            data = b""
+        if data:
+            try:
+                os.write(master, data)
+            except OSError:
+                pass
+        else:
+            stdin_open = False
+    polled = proc.poll()
+    if polled is not None:
+        exit_code = polled
+        deadline = time.time() + 0.2
+        while time.time() < deadline and drain_once():
+            pass
+        break
+if exit_code is None:
+    exit_code = proc.poll()
+if exit_code is None:
+    try:
+        proc.terminate()
+    except Exception:
+        pass
+    exit_code = proc.wait(timeout=1)
+sys.exit(exit_code if exit_code is not None else 1)
 `;
 export async function runDebugPty(args) {
     if (args.length === 0 || args[0] === "--help" || args[0] === "-h") {
@@ -132,47 +132,47 @@ export async function runDebugPty(args) {
     throw new Error(`Unknown pibo debug pty command "${command}". Run pibo debug pty --help.`);
 }
 function printPtyDiscovery() {
-    console.log(`pibo debug pty - run and inspect interactive CLI/TUI commands under a pseudo-terminal
-
-Commands:
-  run             Run one command under PTY
-  scenario        Run a declarative PTY scenario JSON file
-  list-scenarios  List built-in scenario names
-
-Usage:
-  pibo debug pty run [options] -- <command...>
-  pibo debug pty scenario [options] <file>
-  pibo debug pty scenario --builtin cli-session-ui-mocked-e2e
-
-Common options:
-  --rows <n>                 Terminal rows (default: ${DEFAULT_ROWS})
-  --cols <n>                 Terminal columns (default: ${DEFAULT_COLS})
-  --timeout-ms <n>           Wall-clock timeout (default: ${DEFAULT_TIMEOUT_MS})
-  --idle-timeout-ms <n>      Idle timeout after no output (default: ${DEFAULT_IDLE_TIMEOUT_MS})
-  --input-delay-ms <n>       Delay between typed characters (default: ${DEFAULT_INPUT_DELAY_MS})
-  --artifact-dir <path>      Artifact directory
-  --artifact                 Write artifacts for successful runs too
-  --expect <text>            Require cleaned output text (repeatable)
-  --reject <text>            Forbid cleaned output text (repeatable)
-  --type <text>              Type text as a scenario step
-  --press <key>              Press Enter, Escape, CtrlC, Up, or Down
-  --wait-for <text>          Wait until cleaned output contains text
-  --sleep-ms <n>             Sleep as a scenario step
-  --docker-worker <name>     Run inside a named Docker worker/container
-  --workdir <path>           Workdir for host cwd or Docker -w
-  --real-provider            Explicitly allow live provider scenarios
-  --max-iterations <n>       Real-provider iteration cap (default: ${DEFAULT_REAL_PROVIDER_MAX_ITERATIONS})
-
-Safety:
-  Mocked/deterministic mode is default. Real provider mode requires --real-provider and bounded iterations.
+    console.log(`pibo debug pty - run and inspect interactive CLI/TUI commands under a pseudo-terminal
+
+Commands:
+  run             Run one command under PTY
+  scenario        Run a declarative PTY scenario JSON file
+  list-scenarios  List built-in scenario names
+
+Usage:
+  pibo debug pty run [options] -- <command...>
+  pibo debug pty scenario [options] <file>
+  pibo debug pty scenario --builtin cli-session-ui-mocked-e2e
+
+Common options:
+  --rows <n>                 Terminal rows (default: ${DEFAULT_ROWS})
+  --cols <n>                 Terminal columns (default: ${DEFAULT_COLS})
+  --timeout-ms <n>           Wall-clock timeout (default: ${DEFAULT_TIMEOUT_MS})
+  --idle-timeout-ms <n>      Idle timeout after no output (default: ${DEFAULT_IDLE_TIMEOUT_MS})
+  --input-delay-ms <n>       Delay between typed characters (default: ${DEFAULT_INPUT_DELAY_MS})
+  --artifact-dir <path>      Artifact directory
+  --artifact                 Write artifacts for successful runs too
+  --expect <text>            Require cleaned output text (repeatable)
+  --reject <text>            Forbid cleaned output text (repeatable)
+  --type <text>              Type text as a scenario step
+  --press <key>              Press Enter, Escape, CtrlC, Up, or Down
+  --wait-for <text>          Wait until cleaned output contains text
+  --sleep-ms <n>             Sleep as a scenario step
+  --docker-worker <name>     Run inside a named Docker worker/container
+  --workdir <path>           Workdir for host cwd or Docker -w
+  --real-provider            Explicitly allow live provider scenarios
+  --max-iterations <n>       Real-provider iteration cap (default: ${DEFAULT_REAL_PROVIDER_MAX_ITERATIONS})
+
+Safety:
+  Mocked/deterministic mode is default. Real provider mode requires --real-provider and bounded iterations.
 `);
 }
 function printBuiltinScenarios() {
-    console.log(`Built-in PTY scenarios:
-  cli-session-ui-mocked-e2e    Runs pibo tui:sessions without --demo using a deterministic debug fixture when available
-
-Next:
-  pibo debug pty scenario --builtin cli-session-ui-mocked-e2e --artifact
+    console.log(`Built-in PTY scenarios:
+  cli-session-ui-mocked-e2e    Runs pibo tui:sessions without --demo using a deterministic debug fixture when available
+
+Next:
+  pibo debug pty scenario --builtin cli-session-ui-mocked-e2e --artifact
 `);
 }
 function parsePtyOptions(args) {

package/dist/debug/session.js

@@ -121,12 +121,12 @@ export function formatDebugSessionSummary(summary) {
 }
 function listChildSessions(db, piboSessionId, limit) {
     const rows = db
-        .prepare(`
-				SELECT id, pi_session_id, channel, kind, profile, room_id, root_session_id, parent_id, origin_id, workspace, title, status, metadata_json, created_at, updated_at, last_activity_at
-				FROM sessions
-				WHERE parent_id = ?
-				ORDER BY created_at
-				LIMIT ?
+        .prepare(`
+				SELECT id, pi_session_id, channel, kind, profile, room_id, root_session_id, parent_id, origin_id, workspace, title, status, metadata_json, created_at, updated_at, last_activity_at
+				FROM sessions
+				WHERE parent_id = ?
+				ORDER BY created_at
+				LIMIT ?
 			`)
         .all(piboSessionId, limit);
     return rows.map((row) => {
@@ -150,35 +150,35 @@ function listChildSessions(db, piboSessionId, limit) {
 function readChatSession(db, piboSessionId) {
     if (!tableExists(db, "sessions"))
         return undefined;
-    return db.prepare(`
-		SELECT
-			s.id AS pibo_session_id,
-			s.room_id,
-			s.root_session_id,
-			s.status,
-			s.last_activity_at,
-			stats.message_count,
-			stats.tool_call_count,
-			stats.error_count,
-			stats.last_event_stream_id,
-			nav.child_count,
-			nav.sort_key
-		FROM sessions s
-		LEFT JOIN session_stats stats ON stats.session_id = s.id
-		LEFT JOIN session_navigation nav ON nav.session_id = s.id
-		WHERE s.id = ?
+    return db.prepare(`
+		SELECT
+			s.id AS pibo_session_id,
+			s.room_id,
+			s.root_session_id,
+			s.status,
+			s.last_activity_at,
+			stats.message_count,
+			stats.tool_call_count,
+			stats.error_count,
+			stats.last_event_stream_id,
+			nav.child_count,
+			nav.sort_key
+		FROM sessions s
+		LEFT JOIN session_stats stats ON stats.session_id = s.id
+		LEFT JOIN session_navigation nav ON nav.session_id = s.id
+		WHERE s.id = ?
 	`).get(piboSessionId);
 }
 function readEventSummaries(db, piboSessionId, limit) {
     if (!tableExists(db, "event_log"))
         return [];
     return db
-        .prepare(`
-				SELECT type, event_id, created_at, stream_id
-				FROM event_log
-				WHERE session_id = ?
-				ORDER BY stream_id DESC
-				LIMIT ?
+        .prepare(`
+				SELECT type, event_id, created_at, stream_id
+				FROM event_log
+				WHERE session_id = ?
+				ORDER BY stream_id DESC
+				LIMIT ?
 			`)
         .all(piboSessionId, limit);
 }

package/dist/debug/tools.js

@@ -9,11 +9,11 @@ export function inspectDebugTool(piboSessionId, store, selector, options = {}) {
     try {
         if (!tableExists(db, "event_log"))
             return emptyTool(piboSessionId, selector);
-        const rows = db.prepare(`
-			SELECT stream_id, session_id, session_sequence, event_id, type, created_at, preview_text, attributes_json
-			FROM event_log
-			WHERE session_id = ? AND type IN ('tool_call', 'tool_execution_started', 'tool_execution_updated', 'tool_execution_finished')
-			ORDER BY stream_id ASC
+        const rows = db.prepare(`
+			SELECT stream_id, session_id, session_sequence, event_id, type, created_at, preview_text, attributes_json
+			FROM event_log
+			WHERE session_id = ? AND type IN ('tool_call', 'tool_execution_started', 'tool_execution_updated', 'tool_execution_finished')
+			ORDER BY stream_id ASC
 		`).all(piboSessionId);
         const matching = rows.filter((row) => toolCallIdFromRow(row)?.includes(selector) || row.event_id === selector);
         if (matching.length === 0)

package/dist/debug/trace.js

@@ -1,6 +1,6 @@
 import { buildTraceView } from "../apps/chat/trace.js";
 import { normalizeSessionErrorDetails } from "../core/session-errors.js";
-import { compareTraceOrder } from "../shared/trace-order.js";
+import { compareTraceNodes } from "../shared/trace-nodes.js";
 import { openReadOnlyDebugDatabase, withStorePath } from "./sql.js";
 import { formatNextCommands } from "./next-commands.js";
 export async function inspectDebugTrace(piboSessionId, stores, options = {}) {
@@ -16,10 +16,11 @@ export async function inspectDebugTrace(piboSessionId, stores, options = {}) {
             throw new Error(`Pibo session "${piboSessionId}" not found`);
         const session = sessionFromRow(sessionRow);
         const sessions = sessionsDb.prepare("SELECT * FROM sessions").all().map(sessionFromRow);
+        const adapterIssues = [];
         const events = tableExists(chatDb, "event_log")
             ? chatDb
                 .prepare("SELECT stream_id, session_id, session_sequence, event_id, type, created_at, preview_text, attributes_json FROM event_log WHERE session_id = ? ORDER BY stream_id ASC")
-                .all(piboSessionId).map(eventFromRow).filter((event) => event !== undefined)
+                .all(piboSessionId).map((row) => eventFromRow(row, adapterIssues)).filter((event) => event !== undefined)
             : [];
         const view = await buildTraceView({
             session,
@@ -36,7 +37,7 @@ export async function inspectDebugTrace(piboSessionId, stores, options = {}) {
             status: traceStatus(view),
             nodes: filtered,
             rawNodeCount: rows.length,
-            ...(options.check ? { checks: checkTraceView(view) } : {}),
+            ...(options.check ? { checks: checkTraceView(view, adapterIssues) } : {}),
             nextCommands: buildTraceNextCommands(view.piboSessionId, filtered),
         };
     }
@@ -168,10 +169,11 @@ function traceStatus(view) {
         return "running";
     return "done";
 }
-function checkTraceView(view) {
-    const issues = [];
+export function checkTraceView(view, adapterIssues = []) {
+    const issues = [...adapterIssues];
     const all = flattenPiboTraceNodes(view.nodes);
     const ids = new Set();
+    const stableKeyOwners = new Map();
     for (const node of all) {
         if (ids.has(node.id)) {
             issues.push({
@@ -206,6 +208,20 @@ function checkTraceView(view) {
                 message: "Trace node has no conceptual stable key.",
             });
         }
+        else {
+            const existingOwner = stableKeyOwners.get(node.stableKey);
+            if (existingOwner && existingOwner !== node.id) {
+                issues.push({
+                    severity: "warning",
+                    code: "duplicate_stable_key",
+                    nodeId: node.id,
+                    message: `Stable key "${node.stableKey}" is already used by node "${existingOwner}".`,
+                });
+            }
+            else {
+                stableKeyOwners.set(node.stableKey, node.id);
+            }
+        }
     }
     for (const node of all) {
         if (node.parentId && !ids.has(node.parentId)) {
@@ -235,7 +251,7 @@ function checkSiblingOrder(nodes, issues) {
         checkSiblingOrder(node.children, issues);
 }
 function compareOrder(left, right) {
-    return compareTraceOrder(left.orderKey, right.orderKey) || left.id.localeCompare(right.id);
+    return compareTraceNodes(left, right);
 }
 function flattenPiboTraceNodes(nodes) {
     return nodes.flatMap((node) => [node, ...flattenPiboTraceNodes(node.children)]);
@@ -288,10 +304,18 @@ function sessionFromRow(row) {
         updatedAt: row.updated_at,
     };
 }
-function eventFromRow(row) {
+function eventFromRow(row, issues) {
     const payload = outputPayloadFromV2Row(row);
     if (!payload)
         return undefined;
+    if ((row.type === "assistant_delta" || row.type === "thinking_delta") && !nonEmptyEventText(payload)) {
+        issues.push({
+            severity: "warning",
+            code: "missing_delta_text",
+            nodeId: row.event_id ?? String(row.stream_id),
+            message: `Persisted ${row.type} event has no readable text payload.`,
+        });
+    }
     return {
         id: String(row.stream_id),
         piboSessionId: row.session_id ?? undefined,
@@ -315,12 +339,16 @@ function outputPayloadFromV2Row(row) {
     const base = { piboSessionId, eventId: row.event_id ?? undefined };
     if (row.type === "assistant_message")
         return compactObject({ ...base, type: "assistant_message", text: row.preview_text ?? "" });
+    if (row.type === "assistant_delta")
+        return compactObject({ ...base, type: "assistant_delta", text: inlineTextPayload(inlinePayload) ?? row.preview_text ?? "" });
     if (row.type === "message_started")
         return compactObject({ ...base, type: "message_started", text: row.preview_text ?? "" });
     if (row.type === "message_finished")
         return compactObject({ ...base, type: "message_finished" });
     if (row.type === "thinking_started")
         return compactObject({ ...base, type: "thinking_started" });
+    if (row.type === "thinking_delta")
+        return compactObject({ ...base, type: "thinking_delta", text: inlineTextPayload(inlinePayload) ?? row.preview_text ?? "" });
     if (row.type === "thinking_finished")
         return compactObject({ ...base, type: "thinking_finished", text: row.preview_text ?? "" });
     if (row.type === "tool_call")
@@ -337,6 +365,13 @@ function outputPayloadFromV2Row(row) {
     }
     return compactObject({ ...base, type: row.type });
 }
+function inlineTextPayload(value) {
+    return typeof value === "string" ? value : undefined;
+}
+function nonEmptyEventText(event) {
+    const text = event.text;
+    return typeof text === "string" && text.length > 0;
+}
 function stringAttribute(attributes, key) {
     const value = attributes[key];
     return typeof value === "string" ? value : undefined;