@particle-academy/fancy-connector-core 0.2.0 → 0.3.0

package/dist/index.js

@@ -50,16 +50,33 @@ function satisfiesMinimum(coreVersion, minimum) {
 
 // src/delivery.ts
 var UNREACHABLE_CODES = /* @__PURE__ */ new Set([
+  // Every code here must PROVE the request never reached an application:
+  // nothing listening, no route, or a name that never resolved. If a code can
+  // also occur after the peer received and acted on the request, it belongs in
+  // AMBIGUOUS_CODES -- `shouldRetry` retries `unreachable` without consulting
+  // `idempotent`, so a wrong entry here is a duplicate send, not a slow one.
   "ECONNREFUSED",
   "ENOTFOUND",
   "EAI_AGAIN",
   "EHOSTUNREACH",
   "ENETUNREACH",
-  "ECONNRESET",
-  "EPIPE",
   "ERR_SOCKET_CONNECTION_TIMEOUT"
 ]);
 var AMBIGUOUS_CODES = /* @__PURE__ */ new Set([
+  // A peer sends RST whenever it tears the connection down -- INCLUDING after
+  // it has received and acted on the request but before the response comes
+  // back. EPIPE is the same story from our side: we wrote to a socket the peer
+  // had already closed, and whether an earlier complete request was processed
+  // first is not knowable from here. Node surfaces the safe case and the unsafe
+  // case as the same code, so the code cannot carry the claim.
+  //
+  // These two sat in UNREACHABLE_CODES until 0.3.0, which made them
+  // unconditionally retryable and produced three sends of connectors that had
+  // declared `idempotent: false`. Same defect as the 5xx / thrown-transport
+  // split this module already fixed once, and a stated exception to a rule that
+  // should have covered them.
+  "ECONNRESET",
+  "EPIPE",
   "ETIMEDOUT",
   "UND_ERR_HEADERS_TIMEOUT",
   "UND_ERR_BODY_TIMEOUT",