@parse/push-adapter 6.4.0 → 6.5.0

package/README.md

@@ -19,8 +19,10 @@ The official Push Notification adapter for Parse Server. See [Parse Server Push
 - [Configure Parse Server](#configure-parse-server)
   - [Apple Push Options](#apple-push-options)
   - [Android Push Options](#android-push-options)
+  - [Firebase Cloud Messaging (FCM)](#firebase-cloud-messaging-fcm)
     - [Google Cloud Service Account Key](#google-cloud-service-account-key)
     - [Migration to FCM HTTP v1 API (June 2024)](#migration-to-fcm-http-v1-api-june-2024)
+    - [HTTP/1.1 Legacy Option](#http11-legacy-option)
   - [Expo Push Options](#expo-push-options)
 - [Bundled with Parse Server](#bundled-with-parse-server)
 - [Logging](#logging)
@@ -110,6 +112,10 @@ android: {
 }
 ```
 
+### Firebase Cloud Messaging (FCM)
+
+This section contains some considerations when using FCM, regardless of the destination ecosystems the push notification is sent to.
+
 #### Google Cloud Service Account Key
 
 The Firebase console allows to easily create and download a Google Cloud service account key JSON file with the required permissions. Instead of setting `firebaseServiceAccount` to the path of the JSON file, you can provide an object representing a Google Cloud service account key:
@@ -139,6 +145,19 @@ android: {
 }
 ```
 
+#### HTTP/1.1 Legacy Option
+
+With the introduction of the FCM HTTP v1 API, support for HTTP/2 was added which provides faster throughput for push notifications. To use the older version HTTP/1.1 set `fcmEnableLegacyHttpTransport: true` in your push options.
+
+Example options:
+
+```js
+android: {
+  firebaseServiceAccount: __dirname + '/firebase.json',
+  fcmEnableLegacyHttpTransport: true
+}
+```
+
 ### Expo Push Options
 
 Example options:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parse/push-adapter",
-  "version": "6.4.0",
+  "version": "6.5.0",
   "description": "Base parse-server-push-adapter",
   "main": "src/index.js",
   "type": "module",
@@ -8,6 +8,8 @@
     "src/"
   ],
   "scripts": {
+    "lint": "eslint --cache ./",
+    "lint:fix": "eslint --fix --cache ./",
     "test": "TESTING=1 c8 ./node_modules/.bin/jasmine"
   },
   "keywords": [
@@ -25,12 +27,13 @@
     "@parse/node-apn": "6.0.1",
     "@parse/node-gcm": "1.0.2",
     "expo-server-sdk": "3.10.0",
-    "firebase-admin": "12.1.1",
+    "firebase-admin": "12.3.0",
     "npmlog": "7.0.1",
-    "parse": "5.1.0",
+    "parse": "5.2.0",
     "web-push": "3.6.7"
   },
   "devDependencies": {
+    "@eslint/js": "9.6.0",
     "@semantic-release/changelog": "6.0.3",
     "@semantic-release/commit-analyzer": "13.0.0",
     "@semantic-release/git": "10.0.1",
@@ -39,6 +42,7 @@
     "@semantic-release/release-notes-generator": "14.0.1",
     "c8": "10.1.2",
     "codecov": "3.8.0",
+    "eslint": "9.6.0",
     "jasmine": "5.1.0",
     "jasmine-spec-reporter": "7.0.0",
     "semantic-release": "24.0.0"

package/src/APNS.js

@@ -39,7 +39,7 @@ export class APNS {
     }
 
     // Create Provider from each arg-object
-    for (let apnsArgs of apnsArgsList) {
+    for (const apnsArgs of apnsArgsList) {
 
       // rewrite bundleId to topic for backward-compatibility
       if (apnsArgs.bundleId) {
@@ -47,7 +47,7 @@ export class APNS {
         apnsArgs.topic = apnsArgs.bundleId
       }
 
-      let provider = APNS._createProvider(apnsArgs);
+      const provider = APNS._createProvider(apnsArgs);
       this.providers.push(provider);
     }
 
@@ -70,42 +70,42 @@ export class APNS {
    * @returns {Object} A promise which is resolved immediately
    */
   send(data, allDevices) {
-    let coreData = data && data.data;
+    const coreData = data && data.data;
     if (!coreData || !allDevices || !Array.isArray(allDevices)) {
       log.warn(LOG_PREFIX, 'invalid push payload');
       return;
     }
-    let expirationTime = data['expiration_time'] || coreData['expiration_time'];
-    let collapseId = data['collapse_id'] || coreData['collapse_id'];
-    let pushType = data['push_type'] || coreData['push_type'];
-    let priority = data['priority'] || coreData['priority'];
+    const expirationTime = data['expiration_time'] || coreData['expiration_time'];
+    const collapseId = data['collapse_id'] || coreData['collapse_id'];
+    const pushType = data['push_type'] || coreData['push_type'];
+    const priority = data['priority'] || coreData['priority'];
     let allPromises = [];
 
-    let devicesPerAppIdentifier = {};
+    const devicesPerAppIdentifier = {};
 
     // Start by clustering the devices per appIdentifier
     allDevices.forEach(device => {
-      let appIdentifier = device.appIdentifier;
+      const appIdentifier = device.appIdentifier;
       devicesPerAppIdentifier[appIdentifier] = devicesPerAppIdentifier[appIdentifier] || [];
       devicesPerAppIdentifier[appIdentifier].push(device);
     });
 
-    for (let key in devicesPerAppIdentifier) {
-      let devices = devicesPerAppIdentifier[key];
-      let appIdentifier = devices[0].appIdentifier;
-      let providers = this._chooseProviders(appIdentifier);
+    for (const key in devicesPerAppIdentifier) {
+      const devices = devicesPerAppIdentifier[key];
+      const appIdentifier = devices[0].appIdentifier;
+      const providers = this._chooseProviders(appIdentifier);
 
       // No Providers found
       if (!providers || providers.length === 0) {
-        let errorPromises = devices.map(device => APNS._createErrorPromise(device.deviceToken, 'No Provider found'));
+        const errorPromises = devices.map(device => APNS._createErrorPromise(device.deviceToken, 'No Provider found'));
         allPromises = allPromises.concat(errorPromises);
         continue;
       }
 
-      let headers = { expirationTime: expirationTime, topic: appIdentifier, collapseId: collapseId, pushType: pushType, priority: priority }
-      let notification = APNS._generateNotification(coreData, headers);
+      const headers = { expirationTime: expirationTime, topic: appIdentifier, collapseId: collapseId, pushType: pushType, priority: priority }
+      const notification = APNS._generateNotification(coreData, headers);
       const deviceIds = devices.map(device => device.deviceToken);
-      let promise = this.sendThroughProvider(notification, deviceIds, providers);
+      const promise = this.sendThroughProvider(notification, deviceIds, providers);
       allPromises.push(promise.then(this._handlePromise.bind(this)));
     }
 
@@ -117,25 +117,25 @@ export class APNS {
 
   sendThroughProvider(notification, devices, providers) {
     return providers[0]
-        .send(notification, devices)
-        .then((response) => {
-          if (response.failed
+      .send(notification, devices)
+      .then((response) => {
+        if (response.failed
               && response.failed.length > 0
               && providers && providers.length > 1) {
-            let devices = response.failed.map((failure) => { return failure.device; });
-            // Reset the failures as we'll try next connection
-            response.failed = [];
-            return this.sendThroughProvider(notification,
-                            devices,
-                            providers.slice(1, providers.length)).then((retryResponse) => {
-                              response.failed = response.failed.concat(retryResponse.failed);
-                              response.sent = response.sent.concat(retryResponse.sent);
-                              return response;
-                            });
-          } else {
+          const devices = response.failed.map((failure) => { return failure.device; });
+          // Reset the failures as we'll try next connection
+          response.failed = [];
+          return this.sendThroughProvider(notification,
+            devices,
+            providers.slice(1, providers.length)).then((retryResponse) => {
+            response.failed = response.failed.concat(retryResponse.failed);
+            response.sent = response.sent.concat(retryResponse.sent);
             return response;
-          }
-        });
+          });
+        } else {
+          return response;
+        }
+      });
   }
 
   static _validateAPNArgs(apnsArgs) {
@@ -154,7 +154,7 @@ export class APNS {
       throw new Parse.Error(Parse.Error.PUSH_MISCONFIGURED, 'topic is mssing for %j', apnsArgs);
     }
 
-    let provider = new apn.Provider(apnsArgs);
+    const provider = new apn.Provider(apnsArgs);
 
     // Sets the topic on this provider
     provider.topic = apnsArgs.topic;
@@ -176,48 +176,46 @@ export class APNS {
    * @returns {Object} A apns Notification
    */
   static _generateNotification(coreData, headers) {
-    let notification = new apn.Notification();
-    let payload = {};
-    for (let key in coreData) {
+    const notification = new apn.Notification();
+    const payload = {};
+    for (const key in coreData) {
       switch (key) {
-        case 'aps':
-          notification.aps = coreData.aps;
-          break;
-        case 'alert':
-          notification.setAlert(coreData.alert);
-          break;
-        case 'title':
-          notification.setTitle(coreData.title);
+      case 'aps':
+        notification.aps = coreData.aps;
+        break;
+      case 'alert':
+        notification.setAlert(coreData.alert);
+        break;
+      case 'title':
+        notification.setTitle(coreData.title);
+        break;
+      case 'badge':
+        notification.setBadge(coreData.badge);
+        break;
+      case 'sound':
+        notification.setSound(coreData.sound);
+        break;
+      case 'content-available':
+        notification.setContentAvailable(coreData['content-available'] === 1);
+        break;
+      case 'mutable-content':
+        notification.setMutableContent(coreData['mutable-content'] === 1);
+        break;
+      case 'targetContentIdentifier':
+        notification.setTargetContentIdentifier(coreData.targetContentIdentifier);
+        break;
+      case 'interruptionLevel':
+        notification.setInterruptionLevel(coreData.interruptionLevel);
+        break;
+      case 'category':
+        notification.setCategory(coreData.category);
+        break;
+      case 'threadId':
+        notification.setThreadId(coreData.threadId);
+        break;
+      default:
+        payload[key] = coreData[key];
         break;
-        case 'badge':
-          notification.setBadge(coreData.badge);
-          break;
-        case 'sound':
-          notification.setSound(coreData.sound);
-          break;
-        case 'content-available':
-          let isAvailable = coreData['content-available'] === 1;
-          notification.setContentAvailable(isAvailable);
-          break;
-        case 'mutable-content':
-          let isMutable = coreData['mutable-content'] === 1;
-          notification.setMutableContent(isMutable);
-          break;
-        case 'targetContentIdentifier':
-          notification.setTargetContentIdentifier(coreData.targetContentIdentifier);
-          break;
-        case 'interruptionLevel':
-          notification.setInterruptionLevel(coreData.interruptionLevel);
-          break;
-        case 'category':
-          notification.setCategory(coreData.category);
-          break;
-        case 'threadId':
-          notification.setThreadId(coreData.threadId);
-          break;
-        default:
-          payload[key] = coreData[key];
-          break;
       }
     }
 
@@ -251,7 +249,7 @@ export class APNS {
     }*/
 
     // Otherwise we try to match the appIdentifier with topic on provider
-    let qualifiedProviders = this.providers.filter((provider) => appIdentifier === provider.topic);
+    const qualifiedProviders = this.providers.filter((provider) => appIdentifier === provider.topic);
 
     if (qualifiedProviders.length > 0) {
       return qualifiedProviders;
@@ -263,7 +261,7 @@ export class APNS {
   }
 
   _handlePromise(response) {
-    let promises = [];
+    const promises = [];
     response.sent.forEach((token) => {
       log.verbose(LOG_PREFIX, 'APNS transmitted to %s', token.device);
       promises.push(APNS._createSuccesfullPromise(token.device));
@@ -282,8 +280,8 @@ export class APNS {
       log.error(LOG_PREFIX, 'APNS error transmitting to device %s with status %s and reason %s', failure.device, failure.status, failure.response.reason);
       return APNS._createErrorPromise(failure.device, failure.response.reason);
     } else {
-       log.error(LOG_PREFIX, 'APNS error transmitting to device with unkown error');
-       return APNS._createErrorPromise(failure.device, 'Unkown status');
+      log.error(LOG_PREFIX, 'APNS error transmitting to device with unkown error');
+      return APNS._createErrorPromise(failure.device, 'Unkown status');
     }
   }
 

package/src/EXPO.js

@@ -7,19 +7,19 @@ import { Expo } from 'expo-server-sdk';
 const LOG_PREFIX = 'parse-server-push-adapter EXPO';
 
 function expoResultToParseResponse(result) {
-    if (result.status === 'ok') {
-      return result;
-    } else  {
-      // ParseServer looks for "error", and supports ceratin codes like 'NotRegistered' for
-      // cleanup. Expo returns slighyly different ones so changing to match what is expected
-      // This can be taken out if the responsibility gets moved to the adapter itself.
-      const error = result.message === 'DeviceNotRegistered' ?
-        'NotRegistered' : result.message;
-      return {
-        error,
-        ...result
-      }
+  if (result.status === 'ok') {
+    return result;
+  } else  {
+    // ParseServer looks for "error", and supports ceratin codes like 'NotRegistered' for
+    // cleanup. Expo returns slighyly different ones so changing to match what is expected
+    // This can be taken out if the responsibility gets moved to the adapter itself.
+    const error = result.message === 'DeviceNotRegistered' ?
+      'NotRegistered' : result.message;
+    return {
+      error,
+      ...result
     }
+  }
 }
 
 export class EXPO {
@@ -60,7 +60,7 @@ export class EXPO {
 
     const resolvers = [];
     const promises = deviceTokens.map(() => new Promise(resolve => resolvers.push(resolve)));
-    let length = deviceTokens.length;
+    const length = deviceTokens.length;
 
     log.verbose(LOG_PREFIX, `sending to ${length} ${length > 1 ? 'devices' : 'device'}`);
 

package/src/FCM.js

@@ -25,14 +25,26 @@ export default function FCM(args, pushType) {
     );
   }
 
+  const fcmEnableLegacyHttpTransport = typeof args.fcmEnableLegacyHttpTransport === 'boolean'
+    ? args.fcmEnableLegacyHttpTransport
+    : false;
+
   let app;
   if (getApps().length === 0) {
     app = initializeApp({ credential: cert(args.firebaseServiceAccount) });
   } else {
     app = getApp();
   }
+
   this.sender = getMessaging(app);
-  this.pushType = pushType; // Push type is only used to remain backwards compatible with APNS and GCM
+
+  if (fcmEnableLegacyHttpTransport) {
+    this.sender.enableLegacyHttpTransport();
+    log.warn(LOG_PREFIX, 'Legacy HTTP/1.1 transport is enabled. This is a deprecated feature and support for this flag will be removed in the future.');
+  }
+
+  // Push type is only used to remain backwards compatible with APNS and GCM
+  this.pushType = pushType;
 }
 
 FCM.FCMRegistrationTokensMax = FCMRegistrationTokensMax;
@@ -142,14 +154,14 @@ function _APNSToFCMPayload(requestData) {
     coreData = requestData.data;
   }
 
-  let expirationTime =
+  const expirationTime =
     requestData['expiration_time'] || coreData['expiration_time'];
-  let collapseId = requestData['collapse_id'] || coreData['collapse_id'];
-  let pushType = requestData['push_type'] || coreData['push_type'];
-  let priority = requestData['priority'] || coreData['priority'];
+  const collapseId = requestData['collapse_id'] || coreData['collapse_id'];
+  const pushType = requestData['push_type'] || coreData['push_type'];
+  const priority = requestData['priority'] || coreData['priority'];
 
-  let apnsPayload = { apns: { payload: { aps: {} } } };
-  let headers = {};
+  const apnsPayload = { apns: { payload: { aps: {} } } };
+  const headers = {};
 
   // Set to alert by default if not set explicitly
   headers['apns-push-type'] = 'alert';
@@ -172,70 +184,70 @@ function _APNSToFCMPayload(requestData) {
     apnsPayload.apns.headers = headers;
   }
 
-  for (let key in coreData) {
+  for (const key in coreData) {
     switch (key) {
-      case 'aps':
-        apnsPayload['apns']['payload']['aps'] = coreData.aps;
-        break;
-      case 'alert':
-        if (typeof coreData.alert == 'object') {
-          // When we receive a dictionary, use as is to remain
-          // compatible with how the APNS.js + node-apn work
-          apnsPayload['apns']['payload']['aps']['alert'] = coreData.alert;
-        } else {
-          // When we receive a value, prepare `alert` dictionary
-          // and set its `body` property
-          apnsPayload['apns']['payload']['aps']['alert'] = {};
-          apnsPayload['apns']['payload']['aps']['alert']['body'] = coreData.alert;
-        }
-        break;
-      case 'title':
-        // Ensure the alert object exists before trying to assign the title
-        // title always goes into the nested `alert` dictionary
-        if (!apnsPayload['apns']['payload']['aps'].hasOwnProperty('alert')) {
-          apnsPayload['apns']['payload']['aps']['alert'] = {};
-        }
-        apnsPayload['apns']['payload']['aps']['alert']['title'] = coreData.title;
-        break;
-      case 'badge':
-        apnsPayload['apns']['payload']['aps']['badge'] = coreData.badge;
-        break;
-      case 'sound':
-        apnsPayload['apns']['payload']['aps']['sound'] = coreData.sound;
-        break;
-      case 'content-available':
-        apnsPayload['apns']['payload']['aps']['content-available'] =
+    case 'aps':
+      apnsPayload['apns']['payload']['aps'] = coreData.aps;
+      break;
+    case 'alert':
+      if (typeof coreData.alert == 'object') {
+        // When we receive a dictionary, use as is to remain
+        // compatible with how the APNS.js + node-apn work
+        apnsPayload['apns']['payload']['aps']['alert'] = coreData.alert;
+      } else {
+        // When we receive a value, prepare `alert` dictionary
+        // and set its `body` property
+        apnsPayload['apns']['payload']['aps']['alert'] = {};
+        apnsPayload['apns']['payload']['aps']['alert']['body'] = coreData.alert;
+      }
+      break;
+    case 'title':
+      // Ensure the alert object exists before trying to assign the title
+      // title always goes into the nested `alert` dictionary
+      if (!apnsPayload['apns']['payload']['aps'].hasOwnProperty('alert')) {
+        apnsPayload['apns']['payload']['aps']['alert'] = {};
+      }
+      apnsPayload['apns']['payload']['aps']['alert']['title'] = coreData.title;
+      break;
+    case 'badge':
+      apnsPayload['apns']['payload']['aps']['badge'] = coreData.badge;
+      break;
+    case 'sound':
+      apnsPayload['apns']['payload']['aps']['sound'] = coreData.sound;
+      break;
+    case 'content-available':
+      apnsPayload['apns']['payload']['aps']['content-available'] =
           coreData['content-available'];
-        break;
-      case 'mutable-content':
-        apnsPayload['apns']['payload']['aps']['mutable-content'] =
+      break;
+    case 'mutable-content':
+      apnsPayload['apns']['payload']['aps']['mutable-content'] =
           coreData['mutable-content'];
-        break;
-      case 'targetContentIdentifier':
-        apnsPayload['apns']['payload']['aps']['target-content-id'] =
+      break;
+    case 'targetContentIdentifier':
+      apnsPayload['apns']['payload']['aps']['target-content-id'] =
           coreData.targetContentIdentifier;
-        break;
-      case 'interruptionLevel':
-        apnsPayload['apns']['payload']['aps']['interruption-level'] =
+      break;
+    case 'interruptionLevel':
+      apnsPayload['apns']['payload']['aps']['interruption-level'] =
           coreData.interruptionLevel;
-        break;
-      case 'category':
-        apnsPayload['apns']['payload']['aps']['category'] = coreData.category;
-        break;
-      case 'threadId':
-        apnsPayload['apns']['payload']['aps']['thread-id'] = coreData.threadId;
-        break;
-      case 'expiration_time': // Exclude header-related fields as these are set above
-        break;
-      case 'collapse_id':
-        break;
-      case 'push_type':
-        break;
-      case 'priority':
-        break;
-      default:
-        apnsPayload['apns']['payload'][key] = coreData[key]; // Custom keys should be outside aps
-        break;
+      break;
+    case 'category':
+      apnsPayload['apns']['payload']['aps']['category'] = coreData.category;
+      break;
+    case 'threadId':
+      apnsPayload['apns']['payload']['aps']['thread-id'] = coreData.threadId;
+      break;
+    case 'expiration_time': // Exclude header-related fields as these are set above
+      break;
+    case 'collapse_id':
+      break;
+    case 'push_type':
+      break;
+    case 'priority':
+      break;
+    default:
+      apnsPayload['apns']['payload'][key] = coreData[key]; // Custom keys should be outside aps
+      break;
     }
   }
   return apnsPayload;

package/src/GCM.js

@@ -12,7 +12,7 @@ const GCMRegistrationTokensMax = 1000;
 export default function GCM(args) {
   if (typeof args !== 'object' || !args.apiKey) {
     throw new Parse.Error(Parse.Error.PUSH_MISCONFIGURED,
-                          'GCM Configuration is invalid');
+      'GCM Configuration is invalid');
   }
   this.sender = new gcm.Sender(args.apiKey, args.requestOptions);
 }
@@ -30,23 +30,23 @@ GCM.prototype.send = function(data, devices) {
     log.warn(LOG_PREFIX, 'invalid push payload');
     return;
   }
-  let pushId = randomString(10);
+  const pushId = randomString(10);
   // Make a new array
-  devices=devices.slice(0);
-  let timestamp = Date.now();
+  devices = devices.slice(0);
+  const timestamp = Date.now();
   // For android, we can only have 1000 recepients per send, so we need to slice devices to
   // chunk if necessary
-  let slices = sliceDevices(devices, GCM.GCMRegistrationTokensMax);
+  const slices = sliceDevices(devices, GCM.GCMRegistrationTokensMax);
   if (slices.length > 1) {
     log.verbose(LOG_PREFIX, `the number of devices exceeds ${GCMRegistrationTokensMax}`);
     // Make 1 send per slice
-    let promises = slices.reduce((memo, slice) => {
-      let promise = this.send(data, slice, timestamp);
+    const promises = slices.reduce((memo, slice) => {
+      const promise = this.send(data, slice, timestamp);
       memo.push(promise);
       return memo;
     }, [])
-    return Promise.all(promises).then((results) => {
-      let allResults = results.reduce((memo, result) => {
+    return Promise.all(promises).then((results) => {
+      const allResults = results.reduce((memo, result) => {
         return memo.concat(result);
       }, []);
       return Promise.resolve(allResults);
@@ -63,23 +63,23 @@ GCM.prototype.send = function(data, devices) {
   }
   // Generate gcm payload
   // PushId is not a formal field of GCM, but Parse Android SDK uses this field to deduplicate push notifications
-  let gcmPayload = generateGCMPayload(data, pushId, timestamp, expirationTime);
+  const gcmPayload = generateGCMPayload(data, pushId, timestamp, expirationTime);
   // Make and send gcm request
-  let message = new gcm.Message(gcmPayload);
+  const message = new gcm.Message(gcmPayload);
 
   // Build a device map
-  let devicesMap = devices.reduce((memo, device) => {
+  const devicesMap = devices.reduce((memo, device) => {
     memo[device.deviceToken] = device;
     return memo;
   }, {});
 
-  let deviceTokens = Object.keys(devicesMap);
+  const deviceTokens = Object.keys(devicesMap);
 
   const resolvers = [];
-  const promises = deviceTokens.map(() => new Promise(resolve => resolvers.push(resolve)));
-  let registrationTokens = deviceTokens;
-  let length = registrationTokens.length;
-  log.verbose(LOG_PREFIX, `sending to ${length} ${length > 1 ? 'devices' : 'device'}`);
+  const promises = deviceTokens.map(() => new Promise(resolve => resolvers.push(resolve)));
+  const registrationTokens = deviceTokens;
+  const length = registrationTokens.length;
+  log.verbose(LOG_PREFIX, `sending to ${length} ${length > 1 ? 'devices' : 'device'}`);
   this.sender.send(message, { registrationTokens: registrationTokens }, 5, (error, response) => {
     // example response:
     /*
@@ -97,13 +97,13 @@ GCM.prototype.send = function(data, devices) {
     } else {
       log.verbose(LOG_PREFIX, `GCM Response: %s`, JSON.stringify(response, null, 4));
     }
-    let { results, multicast_id } = response || {};
+    const { results, multicast_id } = response || {};
     registrationTokens.forEach((token, index) => {
-      let resolve = resolvers[index];
-      let result = results ? results[index] : undefined;
-      let device = devicesMap[token];
+      const resolve = resolvers[index];
+      const result = results ? results[index] : undefined;
+      const device = devicesMap[token];
       device.deviceType = 'android';
-      let resolution = {
+      const resolution = {
         device,
         multicast_id,
         response: error || result,
@@ -128,7 +128,7 @@ GCM.prototype.send = function(data, devices) {
  * @returns {Object} A promise which is resolved after we get results from gcm
  */
 function generateGCMPayload(requestData, pushId, timeStamp, expirationTime) {
-  let payload = {
+  const payload = {
     priority: 'high'
   };
   payload.data = {
@@ -144,7 +144,7 @@ function generateGCMPayload(requestData, pushId, timeStamp, expirationTime) {
   });
 
   if (expirationTime) {
-   // The timeStamp and expiration is in milliseconds but gcm requires second
+    // The timeStamp and expiration is in milliseconds but gcm requires second
     let timeToLive = Math.floor((expirationTime - timeStamp) / 1000);
     if (timeToLive < 0) {
       timeToLive = 0;
@@ -164,7 +164,7 @@ function generateGCMPayload(requestData, pushId, timeStamp, expirationTime) {
  * @returns {Array} An array which contaisn several arries of devices with fixed chunk size
  */
 function sliceDevices(devices, chunkSize) {
-  let chunkDevices = [];
+  const chunkDevices = [];
   while (devices.length > 0) {
     chunkDevices.push(devices.splice(0, chunkSize));
   }

package/src/ParsePushAdapter.js

@@ -21,38 +21,38 @@ export default class ParsePushAdapter {
     this.feature = {
       immediatePush: true
     };
-    let pushTypes = Object.keys(pushConfig);
+    const pushTypes = Object.keys(pushConfig);
 
-    for (let pushType of pushTypes) {
+    for (const pushType of pushTypes) {
       // adapter may be passed as part of the parse-server initialization
       if (this.validPushTypes.indexOf(pushType) < 0 && pushType != 'adapter') {
         throw new Parse.Error(Parse.Error.PUSH_MISCONFIGURED,
-                             'Push to ' + pushType + ' is not supported');
+          'Push to ' + pushType + ' is not supported');
       }
       switch (pushType) {
-        case 'ios':
-        case 'tvos':
-        case 'osx':
-          if (pushConfig[pushType].hasOwnProperty('firebaseServiceAccount')) {
-            this.senderMap[pushType] = new FCM(pushConfig[pushType], 'apple');
-          } else {
-            this.senderMap[pushType] = new APNS(pushConfig[pushType]);
-          }
-          break;
-        case 'web':
-          this.senderMap[pushType] = new WEB(pushConfig[pushType]);
-          break;
-        case 'expo':
-          this.senderMap[pushType] = new EXPO(pushConfig[pushType]);
-          break;
-        case 'android':
-        case 'fcm':
-          if (pushConfig[pushType].hasOwnProperty('firebaseServiceAccount')) {
-            this.senderMap[pushType] = new FCM(pushConfig[pushType], 'android');
-          } else {
-            this.senderMap[pushType] = new GCM(pushConfig[pushType]);
-          }
-          break;
+      case 'ios':
+      case 'tvos':
+      case 'osx':
+        if (pushConfig[pushType].hasOwnProperty('firebaseServiceAccount')) {
+          this.senderMap[pushType] = new FCM(pushConfig[pushType], 'apple');
+        } else {
+          this.senderMap[pushType] = new APNS(pushConfig[pushType]);
+        }
+        break;
+      case 'web':
+        this.senderMap[pushType] = new WEB(pushConfig[pushType]);
+        break;
+      case 'expo':
+        this.senderMap[pushType] = new EXPO(pushConfig[pushType]);
+        break;
+      case 'android':
+      case 'fcm':
+        if (pushConfig[pushType].hasOwnProperty('firebaseServiceAccount')) {
+          this.senderMap[pushType] = new FCM(pushConfig[pushType], 'android');
+        } else {
+          this.senderMap[pushType] = new GCM(pushConfig[pushType]);
+        }
+        break;
       }
     }
   }
@@ -66,16 +66,16 @@ export default class ParsePushAdapter {
   }
 
   send(data, installations) {
-    let deviceMap = classifyInstallations(installations, this.validPushTypes);
-    let sendPromises = [];
-    for (let pushType in deviceMap) {
-      let sender = this.senderMap[pushType];
-      let devices = deviceMap[pushType];
+    const deviceMap = classifyInstallations(installations, this.validPushTypes);
+    const sendPromises = [];
+    for (const pushType in deviceMap) {
+      const sender = this.senderMap[pushType];
+      const devices = deviceMap[pushType];
 
       if(Array.isArray(devices) && devices.length > 0) {
         if (!sender) {
           log.verbose(LOG_PREFIX, `Can not find sender for push type ${pushType}, ${data}`)
-          let results = devices.map((device) => {
+          const results = devices.map((device) => {
             return Promise.resolve({
               device,
               transmitted: false,
@@ -88,7 +88,7 @@ export default class ParsePushAdapter {
         }
       }
     }
-    return Promise.all(sendPromises).then((promises) => {
+    return Promise.all(sendPromises).then((promises) => {
       // flatten all
       return [].concat.apply([], promises);
     })

package/src/PushAdapterUtils.js

@@ -8,16 +8,16 @@ import { randomBytes } from 'crypto';
    */
 export function classifyInstallations(installations, validPushTypes) {
   // Init deviceTokenMap, create a empty array for each valid pushType
-  let deviceMap = {};
-  for (let validPushType of validPushTypes) {
+  const deviceMap = {};
+  for (const validPushType of validPushTypes) {
     deviceMap[validPushType] = [];
   }
-  for (let installation of installations) {
+  for (const installation of installations) {
     // No deviceToken, ignore
     if (!installation.deviceToken) {
       continue;
     }
-    let devices = deviceMap[installation.pushType] || deviceMap[installation.deviceType] || null;
+    const devices = deviceMap[installation.pushType] || deviceMap[installation.deviceType] || null;
     if (Array.isArray(devices)) {
       devices.push({
         deviceToken: installation.deviceToken,
@@ -33,11 +33,11 @@ export function randomString(size) {
   if (size === 0) {
     throw new Error('Zero-length randomString is useless.');
   }
-  let chars = ('ABCDEFGHIJKLMNOPQRSTUVWXYZ' +
+  const chars = ('ABCDEFGHIJKLMNOPQRSTUVWXYZ' +
                'abcdefghijklmnopqrstuvwxyz' +
                '0123456789');
   let objectId = '';
-  let bytes = randomBytes(size);
+  const bytes = randomBytes(size);
   for (let i = 0; i < bytes.length; ++i) {
     objectId += chars[bytes.readUInt8(i) % chars.length];
   }

package/src/WEB.js

@@ -9,7 +9,7 @@ const LOG_PREFIX = 'parse-server-push-adapter WEB';
 export class WEB {
   /**
    * Create a new WEB push adapter.
-   * 
+   *
    * @param {Object} args https://github.com/web-push-libs/web-push#api-reference
    */
   constructor(args) {
@@ -39,9 +39,9 @@ export class WEB {
     const deviceTokens = Object.keys(devicesMap);
 
     const resolvers = [];
-    const promises = deviceTokens.map(() => new Promise(resolve => resolvers.push(resolve)));
-    let length = deviceTokens.length;
-    log.verbose(LOG_PREFIX, `sending to ${length} ${length > 1 ? 'devices' : 'device'}`);
+    const promises = deviceTokens.map(() => new Promise(resolve => resolvers.push(resolve)));
+    const length = deviceTokens.length;
+    log.verbose(LOG_PREFIX, `sending to ${length} ${length > 1 ? 'devices' : 'device'}`);
 
     const response = await WEB.sendNotifications(coreData, deviceTokens, this.options);
     const { results, sent, failed } = response;

package/src/index.js

@@ -3,11 +3,13 @@
 // PushAdapter, it uses GCM for android push, APNS for ios push.
 // WEB for web push.
 import log from 'npmlog';
+import { booleanParser } from './utils.js';
 
-/* istanbul ignore if */
-if (process.env.VERBOSE || process.env.VERBOSE_PARSE_SERVER_PUSH_ADAPTER) {
+/* c8 ignore start */
+if (booleanParser(process.env.VERBOSE || process.env.VERBOSE_PARSE_SERVER_PUSH_ADAPTER)) {
   log.level = 'verbose';
 }
+/* c8 ignore stop */
 
 import ParsePushAdapter from './ParsePushAdapter.js';
 import GCM from './GCM.js';

package/src/utils.js

@@ -0,0 +1,10 @@
+function booleanParser(opt) {
+  if (opt == true || opt == 'true' || opt == '1') {
+    return true;
+  }
+  return false;
+}
+
+export {
+  booleanParser,
+}