@parhelia/core 0.4.12818 → 0.4.12871

package/dist/editor/reviews/feedbackThreads.js

@@ -0,0 +1,135 @@
+import { getFeedbackActivityTime, isResolvedFeedbackItem, isSuggestedEdit, } from "./feedbackOrdering";
+import { shouldRemoveNoOpSuggestion } from "./suggestionContentChange";
+function parseCreated(value) {
+    if (!value)
+        return 0;
+    const time = new Date(value).getTime();
+    return Number.isFinite(time) ? time : 0;
+}
+function sortByCreated(a, b) {
+    return parseCreated(a.created) - parseCreated(b.created);
+}
+/** Groups the comments attached to suggestions by suggestion id. */
+export function groupSuggestionComments(comments) {
+    const map = new Map();
+    comments.forEach((comment) => {
+        if (!comment.suggestedEditId)
+            return;
+        const list = map.get(comment.suggestedEditId) || [];
+        list.push(comment);
+        map.set(comment.suggestedEditId, list);
+    });
+    map.forEach((list) => list.sort(sortByCreated));
+    return map;
+}
+/**
+ * Groups plain (non-suggestion) comments into reply lists keyed by their root
+ * comment. A reply whose parent is not loaded keeps the parent id as its root.
+ */
+export function groupCommentReplies(comments) {
+    const idToComment = new Map();
+    comments.forEach((comment) => idToComment.set(comment.id, comment));
+    const getRootId = (comment) => {
+        let current = comment;
+        const seen = new Set();
+        while (current && current.parentCommentId) {
+            if (seen.has(current.id))
+                break;
+            seen.add(current.id);
+            const parent = idToComment.get(current.parentCommentId);
+            if (!parent)
+                return current.parentCommentId;
+            current = parent;
+        }
+        return current?.id;
+    };
+    const repliesByRootId = new Map();
+    comments.forEach((comment) => {
+        if (!comment.parentCommentId)
+            return;
+        const rootId = getRootId(comment);
+        if (!rootId)
+            return;
+        const replies = repliesByRootId.get(rootId) || [];
+        replies.push(comment);
+        repliesByRootId.set(rootId, replies);
+    });
+    repliesByRootId.forEach((replies) => replies.sort(sortByCreated));
+    return repliesByRootId;
+}
+/**
+ * Turns the loaded comments and suggested edits into the threads a feedback
+ * surface shows: filtered (resolved, people, no-op suggestions), grouped
+ * (replies under their root, comments under their suggestion) and ordered.
+ */
+export function buildFeedbackThreads({ comments, suggestedEdits, showResolved, selectedPeople, sort, }) {
+    const suggestionComments = groupSuggestionComments(comments);
+    const plainComments = comments.filter((comment) => !comment.suggestedEditId);
+    let items = [...plainComments, ...suggestedEdits];
+    items = items.filter((item) => {
+        if (!isSuggestedEdit(item))
+            return true;
+        const commentCount = (suggestionComments.get(item.id) || []).length;
+        return !shouldRemoveNoOpSuggestion(item.oldValue, item.newValue, commentCount);
+    });
+    if (!showResolved) {
+        items = items.filter((item) => !isResolvedFeedbackItem(item));
+    }
+    if (selectedPeople.length > 0) {
+        items = items.filter((item) => "author" in item && !!item.author && selectedPeople.includes(item.author));
+    }
+    const direction = sort?.direction ?? "desc";
+    const field = sort?.field ?? "date";
+    const multiplier = direction === "asc" ? 1 : -1;
+    items = items
+        .map((item, index) => ({ item, index }))
+        .sort((a, b) => {
+        switch (field) {
+            case "date": {
+                const timeDifference = getFeedbackActivityTime(a.item, suggestionComments) -
+                    getFeedbackActivityTime(b.item, suggestionComments);
+                return multiplier * timeDifference || a.index - b.index;
+            }
+            case "structure": {
+                const pathA = "itemName" in a.item ? a.item.itemName || "" : "";
+                const pathB = "itemName" in b.item ? b.item.itemName || "" : "";
+                return multiplier * pathA.localeCompare(pathB) || a.index - b.index;
+            }
+            default:
+                return a.index - b.index;
+        }
+    })
+        .map(({ item }) => item);
+    const filteredComments = items.filter((item) => !isSuggestedEdit(item));
+    const repliesByRootId = groupCommentReplies(filteredComments);
+    const threads = [];
+    for (const item of items) {
+        if (isSuggestedEdit(item)) {
+            threads.push({
+                kind: "suggestion",
+                id: item.id,
+                suggestion: item,
+                comments: suggestionComments.get(item.id) || [],
+                created: parseCreated(item.created),
+            });
+            continue;
+        }
+        if (item.parentCommentId)
+            continue;
+        threads.push({
+            kind: "comment",
+            id: item.id,
+            root: item,
+            replies: repliesByRootId.get(item.id) || [],
+            created: parseCreated(item.created),
+        });
+    }
+    return threads;
+}
+/** Every comment that belongs to a thread, root/suggestion comments first. */
+export function getThreadComments(thread) {
+    return thread.kind === "comment"
+        ? [thread.root, ...thread.replies]
+        : thread.comments;
+}
+//# sourceMappingURL=feedbackThreads.js.map

package/dist/editor/reviews/feedbackThreads.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"feedbackThreads.js","sourceRoot":"","sources":["../../../src/editor/reviews/feedbackThreads.ts"],"names":[],"mappings":"AACA,OAAO,EAEL,uBAAuB,EACvB,sBAAsB,EACtB,eAAe,GAChB,MAAM,oBAAoB,CAAC;AAC5B,OAAO,EAAE,0BAA0B,EAAE,MAAM,2BAA2B,CAAC;AA0CvE,SAAS,YAAY,CAAC,KAAc;IAClC,IAAI,CAAC,KAAK;QAAE,OAAO,CAAC,CAAC;IACrB,MAAM,IAAI,GAAG,IAAI,IAAI,CAAC,KAAK,CAAC,CAAC,OAAO,EAAE,CAAC;IACvC,OAAO,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC;AAC1C,CAAC;AAED,SAAS,aAAa,CAAC,CAAU,EAAE,CAAU;IAC3C,OAAO,YAAY,CAAC,CAAC,CAAC,OAAO,CAAC,GAAG,YAAY,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC;AAC3D,CAAC;AAED,oEAAoE;AACpE,MAAM,UAAU,uBAAuB,CAAC,QAAmB;IACzD,MAAM,GAAG,GAAG,IAAI,GAAG,EAAqB,CAAC;IACzC,QAAQ,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE;QAC3B,IAAI,CAAC,OAAO,CAAC,eAAe;YAAE,OAAO;QACrC,MAAM,IAAI,GAAG,GAAG,CAAC,GAAG,CAAC,OAAO,CAAC,eAAe,CAAC,IAAI,EAAE,CAAC;QACpD,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACnB,GAAG,CAAC,GAAG,CAAC,OAAO,CAAC,eAAe,EAAE,IAAI,CAAC,CAAC;IACzC,CAAC,CAAC,CAAC;IACH,GAAG,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,CAAC;IAChD,OAAO,GAAG,CAAC;AACb,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,mBAAmB,CAAC,QAAmB;IACrD,MAAM,WAAW,GAAG,IAAI,GAAG,EAAmB,CAAC;IAC/C,QAAQ,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,WAAW,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAEpE,MAAM,SAAS,GAAG,CAAC,OAAgB,EAAsB,EAAE;QACzD,IAAI,OAAO,GAAwB,OAAO,CAAC;QAC3C,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;QAC/B,OAAO,OAAO,IAAI,OAAO,CAAC,eAAe,EAAE,CAAC;YAC1C,IAAI,IAAI,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;gBAAE,MAAM;YAChC,IAAI,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;YACrB,MAAM,MAAM,GAAG,WAAW,CAAC,GAAG,CAAC,OAAO,CAAC,eAAe,CAAC,CAAC;YACxD,IAAI,CAAC,MAAM;gBAAE,OAAO,OAAO,CAAC,eAAe,CAAC;YAC5C,OAAO,GAAG,MAAM,CAAC;QACnB,CAAC;QACD,OAAO,OAAO,EAAE,EAAE,CAAC;IACrB,CAAC,CAAC;IAEF,MAAM,eAAe,GAAG,IAAI,GAAG,EAAqB,CAAC;IACrD,QAAQ,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE;QAC3B,IAAI,CAAC,OAAO,CAAC,eAAe;YAAE,OAAO;QACrC,MAAM,MAAM,GAAG,SAAS,CAAC,OAAO,CAAC,CAAC;QAClC,IAAI,CAAC,MAAM;YAAE,OAAO;QACpB,MAAM,OAAO,GAAG,eAAe,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC;QAClD,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACtB,eAAe,CAAC,GAAG,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IACvC,CAAC,CAAC,CAAC;IACH,eAAe,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,CAAC;IAClE,OAAO,eAAe,CAAC;AACzB,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,oBAAoB,CAAC,EACnC,QAAQ,EACR,cAAc,EACd,YAAY,EACZ,cAAc,EACd,IAAI,GACwB;IAC5B,MAAM,kBAAkB,GAAG,uBAAuB,CAAC,QAAQ,CAAC,CAAC;IAC7D,MAAM,aAAa,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,eAAe,CAAC,CAAC;IAE7E,IAAI,KAAK,GAAmB,CAAC,GAAG,aAAa,EAAE,GAAG,cAAc,CAAC,CAAC;IAElE,KAAK,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE;QAC5B,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAC;QACxC,MAAM,YAAY,GAAG,CAAC,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC;QACpE,OAAO,CAAC,0BAA0B,CAChC,IAAI,CAAC,QAAQ,EACb,IAAI,CAAC,QAAQ,EACb,YAAY,CACb,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,YAAY,EAAE,CAAC;QAClB,KAAK,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAC,CAAC;IAChE,CAAC;IAED,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC9B,KAAK,GAAG,KAAK,CAAC,MAAM,CAClB,CAAC,IAAI,EAAE,EAAE,CACP,QAAQ,IAAI,IAAI,IAAI,CAAC,CAAC,IAAI,CAAC,MAAM,IAAI,cAAc,CAAC,QAAQ,CAAC,IAAI,CAAC,MAAM,CAAC,CAC5E,CAAC;IACJ,CAAC;IAED,MAAM,SAAS,GAAG,IAAI,EAAE,SAAS,IAAI,MAAM,CAAC;IAC5C,MAAM,KAAK,GAAG,IAAI,EAAE,KAAK,IAAI,MAAM,CAAC;IACpC,MAAM,UAAU,GAAG,SAAS,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;IAChD,KAAK,GAAG,KAAK;SACV,GAAG,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC;SACvC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE;QACb,QAAQ,KAAK,EAAE,CAAC;YACd,KAAK,MAAM,EAAE,CAAC;gBACZ,MAAM,cAAc,GAClB,uBAAuB,CAAC,CAAC,CAAC,IAAI,EAAE,kBAAkB,CAAC;oBACnD,uBAAuB,CAAC,CAAC,CAAC,IAAI,EAAE,kBAAkB,CAAC,CAAC;gBACtD,OAAO,UAAU,GAAG,cAAc,IAAI,CAAC,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC;YAC1D,CAAC;YACD,KAAK,WAAW,EAAE,CAAC;gBACjB,MAAM,KAAK,GAAG,UAAU,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,QAAQ,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;gBAChE,MAAM,KAAK,GAAG,UAAU,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,QAAQ,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;gBAChE,OAAO,UAAU,GAAG,KAAK,CAAC,aAAa,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC;YACtE,CAAC;YACD;gBACE,OAAO,CAAC,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC;QAC7B,CAAC;IACH,CAAC,CAAC;SACD,GAAG,CAAC,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,IAAI,CAAC,CAAC;IAE3B,MAAM,gBAAgB,GAAG,KAAK,CAAC,MAAM,CACnC,CAAC,IAAI,EAAmB,EAAE,CAAC,CAAC,eAAe,CAAC,IAAI,CAAC,CAClD,CAAC;IACF,MAAM,eAAe,GAAG,mBAAmB,CAAC,gBAAgB,CAAC,CAAC;IAE9D,MAAM,OAAO,GAAqB,EAAE,CAAC;IACrC,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,IAAI,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;YAC1B,OAAO,CAAC,IAAI,CAAC;gBACX,IAAI,EAAE,YAAY;gBAClB,EAAE,EAAE,IAAI,CAAC,EAAE;gBACX,UAAU,EAAE,IAAI;gBAChB,QAAQ,EAAE,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE;gBAC/C,OAAO,EAAE,YAAY,CAAC,IAAI,CAAC,OAAO,CAAC;aACpC,CAAC,CAAC;YACH,SAAS;QACX,CAAC;QACD,IAAI,IAAI,CAAC,eAAe;YAAE,SAAS;QACnC,OAAO,CAAC,IAAI,CAAC;YACX,IAAI,EAAE,SAAS;YACf,EAAE,EAAE,IAAI,CAAC,EAAE;YACX,IAAI,EAAE,IAAI;YACV,OAAO,EAAE,eAAe,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE;YAC3C,OAAO,EAAE,YAAY,CAAC,IAAI,CAAC,OAAO,CAAC;SACpC,CAAC,CAAC;IACL,CAAC;IAED,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,8EAA8E;AAC9E,MAAM,UAAU,iBAAiB,CAAC,MAAsB;IACtD,OAAO,MAAM,CAAC,IAAI,KAAK,SAAS;QAC9B,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,EAAE,GAAG,MAAM,CAAC,OAAO,CAAC;QAClC,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC;AACtB,CAAC"}

package/dist/editor/reviews/feedbackWheelForwarding.d.ts

@@ -0,0 +1,34 @@
+/**
+ * Finds the nearest feedback scroll container between `target` and `root`
+ * that can still scroll in the wheel direction. When there is none, the wheel
+ * gesture belongs to the canvas (the margin forwards it), otherwise the
+ * container scrolls natively.
+ */
+export declare function findScrollableAncestor(target: Element | null, root: Element, deltaY: number): HTMLElement | null;
+/** Wheel delta in pixels; line-mode deltas (Firefox) are approximated. */
+export declare function wheelDeltaToPixels(deltaY: number, deltaMode: number): number;
+/** Below this (pixels), a wheel delta is a trackpad step and is not eased. */
+export declare const SMOOTH_WHEEL_MIN_DELTA = 40;
+/** Time constant of the ease: about 95% of a notch lands within 3×. */
+export declare const SMOOTH_WHEEL_TIME_CONSTANT_MS = 45;
+type FrameScheduler = {
+    request: (callback: (time: number) => void) => number;
+    cancel: (handle: number) => void;
+    /** Same clock as the request callback's time. */
+    now: () => number;
+};
+/**
+ * Forwards wheel gestures to a scroller that only moves instantly (the canvas
+ * bridge), so that they look like the browser's own wheel scrolling: a mouse
+ * wheel notch glides over a few frames instead of jumping, and quick notches
+ * add up to one glide. Small trackpad deltas pass straight through, as the
+ * browser does not ease those either.
+ *
+ * `forward` returns whether the gesture is handled (`canScroll`), so callers
+ * can let an unhandled wheel propagate.
+ */
+export declare function createSmoothWheelForwarder(scrollBy: (y: number) => boolean, canScroll: () => boolean, frames?: FrameScheduler): {
+    forward(deltaY: number, deltaMode: number): boolean;
+    cancel: () => void;
+};
+export {};

package/dist/editor/reviews/feedbackWheelForwarding.js

@@ -0,0 +1,108 @@
+import { FEEDBACK_SCROLLABLE_ATTRIBUTE } from "./scrollWithin";
+/**
+ * Finds the nearest feedback scroll container between `target` and `root`
+ * that can still scroll in the wheel direction. When there is none, the wheel
+ * gesture belongs to the canvas (the margin forwards it), otherwise the
+ * container scrolls natively.
+ */
+export function findScrollableAncestor(target, root, deltaY) {
+    let current = target;
+    while (current && current !== root) {
+        if (current instanceof HTMLElement &&
+            current.hasAttribute(FEEDBACK_SCROLLABLE_ATTRIBUTE) &&
+            canScrollVertically(current, deltaY)) {
+            return current;
+        }
+        current = current.parentElement;
+    }
+    return null;
+}
+function canScrollVertically(element, deltaY) {
+    const range = element.scrollHeight - element.clientHeight;
+    if (range <= 1)
+        return false;
+    if (deltaY > 0)
+        return element.scrollTop < range - 0.5;
+    if (deltaY < 0)
+        return element.scrollTop > 0.5;
+    return true;
+}
+/** Wheel delta in pixels; line-mode deltas (Firefox) are approximated. */
+export function wheelDeltaToPixels(deltaY, deltaMode) {
+    if (deltaMode === 1)
+        return deltaY * 16;
+    if (deltaMode === 2)
+        return deltaY * 800;
+    return deltaY;
+}
+/** Below this (pixels), a wheel delta is a trackpad step and is not eased. */
+export const SMOOTH_WHEEL_MIN_DELTA = 40;
+/** Time constant of the ease: about 95% of a notch lands within 3×. */
+export const SMOOTH_WHEEL_TIME_CONSTANT_MS = 45;
+const animationFrames = {
+    request: (callback) => window.requestAnimationFrame(callback),
+    cancel: (handle) => window.cancelAnimationFrame(handle),
+    now: () => performance.now(),
+};
+/**
+ * Forwards wheel gestures to a scroller that only moves instantly (the canvas
+ * bridge), so that they look like the browser's own wheel scrolling: a mouse
+ * wheel notch glides over a few frames instead of jumping, and quick notches
+ * add up to one glide. Small trackpad deltas pass straight through, as the
+ * browser does not ease those either.
+ *
+ * `forward` returns whether the gesture is handled (`canScroll`), so callers
+ * can let an unhandled wheel propagate.
+ */
+export function createSmoothWheelForwarder(scrollBy, canScroll, frames = animationFrames) {
+    let remaining = 0;
+    let handle = null;
+    let lastTime = 0;
+    const stop = () => {
+        if (handle !== null)
+            frames.cancel(handle);
+        handle = null;
+        remaining = 0;
+    };
+    const tick = (time) => {
+        handle = null;
+        const elapsed = Math.max(time - lastTime, 1);
+        lastTime = time;
+        const share = 1 - Math.exp(-elapsed / SMOOTH_WHEEL_TIME_CONSTANT_MS);
+        // Whole pixels, at least one, so the glide ends exactly on target.
+        const step = Math.abs(remaining) <= 1
+            ? Math.round(remaining)
+            : Math.round(remaining * share) || Math.sign(remaining);
+        if (step !== 0 && !scrollBy(step)) {
+            stop();
+            return;
+        }
+        remaining -= step;
+        if (Math.abs(remaining) >= 0.5)
+            handle = frames.request(tick);
+        else
+            stop();
+    };
+    return {
+        forward(deltaY, deltaMode) {
+            const pixels = wheelDeltaToPixels(deltaY, deltaMode);
+            if (Math.abs(pixels) < SMOOTH_WHEEL_MIN_DELTA && handle === null) {
+                return scrollBy(pixels);
+            }
+            if (!canScroll())
+                return false;
+            // Reversing direction drops what is left of the previous glide.
+            if (Math.sign(pixels) !== Math.sign(remaining))
+                remaining = 0;
+            remaining += pixels;
+            if (handle === null) {
+                // The glide starts when the notch did, not a frame later.
+                lastTime = frames.now();
+                handle = frames.request(tick);
+            }
+            return true;
+        },
+        cancel: stop,
+    };
+}
+//# sourceMappingURL=feedbackWheelForwarding.js.map

package/dist/editor/reviews/feedbackWheelForwarding.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"feedbackWheelForwarding.js","sourceRoot":"","sources":["../../../src/editor/reviews/feedbackWheelForwarding.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,6BAA6B,EAAE,MAAM,gBAAgB,CAAC;AAE/D;;;;;GAKG;AACH,MAAM,UAAU,sBAAsB,CACpC,MAAsB,EACtB,IAAa,EACb,MAAc;IAEd,IAAI,OAAO,GAAmB,MAAM,CAAC;IACrC,OAAO,OAAO,IAAI,OAAO,KAAK,IAAI,EAAE,CAAC;QACnC,IACE,OAAO,YAAY,WAAW;YAC9B,OAAO,CAAC,YAAY,CAAC,6BAA6B,CAAC;YACnD,mBAAmB,CAAC,OAAO,EAAE,MAAM,CAAC,EACpC,CAAC;YACD,OAAO,OAAO,CAAC;QACjB,CAAC;QACD,OAAO,GAAG,OAAO,CAAC,aAAa,CAAC;IAClC,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,SAAS,mBAAmB,CAAC,OAAoB,EAAE,MAAc;IAC/D,MAAM,KAAK,GAAG,OAAO,CAAC,YAAY,GAAG,OAAO,CAAC,YAAY,CAAC;IAC1D,IAAI,KAAK,IAAI,CAAC;QAAE,OAAO,KAAK,CAAC;IAC7B,IAAI,MAAM,GAAG,CAAC;QAAE,OAAO,OAAO,CAAC,SAAS,GAAG,KAAK,GAAG,GAAG,CAAC;IACvD,IAAI,MAAM,GAAG,CAAC;QAAE,OAAO,OAAO,CAAC,SAAS,GAAG,GAAG,CAAC;IAC/C,OAAO,IAAI,CAAC;AACd,CAAC;AAED,0EAA0E;AAC1E,MAAM,UAAU,kBAAkB,CAAC,MAAc,EAAE,SAAiB;IAClE,IAAI,SAAS,KAAK,CAAC;QAAE,OAAO,MAAM,GAAG,EAAE,CAAC;IACxC,IAAI,SAAS,KAAK,CAAC;QAAE,OAAO,MAAM,GAAG,GAAG,CAAC;IACzC,OAAO,MAAM,CAAC;AAChB,CAAC;AAED,8EAA8E;AAC9E,MAAM,CAAC,MAAM,sBAAsB,GAAG,EAAE,CAAC;AACzC,uEAAuE;AACvE,MAAM,CAAC,MAAM,6BAA6B,GAAG,EAAE,CAAC;AAShD,MAAM,eAAe,GAAmB;IACtC,OAAO,EAAE,CAAC,QAAQ,EAAE,EAAE,CAAC,MAAM,CAAC,qBAAqB,CAAC,QAAQ,CAAC;IAC7D,MAAM,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,oBAAoB,CAAC,MAAM,CAAC;IACvD,GAAG,EAAE,GAAG,EAAE,CAAC,WAAW,CAAC,GAAG,EAAE;CAC7B,CAAC;AAEF;;;;;;;;;GASG;AACH,MAAM,UAAU,0BAA0B,CACxC,QAAgC,EAChC,SAAwB,EACxB,MAAM,GAAmB,eAAe;IAExC,IAAI,SAAS,GAAG,CAAC,CAAC;IAClB,IAAI,MAAM,GAAkB,IAAI,CAAC;IACjC,IAAI,QAAQ,GAAG,CAAC,CAAC;IAEjB,MAAM,IAAI,GAAG,GAAG,EAAE;QAChB,IAAI,MAAM,KAAK,IAAI;YAAE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;QAC3C,MAAM,GAAG,IAAI,CAAC;QACd,SAAS,GAAG,CAAC,CAAC;IAChB,CAAC,CAAC;IAEF,MAAM,IAAI,GAAG,CAAC,IAAY,EAAE,EAAE;QAC5B,MAAM,GAAG,IAAI,CAAC;QACd,MAAM,OAAO,GAAG,IAAI,CAAC,GAAG,CAAC,IAAI,GAAG,QAAQ,EAAE,CAAC,CAAC,CAAC;QAC7C,QAAQ,GAAG,IAAI,CAAC;QAChB,MAAM,KAAK,GAAG,CAAC,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,OAAO,GAAG,6BAA6B,CAAC,CAAC;QACrE,mEAAmE;QACnE,MAAM,IAAI,GACR,IAAI,CAAC,GAAG,CAAC,SAAS,CAAC,IAAI,CAAC;YACtB,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC;YACvB,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,SAAS,GAAG,KAAK,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC5D,IAAI,IAAI,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC;YAClC,IAAI,EAAE,CAAC;YACP,OAAO;QACT,CAAC;QACD,SAAS,IAAI,IAAI,CAAC;QAClB,IAAI,IAAI,CAAC,GAAG,CAAC,SAAS,CAAC,IAAI,GAAG;YAAE,MAAM,GAAG,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;;YACzD,IAAI,EAAE,CAAC;IACd,CAAC,CAAC;IAEF,OAAO;QACL,OAAO,CAAC,MAAc,EAAE,SAAiB;YACvC,MAAM,MAAM,GAAG,kBAAkB,CAAC,MAAM,EAAE,SAAS,CAAC,CAAC;YACrD,IAAI,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,GAAG,sBAAsB,IAAI,MAAM,KAAK,IAAI,EAAE,CAAC;gBACjE,OAAO,QAAQ,CAAC,MAAM,CAAC,CAAC;YAC1B,CAAC;YACD,IAAI,CAAC,SAAS,EAAE;gBAAE,OAAO,KAAK,CAAC;YAC/B,gEAAgE;YAChE,IAAI,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,IAAI,CAAC,IAAI,CAAC,SAAS,CAAC;gBAAE,SAAS,GAAG,CAAC,CAAC;YAC9D,SAAS,IAAI,MAAM,CAAC;YACpB,IAAI,MAAM,KAAK,IAAI,EAAE,CAAC;gBACpB,0DAA0D;gBAC1D,QAAQ,GAAG,MAAM,CAAC,GAAG,EAAE,CAAC;gBACxB,MAAM,GAAG,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;YAChC,CAAC;YACD,OAAO,IAAI,CAAC;QACd,CAAC;QACD,MAAM,EAAE,IAAI;KACb,CAAC;AACJ,CAAC"}

package/dist/editor/reviews/openCommentsFeedback.d.ts

@@ -21,7 +21,7 @@ export declare function exitSuggestionsMode(editContext: CommentsFeedbackContext
 export declare function openCommentsFeedback(editContext: CommentsFeedbackContext | undefined): void;
 export declare function toggleCommentsFeedback(editContext: CommentsFeedbackContext | undefined): void;
 export declare function closeCommentsFeedback(editContext: CommentsFeedbackContext | undefined): void;
-type SuggestionsAvailabilityContext = Pick<EditContextType, "getActiveSlotContext" | "item">;
+type SuggestionsAvailabilityContext = Pick<EditContextType, "getActiveSlotContext" | "item" | "page">;
 /**
  * Suggestions mode only works for items edited on the WYSIWYG canvas (items
  * with a layout). Mirrors the `hasLayout` check used by the viewport toolbar so

package/dist/editor/reviews/openCommentsFeedback.js

@@ -71,7 +71,8 @@ export function isSuggestionsModeAvailable(editContext) {
     if (!editContext)
         return false;
     const slot = editContext.getActiveSlotContext();
-    const pageItem = slot?.primaryPageViewContext?.page?.item;
+    // The edit context's page is the active slot's canvas page.
+    const pageItem = editContext.page?.item;
     return Boolean(slot?.item?.hasLayout ??
         editContext.item?.hasLayout ??
         pageItem?.hasLayout ??

package/dist/editor/reviews/openCommentsFeedback.js.map

@@ -1 +1 @@
-{"version":3,"file":"openCommentsFeedback.js","sourceRoot":"","sources":["../../../src/editor/reviews/openCommentsFeedback.ts"],"names":[],"mappings":"AAgBA,MAAM,UAAU,oBAAoB,CAClC,WAAgD,EAChD,OAA6B;IAE7B,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,WAAW,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC;IAClC,WAAW,CAAC,qBAAqB,EAAE,CAAC,KAAK,CAAC,CAAC;IAC3C,WAAW,CAAC,yBAAyB,EAAE,CAAC,KAAK,CAAC,CAAC;IAE/C,IAAI,WAAW,CAAC,IAAI,KAAK,aAAa,EAAE,CAAC;QACvC,KAAK,WAAW,CAAC,UAAU,EAAE,CAAC,MAAM,EAAE;YACpC,MAAM,EAAE,OAAO,EAAE,MAAM,IAAI,eAAe;SAC3C,CAAC,CAAC;IACL,CAAC;AACH,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,oBAAoB,CAClC,WAAgD,EAChD,OAA6B;IAE7B,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,WAAW,CAAC,qBAAqB,EAAE,CAAC,IAAI,CAAC,CAAC;IAC1C,KAAK,WAAW,CAAC,UAAU,EAAE,CAAC,aAAa,EAAE;QAC3C,MAAM,EAAE,OAAO,EAAE,MAAM,IAAI,SAAS;KACrC,CAAC,CAAC;IACH,oBAAoB,CAAC,WAAW,CAAC,CAAC;AACpC,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,mBAAmB,CACjC,WAAgD,EAChD,OAA6B;IAE7B,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,WAAW,CAAC,qBAAqB,EAAE,CAAC,KAAK,CAAC,CAAC;IAC3C,WAAW,CAAC,yBAAyB,EAAE,CAAC,KAAK,CAAC,CAAC;IAE/C,IAAI,WAAW,CAAC,IAAI,KAAK,aAAa,EAAE,CAAC;QACvC,KAAK,WAAW,CAAC,UAAU,EAAE,CAAC,MAAM,EAAE;YACpC,MAAM,EAAE,OAAO,EAAE,MAAM,IAAI,SAAS;SACrC,CAAC,CAAC;IACL,CAAC;AACH,CAAC;AAED,SAAS,sBAAsB,CAC7B,WAAgD;IAEhD,mBAAmB,CAAC,WAAW,EAAE,EAAE,MAAM,EAAE,yBAAyB,EAAE,CAAC,CAAC;AAC1E,CAAC;AAED,MAAM,UAAU,oBAAoB,CAClC,WAAgD;IAEhD,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,WAAW,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC;AACpC,CAAC;AAED,MAAM,UAAU,sBAAsB,CACpC,WAAgD;IAEhD,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,MAAM,gBAAgB,GAAG,CAAC,WAAW,CAAC,YAAY,CAAC;IACnD,WAAW,CAAC,eAAe,CAAC,gBAAgB,CAAC,CAAC;IAE9C,IAAI,CAAC,gBAAgB,EAAE,CAAC;QACtB,sBAAsB,CAAC,WAAW,CAAC,CAAC;IACtC,CAAC;AACH,CAAC;AAED,MAAM,UAAU,qBAAqB,CACnC,WAAgD;IAEhD,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,WAAW,CAAC,eAAe,CAAC,KAAK,CAAC,CAAC;IACnC,sBAAsB,CAAC,WAAW,CAAC,CAAC;AACtC,CAAC;AAOD;;;;GAIG;AACH,MAAM,UAAU,0BAA0B,CACxC,WAAuD;IAEvD,IAAI,CAAC,WAAW;QAAE,OAAO,KAAK,CAAC;IAE/B,MAAM,IAAI,GAAG,WAAW,CAAC,oBAAoB,EAAE,CAAC;IAChD,MAAM,QAAQ,GAAG,IAAI,EAAE,sBAAsB,EAAE,IAAI,EAAE,IAAI,CAAC;IAE1D,OAAO,OAAO,CACZ,IAAI,EAAE,IAAI,EAAE,SAAS;QACrB,WAAW,CAAC,IAAI,EAAE,SAAS;QAC3B,QAAQ,EAAE,SAAS;QACnB,KAAK,CACN,CAAC;AACJ,CAAC"}
+{"version":3,"file":"openCommentsFeedback.js","sourceRoot":"","sources":["../../../src/editor/reviews/openCommentsFeedback.ts"],"names":[],"mappings":"AAgBA,MAAM,UAAU,oBAAoB,CAClC,WAAgD,EAChD,OAA6B;IAE7B,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,WAAW,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC;IAClC,WAAW,CAAC,qBAAqB,EAAE,CAAC,KAAK,CAAC,CAAC;IAC3C,WAAW,CAAC,yBAAyB,EAAE,CAAC,KAAK,CAAC,CAAC;IAE/C,IAAI,WAAW,CAAC,IAAI,KAAK,aAAa,EAAE,CAAC;QACvC,KAAK,WAAW,CAAC,UAAU,EAAE,CAAC,MAAM,EAAE;YACpC,MAAM,EAAE,OAAO,EAAE,MAAM,IAAI,eAAe;SAC3C,CAAC,CAAC;IACL,CAAC;AACH,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,oBAAoB,CAClC,WAAgD,EAChD,OAA6B;IAE7B,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,WAAW,CAAC,qBAAqB,EAAE,CAAC,IAAI,CAAC,CAAC;IAC1C,KAAK,WAAW,CAAC,UAAU,EAAE,CAAC,aAAa,EAAE;QAC3C,MAAM,EAAE,OAAO,EAAE,MAAM,IAAI,SAAS;KACrC,CAAC,CAAC;IACH,oBAAoB,CAAC,WAAW,CAAC,CAAC;AACpC,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,mBAAmB,CACjC,WAAgD,EAChD,OAA6B;IAE7B,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,WAAW,CAAC,qBAAqB,EAAE,CAAC,KAAK,CAAC,CAAC;IAC3C,WAAW,CAAC,yBAAyB,EAAE,CAAC,KAAK,CAAC,CAAC;IAE/C,IAAI,WAAW,CAAC,IAAI,KAAK,aAAa,EAAE,CAAC;QACvC,KAAK,WAAW,CAAC,UAAU,EAAE,CAAC,MAAM,EAAE;YACpC,MAAM,EAAE,OAAO,EAAE,MAAM,IAAI,SAAS;SACrC,CAAC,CAAC;IACL,CAAC;AACH,CAAC;AAED,SAAS,sBAAsB,CAC7B,WAAgD;IAEhD,mBAAmB,CAAC,WAAW,EAAE,EAAE,MAAM,EAAE,yBAAyB,EAAE,CAAC,CAAC;AAC1E,CAAC;AAED,MAAM,UAAU,oBAAoB,CAClC,WAAgD;IAEhD,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,WAAW,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC;AACpC,CAAC;AAED,MAAM,UAAU,sBAAsB,CACpC,WAAgD;IAEhD,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,MAAM,gBAAgB,GAAG,CAAC,WAAW,CAAC,YAAY,CAAC;IACnD,WAAW,CAAC,eAAe,CAAC,gBAAgB,CAAC,CAAC;IAE9C,IAAI,CAAC,gBAAgB,EAAE,CAAC;QACtB,sBAAsB,CAAC,WAAW,CAAC,CAAC;IACtC,CAAC;AACH,CAAC;AAED,MAAM,UAAU,qBAAqB,CACnC,WAAgD;IAEhD,IAAI,CAAC,WAAW;QAAE,OAAO;IAEzB,WAAW,CAAC,eAAe,CAAC,KAAK,CAAC,CAAC;IACnC,sBAAsB,CAAC,WAAW,CAAC,CAAC;AACtC,CAAC;AAOD;;;;GAIG;AACH,MAAM,UAAU,0BAA0B,CACxC,WAAuD;IAEvD,IAAI,CAAC,WAAW;QAAE,OAAO,KAAK,CAAC;IAE/B,MAAM,IAAI,GAAG,WAAW,CAAC,oBAAoB,EAAE,CAAC;IAChD,4DAA4D;IAC5D,MAAM,QAAQ,GAAG,WAAW,CAAC,IAAI,EAAE,IAAI,CAAC;IAExC,OAAO,OAAO,CACZ,IAAI,EAAE,IAAI,EAAE,SAAS;QACrB,WAAW,CAAC,IAAI,EAAE,SAAS;QAC3B,QAAQ,EAAE,SAAS;QACnB,KAAK,CACN,CAAC;AACJ,CAAC"}

package/dist/editor/reviews/pendingReviewSelection.d.ts

@@ -0,0 +1,13 @@
+/**
+ * A review to show in the Reviews sidebar. A review created outside the
+ * sidebar (from the comments toolbar) has to be selected in a sidebar that may
+ * not be mounted yet, or is mounted on another review, so the id is parked
+ * here and consumed by the sidebar's review manager.
+ */
+type Listener = () => void;
+export declare function setPendingReviewSelection(reviewId: string): void;
+/** Clears the pending selection, or only `reviewId` if a newer one replaced it. */
+export declare function clearPendingReviewSelection(reviewId?: string): void;
+export declare function getPendingReviewSelection(): string | null;
+export declare function subscribePendingReviewSelection(listener: Listener): () => void;
+export {};

package/dist/editor/reviews/pendingReviewSelection.js

@@ -0,0 +1,29 @@
+let pending = null;
+const listeners = new Set();
+function notify() {
+    for (const listener of listeners)
+        listener();
+}
+export function setPendingReviewSelection(reviewId) {
+    pending = reviewId;
+    notify();
+}
+/** Clears the pending selection, or only `reviewId` if a newer one replaced it. */
+export function clearPendingReviewSelection(reviewId) {
+    if (reviewId && pending !== reviewId)
+        return;
+    if (!pending)
+        return;
+    pending = null;
+    notify();
+}
+export function getPendingReviewSelection() {
+    return pending;
+}
+export function subscribePendingReviewSelection(listener) {
+    listeners.add(listener);
+    return () => {
+        listeners.delete(listener);
+    };
+}
+//# sourceMappingURL=pendingReviewSelection.js.map

package/dist/editor/reviews/pendingReviewSelection.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"pendingReviewSelection.js","sourceRoot":"","sources":["../../../src/editor/reviews/pendingReviewSelection.ts"],"names":[],"mappings":"AAQA,IAAI,OAAO,GAAkB,IAAI,CAAC;AAClC,MAAM,SAAS,GAAG,IAAI,GAAG,EAAY,CAAC;AAEtC,SAAS,MAAM;IACb,KAAK,MAAM,QAAQ,IAAI,SAAS;QAAE,QAAQ,EAAE,CAAC;AAC/C,CAAC;AAED,MAAM,UAAU,yBAAyB,CAAC,QAAgB;IACxD,OAAO,GAAG,QAAQ,CAAC;IACnB,MAAM,EAAE,CAAC;AACX,CAAC;AAED,mFAAmF;AACnF,MAAM,UAAU,2BAA2B,CAAC,QAAiB;IAC3D,IAAI,QAAQ,IAAI,OAAO,KAAK,QAAQ;QAAE,OAAO;IAC7C,IAAI,CAAC,OAAO;QAAE,OAAO;IACrB,OAAO,GAAG,IAAI,CAAC;IACf,MAAM,EAAE,CAAC;AACX,CAAC;AAED,MAAM,UAAU,yBAAyB;IACvC,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,MAAM,UAAU,+BAA+B,CAAC,QAAkB;IAChE,SAAS,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;IACxB,OAAO,GAAG,EAAE;QACV,SAAS,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;IAC7B,CAAC,CAAC;AACJ,CAAC"}

package/dist/editor/reviews/requestReview.d.ts

@@ -0,0 +1,27 @@
+import type { DialogProps, EditContextType } from "../client/editContext";
+import type { ItemDescriptor } from "../pageModel";
+/** What the create-review dialog resolves to once a review was created. */
+export type CreatedReview = {
+    reviewId: string | null;
+};
+type CreateReviewDialogHostProps = DialogProps<CreatedReview> & {
+    initialItems?: ItemDescriptor[];
+};
+/**
+ * The create-review wizard as an `openDialog` dialog: resolves to the created
+ * review, or to null when it is cancelled.
+ */
+export declare function CreateReviewDialogHost({ onClose, initialItems, }: CreateReviewDialogHostProps): import("react").JSX.Element;
+type RequestReviewAvailabilityContext = Pick<EditContextType, "user" | "availableSidebars">;
+/**
+ * Reviews can be requested outside the Reviews sidebar only where the sidebar
+ * can show the result, and never by reviewers (limited preview users).
+ */
+export declare function canRequestReview(editContext: RequestReviewAvailabilityContext | undefined): boolean;
+type RequestReviewContext = Pick<EditContextType, "openDialog" | "openSidebar">;
+/**
+ * Opens the create-review wizard for the current page and, once the review is
+ * created, the Reviews sidebar on it. Cancelling leaves the editor as it was.
+ */
+export declare function requestReview(editContext: RequestReviewContext): Promise<void>;
+export {};

package/dist/editor/reviews/requestReview.js

@@ -0,0 +1,36 @@
+import { jsx as _jsx } from "react/jsx-runtime";
+import { CreateReviewDialog } from "./CreateReviewDialog";
+import { setPendingReviewSelection } from "./pendingReviewSelection";
+const REVIEWS_SIDEBAR_ID = "reviews";
+/**
+ * The create-review wizard as an `openDialog` dialog: resolves to the created
+ * review, or to null when it is cancelled.
+ */
+export function CreateReviewDialogHost({ onClose, initialItems, }) {
+    return (_jsx(CreateReviewDialog, { open: true, onOpenChange: (open) => {
+            if (!open)
+                onClose(null);
+        }, onCreated: (reviewId) => onClose({ reviewId }), initialItems: initialItems }));
+}
+/**
+ * Reviews can be requested outside the Reviews sidebar only where the sidebar
+ * can show the result, and never by reviewers (limited preview users).
+ */
+export function canRequestReview(editContext) {
+    if (!editContext || editContext.user?.isLimitedPreviewUser)
+        return false;
+    return (editContext.availableSidebars ?? []).some((sidebar) => sidebar.id === REVIEWS_SIDEBAR_ID);
+}
+/**
+ * Opens the create-review wizard for the current page and, once the review is
+ * created, the Reviews sidebar on it. Cancelling leaves the editor as it was.
+ */
+export async function requestReview(editContext) {
+    const created = await editContext.openDialog(CreateReviewDialogHost, {});
+    if (!created)
+        return;
+    if (created.reviewId)
+        setPendingReviewSelection(created.reviewId);
+    editContext.openSidebar(REVIEWS_SIDEBAR_ID);
+}
+//# sourceMappingURL=requestReview.js.map

package/dist/editor/reviews/requestReview.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"requestReview.js","sourceRoot":"","sources":["../../../src/editor/reviews/requestReview.tsx"],"names":[],"mappings":";AAEA,OAAO,EAAE,kBAAkB,EAAE,MAAM,sBAAsB,CAAC;AAC1D,OAAO,EAAE,yBAAyB,EAAE,MAAM,0BAA0B,CAAC;AAErE,MAAM,kBAAkB,GAAG,SAAS,CAAC;AASrC;;;GAGG;AACH,MAAM,UAAU,sBAAsB,CAAC,EACrC,OAAO,EACP,YAAY,GACgB;IAC5B,OAAO,CACL,KAAC,kBAAkB,IACjB,IAAI,EAAE,IAAI,EACV,YAAY,EAAE,CAAC,IAAI,EAAE,EAAE;YACrB,IAAI,CAAC,IAAI;gBAAE,OAAO,CAAC,IAAI,CAAC,CAAC;QAC3B,CAAC,EACD,SAAS,EAAE,CAAC,QAAQ,EAAE,EAAE,CAAC,OAAO,CAAC,EAAE,QAAQ,EAAE,CAAC,EAC9C,YAAY,EAAE,YAAY,GAC1B,CACH,CAAC;AACJ,CAAC;AAOD;;;GAGG;AACH,MAAM,UAAU,gBAAgB,CAC9B,WAAyD;IAEzD,IAAI,CAAC,WAAW,IAAI,WAAW,CAAC,IAAI,EAAE,oBAAoB;QAAE,OAAO,KAAK,CAAC;IACzE,OAAO,CAAC,WAAW,CAAC,iBAAiB,IAAI,EAAE,CAAC,CAAC,IAAI,CAC/C,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,EAAE,KAAK,kBAAkB,CAC/C,CAAC;AACJ,CAAC;AAID;;;GAGG;AACH,MAAM,CAAC,KAAK,UAAU,aAAa,CAAC,WAAiC;IACnE,MAAM,OAAO,GAAG,MAAM,WAAW,CAAC,UAAU,CAG1C,sBAAsB,EAAE,EAAE,CAAC,CAAC;IAC9B,IAAI,CAAC,OAAO;QAAE,OAAO;IAErB,IAAI,OAAO,CAAC,QAAQ;QAAE,yBAAyB,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;IAClE,WAAW,CAAC,WAAW,CAAC,kBAAkB,CAAC,CAAC;AAC9C,CAAC"}

package/dist/editor/reviews/reviewUrlScope.d.ts

@@ -0,0 +1,23 @@
+export type ReviewScopeItem = {
+    itemId: string;
+    language: string;
+    includeSubitems: boolean;
+};
+export type ReviewScopeTarget = {
+    id: string;
+    language: string;
+    /** Sitecore long ID path ("/{guid}/.../{guid}"), ending with the item itself. */
+    idPath?: string;
+};
+/** Same rules as CollectionMembershipService.IsMember on the server. */
+export declare function reviewCoversItem(items: ReviewScopeItem[], target: ReviewScopeTarget): boolean;
+export declare function getReviewIdFromUrl(): string | null;
+/** Sets or removes reviewId in place, without adding a history entry. */
+export declare function setReviewIdInUrl(reviewId: string | undefined): void;
+/**
+ * Drops reviewId from the URL when the editor opens a page the review does not
+ * cover, or the review is gone or not accessible. Runs on page changes only, so
+ * opening a review while another page is shown keeps the id until the user
+ * moves on.
+ */
+export declare function useLeftoverReviewIdCleanup(target: ReviewScopeTarget | undefined, enabled: boolean): void;

package/dist/editor/reviews/reviewUrlScope.js

@@ -0,0 +1,86 @@
+import { useEffect, useRef } from "react";
+import { getReviewStatus } from "../services/reviewsService";
+// The editor keeps reviewId in its URL so review pages load review-scoped
+// comments and suggestions. The id belongs there only while the user is on a
+// page the review covers; once they browse elsewhere it is a leftover.
+const REVIEW_ID_PARAM = "reviewId";
+function normalizeId(id) {
+    return id.replace(/[{}]/g, "").trim().toLowerCase();
+}
+/** Same rules as CollectionMembershipService.IsMember on the server. */
+export function reviewCoversItem(items, target) {
+    const targetId = normalizeId(target.id);
+    const languageMatches = (item) => item.language === target.language || item.language === "*";
+    if (items.some((item) => normalizeId(item.itemId) === targetId && languageMatches(item))) {
+        return true;
+    }
+    const ancestorIds = new Set((target.idPath ?? "").split("/").filter(Boolean).map(normalizeId));
+    return items.some((item) => item.includeSubitems &&
+        languageMatches(item) &&
+        ancestorIds.has(normalizeId(item.itemId)));
+}
+export function getReviewIdFromUrl() {
+    if (typeof window === "undefined")
+        return null;
+    return new URLSearchParams(window.location.search).get(REVIEW_ID_PARAM);
+}
+/** Sets or removes reviewId in place, without adding a history entry. */
+export function setReviewIdInUrl(reviewId) {
+    if (typeof window === "undefined")
+        return;
+    const params = new URLSearchParams(window.location.search);
+    if ((params.get(REVIEW_ID_PARAM) ?? undefined) === reviewId)
+        return;
+    if (reviewId)
+        params.set(REVIEW_ID_PARAM, reviewId);
+    else
+        params.delete(REVIEW_ID_PARAM);
+    const query = params.toString();
+    const pathname = window.location.pathname;
+    window.history.replaceState(window.history.state, "", query ? `${pathname}?${query}` : pathname);
+}
+/**
+ * Drops reviewId from the URL when the editor opens a page the review does not
+ * cover, or the review is gone or not accessible. Runs on page changes only, so
+ * opening a review while another page is shown keeps the id until the user
+ * moves on.
+ */
+export function useLeftoverReviewIdCleanup(target, enabled) {
+    const reviewItemsRef = useRef(new Map());
+    const itemId = target?.id;
+    const language = target?.language;
+    const idPath = target?.idPath;
+    useEffect(() => {
+        if (!enabled || !itemId || !language)
+            return;
+        const reviewId = getReviewIdFromUrl();
+        if (!reviewId)
+            return;
+        const pageTarget = { id: itemId, language, idPath };
+        const knownItems = reviewItemsRef.current.get(reviewId);
+        if (knownItems && reviewCoversItem(knownItems, pageTarget))
+            return;
+        let cancelled = false;
+        void getReviewStatus(reviewId).then((result) => {
+            if (cancelled || getReviewIdFromUrl() !== reviewId)
+                return;
+            if (result.type === "success" && result.data) {
+                reviewItemsRef.current.set(reviewId, result.data.items);
+                if (!reviewCoversItem(result.data.items, pageTarget)) {
+                    setReviewIdInUrl(undefined);
+                }
+                return;
+            }
+            // Deleted or inaccessible reviews scope nothing. Other failures may be
+            // transient, so the id stays.
+            const status = result.response?.status;
+            if (result.type === "error" && (status === 403 || status === 404)) {
+                setReviewIdInUrl(undefined);
+            }
+        });
+        return () => {
+            cancelled = true;
+        };
+    }, [enabled, itemId, language, idPath]);
+}
+//# sourceMappingURL=reviewUrlScope.js.map

package/dist/editor/reviews/reviewUrlScope.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"reviewUrlScope.js","sourceRoot":"","sources":["../../../src/editor/reviews/reviewUrlScope.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,MAAM,OAAO,CAAC;AAC1C,OAAO,EAAE,eAAe,EAAE,MAAM,4BAA4B,CAAC;AAE7D,0EAA0E;AAC1E,6EAA6E;AAC7E,uEAAuE;AAEvE,MAAM,eAAe,GAAG,UAAU,CAAC;AAenC,SAAS,WAAW,CAAC,EAAU;IAC7B,OAAO,EAAE,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;AACtD,CAAC;AAED,wEAAwE;AACxE,MAAM,UAAU,gBAAgB,CAC9B,KAAwB,EACxB,MAAyB;IAEzB,MAAM,QAAQ,GAAG,WAAW,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IACxC,MAAM,eAAe,GAAG,CAAC,IAAqB,EAAE,EAAE,CAChD,IAAI,CAAC,QAAQ,KAAK,MAAM,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ,KAAK,GAAG,CAAC;IAE7D,IACE,KAAK,CAAC,IAAI,CACR,CAAC,IAAI,EAAE,EAAE,CAAC,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,QAAQ,IAAI,eAAe,CAAC,IAAI,CAAC,CACzE,EACD,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IAED,MAAM,WAAW,GAAG,IAAI,GAAG,CACzB,CAAC,MAAM,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,WAAW,CAAC,CAClE,CAAC;IACF,OAAO,KAAK,CAAC,IAAI,CACf,CAAC,IAAI,EAAE,EAAE,CACP,IAAI,CAAC,eAAe;QACpB,eAAe,CAAC,IAAI,CAAC;QACrB,WAAW,CAAC,GAAG,CAAC,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,CAC5C,CAAC;AACJ,CAAC;AAED,MAAM,UAAU,kBAAkB;IAChC,IAAI,OAAO,MAAM,KAAK,WAAW;QAAE,OAAO,IAAI,CAAC;IAC/C,OAAO,IAAI,eAAe,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,eAAe,CAAC,CAAC;AAC1E,CAAC;AAED,yEAAyE;AACzE,MAAM,UAAU,gBAAgB,CAAC,QAA4B;IAC3D,IAAI,OAAO,MAAM,KAAK,WAAW;QAAE,OAAO;IAC1C,MAAM,MAAM,GAAG,IAAI,eAAe,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC;IAC3D,IAAI,CAAC,MAAM,CAAC,GAAG,CAAC,eAAe,CAAC,IAAI,SAAS,CAAC,KAAK,QAAQ;QAAE,OAAO;IAEpE,IAAI,QAAQ;QAAE,MAAM,CAAC,GAAG,CAAC,eAAe,EAAE,QAAQ,CAAC,CAAC;;QAC/C,MAAM,CAAC,MAAM,CAAC,eAAe,CAAC,CAAC;IAEpC,MAAM,KAAK,GAAG,MAAM,CAAC,QAAQ,EAAE,CAAC;IAChC,MAAM,QAAQ,GAAG,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC;IAC1C,MAAM,CAAC,OAAO,CAAC,YAAY,CACzB,MAAM,CAAC,OAAO,CAAC,KAAK,EACpB,EAAE,EACF,KAAK,CAAC,CAAC,CAAC,GAAG,QAAQ,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,QAAQ,CAC1C,CAAC;AACJ,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,0BAA0B,CACxC,MAAqC,EACrC,OAAgB;IAEhB,MAAM,cAAc,GAAG,MAAM,CAAC,IAAI,GAAG,EAA6B,CAAC,CAAC;IACpE,MAAM,MAAM,GAAG,MAAM,EAAE,EAAE,CAAC;IAC1B,MAAM,QAAQ,GAAG,MAAM,EAAE,QAAQ,CAAC;IAClC,MAAM,MAAM,GAAG,MAAM,EAAE,MAAM,CAAC;IAE9B,SAAS,CAAC,GAAG,EAAE;QACb,IAAI,CAAC,OAAO,IAAI,CAAC,MAAM,IAAI,CAAC,QAAQ;YAAE,OAAO;QAC7C,MAAM,QAAQ,GAAG,kBAAkB,EAAE,CAAC;QACtC,IAAI,CAAC,QAAQ;YAAE,OAAO;QAEtB,MAAM,UAAU,GAAG,EAAE,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC;QACpD,MAAM,UAAU,GAAG,cAAc,CAAC,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;QACxD,IAAI,UAAU,IAAI,gBAAgB,CAAC,UAAU,EAAE,UAAU,CAAC;YAAE,OAAO;QAEnE,IAAI,SAAS,GAAG,KAAK,CAAC;QACtB,KAAK,eAAe,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE;YAC7C,IAAI,SAAS,IAAI,kBAAkB,EAAE,KAAK,QAAQ;gBAAE,OAAO;YAE3D,IAAI,MAAM,CAAC,IAAI,KAAK,SAAS,IAAI,MAAM,CAAC,IAAI,EAAE,CAAC;gBAC7C,cAAc,CAAC,OAAO,CAAC,GAAG,CAAC,QAAQ,EAAE,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;gBACxD,IAAI,CAAC,gBAAgB,CAAC,MAAM,CAAC,IAAI,CAAC,KAAK,EAAE,UAAU,CAAC,EAAE,CAAC;oBACrD,gBAAgB,CAAC,SAAS,CAAC,CAAC;gBAC9B,CAAC;gBACD,OAAO;YACT,CAAC;YAED,uEAAuE;YACvE,8BAA8B;YAC9B,MAAM,MAAM,GAAG,MAAM,CAAC,QAAQ,EAAE,MAAM,CAAC;YACvC,IAAI,MAAM,CAAC,IAAI,KAAK,OAAO,IAAI,CAAC,MAAM,KAAK,GAAG,IAAI,MAAM,KAAK,GAAG,CAAC,EAAE,CAAC;gBAClE,gBAAgB,CAAC,SAAS,CAAC,CAAC;YAC9B,CAAC;QACH,CAAC,CAAC,CAAC;QAEH,OAAO,GAAG,EAAE;YACV,SAAS,GAAG,IAAI,CAAC;QACnB,CAAC,CAAC;IACJ,CAAC,EAAE,CAAC,OAAO,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,CAAC,CAAC,CAAC;AAC1C,CAAC"}

package/dist/editor/reviews/scrollWithin.d.ts

@@ -0,0 +1,29 @@
+/**
+ * Scroll helpers for the feedback surfaces.
+ *
+ * `Element.scrollIntoView` walks every scrollable ancestor and scrolls each
+ * one, and its `block` option only chooses the alignment. Inside the comment
+ * margin the nearest such ancestor is the overlay root that must never
+ * scroll, and in the list it is the editor shell. So every programmatic
+ * reveal names its container and only that container's `scrollTop` changes.
+ */
+export declare const FEEDBACK_SCROLLABLE_ATTRIBUTE = "data-feedback-scrollable";
+export type ScrollWithinOptions = {
+    behavior?: "auto" | "smooth";
+    block?: "nearest" | "center";
+};
+/**
+ * Scrolls `container` so that `element` (a descendant) is visible. Only the
+ * container's own scroll offset changes.
+ */
+export declare function scrollElementIntoContainer(element: HTMLElement, container: HTMLElement, { behavior, block }?: ScrollWithinOptions): void;
+/**
+ * The nearest ancestor (inclusive) marked as a feedback scroll container,
+ * stopping at `root` when given.
+ */
+export declare function findFeedbackScrollContainer(element: Element | null, root?: Element | null): HTMLElement | null;
+/**
+ * Reveals `element` inside its nearest feedback scroll container. Does nothing
+ * when no container is found; it never falls back to `scrollIntoView`.
+ */
+export declare function revealInFeedbackScrollContainer(element: HTMLElement, options?: ScrollWithinOptions): boolean;