@parhelia/core 0.4.12818 → 0.4.12825

package/dist/task-board/TaskBoardWorkspace.js

@@ -34,6 +34,8 @@ import { normalizeTaskStatus } from "./taskStatus";
 import { getTaskExecutionDisplay, } from "./taskExecutionStatus";
 import { indexTaskExecutionRecords, overlayTaskExecutionList, taskExecutionRecordsEqual, } from "./taskExecutionRecords";
 import { WizardCommunicationCenter } from "./components/WizardCommunicationCenter";
+import { AttentionPromptDialog } from "./components/AttentionPromptDialog";
+import { listAttentionTasks } from "./utils/projectDashboardModel";
 import { Loader2 } from "lucide-react";
 import { MainContentTree } from "../editor/sidebar/MainContentTree";
 import { useTaskBoardAgentPanelState } from "./useTaskBoardAgentPanelState";
@@ -54,6 +56,12 @@ const TASKBOARD_PROJECT_QUERY_KEY = "tbProjectId";
 const TASKBOARD_TASK_QUERY_KEY = "tbTaskId";
 const TASKBOARD_VIEW_QUERY_KEY = "tbView";
 const WS_REFRESH_DELAY_MS = 500;
+const ATTENTION_PROMPT_DELAY_MS = 250;
+// Pause after the user handles an action before the panel moves on to the
+// next task that needs them, so the confirmation (approved, answered) is seen.
+const WIZARD_AUTO_ADVANCE_DELAY_MS = 2000;
+/** Retry delays when goal issue counts come back flagged as inconsistent. */
+const GOAL_CONSISTENCY_BACKOFF_MS = [500, 1000, 2000];
 const TASKBOARD_VIEW_TAB_IDS = [
     "overview",
     "kanban",
@@ -283,7 +291,15 @@ export function TaskBoardWorkspace() {
     const directSubprojectIdsRef = useRef(new Set());
     const tasksRef = useRef([]);
     const previousTaskStatusesRef = useRef({});
-    const previousWizardAttentionSignatureRef = useRef("");
+    const previousAttentionSnapshotRef = useRef(null);
+    const wizardDisplayedTaskIdRef = useRef(null);
+    const selectedTaskSourceRef = useRef(null);
+    const wizardDisplayedNeedsAttentionRef = useRef(false);
+    const previousDisplayedAttentionRef = useRef(null);
+    const autoAdvanceTimeoutRef = useRef(null);
+    const findNextAttentionTaskIdRef = useRef(() => null);
+    const [autoAdvancePending, setAutoAdvancePending] = useState(false);
+    const [attentionPromptTaskIds, setAttentionPromptTaskIds] = useState([]);
     const autoSelectedProjectIdsRef = useRef(new Set());
     const syncTaskBoardStateFromUrl = useCallback(() => {
         const nextState = getTaskBoardStateFromUrl();
@@ -682,38 +698,80 @@ export function TaskBoardWorkspace() {
             return;
         setWizardApprovedTaskId(null);
     }, [wizardApprovedTaskId, wizardDisplayedTask?.taskId]);
+    wizardDisplayedTaskIdRef.current = wizardDisplayedTask?.taskId ?? null;
+    selectedTaskSourceRef.current = selectedTaskSource;
+    const wizardDisplayedNeedsAttention = !!wizardDisplayedTask &&
+        (Boolean(wizardDisplayedExecutionDisplay?.needsAttention) ||
+            normalizeTaskStatus(wizardDisplayedTask.status, wizardDisplayedTask.executionState) === "Review");
+    wizardDisplayedNeedsAttentionRef.current = wizardDisplayedNeedsAttention;
+    // Dashboard attention prompt: open a semi-modal dialog when a task the user
+    // already saw newly needs them. Only transitions count, so opening the board
+    // with pending approvals, late-loading subproject lists, or re-renders never
+    // prompt. The check is deferred a tick so the panel's own auto-select can
+    // claim the task first; a task that is already displayed is not prompted.
     useEffect(() => {
-        const attentionSnapshot = JSON.stringify({
-            selectedTaskId,
-            selectedTaskSource,
-            wizardPinnedTaskId,
-            wizardForceOverview,
-            attentionTaskId: wizardAttentionState.task?.taskId ?? null,
-            attentionAgentId: wizardAttentionState.agentId ?? null,
-            summaryState: wizardAttentionState.summaryState,
-            totalCount: wizardAttentionState.stats.totalCount,
-            completedCount: wizardAttentionState.stats.completedCount,
-            approvalCount: wizardAttentionState.stats.approvalCount,
-            blockedCount: wizardAttentionState.stats.blockedCount,
-            runningCount: wizardAttentionState.stats.runningCount,
-            displayedTaskId: wizardDisplayedTask?.taskId ?? null,
-            displayedExecutionLabel: wizardDisplayedExecutionDisplay?.label ?? null,
-            displayedNeedsAttention: wizardDisplayedExecutionDisplay?.needsAttention ?? null,
-        });
-        if (previousWizardAttentionSignatureRef.current === attentionSnapshot) {
+        if (!isOverviewView || isTasksLoading || subprojectCountsLoading) {
+            previousAttentionSnapshotRef.current = null;
             return;
         }
-        previousWizardAttentionSignatureRef.current = attentionSnapshot;
+        const attentionIds = new Set(listAttentionTasks(orderedWizardTasks).map(({ task }) => task.taskId));
+        const knownIds = new Set(orderedWizardTasks.map((task) => task.taskId));
+        const previous = previousAttentionSnapshotRef.current;
+        previousAttentionSnapshotRef.current = { knownIds, attentionIds };
+        if (!previous)
+            return;
+        const arrivedIds = [...attentionIds].filter((taskId) => previous.knownIds.has(taskId) && !previous.attentionIds.has(taskId));
+        if (arrivedIds.length === 0)
+            return;
+        const timeoutId = window.setTimeout(() => {
+            const displayedId = wizardDisplayedTaskIdRef.current;
+            const promptIds = arrivedIds.filter((taskId) => taskId !== displayedId);
+            if (promptIds.length === 0)
+                return;
+            // One action at a time: while the displayed task itself needs the user,
+            // new arrivals just queue up in "Waiting for you" and the panel moves on
+            // to them by itself once this one is handled.
+            if (wizardDisplayedNeedsAttentionRef.current)
+                return;
+            // Nothing the user chose to look at is in the way: show the action
+            // directly instead of asking first.
+            if (selectedTaskSourceRef.current !== "user") {
+                setWizardForceOverview(false);
+                setTaskSelection(promptIds[0], {
+                    source: "system",
+                    pinInWizard: true,
+                });
+                return;
+            }
+            setAttentionPromptTaskIds((current) => [
+                ...current,
+                ...promptIds.filter((taskId) => !current.includes(taskId)),
+            ]);
+        }, ATTENTION_PROMPT_DELAY_MS);
+        return () => window.clearTimeout(timeoutId);
     }, [
-        selectedTaskId,
-        selectedTaskSource,
-        wizardAttentionState,
-        wizardDisplayedExecutionDisplay?.label,
-        wizardDisplayedExecutionDisplay?.needsAttention,
-        wizardDisplayedTask?.taskId,
-        wizardForceOverview,
-        wizardPinnedTaskId,
+        isOverviewView,
+        isTasksLoading,
+        subprojectCountsLoading,
+        orderedWizardTasks,
+        setTaskSelection,
     ]);
+    const attentionPromptTasks = useMemo(() => {
+        if (attentionPromptTaskIds.length === 0)
+            return [];
+        const displayedId = wizardDisplayedTask?.taskId ?? null;
+        const attentionById = new Map(listAttentionTasks(orderedWizardTasks).map(({ task }) => [
+            task.taskId,
+            task,
+        ]));
+        return attentionPromptTaskIds
+            .filter((taskId) => taskId !== displayedId)
+            .map((taskId) => attentionById.get(taskId))
+            .filter((task) => Boolean(task));
+    }, [attentionPromptTaskIds, orderedWizardTasks, wizardDisplayedTask?.taskId]);
+    const dismissAttentionPrompt = useCallback(() => {
+        setAttentionPromptTaskIds([]);
+    }, []);
     const clearWizardCloseTransitionTimeout = useCallback(() => {
         if (wizardCloseTransitionTimeoutRef.current !== null) {
             window.clearTimeout(wizardCloseTransitionTimeoutRef.current);
@@ -748,6 +806,61 @@ export function TaskBoardWorkspace() {
         }
         return null;
     }, [orderedWizardTasks, wizardExecutionRecordsByTaskId]);
+    findNextAttentionTaskIdRef.current = findNextAttentionTaskId;
+    // One action at a time: once the displayed task stops needing the user (its
+    // tool call was approved, its question answered, it was reviewed), move on to
+    // the next task that does, after a short pause so the confirmation is seen.
+    const clearAutoAdvance = useCallback(() => {
+        if (autoAdvanceTimeoutRef.current !== null) {
+            window.clearTimeout(autoAdvanceTimeoutRef.current);
+            autoAdvanceTimeoutRef.current = null;
+        }
+        setAutoAdvancePending(false);
+    }, []);
+    useEffect(() => {
+        const current = wizardDisplayedTask
+            ? {
+                taskId: wizardDisplayedTask.taskId,
+                needsAttention: wizardDisplayedNeedsAttention,
+            }
+            : null;
+        const previous = previousDisplayedAttentionRef.current;
+        previousDisplayedAttentionRef.current = current;
+        if (!current || !previous || previous.taskId !== current.taskId) {
+            clearAutoAdvance();
+            return;
+        }
+        if (!isOverviewView)
+            return;
+        if (!previous.needsAttention || current.needsAttention)
+            return;
+        if (!findNextAttentionTaskId(current.taskId))
+            return;
+        clearAutoAdvance();
+        const sourceTaskId = current.taskId;
+        setAutoAdvancePending(true);
+        autoAdvanceTimeoutRef.current = window.setTimeout(() => {
+            autoAdvanceTimeoutRef.current = null;
+            setAutoAdvancePending(false);
+            if (wizardDisplayedTaskIdRef.current !== sourceTaskId)
+                return;
+            if (wizardDisplayedNeedsAttentionRef.current)
+                return;
+            const nextTaskId = findNextAttentionTaskIdRef.current(sourceTaskId);
+            if (!nextTaskId)
+                return;
+            setWizardForceOverview(false);
+            setTaskSelection(nextTaskId, { source: "system", pinInWizard: true });
+        }, WIZARD_AUTO_ADVANCE_DELAY_MS);
+    }, [
+        clearAutoAdvance,
+        findNextAttentionTaskId,
+        isOverviewView,
+        setTaskSelection,
+        wizardDisplayedNeedsAttention,
+        wizardDisplayedTask,
+    ]);
+    useEffect(() => clearAutoAdvance, [clearAutoAdvance]);
     // ── data fetching ──
     const refreshProjects = useCallback(async (options) => {
         projectsRequestCountRef.current += 1;
@@ -884,7 +997,7 @@ export function TaskBoardWorkspace() {
         const indexed = indexTaskExecutionRecords(records);
         setExecutionRecordsByTaskId(indexed);
     }, []);
-    const refreshGoals = useCallback(async (projectId, includeDescendants) => {
+    const refreshGoals = useCallback(async (projectId, includeDescendants, attempt = 0) => {
         const generation = ++goalsRequestGenerationRef.current;
         latestGoalsProjectIdRef.current = projectId;
         setGoalsLoading(true);
@@ -905,12 +1018,24 @@ export function TaskBoardWorkspace() {
                 toast.error(message);
                 return;
             }
-            setGoals(result.data?.goals ?? []);
+            const goals = result.data?.goals ?? [];
+            setGoals(goals);
             setGoalCatalog(result.data?.catalog ?? []);
             setGoalPermissions(result.data?.permissions ?? {});
             setGoalDisplaySpecs(result.data?.displaySpecs ?? {});
             setGoalStateScope({ projectId, includeDescendants });
             setGoalsError(null);
+            // Issue counts read while issues were changing: read again with
+            // bounded backoff (500 ms, 1 s, 2 s); the last result stays flagged
+            // and the goal card says so. A later goal:changed is not relied on.
+            const inconsistent = goals.some((goal) => goal.issueSummaryConsistent === false);
+            if (inconsistent && attempt < GOAL_CONSISTENCY_BACKOFF_MS.length) {
+                window.setTimeout(() => {
+                    if (latestGoalsProjectIdRef.current === projectId &&
+                        generation === goalsRequestGenerationRef.current)
+                        void refreshGoals(projectId, includeDescendants, attempt + 1);
+                }, GOAL_CONSISTENCY_BACKOFF_MS[attempt]);
+            }
         }
         finally {
             if (latestGoalsProjectIdRef.current === projectId &&
@@ -929,6 +1054,10 @@ export function TaskBoardWorkspace() {
             }
         };
     }, [refreshGoals, includeGoalSubprojects]);
+    // Issue revisions and QA state may have changed while the socket was offline.
+    useEffect(() => {
+        refreshGoalsRef.current?.();
+    }, [editContext?.socketConnectionVersion]);
     // Load goals when the Goals tab or the dashboard is active (and on
     // project/scope change); the dashboard shows each goal's figures.
     const needsGoals = isGoalsView || isOverviewView;
@@ -1777,7 +1906,8 @@ export function TaskBoardWorkspace() {
     }, [refreshSubprojectTaskCounts]);
     useEffect(() => {
         previousTaskStatusesRef.current = {};
-        previousWizardAttentionSignatureRef.current = "";
+        previousAttentionSnapshotRef.current = null;
+        setAttentionPromptTaskIds([]);
         transitionGoalTaskNavigation({
             type: "projectSelected",
             projectId: selectedProjectId,
@@ -2074,6 +2204,9 @@ export function TaskBoardWorkspace() {
     const wizardNextReviewTaskId = useMemo(() => wizardDisplayedTask
         ? findNextAttentionTaskId(wizardDisplayedTask.taskId)
         : null, [findNextAttentionTaskId, wizardDisplayedTask]);
+    const wizardNextReviewTask = useMemo(() => wizardNextReviewTaskId
+        ? (orderedWizardTasks.find((task) => task.taskId === wizardNextReviewTaskId) ?? null)
+        : null, [orderedWizardTasks, wizardNextReviewTaskId]);
     const handleReviewNextWizardTask = useCallback(() => {
         clearWizardCloseTransitionTimeout();
         setWizardApprovedTaskId(null);
@@ -2115,7 +2248,7 @@ export function TaskBoardWorkspace() {
                 });
             }
             await refreshVisibleTaskData();
-        }, showApprovedState: wizardDisplayedTask?.taskId === wizardApprovedTaskId, hasNextReviewTask: Boolean(wizardNextReviewTaskId), onReviewNext: handleReviewNextWizardTask, onInteractionSubmitted: () => {
+        }, showApprovedState: wizardDisplayedTask?.taskId === wizardApprovedTaskId, hasNextReviewTask: Boolean(wizardNextReviewTaskId), nextAttentionTask: wizardNextReviewTask, autoAdvancePending: autoAdvancePending, onReviewNext: handleReviewNextWizardTask, onInteractionSubmitted: () => {
             handleCloseWizardTask({ advanceToNext: true });
         }, onCloseTask: () => handleCloseWizardTask(), onSelectTask: (taskId) => {
             clearWizardCloseTransitionTimeout();
@@ -2141,6 +2274,8 @@ export function TaskBoardWorkspace() {
         setTaskSelection,
         wizardApprovedTaskId,
         wizardNextReviewTaskId,
+        wizardNextReviewTask,
+        autoAdvancePending,
     ]);
     const isProjectViewLoading = !!selectedProjectId && projectViewLoadingId === selectedProjectId;
     const goalScopeMatches = goalScopesMatch(goalStateScope, {
@@ -2253,7 +2388,12 @@ export function TaskBoardWorkspace() {
             return (_jsxs("div", { className: "flex h-full min-h-0 min-w-0 flex-col gap-3", children: [_jsx(ProjectDashboard, { projectId: selectedProjectId, selectedProjectTitle: selectedProject?.project.title ?? "No project selected", selectedProjectDescription: selectedProject?.project.description, selectedProjectCostUsed: selectedProjectCumulativeCostUsed, selectedProjectCostLimit: selectedProject?.project.costLimit ?? null, selectedProjectTaskCounts: selectedProjectTaskCounts, subprojects: directSubprojects, taskCountsByProjectId: subprojectTaskCounts, parentProjectId: parentProject?.project.projectId ?? null, parentProjectTitle: parentProject?.project.title ?? null, onSelectProject: handleSelectProject, canCreateTask: canEditTasks, onCreateTask: () => setCreateDialogOpen(true), showCreateTaskButton: false }), sharedViewSwitcher, _jsx("div", { className: "mt-3 min-h-0 flex-1", children: _jsx(ProjectDashboardView, { projectId: selectedProjectId, projectTitle: selectedProject?.project.title ?? "No project selected", tasks: tasksWithDisplayAssignees, projectTasksLoading: isTasksLoading, dependencies: dependencies, subprojectTaskLists: wizardSubprojectTaskLists, subprojectTasksLoading: subprojectCountsLoading, selectedTaskId: wizardDisplayedTask?.taskId ?? null, onSelectTask: (id) => {
                                 setWizardForceOverview(false);
                                 setTaskSelection(id, { source: "user", pinInWizard: true });
-                            }, projectCostUsed: selectedProjectCumulativeCostUsed, projectCostLimit: selectedProject?.project.costLimit ?? null, goals: goalScopeMatches ? goals : [], goalsLoading: goalsLoading || !goalScopeMatches, goalDisplaySpecs: goalScopeMatches ? goalDisplaySpecs : {}, onOpenGoals: () => setActiveTab(getTaskBoardViewTabIndex("goals")), communicationPanel: wizardDisplayedTask ? wizardCommunicationPanel : undefined }) })] }));
+                            }, projectCostUsed: selectedProjectCumulativeCostUsed, projectCostLimit: selectedProject?.project.costLimit ?? null, goals: goalScopeMatches ? goals : [], goalsLoading: goalsLoading || !goalScopeMatches, goalDisplaySpecs: goalScopeMatches ? goalDisplaySpecs : {}, onOpenGoals: () => setActiveTab(getTaskBoardViewTabIndex("goals")), communicationPanel: wizardDisplayedTask ? wizardCommunicationPanel : undefined }) }), _jsx(AttentionPromptDialog, { tasks: attentionPromptTasks, onReview: (taskId) => {
+                            setAttentionPromptTaskIds([]);
+                            clearWizardCloseTransitionTimeout();
+                            setWizardForceOverview(false);
+                            setTaskSelection(taskId, { source: "user", pinInWizard: true });
+                        }, onDismiss: dismissAttentionPrompt })] }));
         }
         if (isSettingsView) {
             return (_jsxs("div", { className: "flex h-full min-h-0 min-w-0 flex-col gap-3", children: [_jsx(ProjectDashboard, { projectId: selectedProjectId, selectedProjectTitle: selectedProject?.project.title ?? "No project selected", selectedProjectDescription: selectedProject?.project.description, selectedProjectCostUsed: selectedProjectCumulativeCostUsed, selectedProjectCostLimit: selectedProject?.project.costLimit ?? null, selectedProjectTaskCounts: selectedProjectTaskCounts, subprojects: directSubprojects, taskCountsByProjectId: subprojectTaskCounts, parentProjectId: parentProject?.project.projectId ?? null, parentProjectTitle: parentProject?.project.title ?? null, onSelectProject: handleSelectProject, canCreateTask: canEditTasks, onCreateTask: () => setCreateDialogOpen(true), showCreateTaskButton: false }), sharedViewSwitcher, _jsx("div", { className: "mt-3", children: _jsx(ProjectSettingsPanel, { projectId: selectedProjectId, selectedProject: selectedProject, projects: projects, canOpenSourceTemplate: isAdministrator, onOpenSourceTemplate: handleOpenSourceTemplate, onDeleteProject: handleDeleteProject, onChanged: async () => {
@@ -2335,6 +2475,9 @@ export function TaskBoardWorkspace() {
         wizardSubprojectTaskLists,
         wizardDisplayedTask?.taskId,
         wizardCommunicationPanel,
+        attentionPromptTasks,
+        dismissAttentionPrompt,
+        clearWizardCloseTransitionTimeout,
         setTaskSelection,
         refreshProjects,
         refreshGoals,
@@ -2412,6 +2555,8 @@ export function TaskBoardWorkspace() {
     ]);
     const agentTerminalPanel = useMemo(() => (_jsx(TaskAgentPanel, { agentId: displayAgentId, mode: agentPanelMode, label: selectedTaskIsPlan ? "Planner" : "Task Agent", taskDetailsContent: taskDetailsPopoverContent ?? undefined, taskDetailsPopoverOpen: isTaskDetailsPopoverOpen, onTaskDetailsPopoverOpenChange: setIsTaskDetailsPopoverOpen, assignedAgentStatus: undefined, onReopenTask: selectedTask && canEditTasks
             ? () => void handleReopenSelectedTask()
+            : undefined, onClose: selectedTask
+            ? () => setTaskSelection(null, { source: "user" })
             : undefined })), [
         displayAgentId,
         agentPanelMode,
@@ -2421,6 +2566,7 @@ export function TaskBoardWorkspace() {
         canEditTasks,
         selectedTask,
         handleReopenSelectedTask,
+        setTaskSelection,
     ]);
     const buildRightHandPanels = useCallback((showAgentColumn) => {
         const renderDetailPanel = (collapsedFlag) => (_jsx(TaskDetailPanel, { project: selectedTaskProject, projects: projects, task: selectedTask, allTasks: taskSelectionUniverse, dependencies: dependencies, onTaskChanged: () => {