@parhelia/core 0.1.12928 → 0.1.12931

package/dist/editor/client/EditorShell.js

@@ -760,43 +760,6 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         const resolvedMode = typeof nextMode === "function" ? nextMode(modeRef.current) : nextMode;
         void changeMode(resolvedMode);
     }, [changeMode]);
-    const closeFeedbackSuggestionsMode = useCallback(() => {
-        setShowComments(false);
-        setShowSuggestedEdits(false);
-        setShowSuggestedEditsDiff(false);
-        if (modeRef.current === "suggestions") {
-            void changeMode("edit", { reason: "feedback-sidebar-close" });
-        }
-    }, [changeMode]);
-    const feedbackSidebarOpenRef = useRef(openSidebars.includes("feedback"));
-    const feedbackSidebarSuggestionsLoadedRef = useRef(false);
-    useEffect(() => {
-        const feedbackSidebarOpen = openSidebars.includes("feedback");
-        const wasFeedbackSidebarOpen = feedbackSidebarOpenRef.current;
-        feedbackSidebarOpenRef.current = feedbackSidebarOpen;
-        if (!feedbackSidebarOpen) {
-            feedbackSidebarSuggestionsLoadedRef.current = false;
-            if (wasFeedbackSidebarOpen) {
-                closeFeedbackSuggestionsMode();
-            }
-            return;
-        }
-        if (!showComments) {
-            setShowComments(true);
-        }
-        if (!showSuggestedEdits) {
-            setShowSuggestedEdits(true);
-        }
-        if (!feedbackSidebarSuggestionsLoadedRef.current) {
-            feedbackSidebarSuggestionsLoadedRef.current = true;
-            void loadSuggestedEditsRef.current();
-        }
-    }, [
-        closeFeedbackSuggestionsMode,
-        openSidebars,
-        showComments,
-        showSuggestedEdits,
-    ]);
     const activateCommentsModeForWriting = useCallback(async (reason) => {
         setShowComments(true);
         setShowSuggestedEdits(false);
@@ -3576,9 +3539,6 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
             if (sidebarId === "agents-panel") {
                 setUserPreferences({ showAgentsPanel: false });
             }
-            if (sidebarId === "feedback") {
-                closeFeedbackSuggestionsMode();
-            }
             startTransition(() => {
                 updateUrl({ sidebar: sidebarUrlValue(newSidebars) });
             });
@@ -3614,7 +3574,6 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         ensureSidebarPinned,
         setUserPreferences,
         isMobile,
-        closeFeedbackSuggestionsMode,
     ]);
     // Ensure a sidebar is open (without toggling it closed if already open)
     const openSidebar = useCallback((sidebarId, options) => {
@@ -4712,21 +4671,21 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         },
         droppedInPlaceholder: async (placeholderKey, index, spotPositionElement, spotPositionAnchor, insertOption, spotPosition, color) => {
             const droppedDragObject = dragObject;
-            if ((!droppedDragObject && !insertOption) || !page)
-                return;
+            if ((!droppedDragObject && !insertOption) || !page) {
+                return { committed: false };
+            }
             setDragObject(undefined);
             const placeholderKeyComponents = placeholderKey.split("_");
             const parentId = placeholderKeyComponents.length === 1
                 ? undefined
                 : placeholderKeyComponents[1];
-            // Without auto-scroll: the parent is selected for context, not to be
-            // shown — scrolling would move the page away from the drop point
-            // (and, before the refresh lands, toward stale pre-move geometry).
-            if (parentId)
-                selectWithoutAutoScroll([parentId]);
+            // Selection is left alone at drop. The server response's focus id
+            // selects the moved/added component (executeEditOperation); selecting
+            // the drop target's parent here made the single-selection frame
+            // FLIP-animate component -> parent -> component around every drop.
             let op;
             if (!currentItemDescriptorRef.current)
-                return;
+                return { committed: false };
             let insertionSequence;
             if ((spotPosition || spotPositionElement) && spotPositionAnchor) {
                 insertionSequence = ++insertingSequenceRef.current;
@@ -4798,7 +4757,7 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
                     insertingSequenceRef.current === insertionSequence) {
                     setInserting(undefined);
                 }
-                return;
+                return { committed: false };
             }
             let operationFailed = false;
             try {
@@ -4825,6 +4784,7 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
                     }
                 }
             }
+            return { committed: !operationFailed };
         },
         page,
         triggerFieldAction: async (fieldDescriptor, actionButton, parameters, event) => {
@@ -5734,7 +5694,7 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
     ]);
     if (!currentWorkspace)
         return null;
-    const editorUi = fullscreen ? (_jsxs(_Fragment, { children: [_jsx("div", { className: "fixed inset-0 flex", children: _jsx(PageViewerFrame, { compareView: compareMode, pageViewContext: activePageViewContext }) }), showFullscreenHint && !configuration.forceFullscreen && !isMobile && (_jsx("div", { className: "fixed inset-0 z-10000", onMouseMoveCapture: () => {
+    const editorUi = fullscreen ? (_jsxs(_Fragment, { children: [_jsx("div", { className: "bg-neutral-grey-5 fixed inset-0 flex", "data-testid": "fullscreen-root", children: _jsx(PageViewerFrame, { compareView: compareMode, pageViewContext: activePageViewContext }) }), showFullscreenHint && !configuration.forceFullscreen && !isMobile && (_jsx("div", { className: "fixed inset-0 z-10000", onMouseMoveCapture: () => {
                     setTimeout(() => {
                         setShowFullscreenHint(false);
                     }, 600);