@parhelia/core 0.1.12496 → 0.1.12517

package/dist/editor/client/EditorShell.js

@@ -154,14 +154,14 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
     if (typeof window !== "undefined")
         sessionStorage?.setItem("sessionId", sessionId);
     // Workspace state
-    // Note: "reviews" is a sidebar, not a workspace. If view/workspace=reviews, we should
+    // Note: "reviews" is a sidebar, not a workspace. If workspace=reviews, we should
     // set workspace to "editor" and open the reviews sidebar instead.
     // Memoize searchParams reads to avoid triggering Router state updates during render
     // (Next.js App Router uses startTransition internally for URL changes)
-    const rawWorkspace = useMemo(() => searchParams.get("workspace") ?? searchParams.get("view"), [searchParams]);
+    const rawWorkspace = useMemo(() => searchParams.get("workspace"), [searchParams]);
     const isReviewsSidebarRequest = rawWorkspace === "reviews";
     const [workspaceId, setWorkspaceId] = useState(
-    // If view=reviews, use "editor" workspace (reviews is a sidebar, not a workspace)
+    // If workspace=reviews, use "editor" workspace (reviews is a sidebar, not a workspace)
     isReviewsSidebarRequest
         ? "editor"
         : (rawWorkspace ??
@@ -183,7 +183,7 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         else {
             sidebars = [...(configuration.editor.defaultOpenSidebars ?? [])];
         }
-        // If view/workspace=reviews was requested, ensure reviews sidebar is open
+        // If workspace=reviews was requested, ensure reviews sidebar is open
         if (isReviewsSidebarRequest && !sidebars.includes("reviews")) {
             sidebars.push("reviews");
         }
@@ -313,12 +313,7 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         }
         catch { }
     }, [lockedSidebars]);
-    // Legacy aliases for backwards compatibility
     const viewName = workspaceId;
-    const setViewName = setWorkspaceId;
-    const viewNameRef = workspaceIdRef;
-    const previousViewName = previousWorkspaceId;
-    const setPreviousViewName = setPreviousWorkspaceId;
     const [compareMode, setCompareModeState] = useState(false);
     const [componentDesignerComponent, setComponentDesignerComponent] = useState();
     const [componentDesignerRendering, setComponentDesignerRendering] = useState();
@@ -443,13 +438,12 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
             visitedAt: entry.visitedAt,
         }));
     });
-    // Navigation history for browser history (view + item combinations)
+    // Navigation history for browser history (workspace + item combinations)
     const [navigationHistory, setNavigationHistory] = useState(() => {
-        // Initialize from browse history with current view
+        // Initialize from browse history with the current workspace
         if (!userInfo.browseHistory)
             return [];
         const defaultWorkspaceId = searchParams.get("workspace") ??
-            searchParams.get("view") ??
             configuration.editor.defaultWorkspace ??
             configuration.editor.workspaces?.[0]?.id ??
             "editor";
@@ -508,6 +502,7 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
     const [helpTerminalInitialPrompt, setHelpTerminalInitialPrompt] = useState(undefined);
     const [helpTerminalProfileName, setHelpTerminalProfileName] = useState(undefined);
     const [helpTerminalActiveTab, setHelpTerminalActiveTab] = useState(undefined);
+    const [selectedHelpSectionId, setSelectedHelpSectionId] = useState(null);
     const [showAgentsWorkspaceEditor, setShowAgentsWorkspaceEditor] = useState(false);
     const [selectedAgentsWorkspaceAgentId, setSelectedAgentsWorkspaceAgentId] = useState(null);
     const [activeEditorTab, setActiveEditorTab] = useState(null);
@@ -534,13 +529,12 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         if (!startupChecks.hasBlockingIssues)
             return;
         // Don't redirect if already in settings workspace - let user navigate freely within settings
-        const currentWorkspace = searchParams.get("workspace") ?? searchParams.get("view");
+        const currentWorkspace = searchParams.get("workspace");
         if (currentWorkspace === "settings")
             return;
         // Redirect to the status panel (where user can see all issues and navigate to fixes)
         const url = new URL(window.location.href);
         url.searchParams.set("workspace", "settings");
-        url.searchParams.delete("view"); // Remove legacy param
         url.searchParams.set("ccpanel", "status");
         router.push(url.toString(), { scroll: false });
     }, [
@@ -558,6 +552,16 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
             setMode(queryMode);
         }
     }, [searchParams, isInitialLoad]);
+    useEffect(() => {
+        if (!isInitialLoad)
+            return;
+        const helpParam = searchParams.get("help");
+        if (helpParam) {
+            setHelpTerminalActiveTab("manual");
+            setShowHelpTerminal(true);
+            setSelectedHelpSectionId(helpParam === "contents" || helpParam === "true" ? null : helpParam);
+        }
+    }, [searchParams, isInitialLoad]);
     useEffect(() => {
         if (mode === "suggestions") {
             // Ensure we're in the editor workspace and open the feedback sidebar
@@ -782,8 +786,6 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         console.error(`No workspace found for id: ${workspaceId}`);
         return null;
     }
-    // Legacy alias for backwards compatibility
-    const currentView = currentWorkspace;
     const activeKeyboardCommands = useMemo(() => {
         const activeCommandIds = new Set(currentWorkspace.keyboardCommandIds ?? []);
         return (configuration.commands.keyboardCommands ?? []).filter((command) => activeCommandIds.has(command.id));
@@ -934,6 +936,7 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
             setHelpTerminalInitialPrompt(undefined);
             setHelpTerminalProfileName(undefined);
             setHelpTerminalActiveTab(undefined);
+            setSelectedHelpSectionId(null);
         }
     }, [showHelpTerminal]);
     const toggleHelpTerminal = useCallback((options) => {
@@ -1093,9 +1096,8 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
                 isHandlingPopStateRef.current = true;
                 // Sync URL parameters back to component state for browser navigation
                 const urlParams = new URLSearchParams(window.location.search);
-                // Handle workspace changes (with legacy view fallback)
-                const urlWorkspace = urlParams.get("workspace") ?? urlParams.get("view");
-                if (urlWorkspace && urlWorkspace !== viewNameRef.current) {
+                const urlWorkspace = urlParams.get("workspace");
+                if (urlWorkspace && urlWorkspace !== workspaceIdRef.current) {
                     setWorkspaceId(urlWorkspace);
                 }
                 // Handle sidebar changes
@@ -1112,6 +1114,18 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
                 if (compareValue !== compareMode) {
                     setCompareMode(compareValue);
                 }
+                // Handle help panel changes
+                const helpParam = urlParams.get("help");
+                if (helpParam) {
+                    setHelpTerminalActiveTab("manual");
+                    setShowHelpTerminal(true);
+                    setSelectedHelpSectionId(helpParam === "contents" || helpParam === "true"
+                        ? null
+                        : helpParam);
+                }
+                else {
+                    handleSetShowHelpTerminal(false);
+                }
                 // Handle mode changes
                 const urlMode = urlParams.get("mode");
                 if (urlMode && urlMode !== mode) {
@@ -1890,7 +1904,6 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         if (current.get("workspace") !== viewName) {
             current.set("workspace", viewName);
         }
-        current.delete("view"); // Remove legacy view param
         // Sync sidebar state
         const currentSidebars = current.get("sidebar") ?? "";
         const newSidebars = openSidebars.join(",");
@@ -1902,6 +1915,12 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
                 current.delete("sidebar");
             }
         }
+        if (showHelpTerminal) {
+            current.set("help", selectedHelpSectionId ?? "contents");
+        }
+        else {
+            current.delete("help");
+        }
         if (!compareMode) {
             current.delete("compare");
             current.delete("compareLanguage");
@@ -1969,6 +1988,8 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         fullscreen,
         currentWizardId,
         openSidebars,
+        showHelpTerminal,
+        selectedHelpSectionId,
     ]);
     useEffect(() => {
         async function load() {
@@ -2608,14 +2629,6 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         updateUrl,
         handleSetShowAgentsPanel,
     ]);
-    // Legacy alias for backwards compatibility
-    const switchView = useCallback((viewName, options) => {
-        // Handle ccpanel for settings workspace
-        if (options?.ccpanel) {
-            updateUrl({ ccpanel: options.ccpanel, workspace: viewName });
-        }
-        switchWorkspace(viewName, options);
-    }, [switchWorkspace, updateUrl]);
     // Helper: get all sidebar IDs that should be preserved (locked sidebars + their stack mates)
     const getPreservedSidebarIds = useCallback(() => {
         const lockedSet = new Set(lockedSidebarsRef.current);
@@ -3379,8 +3392,7 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
                             skipViewChange: true,
                         });
                         if (item) {
-                            // Switch to the editor view
-                            switchView("editor", {
+                            switchWorkspace("editor", {
                                 skipNavigationHistory: true,
                             });
                             showInfoToast({
@@ -3413,7 +3425,7 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
                 document.removeEventListener("click", handleCtrlClick, true);
             };
         }
-    }, [loadItem, switchView, showInfoToast, showErrorToast]);
+    }, [loadItem, switchWorkspace, showInfoToast, showErrorToast]);
     useEffect(() => {
         const handleGlobalBlur = () => {
             operations.onFieldBlur?.();
@@ -3451,18 +3463,6 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         // Otherwise, only show workspaces that are in the settings
         return workspaceIdsFromSettings.includes(w.id) && !w.visible;
     });
-    // Legacy: Calculate visible views for backwards compatibility
-    const allViews = (configuration.editor.views ?? [])
-        .filter((x) => {
-        return !x.visible && !x.hidden;
-    })
-        .filter((x) => !userInfo.views ||
-        userInfo.views.map((view) => view.name).includes(x.name));
-    const pinnedViews = userInfo.preferences?.pinnedViews ||
-        configuration.editor.defaultPinnedViews ||
-        [];
-    // Legacy visibleViews for backwards compatibility
-    const visibleViews = allViews.filter((view) => view.name === viewName || pinnedViews.includes(view.name));
     // Handle initial mode setup from URL (only on initial load)
     useEffect(() => {
         if (!isInitialLoad)
@@ -3507,7 +3507,7 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
             // This is especially important when called from the tour, where the current workspace
             // might be the editor and URL-only navigation would get "corrected" back.
             try {
-                switchView("home", {
+                switchWorkspace("home", {
                     skipConfirmation: true,
                     skipNavigationHistory: true,
                 });
@@ -3554,7 +3554,6 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
             const current = new URLSearchParams(searchParams.toString());
             current.delete("version");
             current.delete("itemid");
-            current.delete("view"); // Remove legacy param
             current.delete("workspace"); // Clear workspace
             current.set("create", "1");
             const newUrl = `${pathname}?${current.toString()}`;
@@ -3887,12 +3886,6 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         reorderPinnedSidebars,
         reorderOpenSidebars,
         getResolvedSidebar,
-        // Legacy compatibility (deprecated)
-        viewName,
-        previousViewName,
-        switchView,
-        view: currentView,
-        visibleViews,
         compareMode,
         setCompareMode,
         fullscreen,
@@ -4037,6 +4030,8 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         helpTerminalProfileName,
         helpTerminalActiveTab,
         setHelpTerminalActiveTab,
+        selectedHelpSectionId,
+        setSelectedHelpSectionId,
         showAgentsWorkspaceEditor,
         setShowAgentsWorkspaceEditor: handleSetShowAgentsWorkspaceEditor,
         selectedAgentsWorkspaceAgentId,
@@ -4089,7 +4084,6 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         configuration,
         updateUrl,
         workspaceId,
-        switchView,
         pathname,
         router,
         item,
@@ -4130,9 +4124,6 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         reorderOpenSidebars,
         getResolvedSidebar,
         viewName,
-        previousViewName,
-        currentView,
-        visibleViews,
         compareMode,
         // Important: in multi-slot mode the active PageViewContext can change
         // without the base `pageViewContext` identity changing (e.g. switching slots).
@@ -4201,6 +4192,7 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
         helpTerminalProfileName,
         helpTerminalActiveTab,
         setHelpTerminalActiveTab,
+        selectedHelpSectionId,
         showAgentsWorkspaceEditor,
         selectedAgentsWorkspaceAgentId,
         activeEditorTab,
@@ -4474,15 +4466,13 @@ export function EditorShell({ configuration, className, item: loadItemDescriptor
     useEffect(() => {
         fieldsEditContext.clearModifiedFields();
     }, [currentItemDescriptor]);
-    if (!currentView)
+    if (!currentWorkspace)
         return null;
     const editorUi = fullscreen ? (_jsxs(_Fragment, { children: [_jsxs("div", { className: "fixed inset-0 flex", children: [_jsx(PageViewerFrame, { compareView: compareMode, pageViewContext: activePageViewContext }), _jsx(FullscreenControls, { device: activePageViewContext.device, setDevice: (d) => activePageViewContext.setDevice(d), canExit: !configuration.forceFullscreen, onExit: () => setFullscreen(false), firstMobileDeviceName: configuration.devices[0]?.name })] }), showFullscreenHint && !configuration.forceFullscreen && !isMobile && (_jsx("div", { className: "fixed inset-0 z-10000", onMouseMoveCapture: () => {
                     setTimeout(() => {
                         setShowFullscreenHint(false);
                     }, 600);
-                }, "data-testid": "fullscreen-hint-overlay", children: _jsxs("div", { className: "fixed top-6 left-1/2 -translate-x-1/2 transform rounded-full bg-black/60 px-6 py-2.5 text-sm font-medium text-white shadow-2xl backdrop-blur-md transition-all duration-500", children: ["Press", " ", _jsx("kbd", { className: "mx-1 rounded bg-white/20 px-1.5 py-0.5 text-xs font-semibold", children: "Ctrl + F11" }), " ", "to exit fullscreen"] }) }))] })) : (_jsxs(_Fragment, { children: [_jsx(EditorChrome, { className: className, currentWorkspace: currentWorkspace, centerPanelView: centerPanelView, editContext: editContext, showAgentsPanel: showAgentsPanel, handleSetShowAgentsPanel: handleSetShowAgentsPanel, workspaceId: workspaceId, 
-                // Legacy props for backwards compatibility
-                currentView: currentView, viewName: viewName }), isTourActive && (_jsx(Tour, { tourStopCallback: () => {
+                }, "data-testid": "fullscreen-hint-overlay", children: _jsxs("div", { className: "fixed top-6 left-1/2 -translate-x-1/2 transform rounded-full bg-black/60 px-6 py-2.5 text-sm font-medium text-white shadow-2xl backdrop-blur-md transition-all duration-500", children: ["Press", " ", _jsx("kbd", { className: "mx-1 rounded bg-white/20 px-1.5 py-0.5 text-xs font-semibold", children: "Ctrl + F11" }), " ", "to exit fullscreen"] }) }))] })) : (_jsxs(_Fragment, { children: [_jsx(EditorChrome, { className: className, currentWorkspace: currentWorkspace, centerPanelView: centerPanelView, editContext: editContext, showAgentsPanel: showAgentsPanel, handleSetShowAgentsPanel: handleSetShowAgentsPanel, workspaceId: workspaceId }), isTourActive && (_jsx(Tour, { tourStopCallback: () => {
                     setIsTourActive(false);
                     // Remove tour state from URL
                     // Use history.replaceState instead of router.replace to avoid triggering React navigation